This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Remove hasSideEffects from FP converts
ClosedPublic

Authored by dmgreen on Jun 11 2020, 2:49 AM.

Details

Summary

Whether an instruction is deemed to have side effects in determined by whether it has an instruction pattern that emits a single instruction. Because of the way a lot of the the vcvt instructions are specified either in dagtodag code or with tblgen patterns that emit multiple instructions, they don't get marked as not having side effects.

This just marks them as not having side effects manually. It can help especially with instruction scheduling, to not create artificial barriers, but one of these tests also managed to produce fewer instructions.

Diff Detail

Event Timeline

dmgreen created this revision.Jun 11 2020, 2:49 AM
samparker accepted this revision.Jun 11 2020, 3:54 AM

Sounds good.

This revision is now accepted and ready to land.Jun 11 2020, 3:54 AM
This revision was automatically updated to reflect the committed changes.