Page MenuHomePhabricator

[mlir][StandardToSPIRV] Handle i1 case for lowering std.load op and std.store op
AbandonedPublic

Authored by hanchung on Jun 5 2020, 4:05 PM.

Details

Summary

This patch unconditionally converts i1 types to i8 types on memrefs. If the
extensions or capabilities are not met, they will be converted to i32. Hence the
logic in IntLoadPattern and IntStorePattern are also updated.

Diff Detail

Event Timeline

hanchung created this revision.Jun 5 2020, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 4:05 PM

Should we drop this for now given this is not the preferred way to go?

antiagainst requested changes to this revision.Jun 9 2020, 5:42 PM
This revision now requires changes to proceed.Jun 9 2020, 5:42 PM
hanchung abandoned this revision.Jun 9 2020, 8:58 PM

Should we drop this for now given this is not the preferred way to go?

Yes, I forgot to drop it, thanks!