Page MenuHomePhabricator

denis13 (Denis Khalikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 6:23 AM (166 w, 6 d)

Recent Activity

Jun 19 2020

denis13 updated the diff for D82198: [mlir][spirv] Add RewriteInserts pass..

Updated

Jun 19 2020, 11:59 AM · Restricted Project
denis13 added inline comments to D82198: [mlir][spirv] Add RewriteInserts pass..
Jun 19 2020, 11:59 AM · Restricted Project
denis13 added a comment to D82198: [mlir][spirv] Add RewriteInserts pass..

This patch is related to https://github.com/tensorflow/mlir/issues/196, and the pass is based on https://github.com/google/clspv/blob/master/lib/RewriteInsertsPass.cpp

Jun 19 2020, 8:37 AM · Restricted Project
denis13 created D82198: [mlir][spirv] Add RewriteInserts pass..
Jun 19 2020, 8:37 AM · Restricted Project

Jun 18 2020

denis13 accepted D82068: [mlir][vulkan-runner] add support for memref of i8, i16 types in vulkan runner..
Jun 18 2020, 2:41 AM · Restricted Project
denis13 added a comment to D82068: [mlir][vulkan-runner] add support for memref of i8, i16 types in vulkan runner..

LGTM! Thanks for simplifying this!

Jun 18 2020, 2:41 AM · Restricted Project

May 18 2020

denis13 accepted D80149: [mlir][vulkan-runner] Add back accidentially removed header include.
May 18 2020, 12:26 PM · Restricted Project

May 16 2020

denis13 committed rG0dc91bfd11e6: [mlir][spirv] Handle debuginfo for control flow ops. (authored by denis13).
[mlir][spirv] Handle debuginfo for control flow ops.
May 16 2020, 5:41 AM
denis13 closed D79931: [mlir][spirv] Handle debuginfo for control flow ops..
May 16 2020, 5:41 AM · Restricted Project

May 15 2020

denis13 added inline comments to D79931: [mlir][spirv] Handle debuginfo for control flow ops..
May 15 2020, 2:42 PM · Restricted Project
denis13 updated the diff for D79931: [mlir][spirv] Handle debuginfo for control flow ops..

Addressed review comments.

May 15 2020, 2:42 PM · Restricted Project

May 14 2020

denis13 created D79931: [mlir][spirv] Handle debuginfo for control flow ops..
May 14 2020, 3:42 AM · Restricted Project

May 13 2020

denis13 accepted D79860: [mlir][vulkan-runner] Avoid dependency on LLVM libraries.

LGTM! Thanks!

May 13 2020, 7:32 AM · Restricted Project

May 8 2020

denis13 committed rGb5973d20b388: [mlir][spirv] Handle debuginfo for variables. (authored by denis13).
[mlir][spirv] Handle debuginfo for variables.
May 8 2020, 8:33 AM
denis13 closed D79566: [mlir][spirv] Handle debuginfo for variables..
May 8 2020, 8:33 AM · Restricted Project

May 7 2020

denis13 accepted D79577: [mlir][vulkan-runner] Remove duplicated/uncessary link libraries.

Thanks! It fixes a build problem!

May 7 2020, 9:40 AM · Restricted Project
denis13 created D79566: [mlir][spirv] Handle debuginfo for variables..
May 7 2020, 4:29 AM · Restricted Project

May 1 2020

denis13 committed rG29b955f97cc6: [mlir][spirv] Handle debug information during (de)serialization. (authored by denis13).
[mlir][spirv] Handle debug information during (de)serialization.
May 1 2020, 4:14 AM
denis13 closed D79091: [mlir][spirv] Handle debug information during (de)serialization..
May 1 2020, 4:13 AM · Restricted Project
denis13 added inline comments to D79091: [mlir][spirv] Handle debug information during (de)serialization..
May 1 2020, 4:06 AM · Restricted Project

Apr 30 2020

denis13 added a comment to D79091: [mlir][spirv] Handle debug information during (de)serialization..

@antiagainst thanks for review, can you please take a look, to make sure I've updated the patch in right way. Thanks.

Apr 30 2020, 2:00 PM · Restricted Project
denis13 updated the diff for D79091: [mlir][spirv] Handle debug information during (de)serialization..

Addresses comments.

Apr 30 2020, 2:00 PM · Restricted Project
denis13 updated the diff for D79091: [mlir][spirv] Handle debug information during (de)serialization..

Rebase on master.

Apr 30 2020, 9:35 AM · Restricted Project
denis13 updated the diff for D79091: [mlir][spirv] Handle debug information during (de)serialization..

Remove new line.

Apr 30 2020, 7:56 AM · Restricted Project
denis13 updated the diff for D79091: [mlir][spirv] Handle debug information during (de)serialization..

Addresses comments.

Apr 30 2020, 7:56 AM · Restricted Project
denis13 added inline comments to D79091: [mlir][spirv] Handle debug information during (de)serialization..
Apr 30 2020, 7:56 AM · Restricted Project

Apr 29 2020

denis13 added a reviewer for D79091: [mlir][spirv] Handle debug information during (de)serialization.: hanchung.
Apr 29 2020, 8:33 AM · Restricted Project
denis13 created D79091: [mlir][spirv] Handle debug information during (de)serialization..
Apr 29 2020, 8:00 AM · Restricted Project

Apr 27 2020

denis13 abandoned D78951: [mlir][spirv] Enable serialization to SPIR-V binary..

Was fixed at https://reviews.llvm.org/D78934

Apr 27 2020, 1:27 PM · Restricted Project
denis13 updated the diff for D78951: [mlir][spirv] Enable serialization to SPIR-V binary..

Rebase on master.

Apr 27 2020, 12:55 PM · Restricted Project
denis13 created D78951: [mlir][spirv] Enable serialization to SPIR-V binary..
Apr 27 2020, 12:22 PM · Restricted Project

Apr 22 2020

denis13 committed rG1009177d498f: [mlir][vulkan-runner] Add support for integer types. (authored by denis13).
[mlir][vulkan-runner] Add support for integer types.
Apr 22 2020, 9:47 AM
denis13 closed D78560: [mlir][vulkan-runner] Add support for integer types..
Apr 22 2020, 9:46 AM · Restricted Project
denis13 committed rGec16df706682: [mlir][vulkan-runner] Fix testsuite. (authored by denis13).
[mlir][vulkan-runner] Fix testsuite.
Apr 22 2020, 8:40 AM
denis13 closed D78639: [mlir][vulkan-runner] Fix testsuite..
Apr 22 2020, 8:39 AM · Restricted Project
denis13 created D78639: [mlir][vulkan-runner] Fix testsuite..
Apr 22 2020, 8:06 AM · Restricted Project
denis13 updated the diff for D78560: [mlir][vulkan-runner] Add support for integer types..

Addresses review comments.

Apr 22 2020, 3:12 AM · Restricted Project
denis13 added a comment to D78560: [mlir][vulkan-runner] Add support for integer types..

@antiagainst thanks for review, updated!

Apr 22 2020, 3:12 AM · Restricted Project

Apr 21 2020

denis13 created D78560: [mlir][vulkan-runner] Add support for integer types..
Apr 21 2020, 6:26 AM · Restricted Project

Apr 18 2020

denis13 committed rGa48f0a3c7e9f: [mlir][vulkan-runner] Simplify vulkan launch call op. (authored by denis13).
[mlir][vulkan-runner] Simplify vulkan launch call op.
Apr 18 2020, 7:01 AM
denis13 closed D78307: [mlir][vulkan-runner] Simplify vulkan launch call op..
Apr 18 2020, 7:00 AM · Restricted Project

Apr 16 2020

denis13 added inline comments to D78307: [mlir][vulkan-runner] Simplify vulkan launch call op..
Apr 16 2020, 1:55 PM · Restricted Project
denis13 created D78307: [mlir][vulkan-runner] Simplify vulkan launch call op..
Apr 16 2020, 9:27 AM · Restricted Project

Apr 13 2020

denis13 committed rGec99d6e62f0a: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`. (authored by denis13).
[mlir][spirv] Add a `spirv::InterfaceVarABIAttr`.
Apr 13 2020, 1:02 PM
denis13 closed D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`..
Apr 13 2020, 1:01 PM · Restricted Project
denis13 added a comment to D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`..

@mravishankar thanks for review!

Apr 13 2020, 11:17 AM · Restricted Project
denis13 added inline comments to D78034: [mlir][spirv] Improve stride support in array types.
Apr 13 2020, 11:17 AM · Restricted Project
denis13 added a comment to D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`..

@antiagainst thanks for review!I'll fix it.

Apr 13 2020, 11:17 AM · Restricted Project
denis13 accepted D78034: [mlir][spirv] Improve stride support in array types.

LGTM! Looks more pretty than it was, thanks!

Apr 13 2020, 11:17 AM · Restricted Project

Apr 11 2020

denis13 added a comment to D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`..

This patch is related to an issue https://bugs.llvm.org/show_bug.cgi?id=45392

Apr 11 2020, 8:31 AM · Restricted Project
denis13 created D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`..
Apr 11 2020, 6:23 AM · Restricted Project

Apr 10 2020

denis13 accepted D77803: [mlir][spirv] Update doc regarding availability and type conversion.

LGTM!

Apr 10 2020, 4:49 AM · Restricted Project

Apr 3 2020

denis13 committed rG0718e3ae31b0: [mlir][vulkan-runner] Add support for 3D memrefs. (authored by denis13).
[mlir][vulkan-runner] Add support for 3D memrefs.
Apr 3 2020, 5:21 AM
denis13 closed D77157: [mlir][vulkan-runner] Add support for 3D memrefs..
Apr 3 2020, 5:20 AM · Restricted Project
denis13 added a comment to D77157: [mlir][vulkan-runner] Add support for 3D memrefs..

@antiagainst thanks a lot for review! Sure, I would like to help!

Apr 3 2020, 5:20 AM · Restricted Project

Mar 31 2020

denis13 created D77157: [mlir][vulkan-runner] Add support for 3D memrefs..
Mar 31 2020, 11:58 AM · Restricted Project

Mar 27 2020

denis13 committed rG8f4ab8c7d7f5: [mlir][vulkan-runner] Add support for 2D memref. (authored by denis13).
[mlir][vulkan-runner] Add support for 2D memref.
Mar 27 2020, 4:18 AM
denis13 closed D76737: [mlir][vulkan-runner] Add support for 2D memref..
Mar 27 2020, 4:17 AM · Restricted Project

Mar 26 2020

denis13 added inline comments to D76737: [mlir][vulkan-runner] Add support for 2D memref..
Mar 26 2020, 2:08 PM · Restricted Project

Mar 25 2020

denis13 accepted D76799: [mlir][vulkan-runner] Add test to time a large vector add.

LGTM! Thanks!
I'm currently have access only to "mobile" gpu "GeForce GTX 1050 Mobile":
Compute shader execution time: 15.360us
Command buffer submit time: 7us
Wait idle time: 155us

Mar 25 2020, 3:11 PM · Restricted Project

Mar 24 2020

denis13 created D76737: [mlir][vulkan-runner] Add support for 2D memref..
Mar 24 2020, 3:39 PM · Restricted Project

Mar 18 2020

denis13 added a comment to D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..

@mehdi_amini thanks, recently obtained it.

Mar 18 2020, 4:18 AM · Restricted Project

Mar 17 2020

denis13 added inline comments to D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..
Mar 17 2020, 3:43 AM · Restricted Project
denis13 updated the diff for D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..

Address review comments.

Mar 17 2020, 3:43 AM · Restricted Project

Mar 12 2020

denis13 updated the diff for D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..

Address review comments.

Mar 12 2020, 10:51 AM · Restricted Project
denis13 added inline comments to D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..
Mar 12 2020, 10:51 AM · Restricted Project
denis13 updated the diff for D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..

Fix LINT issues.

Mar 12 2020, 10:18 AM · Restricted Project
denis13 added a comment to D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..

This patch eliminates VulkanLaunchOpOperandAdaptor and enables emitCWrappers while lowering to LLVM dialect. By doing this we follow the official guideline for calling convention https://mlir.llvm.org/docs/ConversionToLLVMDialect/#calling-convention.
emitCWrappers enables the following steps:

Mar 12 2020, 5:53 AM · Restricted Project
denis13 created D76059: [mlir][vulkan-runner] Use C-compatible wrapper emission..
Mar 12 2020, 5:13 AM · Restricted Project

Mar 11 2020

denis13 added inline comments to D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..
Mar 11 2020, 2:19 AM · Restricted Project
denis13 added a comment to D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

@rriddle thanks for review, will address it in follow up pr.

Mar 11 2020, 2:19 AM · Restricted Project
denis13 added a comment to D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

This seems to have broken build on gcc 5:
error: converting to 'std::tuple<mlir::Value, mlir::Value>' from initializer list would use explicit constructor 'constexpr std::tuple<_T1, _T2>::tuple(const _T1&, const _T2&) [with _T1 = mlir::Value; _T2 = mlir::Value]'

operands[numConfigOps + index * loweredMemRefNumOps1D + 3]};
                                                          ^
Mar 11 2020, 2:19 AM · Restricted Project

Mar 10 2020

denis13 added inline comments to D75869: [mlir][spirv] Use larger range for target environment lookup function.
Mar 10 2020, 2:19 AM · Restricted Project
denis13 accepted D75868: [mlir][spirv] Use separate attribute for (version, capabilities, extensions).

LGTM! Thanks!

Mar 10 2020, 2:19 AM · Restricted Project

Mar 5 2020

denis13 updated the diff for D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

Address comments, sorry for delay.

Mar 5 2020, 1:44 PM · Restricted Project
denis13 retitled D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver. from [mlir][spirv] Update mlir-vulkan-runner execution driver. to [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..
Mar 5 2020, 1:44 PM · Restricted Project

Mar 2 2020

denis13 added a comment to D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

@antiagainst thanks a lot for detailed review! I'll update soon according to your suggestions, thanks!

Mar 2 2020, 7:29 AM · Restricted Project

Feb 28 2020

denis13 updated the diff for D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

Rebase on master.

Feb 28 2020, 4:13 AM · Restricted Project

Feb 26 2020

denis13 updated the diff for D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

Disable clang-diagnostic for include vulkan header file.

Feb 26 2020, 10:54 AM · Restricted Project
denis13 updated the summary of D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..
Feb 26 2020, 9:10 AM · Restricted Project
denis13 updated the summary of D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..
Feb 26 2020, 9:03 AM · Restricted Project
denis13 added a comment to D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..

To eliminate static construction and desctruction of VulkanRuntimeManager, we need to instrument runtime calls with first argument as a generic pointer to VulkanRuntimeManager, but the setResource function based on std dialect, which fills the given memref with the given value, could not accept generic pointers, because std dialect does not have generic pointer types. So, to solve it, I added new pass which serializes spirv::Module to binary form appends it as a string attribute to vulkan launch call op. Erases all gpu.module and spirv::Module, so we can lower it to LLVM directly, then we instrument host part with runtime calls as before, but adding initVulkan, deinitVulkan calls and for each lowered memref we create call to bindResource according the current GPUToSPIRV convention (Each resource binds to 0 descriptor set and descriptor binding argument order lined up in argument order.

Feb 26 2020, 9:03 AM · Restricted Project
denis13 created D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver..
Feb 26 2020, 9:00 AM · Restricted Project
denis13 accepted D75170: [mlir][spirv] NFC: move folders and canonicalizers in a separate file.

LGTM!

Feb 26 2020, 7:24 AM · Restricted Project

Feb 23 2020

denis13 committed rG21316f6f9283: [NFC] Test commit access. Drop trivial braces. (authored by denis13).
[NFC] Test commit access. Drop trivial braces.
Feb 23 2020, 4:21 AM

Feb 20 2020

denis13 closed D50180: [Sanitizers] Libasan failed to be build with -mthumb and -fno-omit-frame-pointer by GCC.

Since no users anymore for this patch, closing it :)

Feb 20 2020, 2:02 PM

Feb 17 2020

denis13 added a comment to D72696: [mlir][spirv] Add mlir-vulkan-runner.

Thanks, looking forward for the feedback from Lei.

Feb 17 2020, 1:15 AM · Restricted Project

Feb 14 2020

denis13 updated the diff for D72696: [mlir][spirv] Add mlir-vulkan-runner.

Rebased on master to trigger a rebuild.

Feb 14 2020, 10:48 AM · Restricted Project

Feb 13 2020

denis13 updated the diff for D72696: [mlir][spirv] Add mlir-vulkan-runner.

Addresses review comments.

Feb 13 2020, 2:15 PM · Restricted Project
denis13 retitled D72696: [mlir][spirv] Add mlir-vulkan-runner from [mlir][spirv] mlir-vulkan-runner to [mlir][spirv] Add mlir-vulkan-runner.
Feb 13 2020, 2:15 PM · Restricted Project
denis13 updated the diff for D72696: [mlir][spirv] Add mlir-vulkan-runner.

Addresses review comments.

Feb 13 2020, 2:06 PM · Restricted Project
denis13 added a comment to D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..

@rriddle thanks, I'll address your comments D72696

Feb 13 2020, 12:15 PM · Restricted Project
denis13 updated the diff for D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..

Addressed review comments.

Feb 13 2020, 9:28 AM · Restricted Project
denis13 added inline comments to D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..
Feb 13 2020, 9:28 AM · Restricted Project
denis13 updated the diff for D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..

Rebased on master.

Feb 13 2020, 7:03 AM · Restricted Project
denis13 updated the summary of D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..
Feb 13 2020, 5:31 AM · Restricted Project
denis13 updated the diff for D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..

Fix typo in comment.

Feb 13 2020, 5:31 AM · Restricted Project
denis13 added a comment to D72696: [mlir][spirv] Add mlir-vulkan-runner.

Thanks a lot for review! I addressed comments related to pass in separate revision https://reviews.llvm.org/D74549 and will update mlir-vulkan-runner, VulkanRuntime as well.

Feb 13 2020, 5:21 AM · Restricted Project
denis13 created D74549: [mlir][spirv] Add pass ConvertGpuLaunchFuncToVulkanCallsPass..
Feb 13 2020, 5:21 AM · Restricted Project

Feb 11 2020

denis13 updated the diff for D72696: [mlir][spirv] Add mlir-vulkan-runner.

Added simple test to check GpuLaunchFuncToVulkanCalssPass.
Rebased on D74012.
Rebased on 5a1778 which changes MemRef calling convention.

Feb 11 2020, 9:03 AM · Restricted Project