[OpenMP][Tool] Handle detached tasks in Archer
ClosedPublic
Actions

Authored by protze.joachim on Jun 5 2020, 3:36 PM.

Details

Reviewers

Hahnfeld
jdoerfert

Summary

Since detached tasks are supported by clang and the OpenMP runtime, Archer must expect to receive the corresponding callbacks.

This patch adds support to interpret the synchronization semantics of omp_fulfill_event and cleans up the handling of task switches.
The task_late_fulfill.c currently cannot use if(0) for the first task to avoid the race on f_event.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	480 ms	libarcher.task::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/openmp/tools/archer/tests -I /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/lib -Wl,-rpath,/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/lib /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/openmp/tools/archer/tests/task/task_early_fulfill.c -o /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/projects/openmp/tools/archer/tests/task/Output/task_early_fulfill.c.tmp -latomic -fopenmp-version=50 && env OMP_NUM_THREADS='3' env TSAN_OPTIONS='ignore_noninstrumented_modules=1' /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/projects/openmp/tools/archer/tests/task/Output/task_early_fulfill.c.tmp 2>&1 \| tee /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/projects/openmp/tools/archer/tests/task/Output/task_early_fulfill.c.tmp.log

Event Timeline

protze.joachim created this revision.Jun 5 2020, 3:36 PM

Herald added subscribers: sstefan1, guansong, yaxunl. · View Herald TranscriptJun 5 2020, 3:36 PM

Harbormaster failed remote builds in B59332: Diff 268953!Jun 5 2020, 4:16 PM

The tests of cause require tsan.
Also added build dependence to tsan, if tsan is built in the same build.

Herald added a subscriber: mgorny. · View Herald TranscriptJun 6 2020, 8:01 AM

ping

Herald added a subscriber: aaron.ballman. · View Herald TranscriptAug 5 2020, 4:28 AM

Fixed handling of ompt_task_cancel.

This looks reasonable, not that I have much experience with ARCHER.

openmp/tools/archer/tests/task/task_late_fulfill.c
40	Leftover?

This revision is now accepted and ready to land.Oct 29 2020, 1:00 PM

Pushed as e99207feb4b901e8f7bb6d3e70388d31fafc4330, missed to include the Revision line.

ye-luo added a subscriber: ye-luo.Nov 4 2020, 2:47 PM

ye-luo added inline comments.

openmp/tools/archer/tests/task/task_late_fulfill.c
38	de-referencing uninitialized pointer f_event? I expect no task has been run at this point.

ye-luo added inline comments.Nov 4 2020, 4:51 PM

openmp/tools/archer/tests/task/task_late_fulfill.c
38	de-referencing uninitialized pointer f_event? I expect no task has been run at this point. This test is probably good. When OMP_NUM_THREADS>1, there are additional threads available for picking up task 1 and task must be completed within 20000 usec. Not robust but probably OK. When OMP_NUM_THREADS=1, the parallel is inactive and task 1 runs immediately, task 2 is deferred due to dependency, So this test also works fine.

Original intention was to have if(0) on the first task. Unfortunately, clang drops the out dependency for detached tasks in that case: https://bugs.llvm.org/show_bug.cgi?id=46185
Once the clang bug is fixed, we can add the if(0) and make the test more robust.

protze.joachim added inline comments.Nov 11 2020, 11:21 AM

openmp/tools/archer/tests/task/task_late_fulfill.c
38	During discussion for the OpenMP Examples document, I realized that taking the address is not necessary. I pushed a fix as 3fa2e193384048daafe1fa74bf88253b4cf5ce6e.