[Mlir] Add assembly format for `shape.mul`.

[silvas]

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

285

FYI, I think after Jacques' recent patch, you can remove DeclareOpInterfaceMethods<InferTypeOpInterface> as well. I think it would be cool to include that in this patch as well.

[jpienaar]

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

285

I thought I removed all of these earlier this week ...

[pifon2a]

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

285

it was removed by Jacques. I just needed to rebase...

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

def Shape_MulOp : Shape_Op<"mul", [SameOperandsAndResultType]> {
   let description = [{
     Multiplies two valid sizes as follows:
     - lhs * rhs = unknown if either lhs or rhs unknown;
     - lhs * rhs = (int)lhs * (int)rhs if both known;
   }];
 
   let arguments = (ins Shape_SizeType:$lhs, Shape_SizeType:$rhs);
   let results = (outs Shape_SizeType:$result);
+
+  let assemblyFormat = "attr-dict $lhs `,` $rhs";
 }
 
 def Shape_NumElementsOp : Shape_Op<"num_elements", [
     NoSideEffect,
     DeclareOpInterfaceMethods<InferTypeOpInterface>]> {
 
   let summary = "Returns the number of elements for a given shape";
   let description = [{
     Returns the number of elements for a given shape which is the product of its
     dimensions.
+
+    ```mlir
+    %product = shape.mul %lhs, %rhs
+    ```
   }];
 
   let arguments = (ins Shape_ShapeType:$shape);
   let results = (outs Shape_SizeType:$result);
 
   let assemblyFormat = "attr-dict $shape";
 
   let hasFolder = 1;

mlir/test/Dialect/Shape/ops.mlir

 // RUN: mlir-opt -split-input-file %s | mlir-opt | FileCheck %s --dump-input-on-failure
+// Verify the printed output can be parsed.
+// RUN: mlir-opt %s | mlir-opt | FileCheck %s --dump-input-on-failure
+// Verify the generic form can be parsed.
+// RUN: mlir-opt -mlir-print-op-generic %s | mlir-opt | FileCheck %s --dump-input-on-failure
 
 // CHECK-LABEL: shape_num_elements
 func @shape_num_elements(%shape : !shape.shape) -> !shape.size {
   %0 = shape.const_size 0
   %1 = "shape.reduce"(%shape, %0) ( {
     ^bb0(%index: i32, %dim: !shape.size, %lci: !shape.size):
       %acc = "shape.add"(%lci, %dim) : (!shape.size, !shape.size) -> !shape.size
       "shape.yield"(%acc) : (!shape.size) -> ()
func @test_constraints() {
   %w1 = shape.cstr_eq %0, %1
   %w3 = shape.assuming_all %w0, %w1
   shape.assuming %w3 -> !shape.shape {
     %2 = shape.any %0, %1
     shape.assuming_yield %2 : !shape.shape
   }
   return
 }
+
+func @test_mul(%lhs: !shape.size, %rhs: !shape.size) -> !shape.size {
+  %product = shape.mul %lhs, %rhs
+  return %product: !shape.size
+}