This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Separate fields in headers with commas.
ClosedPublic

Authored by ikudrin on May 29 2020, 8:37 AM.

Diff Detail

Event Timeline

ikudrin created this revision.May 29 2020, 8:37 AM
dblaikie accepted this revision.May 29 2020, 9:19 AM

Awesome, thanks! (could separate this into three commits for the three independent changes but I don't feel strongly about that)
Maybe we could even have a utility for printing these headers we could reuse in all these places to ensure consistency? Might not be worth it, though - not sure.

This revision is now accepted and ready to land.May 29 2020, 9:19 AM
MaskRay accepted this revision.May 31 2020, 10:26 AM

See harbomaster failures. Two test/CodeGen/X86/ tests need adjustment as well.

jhenderson accepted this revision.Jun 1 2020, 2:00 AM

LGTM, with the other tests fixed.

This revision was automatically updated to reflect the committed changes.