Page MenuHomePhabricator

[mlir][GPU] Link relevant LLVM components in GPUCommon instead of test
ClosedPublic

Authored by ftynse on May 28 2020, 10:01 AM.

Details

Summary

D80142 restructured MLIR-to-GPU-binary conversion to support multiple
targets. It also modified cmake files to link relevant LLVM components
in test/lib, which broke shared-library builds, and likely made the
conversions unusable outside mlir-opt (or other tools that link in test
library targets). Link these components to GPUCommon instead.

Diff Detail

Event Timeline

ftynse created this revision.May 28 2020, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2020, 10:01 AM

@ftynse Thanks for the patch. Wondering would it be a better idea to amend the text at: https://mlir.llvm.org/getting_started/ so -DBUILD_SHARED_LIBS=ON is always turned on?

whchung accepted this revision.May 28 2020, 10:54 AM
This revision is now accepted and ready to land.May 28 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.