[clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

[njames93]

Summary

Fixes readability-identifier-naming option MacroDefinitionCase should ignore macros passed as parameters.

[aaron.ballman]

LGTM, thank you for this!

[MaskRay]

arc adds many unneeded tags from Phabricator. You can drop Reviewers: Subscribers: Tags: and the text Summary: with the following script:

arcfilter () {
  arc amend
  git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people (https://lists.llvm.org/pipermail/llvm-dev/2020-January/137889.html). You should keep the tag. (I started to use --date=now because some people find author date != committer date annoying. The committer date is usually what people care.))

[njames93]

In D80631#2065168, @MaskRay wrote:

arc adds many unneeded tags from Phabricator. You can drop Reviewers: Subscribers: Tags: and the text Summary: with the following script:

arcfilter () {
  arc amend
  git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people (https://lists.llvm.org/pipermail/llvm-dev/2020-January/137889.html). You should keep the tag. (I started to use --date=now because some people find author date != committer date annoying. The committer date is usually what people care.))

Thanks for this, got it working nicely here https://github.com/llvm/llvm-project/commit/5952125691571de9bd817551fb1baabe270e73f9

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

 public:
   RenamerClangTidyCheckPPCallbacks(Preprocessor *PP,
                                    RenamerClangTidyCheck *Check)
       : PP(PP), Check(Check) {}
 
   /// MacroDefined calls checkMacro for macros in the main file
   void MacroDefined(const Token &MacroNameTok,
                     const MacroDirective *MD) override {
+    if (MD->getMacroInfo()->isBuiltinMacro())
+      return;
+    if (PP->getSourceManager().isWrittenInBuiltinFile(
+            MacroNameTok.getLocation()))
+      return;
+    if (PP->getSourceManager().isWrittenInCommandLineFile(
+            MacroNameTok.getLocation()))
+      return;
     Check->checkMacro(PP->getSourceManager(), MacroNameTok, MD->getMacroInfo());
   }
 
   /// MacroExpands calls expandMacro for macros in the main file
   void MacroExpands(const Token &MacroNameTok, const MacroDefinition &MD,
                     SourceRange /*Range*/,
                     const MacroArgs * /*Args*/) override {
     Check->expandMacro(MacroNameTok, MD.getMacroInfo());

clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp

 // RUN:     {key: readability-identifier-naming.PointerParameterCase, value: lower_case}, \
 // RUN:     {key: readability-identifier-naming.PointerParameterPrefix, value: 'p_'}, \
 // RUN:     {key: readability-identifier-naming.ConstantPointerParameterCase, value: CamelCase}, \
 // RUN:     {key: readability-identifier-naming.ConstantPointerParameterPrefix, value: 'cp_'}, \
 // RUN:     {key: readability-identifier-naming.LocalPointerCase, value: CamelCase}, \
 // RUN:     {key: readability-identifier-naming.LocalPointerPrefix, value: 'l_'}, \
 // RUN:     {key: readability-identifier-naming.LocalConstantPointerCase, value: CamelCase}, \
 // RUN:     {key: readability-identifier-naming.LocalConstantPointerPrefix, value: 'lc_'}, \
-// RUN:   ]}' -- -fno-delayed-template-parsing \
+// RUN:   ]}' -- -fno-delayed-template-parsing -Dbad_macro \
 // RUN:   -I%S/Inputs/readability-identifier-naming \
 // RUN:   -isystem %S/Inputs/readability-identifier-naming/system
 
 // clang-format off
 
 #include <system-header.h>
 #include "user-header.h"
 // NO warnings or fixes expected from declarations within header files without