This is an archive of the discontinued LLVM Phabricator instance.

Differential D80463

Debug Info: Mark os_log helper functions as artificial
ClosedPublic

Authored by aprantl on May 22 2020, 5:36 PM.

Details

Reviewers
vsk
ahatanak
JDevlieghere
friss
Commits
rGb8fe1f678a1e: Debug Info: Mark os_log helper functions as artificial
rGb59b3640bcbd: Debug Info: Mark os_log helper functions as artificial
Summary

The os_log helper functions are linkonce_odr and supposed to be uniqued across TUs, so attachine a DW_AT_decl_line on it is highly misleading. By setting the function decl to implicit, CGDebugInfo properly marks the functions as artificial and uses a default file / line 0 location for the function.

rdar://problem/63450824

Diff Detail

Event Timeline

aprantl created this revision.May 22 2020, 5:36 PM
Herald added a subscriber: dexonsmith. · View Herald TranscriptMay 22 2020, 5:36 PM
aprantl edited the summary of this revision. (Show Details)May 22 2020, 5:36 PM
vsk accepted this revision.May 22 2020, 6:16 PM

Thanks, lgtm!

This revision is now accepted and ready to land.May 22 2020, 6:16 PM
Closed by commit rGb59b3640bcbd: Debug Info: Mark os_log helper functions as artificial (authored by aprantl). · Explain WhyMay 26 2020, 9:12 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 9:12 AM

Revision Contents

PathSize
clang/
lib/
CodeGen/
2 lines
test/
CodeGen/
15 lines

Diff 266243

clang/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,265 Lines • ▼ Show 20 Linesllvm::Function *CodeGenFunction::generateBuiltinOSLogHelperFunction(
if (CGM.getCodeGenOpts().OptimizeSize == 2) if (CGM.getCodeGenOpts().OptimizeSize == 2)
Fn->addFnAttr(llvm::Attribute::NoInline); Fn->addFnAttr(llvm::Attribute::NoInline);
auto NL = ApplyDebugLocation::CreateEmpty(*this); auto NL = ApplyDebugLocation::CreateEmpty(*this);
IdentifierInfo *II = &Ctx.Idents.get(Name); IdentifierInfo *II = &Ctx.Idents.get(Name);
FunctionDecl *FD = FunctionDecl::Create( FunctionDecl *FD = FunctionDecl::Create(
Ctx, Ctx.getTranslationUnitDecl(), SourceLocation(), SourceLocation(), II, Ctx, Ctx.getTranslationUnitDecl(), SourceLocation(), SourceLocation(), II,
FuncionTy, nullptr, SC_PrivateExtern, false, false); FuncionTy, nullptr, SC_PrivateExtern, false, false);
// Avoid generating debug location info for the function.
FD->setImplicit();
StartFunction(FD, ReturnTy, Fn, FI, Args); StartFunction(FD, ReturnTy, Fn, FI, Args);
// Create a scope with an artificial location for the body of this function. // Create a scope with an artificial location for the body of this function.
auto AL = ApplyDebugLocation::CreateArtificial(*this); auto AL = ApplyDebugLocation::CreateArtificial(*this);
CharUnits Offset; CharUnits Offset;
Address BufAddr(Builder.CreateLoad(GetAddrOfLocalVar(Args[0]), "buf"), Address BufAddr(Builder.CreateLoad(GetAddrOfLocalVar(Args[0]), "buf"),
▲ Show 20 Lines • Show All 15,130 Lines • Show Last 20 Lines

clang/test/CodeGen/debug-info-oslog.c

  • This file was added.
// RUN: %clang_cc1 -triple x86_64-darwin-apple -debug-info-kind=limited \
// RUN: %s -emit-llvm -o - | FileCheck %s
void test_builtin_os_log(void *buf, int i, const char *data) {
__builtin_os_log_format(buf, "%d", i);
}
// CHECK: define linkonce_odr {{.*}}@__os_log_helper_1_0_1_4_0(
// CHECK-SAME: !dbg ![[OS_LOG_HELPER:[0-9]+]]
// This helper is going to be uniqued, so it should not have a line
// number between file and type.
// CHECK: distinct !DISubprogram(name: "__os_log_helper_1_0_1_4_0",
// CHECK-SAME: file: !{{[0-9+]}}, type
// CHECK-SAME: flags: DIFlagArtificial