This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add `num_elements` to the shape dialect
ClosedPublic

Authored by frgossen on May 20 2020, 2:08 AM.

Details

Summary

The operation num_elements determines the number of elements for a given
shape.
That is the product of its dimensions.
A tensor of the given shape holds this many elements.

Depends On D80280

Diff Detail

Event Timeline

frgossen created this revision.May 20 2020, 2:08 AM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
pifon2a accepted this revision.May 20 2020, 2:42 AM
herhut accepted this revision.May 20 2020, 3:34 AM

Thanks!

silvas accepted this revision.May 20 2020, 11:56 AM
jpienaar accepted this revision.May 20 2020, 4:30 PM

Thanks

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
242

Seems redundant with the previous line?

243

Already documented in arguments and results

This revision is now accepted and ready to land.May 20 2020, 4:30 PM
frgossen updated this revision to Diff 266132.May 26 2020, 2:16 AM

Remove redundant documentation

frgossen marked 2 inline comments as done.May 26 2020, 2:16 AM
This revision was automatically updated to reflect the committed changes.