Page MenuHomePhabricator

[AArch64][CostModel] getCastInstrCost
ClosedPublic

Authored by samparker on Thu, May 7, 3:33 AM.

Details

Summary

Pass the instruction to the base implementation.

Diff Detail

Event Timeline

samparker created this revision.Thu, May 7, 3:33 AM

Are there costmodel tests for these? If not can you copy the ones over from ARM?

I copied over the tests in https://reviews.llvm.org/rG751da4d596ea, and this patch doesn't change the results.

Is that missing the load_extends tests? Are they the same?

Bingo. Cheers Dave, with those tests ported over it shows some differences.

dmgreen accepted this revision.Tue, May 12, 1:23 AM

They do look like they should be free to me.

LGTM.

This revision is now accepted and ready to land.Tue, May 12, 1:23 AM
This revision was automatically updated to reflect the committed changes.