I thought it would be simpler to understand on how the unique names would look like when an example is present. So I added some examples.
I found 2 such places to add examples
-Common blocks
-Module scope global data
Differential D79442
[flang] Add examples in documentation/BijectiveInternalNameUniquing.md sameeranjoshi on May 5 2020, 1:25 PM. Authored by
Details I thought it would be simpler to understand on how the unique names would look like when an example is present. So I added some examples. I found 2 such places to add examples
Diff Detail Event TimelineComment Actions Thanks for adding these examples
Comment Actions Thanks for adding these examples. A related addition would be to add a unittest that constructs and deconstructs the unique names. Comment Actions Is there some testing guide for the same? Comment Actions I checked LLVM unittesting guidelines for writing tests using gtest and gmock. I grepped for gtest.h and gmock.h, I ended up with no results.
|
The indentation of module mod is slightly weird. Also, I think you could add end module or ... at the end.