[mlir] Add missing dependency to MLIRMlirOptMain

[jpienaar]

Thanks!

[mehdi_amini]

mlir/tools/mlir-opt/CMakeLists.txt

47

Can you clarify which header included from mlir-opt.cpp depends on these?

[antiagainst]

mlir/tools/mlir-opt/CMakeLists.txt

47

InitAllDialects.h. Do you want me to add as a comment to the code? Happy to send out a patch for it if so.

[mehdi_amini]

mlir/tools/mlir-opt/CMakeLists.txt

47

I'd rather cut the dependency :)
I don't think calling into the initialization of dialect should require generated headers: this seems like a rather fundamentally static method.

It seems that this is due to template initialization, we could get away with an indirection, I'll look into this.

[stephenneuendorffer]

We saw some broken windows builds this morning, but I think there is a better fix. In general, I don't think everything should depend on intrinsics_gen.. In this case, MLIROptMain was missing a PUBLIC dependence on it's libraries (including Linalg) which was (I believe) the root of the problem.

[stephenneuendorffer]

In particular c296d2dc53d5c11ce0 should fix this.

[antiagainst]

In D79429#2021563, @stephenneuendorffer wrote:

We saw some broken windows builds this morning, but I think there is a better fix. In general, I don't think everything should depend on intrinsics_gen.. In this case, MLIROptMain was missing a PUBLIC dependence on it's libraries (including Linalg) which was (I believe) the root of the problem.

Thanks for the pointer! Yeah that's better. Sent https://reviews.llvm.org/D79574 to remove the redundancy DEPENDS.

mlir/tools/mlir-opt/CMakeLists.txt

set(LIBS
   MLIRTransforms
   MLIRTransformUtils
   MLIRTestDialect
   MLIRTestIR
   MLIRTestPass
   MLIRTestTransforms
   MLIRSupport
   MLIRIR
-  MLIROptLib
   )
 
 # Exclude from libMLIR.so because this has static options intended for
 # opt-like tools only.
 add_mlir_library(MLIRMlirOptMain
   mlir-opt.cpp
 
   EXCLUDE_FROM_LIBMLIR
 
   LINK_LIBS
   ${LIBS}
+
+  DEPENDS
+  intrinsics_gen
+  mlir-headers
   )
 
 add_llvm_tool(mlir-opt
   mlir-opt.cpp
 
   DEPENDS
   ${LIBS}
   )
 target_link_libraries(mlir-opt PRIVATE ${LIBS})
 llvm_update_compile_flags(mlir-opt)
 
 mlir_check_link_libraries(mlir-opt)