Page MenuHomePhabricator

[llvm-objcopy][ELF] Allow --dump-section to dump an empty non-SHT_NOBITS section
ClosedPublic

Authored by MaskRay on Mon, May 4, 10:12 AM.

Diff Detail

Event Timeline

MaskRay created this revision.Mon, May 4, 10:12 AM
Herald added a reviewer: alexshap. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Tue, May 5, 12:21 AM

LGTM.

llvm/test/tools/llvm-objcopy/ELF/dump-section.test
51

Nit: the prevailing pattern for FileCheck directives in this file is currently #CHECK: (no space). I'm okay if you want to change the other lines to match the # CHECK: style, but perhaps do as a separate NFC commit. Alternatively, make this match the existing ones.

This revision is now accepted and ready to land.Tue, May 5, 12:21 AM
MaskRay updated this revision to Diff 262120.Tue, May 5, 8:24 AM
MaskRay marked an inline comment as done.

#CHECK -> # CHECK in a separate commit