[DebugInfo] - DWARFDebugFrame: do not call abort() on errors.

[grimar]

Summary

Imagine we have a broken .eh_frame.
Below is a possible sample output of llvm-readelf:

...
    entry 2 {
      initial_location: 0x10f5
      address: 0x2080
    }
  }
}
.eh_frame section at offset 0x2028 address 0x2028:
LLVM ERROR: Parsing entry instructions at 0 failed
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
Stack dump:
0.  Program arguments: /home/umb/LLVM/LLVM/llvm-project/build/bin/llvm-readelf -a 1
 #0 0x000055f4a2ff5a1a llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/home/umb/LLVM/LLVM/llvm-project/build/bin/llvm-readelf+0x2b9a1a)
...
#15 0x00007fdae5dc209b __libc_start_main /build/glibc-B9XfQf/glibc-2.28/csu/../csu/libc-start.c:342:3
#16 0x000055f4a2db746a _start (/home/umb/LLVM/LLVM/llvm-project/build/bin/llvm-readelf+0x7b46a)
Aborted

I.e. it calls abort(), suggests to submit a bug report and exits with the code 134.
This patch changes the logic to propagate errors to callers.
This fixes the behavior for llvm-dwarfdump, llvm-readobj and other possible tools.

[grimar]

• Fix comment.

[grimar]

• And one more.

[ikudrin]

Overall looks good. You may want to add a note to PR45105.

llvm/test/DebugInfo/X86/eh-frame-cie-id.s

1

Why do you need to keep that temporary file?

4

Prefixing offsets with 0x should be probably extracted to a separate patch.

[grimar]

In D79165#2012656, @ikudrin wrote:

You may want to add a note to PR45105.

Ah. I didn't see it, thanks! I faced this crash independently using another broken object.

llvm/test/DebugInfo/X86/eh-frame-cie-id.s

1

Having temporarily files helps to debug tests when they fail.

4

This error message is just broken without 0x as it prints values in hex, but you can't know it.
We often adjust/improve messages when doing similar changes. E.g. add error locations or an additional context.
This is the only LLVM test which is affected anyways.

[MaskRay]

Thanks for the patch. Error reporting infrastructure in some components of LLVM is shaky. The merit of report_fatal_error is just that it is easy. As Eli Friedman mentioned, "you don't have to worry about formatting the diagnostic, or the implications of what happens after the error is triggered, or a location for the diagnostic." We do need to use more appropriate error reporting mechanism where we can.

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

532

The return type has been changed to Error. return std::move(E) should be written as return E to avoid clang `warning: moving a local object in a return statement prevents
copy elision [-Wpessimizing-move]`

llvm/test/DebugInfo/X86/eh-frame-cie-id.s

1

I tend to agree with the temporary file. llvm-lit requires me to change the current working directory to somewhere deep in bindir and I feel it cumbersome, so I started to use a simplified version of llvm-lit to run simple tests during debugging.

#!/usr/bin/env python3
import os, sys

os.environ["PATH"] = os.path.expanduser('/tmp/Debug/bin') + os.pathsep + os.environ['PATH']
fname = sys.argv[1]
last = ''

with open(sys.argv[1]) as f:
    for line in f.readlines():
        line = line.strip()
        i = line.find('RUN: ')
        if i < 0:
            last = ''
            continue
        line = line[i+5:]
        if line[-1] == '\\':
            last += line[:-1]
            continue
        line = last + line
        last = ''

        line = line.replace('%s', fname)
        line = line.replace('%S', '.')
        line = line.replace('%p', '.')
        line = line.replace('%t', 'a')
        line = line.replace('%clang_cc1', 'clang -cc1 -internal-isystem /tmp/Debug/lib/clang/11.0.0/include -nostdsysteminc')
        print(line)
        os.system(line)

4

Since the diagnostic line is touched and this is the only test, I think it is fine to adjust it in this patch.

llvm/test/tools/llvm-readobj/ELF/unwind.test

220

We don't need to mention the previous behavior.

237

Perhaps an assembly test is better here? It will require REQUIRES: x86-registered-target.

(You may be interested in this thread:
http://lists.llvm.org/pipermail/llvm-dev/2020-April/141203.html "[yaml2obj] GSoC-20: Add DWARF support to yaml2obj" also see the same thread on 2020-March

[grimar]

• Addressed review comments.

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

532

Ah. I was under impression that return E instead of std::move(E) won't compile, because it usually doesn't (when the function returns Expected<>, what is very common), but I've missed we return an Error here. Thanks!

llvm/test/tools/llvm-readobj/ELF/unwind.test

237

I expect one day we will be able to rewrite it to yaml. At least adding a support for .eh_frame does not feel too hard to me, though I've not tried and may miss something. And this sample is little, so I'd leave it as YAML.

[jhenderson]

llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

816–821

What do you think about fixing the naming of this variable to use UpperCamelCase here? (I see there might be some concerns, hence the question).

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

412–415

createStringError I think would be better?

createStringError would also allow this to change back to PRIx64, if I'm not mistaken.

Also, inconvertibleErrorCode() should probably be replaced with something else, probably invalid_argument.

421–424

Ditto to above.

439–442

Ditto to above.

458–461

Ditto to above.

485–489

Ditto to above.

515–519

Ditto to above.

535–541

Ditto to above.

[MaskRay]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

412–415

Maybe we can de-capitalize the diagnostic by the way.

createStringError(errc::invalid_argument, "unknown augmentation character in entry at 0x" PRIx64, ...)

[grimar]

• Addressed review comments.

llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

816–821

Ok, since it was introduced by this patch.

[jhenderson]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

Don't use illegal_byte_sequence - although it's not clear from the name, this is for Unicode encoding errors, so isn't the right error code for other invalid byte sequences. I've tended to use invalid_argument in similar situations.

[grimar]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

This file already use illegal_byte_sequence (line 50, 65). It is also used widely in LLVM to report invalid non-text data.

[jhenderson]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

Just because it's already used widely incorrectly doesn't mean we should continue to do so - I'm pretty confident that people are all making the same, perfectly understandable, mistake.

[grimar]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

Where it is said that illegal_byte_sequence is about unicode?

MSVS defines it as "illegal_byte_sequence = 42, // EILSEQ" (xerrc.h)

POSIX seems descrives it as "[EILSEQ] Illegal byte sequence."
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html

C95 says the same:
https://en.cppreference.com/w/c/error/errno_macros

[grimar]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

Seems that EILSEQ is used by functions like fputwc to report errors about wide characters. But I haven't found that it can't be used for other cases. And "Illegal byte sequence" description fits here much better than "Invalid argument".

[jhenderson]

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

413

You're right that the standard doesn't explicitly say it is for multibyte/UTF-8 etc, but every reference I found to it outside of LLVM is to do with such instances, so I think it can be reasonably inferred that that is the expected usage (I thought I ran into something at some point a couple of years ago where the illegal_byte_sequence usage actually caused a problem in LLVM because of this, although I haven't been able to identify where yet). invalid_argument is perfectly correct - the character being used here is not a valid input character (think of this piece of code as the augmentation string constructor).

[grimar]

• Use invalid_argument.

[jhenderson]

LGTM, but please give a chance for the other reviewers to look further too.

[MaskRay]

llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

816–821

auto because the type is obvious from make_unique

832

auto

llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h

public:
 
   /// Get a pointer to the parsed dwo abbreviations object.
   const DWARFDebugAbbrev *getDebugAbbrevDWO();
 
   /// Get a pointer to the parsed DebugAranges object.
   const DWARFDebugAranges *getDebugAranges();
 
   /// Get a pointer to the parsed frame information object.
-  const DWARFDebugFrame *getDebugFrame();
+  Expected<const DWARFDebugFrame *> getDebugFrame();
 
   /// Get a pointer to the parsed eh frame information object.
-  const DWARFDebugFrame *getEHFrame();
+  Expected<const DWARFDebugFrame *> getEHFrame();
 
   /// Get a pointer to the parsed DebugMacinfo information object.
   const DWARFDebugMacro *getDebugMacinfo();
 
   /// Get a pointer to the parsed DebugMacinfoDWO information object.
   const DWARFDebugMacro *getDebugMacinfoDWO();
 
   /// Get a pointer to the parsed DebugMacro information object.

llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h

public:
   ~DWARFDebugFrame();
 
   /// Dump the section data into the given stream.
   void dump(raw_ostream &OS, const MCRegisterInfo *MRI,
             Optional<uint64_t> Offset) const;
 
   /// Parse the section from raw data. \p Data is assumed to contain the whole
   /// frame section contents to be parsed.
-  void parse(DWARFDataExtractor Data);
+  Error parse(DWARFDataExtractor Data);
 
   /// Return whether the section has any entries.
   bool empty() const { return Entries.empty(); }
 
   /// DWARF Frame entries accessors
   iterator begin() const { return Entries.begin(); }
   iterator end() const { return Entries.end(); }
   iterator_range<iterator> entries() const {

llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

if (*Off) {
                            LLDumpOpts, /*Indent=*/0);
       OS << "\n";
     } else {
       Loc.dumpRange(0, Data.getData().size(), OS, getRegisterInfo(), *DObj,
                     LLDumpOpts);
     }
   }
 
-  if (const auto *Off = shouldDump(Explicit, ".debug_frame", DIDT_ID_DebugFrame,
-                                   DObj->getFrameSection().Data))
-    getDebugFrame()->dump(OS, getRegisterInfo(), *Off);
-
-  if (const auto *Off = shouldDump(Explicit, ".eh_frame", DIDT_ID_DebugFrame,
-                                   DObj->getEHFrameSection().Data))
-    getEHFrame()->dump(OS, getRegisterInfo(), *Off);
+  if (const Optional<uint64_t> *Off =
+          shouldDump(Explicit, ".debug_frame", DIDT_ID_DebugFrame,
+                     DObj->getFrameSection().Data)) {
+    if (Expected<const DWARFDebugFrame *> DF = getDebugFrame())
+      (*DF)->dump(OS, getRegisterInfo(), *Off);
+    else
+      RecoverableErrorHandler(DF.takeError());
+  }
+
+  if (const Optional<uint64_t> *Off =
+          shouldDump(Explicit, ".eh_frame", DIDT_ID_DebugFrame,
+                     DObj->getEHFrameSection().Data)) {
+    if (Expected<const DWARFDebugFrame *> DF = getEHFrame())
+      (*DF)->dump(OS, getRegisterInfo(), *Off);
+    else
+      RecoverableErrorHandler(DF.takeError());
+  }
 
   if (shouldDump(Explicit, ".debug_macro", DIDT_ID_DebugMacro,
                  DObj->getMacroSection().Data)) {
     if (auto Macro = getDebugMacro())
       Macro->dump(OS);
   }
 
   if (shouldDump(Explicit, ".debug_macinfo", DIDT_ID_DebugMacro,
const DWARFDebugAranges *DWARFContext::getDebugAranges() {
   if (Aranges)
     return Aranges.get();
 
   Aranges.reset(new DWARFDebugAranges());
   Aranges->generate(this);
   return Aranges.get();
 }
 
-const DWARFDebugFrame *DWARFContext::getDebugFrame() {
+Expected<const DWARFDebugFrame *> DWARFContext::getDebugFrame() {
   if (DebugFrame)
     return DebugFrame.get();
 
   // There's a "bug" in the DWARFv3 standard with respect to the target address
   // size within debug frame sections. While DWARF is supposed to be independent
   // of its container, FDEs have fields with size being "target address size",
   // which isn't specified in DWARF in general. It's only specified for CUs, but
   // .eh_frame can appear without a .debug_info section. Follow the example of
   // other tools (libdwarf) and extract this from the container (ObjectFile
   // provides this information). This problem is fixed in DWARFv4
   // See this dwarf-discuss discussion for more details:
   // http://lists.dwarfstd.org/htdig.cgi/dwarf-discuss-dwarfstd.org/2011-December/001173.html
   DWARFDataExtractor debugFrameData(*DObj, DObj->getFrameSection(),
                                     isLittleEndian(), DObj->getAddressSize());
-  DebugFrame.reset(new DWARFDebugFrame(getArch(), false /* IsEH */));
-  DebugFrame->parse(debugFrameData);
+  std::unique_ptr<DWARFDebugFrame> debugFrame =
+      std::make_unique<DWARFDebugFrame>(getArch(), /*IsEH=*/false);
+  if (Error E = debugFrame->parse(debugFrameData))
+    return std::move(E);
+
+  DebugFrame.swap(debugFrame);
   return DebugFrame.get();
 }
 
-const DWARFDebugFrame *DWARFContext::getEHFrame() {
+Expected<const DWARFDebugFrame *> DWARFContext::getEHFrame() {
   if (EHFrame)
     return EHFrame.get();
 
   DWARFDataExtractor debugFrameData(*DObj, DObj->getEHFrameSection(),
                                     isLittleEndian(), DObj->getAddressSize());
-  DebugFrame.reset(new DWARFDebugFrame(getArch(), true /* IsEH */));
-  DebugFrame->parse(debugFrameData);
+
+  std::unique_ptr<DWARFDebugFrame> debugFrame =
+      std::make_unique<DWARFDebugFrame>(getArch(), /*IsEH=*/true);
+  if (Error E = debugFrame->parse(debugFrameData))
+    return std::move(E);
+  DebugFrame.swap(debugFrame);
   return DebugFrame.get();
 }
 
 const DWARFDebugMacro *DWARFContext::getDebugMacro() {
   if (!Macro)
     Macro = parseMacroOrMacinfo(MacroSection);
   return Macro.get();
 }

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

static void LLVM_ATTRIBUTE_UNUSED dumpDataAux(DataExtractor Data,
   errs() << "DUMP: ";
   for (int i = 0; i < Length; ++i) {
     uint8_t c = Data.getU8(&Offset);
     errs().write_hex(c); errs() << " ";
   }
   errs() << "\n";
 }
 
-// This is a workaround for old compilers which do not allow
-// noreturn attribute usage in lambdas. Once the support for those
-// compilers are phased out, we can remove this and return back to
-// a ReportError lambda: [StartOffset](const char *ErrorMsg).
-static void LLVM_ATTRIBUTE_NORETURN ReportError(uint64_t StartOffset,
-                                                const char *ErrorMsg) {
-  std::string Str;
-  raw_string_ostream OS(Str);
-  OS << format(ErrorMsg, StartOffset);
-  OS.flush();
-  report_fatal_error(Str);
-}
-
-void DWARFDebugFrame::parse(DWARFDataExtractor Data) {
+Error DWARFDebugFrame::parse(DWARFDataExtractor Data) {
   uint64_t Offset = 0;
   DenseMap<uint64_t, CIE *> CIEs;
 
   while (Data.isValidOffset(Offset)) {
     uint64_t StartOffset = Offset;
 
     uint64_t Length;
     DwarfFormat Format;
if (Id == getCIEId(IsDWARF64, IsEH)) {
       if (IsEH) {
         Optional<uint64_t> AugmentationLength;
         uint64_t StartAugmentationOffset;
         uint64_t EndAugmentationOffset;
 
         // Walk the augmentation string to get all the augmentation data.
         for (unsigned i = 0, e = AugmentationString.size(); i != e; ++i) {
           switch (AugmentationString[i]) {
-            default:
-              ReportError(
-                  StartOffset,
-                  "Unknown augmentation character in entry at %" PRIx64);
-            case 'L':
-              LSDAPointerEncoding = Data.getU8(&Offset);
-              break;
-            case 'P': {
-              if (Personality)
-                ReportError(StartOffset,
-                            "Duplicate personality in entry at %" PRIx64);
-              PersonalityEncoding = Data.getU8(&Offset);
-              Personality = Data.getEncodedPointer(
-                  &Offset, *PersonalityEncoding,
-                  EHFrameAddress ? EHFrameAddress + Offset : 0);
-              break;
-            }
-            case 'R':
-              FDEPointerEncoding = Data.getU8(&Offset);
-              break;
-            case 'S':
-              // Current frame is a signal trampoline.
-              break;
-            case 'z':
-              if (i)
-                ReportError(StartOffset,
-                            "'z' must be the first character at %" PRIx64);
-              // Parse the augmentation length first.  We only parse it if
-              // the string contains a 'z'.
-              AugmentationLength = Data.getULEB128(&Offset);
-              StartAugmentationOffset = Offset;
-              EndAugmentationOffset = Offset + *AugmentationLength;
-              break;
-            case 'B':
-              // B-Key is used for signing functions associated with this
-              // augmentation string
-              break;
+            return make_error<StringError>(
+                "Unknown augmentation character in entry at 0x" +
+                    Twine::utohexstr(StartOffset),
+                inconvertibleErrorCode());
+              return make_error<StringError>(
+                  "Duplicate personality in entry at 0x" +
+                      Twine::utohexstr(StartOffset),
+                  inconvertibleErrorCode());
+              return make_error<StringError>(
+                  "'z' must be the first character at 0x" +
+                      Twine::utohexstr(StartOffset),
+                  inconvertibleErrorCode());
           }
         }
 
         if (AugmentationLength.hasValue()) {
           if (Offset != EndAugmentationOffset)
-            ReportError(StartOffset,
-                        "Parsing augmentation data at %" PRIx64 " failed");
-
+            return make_error<StringError>("Parsing augmentation data at 0x" +
+                                               Twine::utohexstr(StartOffset),
+                                           inconvertibleErrorCode());
           AugmentationData = Data.getData().slice(StartAugmentationOffset,
                                                   EndAugmentationOffset);
         }
       }
 
       auto Cie = std::make_unique<CIE>(
           IsDWARF64, StartOffset, Length, Version, AugmentationString,
           AddressSize, SegmentDescriptorSize, CodeAlignmentFactor,
           DataAlignmentFactor, ReturnAddressRegister, AugmentationData,
           FDEPointerEncoding, LSDAPointerEncoding, Personality,
           PersonalityEncoding, Arch);
       CIEs[StartOffset] = Cie.get();
       Entries.emplace_back(std::move(Cie));
     } else {
       // FDE
       uint64_t CIEPointer = Id;
       uint64_t InitialLocation = 0;
       uint64_t AddressRange = 0;
       Optional<uint64_t> LSDAAddress;
       CIE *Cie = CIEs[IsEH ? (StartStructureOffset - CIEPointer) : CIEPointer];
 
       if (IsEH) {
         // The address size is encoded in the CIE we reference.
         if (!Cie)
-          ReportError(StartOffset, "Parsing FDE data at %" PRIx64
-                                   " failed due to missing CIE");
+          return make_error<StringError>("Parsing FDE data at 0x" +
+                                             Twine::utohexstr(StartOffset) +
+                                             " failed due to missing CIE",
+                                         inconvertibleErrorCode());
 
         if (auto Val = Data.getEncodedPointer(
                 &Offset, Cie->getFDEPointerEncoding(),
                 EHFrameAddress ? EHFrameAddress + Offset : 0)) {
           InitialLocation = *Val;
         }
         if (auto Val = Data.getEncodedPointer(
                 &Offset, Cie->getFDEPointerEncoding(), 0)) {
           AddressRange = *Val;
if (Id == getCIEId(IsDWARF64, IsEH)) {
           // Decode the LSDA if the CIE augmentation string said we should.
           if (Cie->getLSDAPointerEncoding() != DW_EH_PE_omit) {
             LSDAAddress = Data.getEncodedPointer(
                 &Offset, Cie->getLSDAPointerEncoding(),
                 EHFrameAddress ? Offset + EHFrameAddress : 0);
           }
 
           if (Offset != EndAugmentationOffset)
-            ReportError(StartOffset,
-                        "Parsing augmentation data at %" PRIx64 " failed");
+            return make_error<StringError>("Parsing augmentation data at 0x" +
+                                               Twine::utohexstr(StartOffset) +
+                                               " failed",
+                                           inconvertibleErrorCode());
         }
       } else {
         InitialLocation = Data.getRelocatedAddress(&Offset);
         AddressRange = Data.getRelocatedAddress(&Offset);
       }
 
       Entries.emplace_back(new FDE(IsDWARF64, StartOffset, Length, CIEPointer,
                                    InitialLocation, AddressRange, Cie,
                                    LSDAAddress, Arch));
     }
 
     if (Error E =
-            Entries.back()->cfis().parse(Data, &Offset, EndStructureOffset)) {
-      report_fatal_error(toString(std::move(E)));
-    }
+            Entries.back()->cfis().parse(Data, &Offset, EndStructureOffset))
+      return std::move(E);
 
     if (Offset != EndStructureOffset)
-      ReportError(StartOffset,
-                  "Parsing entry instructions at %" PRIx64 " failed");
+      return make_error<StringError>("Parsing entry instructions at 0x" +
+                                         Twine::utohexstr(StartOffset) +
+                                         " failed",
+                                     inconvertibleErrorCode());
   }
+
+  return Error::success();
 }
 
 FrameEntry *DWARFDebugFrame::getEntryAtOffset(uint64_t Offset) const {
   auto It = partition_point(Entries, [=](const std::unique_ptr<FrameEntry> &E) {
     return E->getOffset() < Offset;
   });
   if (It != Entries.end() && (*It)->getOffset() == Offset)
     return It->get();

llvm/test/DebugInfo/X86/eh-frame-cie-id.s

-# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o - | \
-# RUN:   not --crash llvm-dwarfdump -debug-frame - 2>&1 | \
-# RUN:   FileCheck %s
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t
+# RUN: not llvm-dwarfdump -debug-frame %t 2>&1 | FileCheck %s
 
-# CHECK: Parsing FDE data at 0 failed due to missing CIE
+# CHECK: Parsing FDE data at 0x0 failed due to missing CIE
 
         .section .eh_frame,"a",@unwind
 ## This FDE was formerly wrongly interpreted as a CIE because its CIE pointer
 ## is similar to CIE id of a .debug_frame FDE.
         .long .Lend - .LCIEptr  # Length
 .LCIEptr:
         .long 0xffffffff        # CIE pointer
         .quad 0x1111abcd        # Initial location
         .quad 0x00010000        # Address range
 .Lend:

llvm/test/tools/llvm-readobj/ELF/unwind.test

-# RUN: yaml2obj %s -o %t.exe
-# RUN: llvm-readobj --unwind %t.exe | FileCheck %s
+# RUN: yaml2obj --docnum=1 %s -o %t1.exe
+# RUN: llvm-readobj --unwind %t1.exe | FileCheck %s
 
 # CHECK:      EHFrameHeader {
 # CHECK-NEXT:  Address: 0x4013c0
 # CHECK-NEXT:  Offset: 0xbc
 # CHECK-NEXT:  Size: 0x3c
 # CHECK-NEXT:  Corresponding Section: .eh_frame_hdr
 # CHECK-NEXT:  Header {
 # CHECK-NEXT:    version: 1
Sections:
       - Section: .text
   - Type: PT_GNU_EH_FRAME
     Flags: [ PF_X, PF_R ]
     VAddr: 0x004013C0
     PAddr: 0x004013C0
     Sections:
       - Section: .eh_frame_hdr
 ...
+
+## Check we report an error when the tool is unable to parse .eh_frame section.
+## Previously it also suggested to send an error report to LLVM.
+# RUN: yaml2obj --docnum=2 %s -o %t2.exe
+# RUN: not llvm-readobj --unwind %t2.exe 2>&1 | FileCheck %s -DFILE=%t2.exe --check-prefix=NO-CIE-ERR
+
+# NO-CIE-ERR:      .eh_frame section at offset 0x40 address 0x0:
+# NO-CIE-ERR-NEXT: error: '[[FILE]]': Parsing FDE data at 0x0 failed due to missing CIE
+# NO-CIE-ERR-NOT:  {{.}}
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_X86_64
+Sections:
+  - Name: .eh_frame
+    Type: SHT_X86_64_UNWIND
+## The content is generated from the following code. It has no CIE.
+## See the DebugInfoX86/eh-frame-cie-id.s test case for more history.
+## .section .eh_frame,"a",@unwind
+## .long .Lend - .LCIEptr  # Length
+## .LCIEptr:
+##   .long 0xffffffff # CIE pointer
+##   .quad 0x1111abcd # Initial location
+##   .quad 0x00010000 # Address range
+## .Lend:
+    Content: 14000000FFFFFFFFCDAB1111000000000000010000000000

llvm/tools/llvm-readobj/DwarfCFIEHPrinter.h

void PrinterContext<ELFT>::printEHFrame(
   if (Error E = Result.takeError())
     reportError(std::move(E), ObjF->getFileName());
 
   DWARFDataExtractor DE(*Result,
                         ELFT::TargetEndianness == support::endianness::little,
                         ELFT::Is64Bits ? 8 : 4);
   DWARFDebugFrame EHFrame(Triple::ArchType(ObjF->getArch()), /*IsEH=*/true,
                           /*EHFrameAddress=*/Address);
-  EHFrame.parse(DE);
+  if (Error E = EHFrame.parse(DE))
+    reportError(std::move(E), ObjF->getFileName());
 
   for (const auto &Entry : EHFrame) {
     if (const auto *CIE = dyn_cast<dwarf::CIE>(&Entry)) {
       W.startLine() << format("[0x%" PRIx64 "] CIE length=%" PRIu64 "\n",
                               Address + CIE->getOffset(),
                               CIE->getLength());
       W.indent();