In D77860, we have changed getSymbolFlags() return type to Expected<uint32_t>.
This change helps bubble the error further up the stack.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Because llvm-objdump calls getSymbolAddress() first, then calls getSymbolFlags(). We have to enable error reporting in getSymbolAddress() as well.
llvm/lib/DebugInfo/GSYM/ObjectFileTransformer.cpp | ||
---|---|---|
91 | Should this either a) be a cantFail or b) returned? If the latter, it should be commented with a TODO. | |
llvm/lib/XRay/InstrumentationMap.cpp | ||
121–122 | Whilst you're at it, could you fold these two lines together or at least rename resolved to Resolved? |
Should this either a) be a cantFail or b) returned? If the latter, it should be commented with a TODO.