Page MenuHomePhabricator

[docs] avoid 'arc land' command
Needs ReviewPublic

Authored by trofi on Apr 25 2020, 11:55 AM.

Details

Summary

Avoid using arc land and suggest cleaning up commit
message from most ofr Phabricator tags like Summary,
Reviewers, Subscribers and Tags.

Suggest keeping Differential Revision and use
git commit --amend for that.

Diff Detail

Event Timeline

trofi created this revision.Apr 25 2020, 11:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2020, 11:55 AM
trofi updated this revision to Diff 260159.Apr 26 2020, 3:54 AM

Minor: tweak summary to contain '[docs]' instead of 'docs:'.

are you sure? D<revision> worked for me in the past

mehdi_amini added inline comments.Tue, Apr 28, 9:16 AM
llvm/docs/Phabricator.rst
232–233

I didn't know we were documenting arc land, I think we should discourage it heavily instead.

This is creating commit message with a lot of cruft inside: all the Phabricator tags should be removed before pushing IMO.

trofi marked an inline comment as done.Tue, Apr 28, 10:35 AM

are you sure? D<revision> worked for me in the past

I copied arc output right from the terminal. Maybe I'm missing some configuration or arc behaviour changed.

llvm/docs/Phabricator.rst
232–233

Oh, TIL.

I can reword the section to avoid arc land. Would you be fine to review it or maybe you can suggest someone else as well?

trofi updated this revision to Diff 260704.Tue, Apr 28, 11:06 AM

Instead of tweaking arc land command add a note to strip all
Phabricator tags except Differential Revision.

trofi marked 2 inline comments as done.Tue, Apr 28, 11:07 AM
trofi added inline comments.
llvm/docs/Phabricator.rst
232–233

Reworded to discourage arc land.

trofi retitled this revision from docs: update 'arc land' command to [docs] avoid 'arc land' command.Tue, Apr 28, 11:10 AM
trofi edited the summary of this revision. (Show Details)
trofi added a reviewer: lattner.
mehdi_amini added inline comments.Tue, Apr 28, 4:59 PM
llvm/docs/Phabricator.rst
236

What about adding the same helper function as we document here: https://mlir.llvm.org/getting_started/Contributing/#using-arcanist ?