Page MenuHomePhabricator
People trofi

trofi (Sergei Trofimovich)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 22 2020, 2:20 PM (39 w, 4 h)

Recent Activity
View All

Nov 12 2020

trofi added a comment to D79140: [ThinLTO] return error instead of crashing on invalid input.
In D79140#2391922, @tejohnson wrote:

Please address the earlier suggestions (needs a test case

Nov 12 2020, 3:42 PM · Restricted Project

Oct 19 2020

trofi committed rG1eb812e06d0f: [VE] Fix initializer visibility (authored by trofi).
[VE] Fix initializer visibility
Oct 19 2020, 2:55 PM
trofi closed D89633: [VE] Fix initializer visibility.
Oct 19 2020, 2:55 PM · Restricted Project

Oct 17 2020

trofi requested review of D89633: [VE] Fix initializer visibility.
Oct 17 2020, 12:30 PM · Restricted Project

Oct 15 2020

trofi added a comment to D89450: llvm/utils/benchmark: add missing <limits> inclusion.

Sounds good! Proposed upstream as https://github.com/google/benchmark/pull/1060

Oct 15 2020, 1:02 AM · Restricted Project
trofi added a reviewer for D89450: llvm/utils/benchmark: add missing <limits> inclusion: kbobyrev.
Oct 15 2020, 12:11 AM · Restricted Project
trofi requested review of D89450: llvm/utils/benchmark: add missing <limits> inclusion.
Oct 15 2020, 12:09 AM · Restricted Project

Jun 18 2020

trofi abandoned D78867: [docs] avoid 'arc land' command.

Initially I intended to tweak the command to something that just works. I don't think I'm the right person to decide on how the changes should be landed. I'll abandon the change.

Jun 18 2020, 12:34 PM · Restricted Project

Apr 29 2020

trofi created D79140: [ThinLTO] return error instead of crashing on invalid input.
Apr 29 2020, 4:12 PM · Restricted Project

Apr 28 2020

trofi added a reviewer for D78867: [docs] avoid 'arc land' command: lattner.
Apr 28 2020, 11:17 AM · Restricted Project
trofi retitled D78867: [docs] avoid 'arc land' command from docs: update 'arc land' command to [docs] avoid 'arc land' command.
Apr 28 2020, 11:17 AM · Restricted Project
trofi added inline comments to D78867: [docs] avoid 'arc land' command.
Apr 28 2020, 11:17 AM · Restricted Project
trofi updated the diff for D78867: [docs] avoid 'arc land' command.

Instead of tweaking arc land command add a note to strip all
Phabricator tags except Differential Revision.

Apr 28 2020, 11:17 AM · Restricted Project
trofi added a comment to D78867: [docs] avoid 'arc land' command.
In D78867#2007155, @sylvestre.ledru wrote:

are you sure? D<revision> worked for me in the past

Apr 28 2020, 10:44 AM · Restricted Project
trofi added a reviewer for D78867: [docs] avoid 'arc land' command: mehdi_amini.
Apr 28 2020, 1:02 AM · Restricted Project

Apr 26 2020

trofi committed rG41eb0fc00d61: [Lexicon] fix typo "may is" -> "is" (authored by trofi).
[Lexicon] fix typo "may is" -> "is"
Apr 26 2020, 11:40 AM
trofi closed D78878: [Lexicon] fix typo "may is" -> "is".
Apr 26 2020, 11:40 AM · Restricted Project
trofi added a reviewer for D78878: [Lexicon] fix typo "may is" -> "is": MaskRay.
Apr 26 2020, 4:46 AM · Restricted Project
trofi updated the diff for D78867: [docs] avoid 'arc land' command.

Minor: tweak summary to contain '[docs]' instead of 'docs:'.

Apr 26 2020, 4:14 AM · Restricted Project
trofi created D78878: [Lexicon] fix typo "may is" -> "is".
Apr 26 2020, 4:14 AM · Restricted Project

Apr 25 2020

trofi created D78867: [docs] avoid 'arc land' command.
Apr 25 2020, 12:12 PM · Restricted Project
trofi committed rG09684b08d3b5: llvm: IPO: handle IRMover error handling, bug #45636 (authored by trofi).
llvm: IPO: handle IRMover error handling, bug #45636
Apr 25 2020, 11:40 AM
trofi closed D78676: llvm: IPO: handle IRMover error handling, bug #45636.
Apr 25 2020, 11:40 AM · Restricted Project
trofi updated the diff for D78676: llvm: IPO: handle IRMover error handling, bug #45636.

Update author to personal email address.

Apr 25 2020, 2:05 AM · Restricted Project
trofi updated the diff for D78676: llvm: IPO: handle IRMover error handling, bug #45636.

Rebased to get fast failed PE tests. No code changes.

Apr 25 2020, 1:01 AM · Restricted Project

Apr 22 2020

trofi added a comment to D78676: llvm: IPO: handle IRMover error handling, bug #45636.

Thank you for the quick review!

Apr 22 2020, 11:57 PM · Restricted Project
trofi created D78676: llvm: IPO: handle IRMover error handling, bug #45636.
Apr 22 2020, 2:41 PM · Restricted Project