This is an archive of the discontinued LLVM Phabricator instance.

[Matrix] Minor fixes with language extension docs
ClosedPublic

Authored by SaurabhJha on Jun 26 2021, 1:42 AM.

Details

Summary

There were some issues in the patch https://reviews.llvm.org/D104198. I also forgot to address one comment. This patch addresses these.

Diff Detail

Event Timeline

SaurabhJha created this revision.Jun 26 2021, 1:42 AM
SaurabhJha requested review of this revision.Jun 26 2021, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2021, 1:42 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
SaurabhJha edited the summary of this revision. (Show Details)Jun 26 2021, 1:43 AM
SaurabhJha added reviewers: fhahn, xgupta.

This is a light patch that probably does not require a review and I created a patch anyway.

Would it be appropriate to get this into main using arc land if this is approved? I saw this https://reviews.llvm.org/D78867 which advises against arc land but could not find anything related to that in the main docs.

xgupta accepted this revision.Jun 26 2021, 1:58 AM

This is a light patch that probably does not require a review and I created a patch anyway.

Would it be appropriate to get this into main using arc land if this is approved? I saw this https://reviews.llvm.org/D78867 which advises against arc land but could not find anything related to that in the main docs.

I follow https://www.llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator
which says git push https://github.com/llvm/llvm-project.git HEAD:main

This revision is now accepted and ready to land.Jun 26 2021, 1:58 AM
xgupta added a comment.EditedJun 26 2021, 2:03 AM

btw you should use [Docs] or [NFC] tag for this patch.

btw you should use [Docs] or [NFC] tag for this patch.

Okay, will follow the linked docs and amend the commit message with [Docs].

This revision was landed with ongoing or failed builds.Jun 26 2021, 2:11 AM
This revision was automatically updated to reflect the committed changes.