This is an archive of the discontinued LLVM Phabricator instance.

[SveEmitter] Add builtins for compares and ReverseCompare flag.
ClosedPublic

Authored by sdesmalen on Apr 23 2020, 12:19 PM.

Details

Summary

The IsReverseCompare flag tells CGBuiltin to swap the operands,
so that a LT/LE intrinsics can be expressed in terms of GE/GT
intrinsics.

This patch also adds builtins for the wide-variants of the compares.

Diff Detail

Event Timeline

sdesmalen created this revision.Apr 23 2020, 12:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2020, 12:19 PM
Herald added a subscriber: tschuett. · View Herald Transcript
efriedma added inline comments.Apr 23 2020, 12:56 PM
clang/include/clang/Basic/arm_sve.td
73

Isn't "w" the same as the existing "g"? Or is there some difference I'm missing?

efriedma accepted this revision.Apr 23 2020, 12:59 PM

LGTM with one minor comment

clang/include/clang/Basic/arm_sve.td
73

Oh, wait, I see, it keep the sign of the original overload type. Maybe you could clarify the comment a bit.

This revision is now accepted and ready to land.Apr 23 2020, 12:59 PM
This revision was automatically updated to reflect the committed changes.
sdesmalen marked an inline comment as done.