Page MenuHomePhabricator

[clang-format] Fix lambda with ellipsis in return type
ClosedPublic

Authored by johnchen902 on Apr 22 2020, 9:47 PM.

Details

Summary

BTW my actual code that hit this issue is like

[a, b = std::move(b)](auto &&... c) mutable -> std::invoke_result_t<decltype(b), decltype(c)...> { /* omitted */ }

where this explicit return type is required for SFINAE.

Diff Detail

Event Timeline

johnchen902 created this revision.Apr 22 2020, 9:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 9:47 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
johnchen902 retitled this revision from [Format] Fix lambda with ellipsis in return type to [clang-format] Fix lambda with ellipsis in return type.Apr 22 2020, 10:12 PM
johnchen902 edited the summary of this revision. (Show Details)
johnchen902 added a reviewer: jkorous.

Could you please update the patch with full context: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
This helps out when reviewing.

Rebased to HEAD.

Thank you!

I think this is OK as-is.

krasimir accepted this revision.Apr 28 2020, 4:12 AM
This revision is now accepted and ready to land.Apr 28 2020, 4:12 AM
MyDeveloperDay accepted this revision.Apr 28 2020, 5:15 AM

Me too LGTM

Well... I don't know how to land this. I guess I don't have commit access anyway.

This revision was automatically updated to reflect the committed changes.