Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (236 w, 1 d)

Recent Activity

Yesterday

krasimir accepted D100752: clang-format: [JS] do not merge imports and exports..
Tue, Apr 20, 3:49 AM · Restricted Project

Wed, Mar 31

krasimir added a comment to rGc51e91e04681: Revert "[Passes] Add relative lookup table converter pass".

Followed up offline with reproduction instructions.

Wed, Mar 31, 12:45 AM

Tue, Mar 30

krasimir added a reverting change for rG5178ffc7cf92: [Passes] Add relative lookup table converter pass: rGc51e91e04681: Revert "[Passes] Add relative lookup table converter pass".
Tue, Mar 30, 5:15 AM
krasimir committed rGc51e91e04681: Revert "[Passes] Add relative lookup table converter pass" (authored by krasimir).
Revert "[Passes] Add relative lookup table converter pass"
Tue, Mar 30, 5:15 AM
krasimir added a reverting change for D94355: [Passes] Add relative lookup table converter pass: rGc51e91e04681: Revert "[Passes] Add relative lookup table converter pass".
Tue, Mar 30, 5:15 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rG92ddd3c1b6cd: [loop-idiom] Hoist loop memcpys to loop preheader: rG8e7df996e305: Revert "[loop-idiom] Hoist loop memcpys to loop preheader".
Tue, Mar 30, 2:47 AM
krasimir committed rG8e7df996e305: Revert "[loop-idiom] Hoist loop memcpys to loop preheader" (authored by krasimir).
Revert "[loop-idiom] Hoist loop memcpys to loop preheader"
Tue, Mar 30, 2:47 AM
krasimir added a reverting change for D97667: [loop-idiom] Hoist loop memcpys to loop preheader: rG8e7df996e305: Revert "[loop-idiom] Hoist loop memcpys to loop preheader".
Tue, Mar 30, 2:47 AM · Restricted Project
krasimir added a comment to D99244: [X86] Pass to transform tdpbsud&tdpbusd&tdpbuud intrinsics to scalar operation.

PTAL at this build bot breakage:
https://lab.llvm.org/buildbot/#/builders/57/builds/5728

FAILED: lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXIntrinsics.cpp.o 
/home/buildbots/clang.11.0.0/bin/clang++ --gcc-toolchain=/opt/rh/devtoolset-7/root/usr  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Target/X86 -I/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/lib/Target/X86 -Iinclude -I/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/include -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3  -fPIC    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXIntrinsics.cpp.o -MF lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXIntrinsics.cpp.o.d -o lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86LowerAMXIntrinsics.cpp.o -c /home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp
/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:381:13: error: no case matching constant switch condition '9824' [-Werror]
    switch (IntrID) {
            ^~~~~~
/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:485:19: note: in instantiation of function template specialization '(anonymous namespace)::X86LowerAMXIntrinsics::createTileDPLoops<9824>' requested here
  Value *ResVec = createTileDPLoops<IntrID>(Start, End, Builder, M, NDWord,
                  ^
/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm/llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:607:11: note: in instantiation of function template specialization '(anonymous namespace)::X86LowerAMXIntrinsics::lowerTileDP<9824>' requested here
      C = lowerTileDP<Intrinsic::x86_tdpbf16ps_internal>(Inst) || C;
          ^
1 error generated.
Tue, Mar 30, 1:33 AM · Restricted Project

Mon, Mar 29

krasimir accepted D99495: clang-format: [JS] do not collapse - - to --..
Mon, Mar 29, 4:40 AM · Restricted Project

Thu, Mar 25

krasimir committed rGd9abcdd9f471: [clang-format] Fix ObjC method indent after f7f9f94b (authored by krasimir).
[clang-format] Fix ObjC method indent after f7f9f94b
Thu, Mar 25, 2:53 AM
krasimir closed D99063: [clang-format] Fix ObjC method indent after f7f9f94b.
Thu, Mar 25, 2:52 AM · Restricted Project, Restricted Project

Wed, Mar 24

krasimir added a reviewer for D99063: [clang-format] Fix ObjC method indent after f7f9f94b: benhamilton.
Wed, Mar 24, 1:40 AM · Restricted Project, Restricted Project

Mar 22 2021

krasimir edited reviewers for D99063: [clang-format] Fix ObjC method indent after f7f9f94b, added: sammccall; removed: benhamilton.
Mar 22 2021, 4:36 AM · Restricted Project, Restricted Project
krasimir updated the summary of D99063: [clang-format] Fix ObjC method indent after f7f9f94b.
Mar 22 2021, 3:20 AM · Restricted Project, Restricted Project
krasimir updated the summary of D99063: [clang-format] Fix ObjC method indent after f7f9f94b.
Mar 22 2021, 3:20 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D99063: [clang-format] Fix ObjC method indent after f7f9f94b: benhamilton.
Mar 22 2021, 3:17 AM · Restricted Project, Restricted Project
krasimir requested review of D99063: [clang-format] Fix ObjC method indent after f7f9f94b.
Mar 22 2021, 3:11 AM · Restricted Project, Restricted Project

Mar 9 2021

krasimir committed rG587859d977e8: clang-format: use `pb` as a canonical raw string delimiter for google style (authored by krasimir).
clang-format: use `pb` as a canonical raw string delimiter for google style
Mar 9 2021, 12:08 AM
krasimir closed D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.
Mar 9 2021, 12:08 AM · Restricted Project

Mar 8 2021

krasimir updated the summary of D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.
Mar 8 2021, 2:02 AM · Restricted Project
krasimir added a comment to D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.

Also fixes a bug where the canonical delimiter was not applied for raw strings with empty delimiters detected via well-known enclosing functions that expect a text proto.

Are you sure this was a bug rather than intended behavior? Seems... not unreasonable.

CanonicalDelemiter seems very rarely used so far though, so should be safe.

Mar 8 2021, 2:00 AM · Restricted Project

Mar 5 2021

krasimir accepted D98032: [clang-format] Improve clang-format-diff.py error message.

Thank you!

Mar 5 2021, 5:03 AM · Restricted Project

Mar 4 2021

krasimir updated the summary of D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.
Mar 4 2021, 2:08 AM · Restricted Project
krasimir updated the diff for D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.

Collect commits

Mar 4 2021, 2:03 AM · Restricted Project
krasimir updated the diff for D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.

Update tests

Mar 4 2021, 2:03 AM · Restricted Project

Mar 1 2021

krasimir retitled D97688: clang-format: use `pb` as a canonical raw string delimiter for google style from clang-format: use `ph` as a canonical raw string delimiter for google style to clang-format: use `pb` as a canonical raw string delimiter for google style.
Mar 1 2021, 7:55 AM · Restricted Project
krasimir updated the diff for D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.

clang-format: use pb as a canonical raw string delimiter for google style

Mar 1 2021, 7:52 AM · Restricted Project
krasimir requested review of D97688: clang-format: use `pb` as a canonical raw string delimiter for google style.
Mar 1 2021, 7:32 AM · Restricted Project

Jan 29 2021

krasimir added inline comments to D92257: [clang-format] Add option to control the space at the front of a line comment.
Jan 29 2021, 1:06 AM · Restricted Project, Restricted Project

Dec 17 2020

krasimir committed rGe71a4cc20789: fix a -Wunused-variable warning in release build (authored by krasimir).
fix a -Wunused-variable warning in release build
Dec 17 2020, 2:53 AM
krasimir added a reverting change for rGcee1e7d14f46: [libc][NFC][Obvious] Remove few unnecessary #include directives in tests.: rG352cba2441c6: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h.
Dec 17 2020, 2:22 AM
krasimir committed rG352cba2441c6: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h (authored by krasimir).
[libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h
Dec 17 2020, 2:22 AM

Dec 9 2020

krasimir accepted D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess.

This is very nice :)

Dec 9 2020, 7:21 AM · Restricted Project, Restricted Project

Dec 6 2020

krasimir added inline comments to D92257: [clang-format] Add option to control the space at the front of a line comment.
Dec 6 2020, 10:46 AM · Restricted Project, Restricted Project

Nov 11 2020

krasimir committed rG77b484116971: [clang-format] do not break before @tags in JS comments (authored by krasimir).
[clang-format] do not break before @tags in JS comments
Nov 11 2020, 3:31 AM
krasimir closed D91078: [clang-format] do not break before @tags in JS comments.
Nov 11 2020, 3:31 AM · Restricted Project, Restricted Project

Nov 10 2020

krasimir accepted D91132: clang-format: [JS] support new assignment operators..
Nov 10 2020, 12:21 AM · Restricted Project

Nov 9 2020

krasimir added a reviewer for D91078: [clang-format] do not break before @tags in JS comments: mprobst.
Nov 9 2020, 7:09 AM · Restricted Project, Restricted Project
krasimir added inline comments to D91078: [clang-format] do not break before @tags in JS comments.
Nov 9 2020, 7:00 AM · Restricted Project, Restricted Project
krasimir requested review of D91078: [clang-format] do not break before @tags in JS comments.
Nov 9 2020, 6:57 AM · Restricted Project, Restricted Project
krasimir committed rG7b7170fa5791: [clang-format] avoid introducing multiline comments (authored by krasimir).
[clang-format] avoid introducing multiline comments
Nov 9 2020, 6:30 AM
krasimir closed D90949: [clang-format] avoid introducing multiline comments.
Nov 9 2020, 6:30 AM · Restricted Project, Restricted Project
krasimir added inline comments to D90949: [clang-format] avoid introducing multiline comments.
Nov 9 2020, 2:20 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90949: [clang-format] avoid introducing multiline comments.
  • address review comments
Nov 9 2020, 2:17 AM · Restricted Project, Restricted Project

Nov 6 2020

krasimir added a project to D90949: [clang-format] avoid introducing multiline comments: Restricted Project.
Nov 6 2020, 8:26 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D90949: [clang-format] avoid introducing multiline comments: sammccall.
Nov 6 2020, 8:16 AM · Restricted Project, Restricted Project
krasimir requested review of D90949: [clang-format] avoid introducing multiline comments.
Nov 6 2020, 8:16 AM · Restricted Project, Restricted Project
krasimir committed rG2dbcbd357d1d: [clang-format] do not break before { in JS comments (authored by krasimir).
[clang-format] do not break before { in JS comments
Nov 6 2020, 1:35 AM
krasimir closed D90908: [clang-format] do not break before { in JS comments.
Nov 6 2020, 1:35 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D90908: [clang-format] do not break before { in JS comments: mprobst.
Nov 6 2020, 12:53 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90908: [clang-format] do not break before { in JS comments.

collect commits

Nov 6 2020, 12:52 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90908: [clang-format] do not break before { in JS comments.

update test case range

Nov 6 2020, 12:50 AM · Restricted Project, Restricted Project
krasimir requested review of D90908: [clang-format] do not break before { in JS comments.
Nov 6 2020, 12:47 AM · Restricted Project, Restricted Project

Oct 29 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

This doe snot lgtm. clang-format should not depend on clangFrontend, see the lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find another fix here (and include a test for whatever this fixes). I'll revert this for now.

Oct 29 2020, 7:47 AM · Restricted Project, Restricted Project
krasimir committed rGdf00267f1fdb: clang-format: Add a consumer to diagnostics engine (authored by krasimir).
clang-format: Add a consumer to diagnostics engine
Oct 29 2020, 3:29 AM
krasimir closed D90121: clang-format: Add a consumer to diagnostics engine.
Oct 29 2020, 3:29 AM · Restricted Project, Restricted Project

Oct 28 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

@krasimir What would our next steps be to get this change into LLVM source tree? JIC, I don't have commit rights :)

Oct 28 2020, 1:58 PM · Restricted Project, Restricted Project

Oct 27 2020

krasimir accepted D90121: clang-format: Add a consumer to diagnostics engine.

Thank you! Your fix looks good for clang-format.

Oct 27 2020, 3:37 AM · Restricted Project, Restricted Project

Oct 26 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

This looks reasonable.

Oct 26 2020, 1:44 AM · Restricted Project, Restricted Project

Aug 10 2020

krasimir removed a reviewer for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends: krasimir.
Aug 10 2020, 7:34 AM
krasimir removed a reviewer for D56345: [clang-format] Assert that filenames are not empty: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D58404: [clang-format] Add basic support for formatting C# files: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58819: [clang-format] clang-format off/on not respected when using C Style comments: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D58922: [clang-format] broken after lambda with return type template with boolean literal: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59627: [clang-format] Keep protobuf "package" statement on one line: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59629: [clang-format] correctly format protobuf fields named "enum".: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D60115: Adding 'CLion integration' to clang-format doc: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60308: Leave alone the semicolon after the MacroBlockBegin name: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60374: clang-format incorrectly indents wrapped closing parenthesis: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61001: [clang-format][tests] Explicitly specify style in some tests: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61276: [clang-format] Fix bug in block comment reflow that joins * and /: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61297: [clang-format] Fix bug that misses some function-like macro usages: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61559: Fix the crash when formatting unsupported encodings: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D64775: [Format/ObjC] Avoid breaking between unary operators and operands: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.: krasimir.
Aug 10 2020, 7:30 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D66650: clang-format: chromium style: Disable across-block include reordering.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D67750: Allow additional file suffixes/extensions considered as source in main include grouping: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68783: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2): krasimir.
Aug 10 2020, 7:28 AM · Restricted Project
krasimir removed a reviewer for D69971: clang-format: [JS] support null operators.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D69972: clang-format: [JS] test declared fields.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D71512: [clang-format] Fix short block when braking after control statement: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D73977: [clang-format] Allow a comment to follow a C# attribute specifier: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation: krasimir.
Aug 10 2020, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D75791: [clang-format] Added new option IndentExternBlock: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D76197: clang-format: Use block indentation for braced initializations: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project