Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (153 w, 2 d)

Recent Activity

Wed, Sep 18

krasimir committed rG2f1bba7fd077: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" (authored by krasimir).
Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Wed, Sep 18, 7:49 AM
krasimir committed rL372228: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Wed, Sep 18, 7:40 AM
krasimir closed D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Wed, Sep 18, 7:40 AM · Restricted Project
krasimir added a reviewer for D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize": bkramer.
Wed, Sep 18, 7:40 AM · Restricted Project
krasimir retitled D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" from Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" This reverts commit r372204. This change appears to cause build bot failures under msan: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check... to Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Wed, Sep 18, 7:40 AM · Restricted Project
krasimir created D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Wed, Sep 18, 7:40 AM · Restricted Project
krasimir added a comment to rL372204: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize.

This change appears to cause build bot failures under msan:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check-llvm%20msan/logs/stdio

FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579)
******************** TEST 'LLVM :: DebugInfo/AArch64/asan-stack-vars.mir' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0 -start-before=livedebugvalues -filetype=obj -o - /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump -v - | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
--
Exit Code: 2
Wed, Sep 18, 7:31 AM
krasimir committed rG98c0dc39de24: [lldb] Fix a test assertion after r372192 (authored by krasimir).
[lldb] Fix a test assertion after r372192
Wed, Sep 18, 5:41 AM
krasimir committed rL372221: [lldb] Fix a test assertion after r372192.
[lldb] Fix a test assertion after r372192
Wed, Sep 18, 5:40 AM
krasimir closed D67702: [lldb] Fix a test assertion after r372192.
Wed, Sep 18, 5:40 AM · Restricted Project
krasimir added a reviewer for D67702: [lldb] Fix a test assertion after r372192: bkramer.
Wed, Sep 18, 5:25 AM · Restricted Project
krasimir added inline comments to rL372192: [ScriptInterpreter] Limit LLDB's globals to interactive mode..
Wed, Sep 18, 5:25 AM
krasimir created D67702: [lldb] Fix a test assertion after r372192.
Wed, Sep 18, 5:25 AM · Restricted Project
krasimir added a comment to D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".

Hey! Thank you very much for your investigations!

Wed, Sep 18, 2:49 AM · Restricted Project
krasimir abandoned D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Wed, Sep 18, 2:49 AM · Restricted Project

Tue, Sep 17

krasimir added a comment to D67539: [ARM][LowOverheadLoops] Add LR def safety check.

@samparker : right after r372126 there still seems to be a test failure remaining:

Tue, Sep 17, 7:51 AM · Restricted Project
krasimir accepted D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes..

Thank you!

Tue, Sep 17, 7:42 AM · Restricted Project, Restricted Project
krasimir committed rGbdff164e0e07: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'… (authored by krasimir).
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'…
Tue, Sep 17, 7:20 AM
krasimir committed rL372125: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'….
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'…
Tue, Sep 17, 7:20 AM
krasimir closed D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Tue, Sep 17, 7:20 AM · Restricted Project
krasimir created D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Tue, Sep 17, 6:51 AM · Restricted Project
krasimir added a reviewer for D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)": xbolva00.
Tue, Sep 17, 6:51 AM · Restricted Project
krasimir added a reviewer for D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)": bkramer.
Tue, Sep 17, 6:51 AM · Restricted Project
krasimir added a comment to rL372101: [SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y).

This caused some ASAN tests to start breaking:

Tue, Sep 17, 6:51 AM
krasimir committed rG88b4b9f97391: lldb: move a test input to the test Inputs dir (authored by krasimir).
lldb: move a test input to the test Inputs dir
Tue, Sep 17, 5:22 AM
krasimir committed rL372112: lldb: move a test input to the test Inputs dir.
lldb: move a test input to the test Inputs dir
Tue, Sep 17, 5:21 AM
krasimir closed D67655: lldb: move a test input to the test Inputs dir.
Tue, Sep 17, 5:21 AM · Restricted Project
krasimir added a reviewer for D67655: lldb: move a test input to the test Inputs dir: bkramer.
Tue, Sep 17, 5:12 AM · Restricted Project
krasimir created D67655: lldb: move a test input to the test Inputs dir.
Tue, Sep 17, 5:07 AM · Restricted Project
krasimir added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

Adding @djasper as this is really a re-implementation of https://reviews.llvm.org/D6833.
Agree with @MyDeveloperDay that in general we should aim to document all the known cases where a style doesn't work (with FIXMEs etc.), but not submit failing tests. We can have tests that demonstrate the current (bad) behavior together with a FIXME comment about what is the expected good outcome instead.

Tue, Sep 17, 4:53 AM · Restricted Project
krasimir edited reviewers for D67627: Clang-format: Add Whitesmiths indentation style, added: djasper; removed: krasimir.
Tue, Sep 17, 4:53 AM · Restricted Project

Fri, Sep 13

krasimir abandoned D66653: [clang-format] Turn include regrouping on for Google ObjC style.

This was for experimental purposes, abandoning.

Fri, Sep 13, 2:13 AM · Restricted Project
krasimir accepted D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

This looks good with the FIXME.

Fri, Sep 13, 2:09 AM · Restricted Project

Tue, Sep 10

krasimir added a comment to D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

I'll need some more time to investigate the implications of this with respect to Objective-C disambiguation stuff.
Specifically, this may interact with funny ways with the heuristic outlined in (old) UnwrappedLineParser.cpp line 1453:

// In a C++ lambda a template type can only occur after an arrow. We use
// this as an heuristic to distinguish between Objective-C expressions
// followed by an `a->b` expression, such as:
// ([obj func:arg] + a->b)
Tue, Sep 10, 2:32 AM · Restricted Project

Mon, Aug 26

krasimir accepted D66736: clang-format: [JS] handle `as const`..
Mon, Aug 26, 6:11 AM · Restricted Project

Fri, Aug 23

krasimir created D66653: [clang-format] Turn include regrouping on for Google ObjC style.
Fri, Aug 23, 7:21 AM · Restricted Project

Aug 8 2019

krasimir committed rG9ab051bdda8d: [clang-format] fix crash involving invalid preprocessor line (authored by krasimir).
[clang-format] fix crash involving invalid preprocessor line
Aug 8 2019, 4:56 AM
krasimir committed rL368280: [clang-format] fix crash involving invalid preprocessor line.
[clang-format] fix crash involving invalid preprocessor line
Aug 8 2019, 4:55 AM
krasimir closed D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:55 AM · Restricted Project, Restricted Project
krasimir added inline comments to D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:54 AM · Restricted Project, Restricted Project
krasimir updated the diff for D65940: [clang-format] fix crash involving invalid preprocessor line.
  • Apply review comments
Aug 8 2019, 4:53 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D65940: [clang-format] fix crash involving invalid preprocessor line: gribozavr.
Aug 8 2019, 4:47 AM · Restricted Project, Restricted Project
krasimir created D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:44 AM · Restricted Project, Restricted Project

Jul 25 2019

krasimir committed rG369dd3407ccf: Update some tests after r366702 (authored by krasimir).
Update some tests after r366702
Jul 25 2019, 5:20 AM
krasimir committed rL367012: Update some tests after r366702.
Update some tests after r366702
Jul 25 2019, 5:19 AM
krasimir closed D65272: Update some tests after r366702.
Jul 25 2019, 5:19 AM · Restricted Project, Restricted Project
krasimir updated the summary of D65272: Update some tests after r366702.
Jul 25 2019, 4:52 AM · Restricted Project, Restricted Project
krasimir updated the summary of D65272: Update some tests after r366702.
Jul 25 2019, 4:52 AM · Restricted Project, Restricted Project
krasimir created D65272: Update some tests after r366702.
Jul 25 2019, 4:46 AM · Restricted Project, Restricted Project

Jul 23 2019

krasimir accepted D64998: Improve clang-format-diff help output.
Jul 23 2019, 6:42 AM · Restricted Project

May 10 2019

krasimir committed rG4dea1378eac0: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"" (authored by krasimir).
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir committed rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir added a reverting change for rL356912: Revert "[clang-format] Keep protobuf "package" statement on one line": rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM
krasimir committed rC360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir closed D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM · Restricted Project
krasimir accepted D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

Sorry for the delay. I'll submit this for you.

May 10 2019, 1:56 AM · Restricted Project

May 7 2019

krasimir committed rLLDB360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rG435e76a558b3: [lldb] Add MacroQualified switch cases for r360109 (authored by krasimir).
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rL360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:57 AM
krasimir closed D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 6:57 AM · Restricted Project
krasimir added a reviewer for D61640: [lldb] Add MacroQualified switch cases for r360109: gribozavr.
May 7 2019, 5:46 AM · Restricted Project
krasimir updated the summary of D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:45 AM · Restricted Project
krasimir created D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:41 AM · Restricted Project
krasimir committed rG866e05f02346: Revert "[TableGen] Fix a typo" (authored by krasimir).
Revert "[TableGen] Fix a typo"
May 7 2019, 4:39 AM
krasimir committed rL360136: Revert "[TableGen] Fix a typo".
Revert "[TableGen] Fix a typo"
May 7 2019, 4:37 AM
krasimir closed D61632: Revert "[TableGen] Fix a typo".
May 7 2019, 4:37 AM · Restricted Project
krasimir added reviewers for D61632: Revert "[TableGen] Fix a typo": yan_luo, craig.topper.
May 7 2019, 2:15 AM · Restricted Project
krasimir added a reviewer for D61632: Revert "[TableGen] Fix a typo": sammccall.
May 7 2019, 2:03 AM · Restricted Project
krasimir created D61632: Revert "[TableGen] Fix a typo".
May 7 2019, 1:57 AM · Restricted Project

Apr 18 2019

krasimir committed rGbda8482abaa8: [clang-format] Fix indent of trailing raw string param after newline (authored by krasimir).
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:13 AM
krasimir committed rL358689: [clang-format] Fix indent of trailing raw string param after newline.
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:12 AM
krasimir committed rC358689: [clang-format] Fix indent of trailing raw string param after newline.
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:12 AM
krasimir closed D60558: [clang-format] Fix indent of trailing raw string param after newline.
Apr 18 2019, 10:12 AM · Restricted Project

Apr 12 2019

krasimir committed rG69150467b098: [clang-format] Use SpacesBeforeTrailingComments for "option" directive (authored by krasimir).
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir committed rL358275: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir committed rC358275: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir closed D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
Apr 12 2019, 3:11 AM · Restricted Project
krasimir added a comment to D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.

I'll merge this.

Apr 12 2019, 2:46 AM · Restricted Project

Apr 11 2019

krasimir edited reviewers for D60558: [clang-format] Fix indent of trailing raw string param after newline, added: djasper; removed: ioeric.
Apr 11 2019, 10:43 AM · Restricted Project
krasimir accepted D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.

Thank you!

Apr 11 2019, 4:41 AM · Restricted Project
krasimir added a reviewer for D60558: [clang-format] Fix indent of trailing raw string param after newline: ioeric.
Apr 11 2019, 3:15 AM · Restricted Project
krasimir created D60558: [clang-format] Fix indent of trailing raw string param after newline.
Apr 11 2019, 3:05 AM · Restricted Project

Apr 8 2019

krasimir resigned from D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.
Apr 8 2019, 3:53 AM · Restricted Project
krasimir added inline comments to D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.
Apr 8 2019, 3:42 AM · Restricted Project

Apr 5 2019

krasimir added inline comments to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Apr 5 2019, 6:25 AM · Restricted Project
krasimir added a comment to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Generally I'm against introducing new style flags or flag options unless a supported style requires it.
IMO this increases maintenance burden and can quickly lead to a big space of style flags that contain tricky incompatibilities.

Apr 5 2019, 6:10 AM · Restricted Project
krasimir added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

I believe there is no such thing as an "short else statement". The else is part of the if statement and if it is present, I don't consider the whole if statement short. As such, IMO the bug is invalid.

Apr 5 2019, 6:01 AM · Restricted Project, Restricted Project

Apr 4 2019

krasimir committed rG00e7ae9f80cc: [clang-format] Preserve include blocks in ObjC Google style (authored by krasimir).
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:03 AM
krasimir committed rL357695: [clang-format] Preserve include blocks in ObjC Google style.
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:03 AM
krasimir committed rC357695: [clang-format] Preserve include blocks in ObjC Google style.
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:02 AM
krasimir closed D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 7:02 AM · Restricted Project, Restricted Project
krasimir updated the diff for D60263: [clang-format] Preserve include blocks in ObjC Google style.
  • Add a note about intent
Apr 4 2019, 7:02 AM · Restricted Project, Restricted Project
krasimir added a comment to D60263: [clang-format] Preserve include blocks in ObjC Google style.

Why would we want this to be different in Obj-C and C++?

Apr 4 2019, 6:46 AM · Restricted Project, Restricted Project
krasimir added inline comments to D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:33 AM · Restricted Project, Restricted Project
krasimir created D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:15 AM · Restricted Project, Restricted Project

Apr 3 2019

krasimir committed rG925bb20c794f: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir).
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:15 AM
krasimir committed rL357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:14 AM
krasimir committed rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:14 AM
krasimir closed D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
Apr 3 2019, 8:14 AM · Restricted Project
krasimir updated the diff for D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
  • Address review comments
Apr 3 2019, 7:51 AM · Restricted Project