Page MenuHomePhabricator
People krasimir

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (170 w, 4 d)

Recent Activity
View All

Yesterday

krasimir accepted D72907: clang-format: [JS] pragmas for tslint, tsc..
Fri, Jan 17, 4:37 AM · Restricted Project
krasimir committed rG33463cfba2be: clang-format: fix spacing in `operator const char*()` (authored by krasimir).
clang-format: fix spacing in `operator const char*()`
Fri, Jan 17, 4:35 AM
krasimir closed D72911: clang-format: fix spacing in `operator const char*()`.
Fri, Jan 17, 4:35 AM · Restricted Project
krasimir updated the diff for D72911: clang-format: fix spacing in `operator const char*()`.
  • Fix typo
Fri, Jan 17, 4:26 AM · Restricted Project
krasimir added inline comments to D72911: clang-format: fix spacing in `operator const char*()`.
Fri, Jan 17, 4:25 AM · Restricted Project
krasimir updated the diff for D72911: clang-format: fix spacing in `operator const char*()`.
  • Fix typo
Fri, Jan 17, 4:25 AM · Restricted Project
krasimir updated the diff for D72911: clang-format: fix spacing in `operator const char*()`.
  • Address review comments
Fri, Jan 17, 4:25 AM · Restricted Project
krasimir updated the diff for D72911: clang-format: fix spacing in `operator const char*()`.
  • Add more tests
Fri, Jan 17, 3:57 AM · Restricted Project
krasimir added a reviewer for D72911: clang-format: fix spacing in `operator const char*()`: mprobst.
Fri, Jan 17, 3:51 AM · Restricted Project
krasimir created D72911: clang-format: fix spacing in `operator const char*()`.
Fri, Jan 17, 3:51 AM · Restricted Project

Thu, Jan 16

krasimir accepted D72827: clang-format: [JS] Handle keyword-named methods..

How about if and try? Is there a list somewhere for all such valid identifiers?

Thu, Jan 16, 6:19 AM · Restricted Project, Restricted Project

Tue, Jan 14

krasimir added a comment to D67843: [clang-format] DisableFormat also now disables SortIncludes.

I also am worried that this makes it impossible to just sort includes.

Tue, Jan 14, 2:52 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jan 13

krasimir accepted D70377: clang-format: [JS] tests for async wrapping..
Mon, Jan 13, 12:06 AM · Restricted Project
krasimir added inline comments to D72401: Fixes for spaces around C# object initializers.
Mon, Jan 13, 12:06 AM · Restricted Project, Restricted Project

Sat, Jan 11

krasimir added inline comments to D72401: Fixes for spaces around C# object initializers.
Sat, Jan 11, 2:42 AM · Restricted Project, Restricted Project
krasimir requested changes to D72401: Fixes for spaces around C# object initializers.
Sat, Jan 11, 2:41 AM · Restricted Project, Restricted Project
krasimir accepted D72150: Allow space after C-style cast in C# code.
Sat, Jan 11, 2:32 AM · Restricted Project, Restricted Project
krasimir requested changes to D72144: Treat C# `using` as a control statement.
Sat, Jan 11, 2:25 AM · Restricted Project, Restricted Project

Wed, Jan 8

krasimir added a comment to D72396: [InstCombine] fold zext of masked bit set/clear.

The original code seems ubsan-clean.

Wed, Jan 8, 8:37 AM · Restricted Project
krasimir added a comment to D72396: [InstCombine] fold zext of masked bit set/clear.

Internally, I can see that either (1) this causes the following code to miscompile, or (2) the code is UB:
https://github.com/grpc/grpc/blob/master/src/core/ext/transport/chttp2/transport/frame_settings.cc#L48
Note that in that code the two checks on lines 57 and 64 are related if that helps.

Wed, Jan 8, 7:12 AM · Restricted Project

Oct 18 2019

krasimir added inline comments to D69164: [clang-format] fix regression recognizing casts in Obj-C calls.
Oct 18 2019, 11:34 AM · Restricted Project
krasimir committed rGeff2a2ab2b51: [clang-format] fix regression recognizing casts in Obj-C calls (authored by krasimir).
[clang-format] fix regression recognizing casts in Obj-C calls
Oct 18 2019, 8:20 AM
krasimir closed D69164: [clang-format] fix regression recognizing casts in Obj-C calls.
Oct 18 2019, 8:20 AM · Restricted Project
krasimir committed rL375247: [clang-format] fix regression recognizing casts in Obj-C calls.
[clang-format] fix regression recognizing casts in Obj-C calls
Oct 18 2019, 8:20 AM
krasimir added a reviewer for D69164: [clang-format] fix regression recognizing casts in Obj-C calls: MyDeveloperDay.
Oct 18 2019, 5:56 AM · Restricted Project
krasimir updated the summary of D69164: [clang-format] fix regression recognizing casts in Obj-C calls.
Oct 18 2019, 5:56 AM · Restricted Project
krasimir created D69164: [clang-format] fix regression recognizing casts in Obj-C calls.
Oct 18 2019, 5:56 AM · Restricted Project

Oct 9 2019

krasimir committed rGae1b7859cbd6: [clang-format] Update noexcept reference qualifiers detection (authored by krasimir).
[clang-format] Update noexcept reference qualifiers detection
Oct 9 2019, 7:49 AM
krasimir committed rL374172: [clang-format] Update noexcept reference qualifiers detection.
[clang-format] Update noexcept reference qualifiers detection
Oct 9 2019, 7:49 AM
krasimir closed D68695: [clang-format] Update noexcept reference qualifiers detection.
Oct 9 2019, 7:49 AM · Restricted Project, Restricted Project
krasimir added inline comments to D68695: [clang-format] Update noexcept reference qualifiers detection.
Oct 9 2019, 6:03 AM · Restricted Project, Restricted Project
krasimir added inline comments to D68695: [clang-format] Update noexcept reference qualifiers detection.
Oct 9 2019, 5:22 AM · Restricted Project, Restricted Project
krasimir added reviewers for D68695: [clang-format] Update noexcept reference qualifiers detection: AndWass, MyDeveloperDay.
Oct 9 2019, 5:16 AM · Restricted Project, Restricted Project
krasimir created D68695: [clang-format] Update noexcept reference qualifiers detection.
Oct 9 2019, 5:16 AM · Restricted Project, Restricted Project

Oct 1 2019

krasimir accepted D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed.

Thank you!

Oct 1 2019, 11:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
krasimir added inline comments to D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed.
Oct 1 2019, 2:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 30 2019

krasimir added inline comments to D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed.
Sep 30 2019, 1:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 18 2019

krasimir committed rG2f1bba7fd077: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" (authored by krasimir).
Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Sep 18 2019, 7:49 AM
krasimir committed rL372228: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Sep 18 2019, 7:40 AM
krasimir closed D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Sep 18 2019, 7:40 AM · Restricted Project
krasimir added a reviewer for D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize": bkramer.
Sep 18 2019, 7:40 AM · Restricted Project
krasimir retitled D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" from Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" This reverts commit r372204. This change appears to cause build bot failures under msan: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check... to Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Sep 18 2019, 7:40 AM · Restricted Project
krasimir created D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".
Sep 18 2019, 7:40 AM · Restricted Project
krasimir added a comment to rL372204: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize.

This change appears to cause build bot failures under msan:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check-llvm%20msan/logs/stdio

FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579)
******************** TEST 'LLVM :: DebugInfo/AArch64/asan-stack-vars.mir' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0 -start-before=livedebugvalues -filetype=obj -o - /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump -v - | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
--
Exit Code: 2
Sep 18 2019, 7:31 AM
krasimir committed rG98c0dc39de24: [lldb] Fix a test assertion after r372192 (authored by krasimir).
[lldb] Fix a test assertion after r372192
Sep 18 2019, 5:41 AM
krasimir committed rL372221: [lldb] Fix a test assertion after r372192.
[lldb] Fix a test assertion after r372192
Sep 18 2019, 5:40 AM
krasimir closed D67702: [lldb] Fix a test assertion after r372192.
Sep 18 2019, 5:40 AM · Restricted Project
krasimir added a reviewer for D67702: [lldb] Fix a test assertion after r372192: bkramer.
Sep 18 2019, 5:25 AM · Restricted Project
krasimir added inline comments to rL372192: [ScriptInterpreter] Limit LLDB's globals to interactive mode..
Sep 18 2019, 5:25 AM
krasimir created D67702: [lldb] Fix a test assertion after r372192.
Sep 18 2019, 5:25 AM · Restricted Project
krasimir added a comment to D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".

Hey! Thank you very much for your investigations!

Sep 18 2019, 2:49 AM · Restricted Project
krasimir abandoned D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Sep 18 2019, 2:49 AM · Restricted Project

Sep 17 2019

krasimir added a comment to D67539: [ARM][LowOverheadLoops] Add LR def safety check.

@samparker : right after r372126 there still seems to be a test failure remaining:

Sep 17 2019, 7:51 AM · Restricted Project
krasimir accepted D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes..

Thank you!

Sep 17 2019, 7:42 AM · Restricted Project, Restricted Project
krasimir committed rGbdff164e0e07: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'… (authored by krasimir).
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'…
Sep 17 2019, 7:20 AM
krasimir committed rL372125: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'….
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0'…
Sep 17 2019, 7:20 AM
krasimir closed D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Sep 17 2019, 7:20 AM · Restricted Project
krasimir created D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".
Sep 17 2019, 6:51 AM · Restricted Project
krasimir added a reviewer for D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)": xbolva00.
Sep 17 2019, 6:51 AM · Restricted Project
krasimir added a reviewer for D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)": bkramer.
Sep 17 2019, 6:51 AM · Restricted Project
krasimir added a comment to rL372101: [SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y).

This caused some ASAN tests to start breaking:

Sep 17 2019, 6:51 AM
krasimir committed rG88b4b9f97391: lldb: move a test input to the test Inputs dir (authored by krasimir).
lldb: move a test input to the test Inputs dir
Sep 17 2019, 5:22 AM
krasimir committed rL372112: lldb: move a test input to the test Inputs dir.
lldb: move a test input to the test Inputs dir
Sep 17 2019, 5:21 AM
krasimir closed D67655: lldb: move a test input to the test Inputs dir.
Sep 17 2019, 5:21 AM · Restricted Project
krasimir added a reviewer for D67655: lldb: move a test input to the test Inputs dir: bkramer.
Sep 17 2019, 5:12 AM · Restricted Project
krasimir created D67655: lldb: move a test input to the test Inputs dir.
Sep 17 2019, 5:07 AM · Restricted Project
krasimir added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

Adding @djasper as this is really a re-implementation of https://reviews.llvm.org/D6833.
Agree with @MyDeveloperDay that in general we should aim to document all the known cases where a style doesn't work (with FIXMEs etc.), but not submit failing tests. We can have tests that demonstrate the current (bad) behavior together with a FIXME comment about what is the expected good outcome instead.

Sep 17 2019, 4:53 AM · Restricted Project, Restricted Project
krasimir edited reviewers for D67627: Clang-format: Add Whitesmiths indentation style, added: djasper; removed: krasimir.
Sep 17 2019, 4:53 AM · Restricted Project, Restricted Project

Sep 13 2019

krasimir abandoned D66653: [clang-format] Turn include regrouping on for Google ObjC style.

This was for experimental purposes, abandoning.

Sep 13 2019, 2:13 AM · Restricted Project
krasimir accepted D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

This looks good with the FIXME.

Sep 13 2019, 2:09 AM · Restricted Project

Sep 10 2019

krasimir added a comment to D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

I'll need some more time to investigate the implications of this with respect to Objective-C disambiguation stuff.
Specifically, this may interact with funny ways with the heuristic outlined in (old) UnwrappedLineParser.cpp line 1453:

// In a C++ lambda a template type can only occur after an arrow. We use
// this as an heuristic to distinguish between Objective-C expressions
// followed by an `a->b` expression, such as:
// ([obj func:arg] + a->b)
Sep 10 2019, 2:32 AM · Restricted Project

Aug 26 2019

krasimir accepted D66736: clang-format: [JS] handle `as const`..
Aug 26 2019, 6:11 AM · Restricted Project

Aug 23 2019

krasimir created D66653: [clang-format] Turn include regrouping on for Google ObjC style.
Aug 23 2019, 7:21 AM · Restricted Project

Aug 8 2019

krasimir committed rG9ab051bdda8d: [clang-format] fix crash involving invalid preprocessor line (authored by krasimir).
[clang-format] fix crash involving invalid preprocessor line
Aug 8 2019, 4:56 AM
krasimir committed rL368280: [clang-format] fix crash involving invalid preprocessor line.
[clang-format] fix crash involving invalid preprocessor line
Aug 8 2019, 4:55 AM
krasimir closed D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:55 AM · Restricted Project, Restricted Project
krasimir added inline comments to D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:54 AM · Restricted Project, Restricted Project
krasimir updated the diff for D65940: [clang-format] fix crash involving invalid preprocessor line.
  • Apply review comments
Aug 8 2019, 4:53 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D65940: [clang-format] fix crash involving invalid preprocessor line: gribozavr.
Aug 8 2019, 4:47 AM · Restricted Project, Restricted Project
krasimir created D65940: [clang-format] fix crash involving invalid preprocessor line.
Aug 8 2019, 4:44 AM · Restricted Project, Restricted Project

Jul 25 2019

krasimir committed rG369dd3407ccf: Update some tests after r366702 (authored by krasimir).
Update some tests after r366702
Jul 25 2019, 5:20 AM
krasimir committed rL367012: Update some tests after r366702.
Update some tests after r366702
Jul 25 2019, 5:19 AM
krasimir closed D65272: Update some tests after r366702.
Jul 25 2019, 5:19 AM · Restricted Project, Restricted Project
krasimir updated the summary of D65272: Update some tests after r366702.
Jul 25 2019, 4:52 AM · Restricted Project, Restricted Project
krasimir updated the summary of D65272: Update some tests after r366702.
Jul 25 2019, 4:52 AM · Restricted Project, Restricted Project
krasimir created D65272: Update some tests after r366702.
Jul 25 2019, 4:46 AM · Restricted Project, Restricted Project

Jul 23 2019

krasimir accepted D64998: Improve clang-format-diff help output.
Jul 23 2019, 6:42 AM · Restricted Project

May 10 2019

krasimir committed rG4dea1378eac0: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"" (authored by krasimir).
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir committed rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir added a reverting change for rL356912: Revert "[clang-format] Keep protobuf "package" statement on one line": rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM
krasimir committed rC360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir closed D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM · Restricted Project
krasimir accepted D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

Sorry for the delay. I'll submit this for you.

May 10 2019, 1:56 AM · Restricted Project

May 7 2019

krasimir committed rLLDB360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rG435e76a558b3: [lldb] Add MacroQualified switch cases for r360109 (authored by krasimir).
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rL360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:57 AM
krasimir closed D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 6:57 AM · Restricted Project
krasimir added a reviewer for D61640: [lldb] Add MacroQualified switch cases for r360109: gribozavr.
May 7 2019, 5:46 AM · Restricted Project
krasimir updated the summary of D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:45 AM · Restricted Project
krasimir created D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:41 AM · Restricted Project