User Details
User Details
- User Since
- Oct 11 2016, 5:32 AM (79 w, 6 d)
Today
Today
[clang-format] Fix clang-tidy readability problems, NFCI
[clang-format] Fix clang-tidy readability problems, NFCI
krasimir committed rC330569: Revert "[clang-format] Improve Incomplete detection for (text) protos".
Revert "[clang-format] Improve Incomplete detection for (text) protos"
krasimir committed rL330569: Revert "[clang-format] Improve Incomplete detection for (text) protos".
Revert "[clang-format] Improve Incomplete detection for (text) protos"
Thu, Apr 19
Thu, Apr 19
[clang-format] Don't remove empty lines before namespace endings
[clang-format] Don't remove empty lines before namespace endings
krasimir added inline comments to D45373: [clang-format] Don't remove empty lines before namespace endings.
krasimir added a comment to D45726: Format closing braces when reformatting the line containing theopening brace..
Another point: for the example in the summary about bailing-out early, is there a test for this already? If not, we should add one.
krasimir updated the summary of D45726: Format closing braces when reformatting the line containing theopening brace..
krasimir updated the summary of D45726: Format closing braces when reformatting the line containing theopening brace..
krasimir retitled D45726: Format closing braces when reformatting the line containing theopening brace. from Format closing braces when reformatting the line containing the
opening brace.
This required a couple of yaks to be shaved:
1. MatchingOpeningBlockLineIndex was misused to also store the
closing index; instead, use a second variable, as this... to Format closing braces when reformatting the line containing theopening brace..
krasimir added a comment to D45726: Format closing braces when reformatting the line containing theopening brace..
Great patch!
Fri, Apr 13
Fri, Apr 13
krasimir added inline comments to D44203: [clang-format] Improve Incomplete detection for (text) protos.
[clang-format] Improve Incomplete detection for (text) protos
[clang-format] Improve Incomplete detection for (text) protos
krasimir updated the diff for D44203: [clang-format] Improve Incomplete detection for (text) protos.
- Address review comments
Mon, Apr 9
Mon, Apr 9
[RuntimeDyld][PowerPC] Fix a newly added test in r329355
Fri, Apr 6
Fri, Apr 6
Thu, Apr 5
Thu, Apr 5
krasimir added inline comments to D44203: [clang-format] Improve Incomplete detection for (text) protos.
krasimir updated the diff for D44203: [clang-format] Improve Incomplete detection for (text) protos.
- Address review comments
[clang-format] Preserve spaces before a percent in (text) protos
[clang-format] Preserve spaces before a percent in (text) protos
krasimir added a comment to rL329258: [MIR-Canon] Fixing warnings in Non-assert builds..
Why not inline LastRenameReg into the DEBUG macro? Now that call will be made in non-debug builds :(
Wed, Apr 4
Wed, Apr 4
Thank you!
Thu, Mar 29
Thu, Mar 29
krasimir added inline comments to D44765: PR36643 Make clang-format support more generic TMarcos.
Tue, Mar 27
Tue, Mar 27
krasimir requested changes to D42034: [clang-format] In tests, expected code should be format-stable.
Thank you!
If this works, we should apply it to all files in unittest/Format.
krasimir added a reviewer for D44765: PR36643 Make clang-format support more generic TMarcos: klimek.
krasimir added a comment to D44765: PR36643 Make clang-format support more generic TMarcos.
I don't have preferences over names, but I agree with Alex that the option should have more detailed description.
[clang-move] Fix test failing due to clang-format change
[clang-move] Fix test failing due to clang-format change
Revert "[clang-format] Remove empty lines before }[;] // comment"
Revert "[clang-format] Remove empty lines before }[;] // comment"
Mar 20 2018
Mar 20 2018
krasimir added a comment to D44695: [clang-format] Partially revert r322749, replacing array with DenseSet.
One way in which DenseSet is better is that it supports StringRefs - we don't have to define hash. Seems like the lack of this override in core LLVM suggests that unordered_set is not commonly used with StringRefs.
krasimir added inline comments to D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic.
krasimir added reviewers for D44695: [clang-format] Partially revert r322749, replacing array with DenseSet: benhamilton, bkramer, djasper, jolesiak.
Mar 19 2018
Mar 19 2018
[clang-format] Remove empty lines before }[;] // comment
[clang-format] Remove empty lines before }[;] // comment
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 16 2018
Mar 16 2018
[clang-format] Disallow breaks before ']' in text proto extensions
[clang-format] Disallow breaks before ']' in text proto extensions
This revision was not accepted when it landed; it landed in state Needs Review.
krasimir updated the diff for D44569: [clang-format] Disallow breaks before ']' in text proto extensions.
- Remove newlines
[clang-format] Fix raw string prefix penalty
[clang-format] Fix raw string prefix penalty
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 14 2018
Mar 14 2018
krasimir added inline comments to D33560: [clang-format] Add option to specify explicit config file.
Mar 8 2018
Mar 8 2018
krasimir committed rC326996: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
[clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings
krasimir committed rL326996: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
[clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings
Mar 7 2018
Mar 7 2018
[clang-format] Break consecutive string literals in text protos
[clang-format] Break consecutive string literals in text protos
krasimir added a reviewer for D44204: [clang-format] Break consecutive string literals in text protos: alexfh.
krasimir added inline comments to D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC.
Mar 6 2018
Mar 6 2018
[clang-format] fix handling of consecutive unary operators
[clang-format] fix handling of consecutive unary operators
[clang-format] Fix documentation for SpaceAfterCStyleCast option
[clang-format] Fix documentation for SpaceAfterCStyleCast option
krasimir added a comment to D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.
I'll commit this for you.
krasimir added inline comments to D43904: [clang-format] Improve detection of ObjC for-in statements.
krasimir added inline comments to D43906: [clang-format] Improve detection of Objective-C block types.
Mar 5 2018
Mar 5 2018
Thank you!
krasimir added inline comments to D43906: [clang-format] Improve detection of Objective-C block types.
krasimir added inline comments to D43904: [clang-format] Improve detection of ObjC for-in statements.
krasimir added inline comments to D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC.
Mar 1 2018
Mar 1 2018
krasimir added a reviewer for D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC: djasper.
krasimir requested changes to D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.
This rst file is generated from include/clang/Format/Format.h using docs/tools/dump_format_style.py. Update it there and run the tool to regenerate the .rst file.
Feb 27 2018
Feb 27 2018
[clang-format] Format operator key in protos
[clang-format] Format operator key in protos
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 26 2018
Feb 26 2018
Feb 21 2018
Feb 21 2018
Feb 19 2018
Feb 19 2018
[clang-format] Fix text proto extension scope opening detection
[clang-format] Fix text proto extension scope opening detection
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was not accepted when it landed; it landed in state Needs Review.
[clang-format] Fixup a case of text proto message attributes
[clang-format] Fixup a case of text proto message attributes
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 16 2018
Feb 16 2018
Thank you! Do you have commit access or should I commit this for you?
[clang-format] Enable google text proto formatting in R"proto('s