krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (32 w, 21 h)

Recent Activity

Today

krasimir added inline comments to D33416: [clangd] Allow to use vfs::FileSystem for file accesses..
Wed, May 24, 2:49 AM

Yesterday

krasimir committed rL303635: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
[Tooling][libclang] Remove unused CompilationDatabase::MappedSources
Tue, May 23, 6:50 AM
krasimir closed D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources by committing rL303635: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
Tue, May 23, 6:50 AM
krasimir accepted D33415: [clangd] Replaced WorkerRequest with std::function....

Looks good.

Tue, May 23, 4:59 AM · Restricted Project
krasimir added a comment to D32480: clang-format: Add CompactNamespaces option.

In any case, adding a namespace end comment to a line closing multiple namespaces is super confusing for me: what does the comment refer to: the inner one, the outer one, or both?
}} // namespace A::B

Tue, May 23, 4:43 AM · Restricted Project
krasimir added a comment to D32480: clang-format: Add CompactNamespaces option.

This change should also adapt NamespaceEndCommentFixer to respect the new option and not introduce/remove/change the comments unexpectedly.

Tue, May 23, 4:39 AM · Restricted Project
krasimir added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

@klimek: ping

Tue, May 23, 3:21 AM
krasimir added inline comments to D33415: [clangd] Replaced WorkerRequest with std::function....
Tue, May 23, 2:51 AM · Restricted Project
krasimir added inline comments to D33415: [clangd] Replaced WorkerRequest with std::function....
Tue, May 23, 2:48 AM · Restricted Project

Mon, May 22

krasimir committed rL303547: [clangd] Switch to incomplete translation units.
[clangd] Switch to incomplete translation units
Mon, May 22, 5:49 AM
krasimir closed D33350: [clangd] Switch to incomplete translation units by committing rL303547: [clangd] Switch to incomplete translation units.
Mon, May 22, 5:49 AM
krasimir accepted D33285: clang-format: do not reflow bullet lists.

Looks great!

Mon, May 22, 5:39 AM
krasimir added inline comments to D33395: [clangd] Split clangd into library+executable (mainly for unit tests)..
Mon, May 22, 4:57 AM · Restricted Project
krasimir committed rL303541: [clang-format] Keep trailing preprocessor line comments separate from the….
[clang-format] Keep trailing preprocessor line comments separate from the…
Mon, May 22, 3:08 AM
krasimir closed D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments by committing rL303541: [clang-format] Keep trailing preprocessor line comments separate from the….
Mon, May 22, 3:08 AM
krasimir updated the diff for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
  • Remove parentheses
Mon, May 22, 3:06 AM
krasimir added inline comments to D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
Mon, May 22, 3:00 AM
krasimir updated the diff for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
  • Address review comments
Mon, May 22, 3:00 AM
krasimir added a reviewer for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments: djasper.
Mon, May 22, 1:45 AM
krasimir created D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
Mon, May 22, 1:44 AM

Fri, May 19

krasimir committed rL303415: [clang-format] Handle trailing comment sections in import statement lines.
[clang-format] Handle trailing comment sections in import statement lines
Fri, May 19, 3:48 AM
krasimir closed D33351: [clang-format] Handle trailing comment sections in import statement lines by committing rL303415: [clang-format] Handle trailing comment sections in import statement lines.
Fri, May 19, 3:48 AM
krasimir updated the diff for D33351: [clang-format] Handle trailing comment sections in import statement lines.
  • Address review comments
Fri, May 19, 3:45 AM
krasimir removed a reviewer for D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines: djasper.
Fri, May 19, 3:37 AM
krasimir added a reviewer for D33351: [clang-format] Handle trailing comment sections in import statement lines: djasper.
Fri, May 19, 3:35 AM
krasimir retitled D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines from [clang-format] Handle trailing comment sections in import statement lines to OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines.
Fri, May 19, 3:34 AM
krasimir created D33351: [clang-format] Handle trailing comment sections in import statement lines.
Fri, May 19, 3:33 AM
krasimir created D33350: [clangd] Switch to incomplete translation units.
Fri, May 19, 2:58 AM

Thu, May 18

krasimir committed rL303353: [clang-format] Fix MatchingOpeningBlockLineIndex computation.
[clang-format] Fix MatchingOpeningBlockLineIndex computation
Thu, May 18, 8:29 AM
krasimir closed D32524: [clang-format] Fix MatchingOpeningBlockLineIndex computation by committing rL303353: [clang-format] Fix MatchingOpeningBlockLineIndex computation.
Thu, May 18, 8:29 AM
krasimir added a comment to D32524: [clang-format] Fix MatchingOpeningBlockLineIndex computation.

It should be enough for commit access. Mention your patches while requesting commit access. I'll submit this in the meantime.

Thu, May 18, 8:01 AM
krasimir added a comment to D32524: [clang-format] Fix MatchingOpeningBlockLineIndex computation.

Do you need me to commit this?

Thu, May 18, 7:28 AM
krasimir added inline comments to D33285: clang-format: do not reflow bullet lists.
Thu, May 18, 6:39 AM
krasimir added a comment to D33314: clang-format: Add option to remove semicolon at end of namespace.

I think that this is more of a linter check and as such doesn't really belong to clang-format.
@djasper: what do you think about this?

Thu, May 18, 4:53 AM
krasimir committed rL303332: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore.
[clang-format] Make NoLineBreakFormatter respect MustBreakBefore
Thu, May 18, 1:21 AM
krasimir closed D33238: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore by committing rL303332: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore.
Thu, May 18, 1:21 AM
krasimir updated the diff for D33238: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore.
  • Add comment about import statements.
Thu, May 18, 1:17 AM
krasimir committed rL303330: clang-format: fix prefix for doxygen comments after member.
clang-format: fix prefix for doxygen comments after member
Thu, May 18, 12:49 AM
krasimir closed D33282: clang-format: fix prefix for doxygen comments after member by committing rL303330: clang-format: fix prefix for doxygen comments after member.
Thu, May 18, 12:49 AM
krasimir added a comment to D33282: clang-format: fix prefix for doxygen comments after member.

I'll commit this.

Thu, May 18, 12:39 AM
krasimir added inline comments to D33285: clang-format: do not reflow bullet lists.
Thu, May 18, 12:26 AM
krasimir accepted D33282: clang-format: fix prefix for doxygen comments after member.

Looks good. Thank you!

Thu, May 18, 12:13 AM

Wed, May 17

krasimir committed rL303265: [Frontend] Remove unused TemporaryFiles.
[Frontend] Remove unused TemporaryFiles
Wed, May 17, 8:05 AM
krasimir closed D33270: [Frontend] Remove unused TemporaryFiles by committing rL303265: [Frontend] Remove unused TemporaryFiles.
Wed, May 17, 8:05 AM
krasimir accepted D32524: [clang-format] Fix MatchingOpeningBlockLineIndex computation.

I can't think of a test case either. Thanks!

Wed, May 17, 3:42 AM
krasimir updated the diff for D33270: [Frontend] Remove unused TemporaryFiles.
  • Remove unused method from the header file too
Wed, May 17, 2:31 AM
krasimir created D33270: [Frontend] Remove unused TemporaryFiles.
Wed, May 17, 2:27 AM

Tue, May 16

krasimir added a reviewer for D33238: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore: djasper.
Tue, May 16, 7:19 AM
krasimir updated the diff for D33238: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore.
  • Updated comments
Tue, May 16, 7:18 AM
krasimir created D33238: [clang-format] Make NoLineBreakFormatter respect MustBreakBefore.
Tue, May 16, 7:16 AM
krasimir accepted D33201: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer.

Looks good!

Tue, May 16, 6:27 AM · Restricted Project
krasimir added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

@klimek: ping

Tue, May 16, 5:39 AM
krasimir added a comment to D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines.

@djasper: ping

Tue, May 16, 5:38 AM
krasimir added inline comments to D33201: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer.
Tue, May 16, 5:29 AM · Restricted Project
krasimir added a comment to D33201: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer.

nit: rename this patch title to start with [clangd]

Tue, May 16, 5:25 AM · Restricted Project
krasimir added inline comments to D33201: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer.
Tue, May 16, 2:55 AM · Restricted Project
krasimir accepted D33233: Restored r303067 and fixed failing test..
Tue, May 16, 2:49 AM

Thu, May 11

krasimir added inline comments to D33047: [ClangD] Refactor clangd into separate components.
Thu, May 11, 6:44 AM · Restricted Project

Fri, May 5

krasimir added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

@klimek: We don't have any clients of this field inside clang.

Fri, May 5, 10:03 AM
krasimir committed rL302236: [Tooling] Remove redundant check, NFCi.
[Tooling] Remove redundant check, NFCi
Fri, May 5, 7:26 AM
krasimir closed D32909: [Tooling] Remove redundant check, NFCi by committing rL302236: [Tooling] Remove redundant check, NFCi.
Fri, May 5, 7:22 AM
krasimir created D32909: [Tooling] Remove redundant check, NFCi.
Fri, May 5, 7:06 AM
krasimir added a reviewer for D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines: djasper.
Fri, May 5, 4:52 AM
krasimir created D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines.
Fri, May 5, 4:51 AM
krasimir added a comment to D32524: [clang-format] Fix MatchingOpeningBlockLineIndex computation.

Thank you! A test would be nice.

Fri, May 5, 1:40 AM

Wed, May 3

krasimir accepted D31887: [clangd] Add documentation page.

Looks good! Thank you!

Wed, May 3, 8:36 AM · Restricted Project

Apr 21 2017

krasimir added a reviewer for D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources: klimek.
Apr 21 2017, 8:54 AM
krasimir committed rL300985: [clang-format] Replace IncompleteFormat by a struct with Line.
[clang-format] Replace IncompleteFormat by a struct with Line
Apr 21 2017, 7:48 AM
krasimir closed D32298: [clang-format] Replace IncompleteFormat by a struct with Line by committing rL300985: [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 21 2017, 7:48 AM
krasimir committed rL300983: [clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC.
[clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC
Apr 21 2017, 7:42 AM
krasimir committed rL300982: [clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC.
[clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC
Apr 21 2017, 7:34 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 21 2017, 7:30 AM
krasimir retitled D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources from [Tooling, libclang] Remove unused CompilationDatabase::MappedSources to [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
Apr 21 2017, 7:20 AM
krasimir created D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
Apr 21 2017, 7:19 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 21 2017, 6:38 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Refactor tests
Apr 21 2017, 6:37 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Changed IncompleteFormat to FormatComplete
Apr 21 2017, 6:27 AM
krasimir retitled D32298: [clang-format] Replace IncompleteFormat by a struct with Line from [clang-format] Turn IncompleteFormat into a string to [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 21 2017, 4:01 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Introduce a proper abstraction
Apr 21 2017, 3:58 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 21 2017, 2:47 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Removed double declaration
Apr 21 2017, 2:47 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Address review comments
Apr 21 2017, 2:43 AM

Apr 20 2017

krasimir added a reviewer for D32298: [clang-format] Replace IncompleteFormat by a struct with Line: djasper.
Apr 20 2017, 9:44 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Removed comments
Apr 20 2017, 9:43 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Updated string escaping
Apr 20 2017, 9:39 AM
krasimir created D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Apr 20 2017, 9:35 AM
krasimir committed rL300841: Delete unused IncompleteFormat variable, NFCi..
Delete unused IncompleteFormat variable, NFCi.
Apr 20 2017, 6:58 AM

Apr 13 2017

krasimir added a comment to D31992: [clangd] Escape only necessary characters in JSON output.

Seems that we're starting to hit some YAML/JSON mismatches, or is it that your YAML string support is lacking?

Apr 13 2017, 5:38 AM · Restricted Project
krasimir added a reviewer for D31992: [clangd] Escape only necessary characters in JSON output: klimek.
Apr 13 2017, 5:37 AM · Restricted Project

Apr 12 2017

krasimir committed rL300077: [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC.
[clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC
Apr 12 2017, 10:25 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

By the way, you may want to look at this build bot stage 2 failure (not sure if that's just stale data or a genuine new failure).
http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto_check/14795/consoleFull#74713522449ba4694-19c4-4d7e-bec5-911270d8a58c
Specifically, look for the line:

TEST 'LLVM :: Analysis/CostModel/SystemZ/ext-load.ll' FAILED
Apr 12 2017, 8:39 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

Thanks!

Apr 12 2017, 5:28 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

I'll revert this in 10 minutes to keep the build going.

Apr 12 2017, 5:20 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

Seems that this breaks CostModel/SystemZ/fp-cast.ll:

Command Output (stderr):
--
/usr/local/google/home/krasimir/work3/llvm/test/Analysis/CostModel/SystemZ/fp-cast.ll:113:10: error: expected string not found in input
; CHECK: Cost Model: Found an estimated cost of 6 for instruction: %v17 = fptosi <2 x double> undef to <2 x i32>
^
<stdin>:34:1: note: scanning from here
Cost Model: Found an estimated cost of 7 for instruction: %v17 = fptosi <2 x double> undef to <2 x i32>
^
Apr 12 2017, 5:06 AM
krasimir committed rL300051: [DWARF] Fix compiler warnings in DWARFContext.cpp, NFCi.
[DWARF] Fix compiler warnings in DWARFContext.cpp, NFCi
Apr 12 2017, 4:46 AM

Apr 11 2017

krasimir committed rL299935: [clangd] Implement item kind for completion results.
[clangd] Implement item kind for completion results
Apr 11 2017, 6:40 AM
krasimir closed D31853: [clangd] Implement item kind for completion results by committing rL299935: [clangd] Implement item kind for completion results.
Apr 11 2017, 6:39 AM · Restricted Project
krasimir added a comment to D31853: [clangd] Implement item kind for completion results.

Do you still need someone to commit this?

Apr 11 2017, 6:21 AM · Restricted Project
krasimir accepted D31853: [clangd] Implement item kind for completion results.

Looks good! Thank you!

Apr 11 2017, 1:56 AM · Restricted Project

Apr 10 2017

krasimir committed rL299844: [clangd] Fix nondeterminism in clangd test.
[clangd] Fix nondeterminism in clangd test
Apr 10 2017, 7:19 AM