krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (53 w, 6 d)

Recent Activity

Fri, Oct 20

krasimir added inline comments to D38805: [clang-format] Handle CRLF correctly when formatting escaped newlines.
Fri, Oct 20, 4:39 AM · Restricted Project

Wed, Oct 18

krasimir committed rL316130: [clang-format] Sort whole block of using declarations while partially formatting.
[clang-format] Sort whole block of using declarations while partially formatting
Wed, Oct 18, 3:15 PM
krasimir closed D39024: [clang-format] Sort whole block of using declarations while partially formatting by committing rL316130: [clang-format] Sort whole block of using declarations while partially formatting.
Wed, Oct 18, 3:15 PM
krasimir updated the diff for D39024: [clang-format] Sort whole block of using declarations while partially formatting.
  • Address review comments
Wed, Oct 18, 12:56 PM
krasimir added a comment to rL316102: [Hexagon] Handling of new HVX flags and target-features.

A newly added test seems to be failing:

/usr/local/google/home/krasimir/work/llvm/tools/clang/test/Driver/hexagon-hvx.c:71:25: error: expected string not found in input
// CHECK-HVXLENGTH-64B: "-target-feature" "+hvx{{.*}}" "-target-feature" "+hvx-length64b"
Wed, Oct 18, 12:13 PM

Tue, Oct 17

krasimir added a comment to D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER).

How is this even reviewed?

Tue, Oct 17, 11:36 PM
krasimir created D39024: [clang-format] Sort whole block of using declarations while partially formatting.
Tue, Oct 17, 5:09 PM

Mon, Oct 16

krasimir accepted D38731: [clangd] Allow to pass code completion opts to ClangdServer..

Great! I like the unit testing approach a lot!

Mon, Oct 16, 6:23 AM
krasimir committed rL315893: [clang-format] Break non-trailing comments, try 2.
[clang-format] Break non-trailing comments, try 2
Mon, Oct 16, 2:09 AM
krasimir closed D37695: [clang-format] Break non-trailing comments, try 2 by committing rL315893: [clang-format] Break non-trailing comments, try 2.
Mon, Oct 16, 2:09 AM

Thu, Oct 12

krasimir added a comment to D35943: [clang-format] Format raw string literals.

ping

Thu, Oct 12, 1:35 AM
krasimir added a comment to D37695: [clang-format] Break non-trailing comments, try 2.

ping

Thu, Oct 12, 1:34 AM

Mon, Oct 2

krasimir committed rL314683: [clang-format] Fix regression about short functions after #else.
[clang-format] Fix regression about short functions after #else
Mon, Oct 2, 8:55 AM
krasimir closed D37973: [clang-format] Fix regression about short functions after #else by committing rL314683: [clang-format] Fix regression about short functions after #else.
Mon, Oct 2, 8:55 AM
krasimir edited reviewers for D37973: [clang-format] Fix regression about short functions after #else, added: sammccall; removed: djasper, klimek.
Mon, Oct 2, 7:59 AM

Fri, Sep 29

thomasjo awarded D34947: [clangd] Add support for per-file extra flags a Love token.
Fri, Sep 29, 8:40 AM · Restricted Project

Tue, Sep 26

krasimir added inline comments to D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.
Tue, Sep 26, 10:04 PM · Restricted Project
krasimir accepted D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Looks good!

Tue, Sep 26, 9:53 PM
krasimir updated the diff for D37695: [clang-format] Break non-trailing comments, try 2.
  • Change bool from Paren to Line and generalize it
Tue, Sep 26, 5:47 PM
krasimir committed rL314211: [clang-format] Add ext/ to google include categories.
[clang-format] Add ext/ to google include categories
Tue, Sep 26, 3:33 PM
krasimir closed D38243: [clang-format] Add ext/ to google include categories by committing rL314211: [clang-format] Add ext/ to google include categories.
Tue, Sep 26, 3:33 PM

Mon, Sep 25

krasimir added a comment to D37695: [clang-format] Break non-trailing comments, try 2.

ping

Mon, Sep 25, 12:21 PM
krasimir added a comment to D35943: [clang-format] Format raw string literals.

ping

Mon, Sep 25, 12:21 PM
krasimir created D38243: [clang-format] Add ext/ to google include categories.
Mon, Sep 25, 10:52 AM

Sep 21 2017

krasimir committed rL313963: [clang-format] Ignore case and stable sort using-declarations.
[clang-format] Ignore case and stable sort using-declarations
Sep 21 2017, 9:50 PM
krasimir closed D37263: [clang-format] Ignore case and stable sort using-declarations by committing rL313963: [clang-format] Ignore case and stable sort using-declarations.
Sep 21 2017, 9:50 PM
krasimir committed rL313962: [clang-tidy] Fix example in documentation, NFC.
[clang-tidy] Fix example in documentation, NFC
Sep 21 2017, 9:39 PM
krasimir closed D38087: [clang-tidy] Fix example in documentation, NFC by committing rL313962: [clang-tidy] Fix example in documentation, NFC.
Sep 21 2017, 9:39 PM

Sep 20 2017

krasimir created D38087: [clang-tidy] Fix example in documentation, NFC.
Sep 20 2017, 9:41 AM
krasimir added a comment to D38081: Set completion priority of destructors and operators to CCP_Unlikely..

+1! I totally agree with this!

Sep 20 2017, 7:50 AM
krasimir accepted D38077: [clangd] Put inacessible items to the end of completion list..

Makes sense.

Sep 20 2017, 7:46 AM
krasimir retitled D37263: [clang-format] Ignore case and stable sort using-declarations from [clang-format] Ignore case when sorting using-declarations to [clang-format] Ignore case and stable sort using-declarations.
Sep 20 2017, 7:38 AM
krasimir updated the diff for D37263: [clang-format] Ignore case and stable sort using-declarations.
  • Stable sort using declarations
Sep 20 2017, 7:36 AM
krasimir added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

This is how you could add a test in NamespaceEndCommentsFixerTest.cpp:

TEST_F(NamespaceEndCommentsFixerTest, FixesNamespaceCommentsInAllmanStyle) {
  FormatStyle AllmanStyle = getLLVMStyle();
  AllmanStyle.BreakBeforeBraces = FormatStyle::BS_Allman;
  EXPECT_EQ("namespace a\n"
            "{\n"
            "void f();\n"
            "void g();\n"
            "}// namespace a\n",
            fixNamespaceEndComments("namespace a\n"
                                    "{\n"
                                    "void f();\n"
                                    "void g();\n"
                                    "}\n",
                                    AllmanStyle));
}
Sep 20 2017, 7:03 AM

Sep 19 2017

krasimir added a reviewer for D37263: [clang-format] Ignore case and stable sort using-declarations: alexfh.
Sep 19 2017, 3:19 AM

Sep 18 2017

krasimir added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Could you please move the test that adds a namespace end comment to unittests/Format/NamespaceEndCommentsFixerTest.cpp?

Sep 18 2017, 8:54 AM
krasimir added a reviewer for D37973: [clang-format] Fix regression about short functions after #else: klimek.
Sep 18 2017, 6:41 AM
krasimir created D37973: [clang-format] Fix regression about short functions after #else.
Sep 18 2017, 6:36 AM

Sep 15 2017

krasimir committed rL313354: [clang-format] New flag - BraceWrapping.AfterExternBlock.
[clang-format] New flag - BraceWrapping.AfterExternBlock
Sep 15 2017, 4:25 AM
krasimir closed D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock by committing rL313354: [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 15 2017, 4:25 AM
krasimir accepted D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

Looks good! Should I commit this for you?

Sep 15 2017, 1:52 AM

Sep 14 2017

krasimir added a comment to D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

Looks great! Just one more nit: please add a line checking the parsing of the new option similar to the line CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterStruct); in unittests/Format/FormatTest.cpp.

Sep 14 2017, 6:31 AM
krasimir added inline comments to D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 14 2017, 5:03 AM
krasimir added inline comments to D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 14 2017, 2:47 AM
krasimir added inline comments to D33440: clang-format: better handle statement macros.
Sep 14 2017, 1:00 AM

Sep 13 2017

krasimir added a comment to D33440: clang-format: better handle statement macros.

Patch looks good, but I also would like to see it splited. I would suggest to first get the statement macro part in, which requires less code. Then we can put the namespace macros on top of that. I really like the generality of this approach and would want to also add support for class macros eventually.

Sep 13 2017, 3:30 AM

Sep 11 2017

krasimir added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

Yes, I meant that it should at least be controlled by a flag. However, adding flags to clang-format requires careful consideration, we usually would accept options that are necessary for commonly used styles with style guides and with a community willing to support these options.

Sep 11 2017, 8:30 AM
krasimir updated the diff for D37695: [clang-format] Break non-trailing comments, try 2.
  • Add the original test cases
Sep 11 2017, 8:25 AM
krasimir created D37695: [clang-format] Break non-trailing comments, try 2.
Sep 11 2017, 8:22 AM
krasimir committed rL312904: [clang-format] Fixed one-line if statement.
[clang-format] Fixed one-line if statement
Sep 11 2017, 3:14 AM
krasimir closed D37140: [clang-format] Fixed one-line if statement by committing rL312904: [clang-format] Fixed one-line if statement.
Sep 11 2017, 3:14 AM
krasimir added a comment to D35943: [clang-format] Format raw string literals.

I think this is ready for another round of reviews.

Sep 11 2017, 2:54 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Document FirstStateColumn @ getInitialState
Sep 11 2017, 2:50 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Remove raw string cache
Sep 11 2017, 2:42 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Fix a regression after preprocessor indentation
Sep 11 2017, 2:35 AM

Sep 8 2017

krasimir accepted D37140: [clang-format] Fixed one-line if statement .

Great! Would you like me to commit this for you?

Sep 8 2017, 7:13 AM
krasimir added a comment to D37263: [clang-format] Ignore case and stable sort using-declarations.

ping

Sep 8 2017, 6:58 AM
krasimir committed rL312790: Updated two annotations for Store.h and CodeGenFunction.h..
Updated two annotations for Store.h and CodeGenFunction.h.
Sep 8 2017, 6:46 AM
krasimir closed D36330: Updated two annotations for Store.h and CodeGenFunction.h. by committing rL312790: Updated two annotations for Store.h and CodeGenFunction.h..
Sep 8 2017, 6:46 AM
krasimir accepted D37101: [clangd] Add support for snippet completions.

Great!

Sep 8 2017, 6:38 AM · Restricted Project

Sep 5 2017

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Rebase with master
Sep 5 2017, 7:29 AM
krasimir committed rL312536: [clang-format] Fix lines=all case in clang-format.py.
[clang-format] Fix lines=all case in clang-format.py
Sep 5 2017, 7:00 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Sep 5 2017, 6:56 AM

Aug 30 2017

krasimir committed rL312125: clang-format: Add preprocessor directive indentation.
clang-format: Add preprocessor directive indentation
Aug 30 2017, 7:36 AM
krasimir closed D35955: clang-format: Add preprocessor directive indentation by committing rL312125: clang-format: Add preprocessor directive indentation.
Aug 30 2017, 7:36 AM · Restricted Project
krasimir added a comment to D35955: clang-format: Add preprocessor directive indentation.

I'll land this for you, as discussed offline. The best thing is to apply for commit rights after you have a few patches landed.

Aug 30 2017, 7:05 AM · Restricted Project
krasimir added inline comments to D37140: [clang-format] Fixed one-line if statement .
Aug 30 2017, 6:12 AM
krasimir added inline comments to D37101: [clangd] Add support for snippet completions.
Aug 30 2017, 5:20 AM · Restricted Project
krasimir added inline comments to D37150: [clangd] Command line arg to specify compile_commands.json path.
Aug 30 2017, 3:21 AM
krasimir added a comment to D35943: [clang-format] Format raw string literals.

I think this is ready for another round of reviews.

Aug 30 2017, 2:05 AM

Aug 29 2017

krasimir updated the diff for D37263: [clang-format] Ignore case and stable sort using-declarations.
  • Actually add a test
Aug 29 2017, 7:40 AM
krasimir created D37263: [clang-format] Ignore case and stable sort using-declarations.
Aug 29 2017, 7:38 AM
krasimir committed rL312000: [clang-format] Refactor likely xml a bit, NFC.
[clang-format] Refactor likely xml a bit, NFC
Aug 29 2017, 6:58 AM
krasimir committed rL311999: [clang-format] Do not format likely xml.
[clang-format] Do not format likely xml
Aug 29 2017, 6:53 AM
krasimir closed D37136: [clang-format] Do not format likely xml by committing rL311999: [clang-format] Do not format likely xml.
Aug 29 2017, 6:53 AM
krasimir updated the diff for D37136: [clang-format] Do not format likely xml.
  • Address review comments
Aug 29 2017, 6:48 AM
krasimir committed rL311998: [clang-format] Fixed typedef enum brace wrapping.
[clang-format] Fixed typedef enum brace wrapping
Aug 29 2017, 6:33 AM
krasimir closed D37143: [clang-format] Fixed typedef enum brace wrapping by committing rL311998: [clang-format] Fixed typedef enum brace wrapping.
Aug 29 2017, 6:33 AM
krasimir added a comment to D37143: [clang-format] Fixed typedef enum brace wrapping.

Thank you! I prefer this patch to be split in two. I am still not convinced about the extern part: some clients might prefer the other style.

Aug 29 2017, 2:59 AM
krasimir added a comment to D35955: clang-format: Add preprocessor directive indentation.

@euhlmann: are you planning to commit this?

Aug 29 2017, 1:56 AM · Restricted Project

Aug 28 2017

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Updated indent to IndentWidth
  • Revised the rules for formatting the prefix and suffix
Aug 28 2017, 8:36 AM

Aug 25 2017

krasimir added a comment to D37143: [clang-format] Fixed typedef enum brace wrapping.

These look like they could be two separate patches: I like the typedef enum part, not convinced about the extern part. Also, please add unit tests.

Aug 25 2017, 6:26 AM
krasimir updated subscribers of D37136: [clang-format] Do not format likely xml.
Aug 25 2017, 2:45 AM
krasimir created D37136: [clang-format] Do not format likely xml.
Aug 25 2017, 2:42 AM

Aug 24 2017

krasimir committed rL311672: [clang-format] Emit absolute splits before lines for comments, try 2.
[clang-format] Emit absolute splits before lines for comments, try 2
Aug 24 2017, 9:42 AM
krasimir closed D37109: [clang-format] Emit absolute splits before lines for comments, try 2 by committing rL311672: [clang-format] Emit absolute splits before lines for comments, try 2.
Aug 24 2017, 9:42 AM
krasimir committed rL311666: [X86AsmParser] Refactor AsmRewrite constructors, NFCI.
[X86AsmParser] Refactor AsmRewrite constructors, NFCI
Aug 24 2017, 8:04 AM
krasimir closed D37110: [X86AsmParser] Refactor AsmRewrite constructors, NFCI by committing rL311666: [X86AsmParser] Refactor AsmRewrite constructors, NFCI.
Aug 24 2017, 8:04 AM
krasimir added a comment to D35955: clang-format: Add preprocessor directive indentation.

Thank you! I understand this patch better now. Looks good from my side!

Aug 24 2017, 8:03 AM · Restricted Project
krasimir accepted D35955: clang-format: Add preprocessor directive indentation.
Aug 24 2017, 8:03 AM · Restricted Project
krasimir added a comment to D35012: [refactor] Add the AST source selection component.

The test CursorAtStartOfFunction is segfaulting.

Aug 24 2017, 7:50 AM
krasimir created D37110: [X86AsmParser] Refactor AsmRewrite constructors, NFCI.
Aug 24 2017, 7:47 AM
krasimir added a comment to D36330: Updated two annotations for Store.h and CodeGenFunction.h..

@MTC, do you have commit access or should we commit this for you?

Aug 24 2017, 7:42 AM
krasimir added a comment to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.

Thank you! I think your suggestion is nice. I'll create a follow-up patch for that!

Aug 24 2017, 7:32 AM
krasimir added a comment to D37109: [clang-format] Emit absolute splits before lines for comments, try 2.

@djasper: No. The test case is a special constellation.

Aug 24 2017, 7:29 AM
krasimir added a reviewer for D37109: [clang-format] Emit absolute splits before lines for comments, try 2: djasper.
Aug 24 2017, 7:14 AM
krasimir created D37109: [clang-format] Emit absolute splits before lines for comments, try 2.
Aug 24 2017, 7:12 AM
krasimir added inline comments to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
Aug 24 2017, 6:50 AM
krasimir committed rL311653: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
[X86AsmParser] Fix msan: use-of-uninitialized-value after r311639
Aug 24 2017, 6:40 AM
krasimir closed D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639 by committing rL311653: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
Aug 24 2017, 6:40 AM