Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (292 w, 6 d)

Recent Activity

Tue, May 17

krasimir added a comment to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

We found another regression with this in wrongly indenting/not putting on its own line ObjC @interface:

% ./clang-format --version           
clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655)
% cat test.m
NS_SWIFT_NAME(A)
@interface B : C
@property(readonly) D value;
@end
Tue, May 17, 8:06 AM · Restricted Project, Restricted Project

Mon, May 16

krasimir added a comment to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

It looks like this regressed the following example by adding an unwanted level of indentation to the #elif B branch:

% ./clang-format --version
clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655)
% cat test.cc             
#define MACRO_BEGIN
Mon, May 16, 8:03 AM · Restricted Project, Restricted Project

Wed, May 11

krasimir committed rG52328dafda13: silence new -Wunused-result warnings in test (authored by krasimir).
silence new -Wunused-result warnings in test
Wed, May 11, 11:35 PM · Restricted Project, Restricted Project

Tue, May 3

krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@krasimir could you please test this patch on your side?

@kwk thank you! the new version of the patch looks good!

Tue, May 3, 12:43 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Apr 28

krasimir abandoned D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Thu, Apr 28, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir committed rGbe656df18721: [clang-format] add a regression test for include sorting (authored by krasimir).
[clang-format] add a regression test for include sorting
Thu, Apr 28, 2:03 AM · Restricted Project, Restricted Project
krasimir closed D124513: [clang-format] add a regression test for include sorting.
Thu, Apr 28, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C: rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective….
Thu, Apr 28, 2:01 AM · Restricted Project, Restricted Project
krasimir committed rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective… (authored by krasimir).
Revert "[clang-format] SortIncludes should support "@import" lines in Objective…
Thu, Apr 28, 2:01 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C: rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective….
Thu, Apr 28, 2:01 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Apr 27

krasimir added a reviewer for D124513: [clang-format] add a regression test for include sorting: MyDeveloperDay.
Wed, Apr 27, 2:58 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reviewer for D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C": MyDeveloperDay.
Wed, Apr 27, 2:57 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the diff for D124513: [clang-format] add a regression test for include sorting.
  • update with just the last commit
Wed, Apr 27, 2:55 AM · Restricted Project, Restricted Project, Restricted Project
krasimir requested review of D124513: [clang-format] add a regression test for include sorting.
Wed, Apr 27, 2:51 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C: D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Wed, Apr 27, 2:49 AM · Restricted Project, Restricted Project
krasimir requested review of D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Wed, Apr 27, 2:49 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C: D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Wed, Apr 27, 2:49 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@krasimir I'm on sick leave and will have a look as soon as I'm back. Can it wait that long?

Wed, Apr 27, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Apr 25

krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

It appears that this regressed include sorting in the following case, where the contents of test.h show the expected include order and the clang-format behavior before this patch:

% cat test.h
#include <cstdint>
Mon, Apr 25, 2:00 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

krasimir added a reverting change for rG126b37a713dc: [clang-format] Correctly recognize arrays in template parameter list.: rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list.".
Mar 24 2022, 2:16 AM · Restricted Project
krasimir committed rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list." (authored by krasimir).
Revert "[clang-format] Correctly recognize arrays in template parameter list."
Mar 24 2022, 2:16 AM · Restricted Project
krasimir added a reverting change for D121584: [clang-format] Correctly recognize arrays in template parameter list.: rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list.".
Mar 24 2022, 2:16 AM · Restricted Project, Restricted Project
krasimir added a comment to D121584: [clang-format] Correctly recognize arrays in template parameter list..

It appears that this regressed some ObjC patterns:

Mar 24 2022, 1:11 AM · Restricted Project, Restricted Project

Mar 22 2022

krasimir committed rGeb35e0ecbe0a: [clang-format] don't break up #-style comment sections (authored by krasimir).
[clang-format] don't break up #-style comment sections
Mar 22 2022, 7:30 AM · Restricted Project
krasimir closed D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the summary of D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:05 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reviewer for D122230: [clang-format] don't break up #-style comment sections: curdeius.
Mar 22 2022, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
krasimir edited projects for D122230: [clang-format] don't break up #-style comment sections, added: Restricted Project; removed Restricted Project.
Mar 22 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir requested review of D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

So I'd rather keep the old behaviour for # in Proto but not in C-like languages. Is that acceptable?

Mar 22 2022, 6:43 AM · Restricted Project, Restricted Project

Mar 21 2022

krasimir added a comment to D121584: [clang-format] Correctly recognize arrays in template parameter list..

It appears that this regressed some ObjC patterns:

% cat test.m  # before: good
void f() {
  //
  BOOL a = [b.c count] > 1;
  int b = a;
}
% clang-format -style=google test.m  # after: bad, statements joined on the same line
void f() {
  //
  BOOL a = [b.c count] > 1; int b = a;
}
%
Mar 21 2022, 4:32 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This is getting more fun: the reason why /// isn't broken up is because the first character / after the comment leader // is considered punctuation per isPunctuation's CHAR_RAWDEL, which includes all these {}[]#<>%:;?*+-/^&|~!=,"':

Mar 21 2022, 3:06 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this:

################################################################################
# Big section name
################################################################################

That's a pity.
Do you think that just doing a different thing (what we had before) for Proto (and if possible other languages where # is used in a similar way) should be enough?

Mar 21 2022, 1:54 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this:

################################################################################
# Big section name
################################################################################
Mar 21 2022, 1:40 AM · Restricted Project, Restricted Project

Mar 16 2022

krasimir added inline comments to D121758: [clang-format] Add support for formatting Verilog code.
Mar 16 2022, 2:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

krasimir committed rGad709bcfb02e: [lldb] Fix -Wformat warning after 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31 (authored by krasimir).
[lldb] Fix -Wformat warning after 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31
Mar 9 2022, 3:42 AM · Restricted Project

Mar 4 2022

krasimir added a comment to D118869: [clang-format] Non-latin comment prefix whitespace.

Thank you!
Turns out the original source wasn't using an ascii space for the comment indentation but a unicode [c2 a0] no-break space:

2f 2f c2 a0 43 6f 6d 6d  65 6e 74 0a 69 6e 74 20  |//..Comment.int |

IMO we shouldn't aim to handle non-ascii spaces for indentation in clang-format; the new behavior on this example is fine.

Mar 4 2022, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D118869: [clang-format] Non-latin comment prefix whitespace: Restricted Project.

It appears that this caused a regression by adding an additional space of indentation to line comments in some cases:

% cat test.cc  # (before)
// Comment
int i;
% clang-format -style=google test.cc
//  Comment
int i;

@ksyx could you please take a look?

Mar 4 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2022

krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

I just pushed 6cb42cd6669785f3b611106e1b6b38bbe65733a9 to hopefully fix this.

Mar 3 2022, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

krasimir removed a reviewer for D118361: clang-format: [JS] sort import aliases.: krasimir.
Mar 2 2022, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence thank you for looking into this, sorry for the late reply!

Mar 2 2022, 7:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example?

Sorry, I don't have a solution right now.

Feb 24 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example?

Feb 24 2022, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

krasimir accepted D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages..

Thank you!

Feb 22 2022, 7:09 AM · Restricted Project
krasimir committed rGc9592ae49b8c: [clang-format] Fix preprocessor nesting after commit… (authored by krasimir).
[clang-format] Fix preprocessor nesting after commit…
Feb 22 2022, 6:44 AM
krasimir closed D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c.
Feb 22 2022, 6:44 AM · Restricted Project, Restricted Project
krasimir updated the diff for D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c.
  • address review comments
Feb 22 2022, 6:42 AM · Restricted Project, Restricted Project
krasimir added a comment to D113319: [clang-format] Improve require and concept handling.

It appears that this causes a regression by adding a space in-between pointer dereferences *p -> * p in some cases, e.g. formatting this with llvm style:

// before
void f() {
  while (p < a && *p == 'a')
    p++;
}
// after
void f() {
  while (p < a && * p == 'a')
    p++;
}
Feb 22 2022, 6:36 AM · Restricted Project, Restricted Project
krasimir added a comment to D113319: [clang-format] Improve require and concept handling.

It appears that after this patch clang-format started breaking up requires in javascript, e.g.:

// before
function f() {
  var requires = {};
}
// after
function f() {
  var
    requires
  = {};
}
Feb 22 2022, 5:13 AM · Restricted Project, Restricted Project
krasimir added reviewers for D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c: curdeius, owenpan, HazardyKnusperkeks.
Feb 22 2022, 3:24 AM · Restricted Project, Restricted Project
krasimir requested review of D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c.
Feb 22 2022, 3:22 AM · Restricted Project, Restricted Project

Feb 18 2022

krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

It appears that this is causing an assertion segfault in a rustc test over at our experimental rust + llvm@head bot:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8430#167e6de5-2dd5-41c3-87d7-b6e3f3908371/262-706
The test is https://github.com/rust-lang/rust/blob/master/src/test/assembly/asm/riscv-types.rs. These two lines appear to cause it (code compiles fine when removed):

The assertion:

Impossible reg-to-reg copy
UNREACHABLE executed at [...]/rust/src/llvm-project/llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:350
Feb 18 2022, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2022

krasimir accepted D118448: clang-format: [JS] fix uninitialized memory..
Jan 28 2022, 3:21 AM · Restricted Project

Jan 5 2022

krasimir added a reviewer for D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0: mprobst.
Jan 5 2022, 2:15 AM · Restricted Project, Restricted Project

Dec 24 2021

krasimir added a reverting change for rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library.: rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library.".
Dec 24 2021, 3:05 AM
krasimir committed rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library." (authored by krasimir).
Revert "[ASan] Moved optimized callbacks into a separate library."
Dec 24 2021, 3:05 AM
krasimir added a reverting change for D116182: [ASan] Moved optimized callbacks into a separate library.: rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library.".
Dec 24 2021, 3:05 AM · Restricted Project, Restricted Project

Dec 22 2021

krasimir added a comment to D116031: [ArgPromotion][TTI] Pass types to ABI compatibility hook.

Added a dependent quick fix https://github.com/llvm/llvm-project/commit/37c8d5915f37432f49fd4b0e6ec318ae68750af1.

Dec 22 2021, 1:08 AM · Restricted Project
krasimir committed rG37c8d5915f37: fix build bots after f5ac23b5ae090d64d31f0b6624470af97dc20bf6 (authored by krasimir).
fix build bots after f5ac23b5ae090d64d31f0b6624470af97dc20bf6
Dec 22 2021, 1:05 AM

Dec 19 2021

krasimir committed rG3a3fcd6a23ad: [clang-format] add regression tests for braced lists (authored by krasimir).
[clang-format] add regression tests for braced lists
Dec 19 2021, 7:10 AM
krasimir closed D116001: [clang-format] add regression tests for braced lists.
Dec 19 2021, 7:09 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rGc41b3b0fa0f4: [clang-format] Adjust braced list detection: rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:06 AM
krasimir committed rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection" (authored by krasimir).
Revert "[clang-format] Adjust braced list detection"
Dec 19 2021, 7:06 AM
krasimir added a reverting change for D114583: [clang-format] Adjust braced list detection: rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:05 AM · Restricted Project, Restricted Project
krasimir closed D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:05 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D116001: [clang-format] add regression tests for braced lists: MyDeveloperDay.
Dec 19 2021, 6:12 AM · Restricted Project, Restricted Project
krasimir requested review of D116001: [clang-format] add regression tests for braced lists.
Dec 19 2021, 6:11 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D116000: Revert "[clang-format] Adjust braced list detection": MyDeveloperDay.
Dec 19 2021, 5:50 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rGc41b3b0fa0f4: [clang-format] Adjust braced list detection: D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM
krasimir requested review of D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D114583: [clang-format] Adjust braced list detection: D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM · Restricted Project, Restricted Project
krasimir committed rGeeed24e766a1: [Bazel] update build files for (authored by krasimir).
[Bazel] update build files for
Dec 19 2021, 5:39 AM

Dec 13 2021

krasimir added a comment to D114583: [clang-format] Adjust braced list detection.

It appears that this regressed the formatting of initializer lists in some cases:

# Before
% cat ~/test.cc
class A {
  A() : a{} {}
Dec 13 2021, 2:54 AM · Restricted Project, Restricted Project

Nov 16 2021

krasimir added a comment to D113957: DebugInfo: Stop modifying Operation::Error inside of verify().

Thank you! This and the follow-up https://reviews.llvm.org/D113958 look reasonable to me.
Letting the people more familiar with the DebugInfo parts of the codebase have a chance to review.

Nov 16 2021, 2:47 AM · Restricted Project
krasimir added a comment to D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.

I pushed fa39ec5786c08e78cc247a48c17aef66ca5985fb, a35226b9b606f4ea32e7db9e2f4de0d99ab6bef0, and 7a1b670f0f2f0a38a673b5554bb2c4d9d50447bf to fix most of the blockers. Then https://reviews.llvm.org/D113957 fixes Operation::verify() and https://reviews.llvm.org/D113958 makes it iterate over const Operation and removes the mutable.

Thank you! These look good!

Nov 16 2021, 2:41 AM · Restricted Project

Nov 15 2021

krasimir added a reviewer for D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c: dexonsmith.
Nov 15 2021, 2:12 PM · Restricted Project
krasimir added a comment to D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.

Sorry for submitting quickly, I just wanted to unblock build bots. I still think that this patch is OK considering the weirdness of this Operation class.

Nov 15 2021, 2:10 PM · Restricted Project
krasimir committed rG3d1d8c767be5: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c (authored by krasimir).
[llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c
Nov 15 2021, 1:09 PM
krasimir closed D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 1:09 PM · Restricted Project
krasimir updated subscribers of D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 12:44 PM · Restricted Project
krasimir added a reviewer for D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c: bkramer.
Nov 15 2021, 12:43 PM · Restricted Project
krasimir requested review of D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 12:42 PM · Restricted Project

Oct 1 2021

krasimir added a reverting change for rG1fb37334bdb3: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction…: rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)….
Oct 1 2021, 2:40 AM
krasimir committed rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)… (authored by krasimir).
Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)…
Oct 1 2021, 2:40 AM
krasimir added a reverting change for D108136: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction patterns: rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)….
Oct 1 2021, 2:40 AM · Restricted Project

Sep 29 2021

krasimir committed rG6cffc35746b4: [Bazel] fix for aa53785f23b2b89a9a423af131697b1f7c92869f (authored by krasimir).
[Bazel] fix for aa53785f23b2b89a9a423af131697b1f7c92869f
Sep 29 2021, 1:54 AM

Sep 27 2021

krasimir committed rG8cb234e07d46: [Bazel] Fix for 6498b0e991babe71e69ab02e1afa7f5535f2be0f (authored by krasimir).
[Bazel] Fix for 6498b0e991babe71e69ab02e1afa7f5535f2be0f
Sep 27 2021, 1:45 AM
krasimir committed rG92b475f0b079: [lldb] silence -Wsometimes-uninitialized warnings (authored by krasimir).
[lldb] silence -Wsometimes-uninitialized warnings
Sep 27 2021, 12:39 AM

Sep 24 2021

krasimir added a comment to D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA.

I like this. Consider only displaying the major version (e.g., clang-format 14 instead of clang-format 14.0.0).

Sep 24 2021, 11:25 AM · Restricted Project, Restricted Project

Aug 27 2021

krasimir accepted D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change.
Aug 27 2021, 6:06 AM · Restricted Project, Restricted Project
krasimir accepted D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change.
Aug 27 2021, 2:22 AM · Restricted Project, Restricted Project

Aug 25 2021

krasimir committed rGe708808f875f: [clang-format] Support TypeScript override keyword (authored by jankuehle).
[clang-format] Support TypeScript override keyword
Aug 25 2021, 5:13 AM
krasimir closed D108692: [clang-format] Support TypeScript override keyword.
Aug 25 2021, 5:13 AM · Restricted Project, Restricted Project
krasimir accepted D108692: [clang-format] Support TypeScript override keyword.

Thank you!
Let me know if you would like me to commit this for you in case you don't have commit rights for LLVM.

Aug 25 2021, 3:40 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D108692: [clang-format] Support TypeScript override keyword: krasimir.
Aug 25 2021, 3:33 AM · Restricted Project, Restricted Project

Aug 24 2021

krasimir committed rGbefb9dc3694e: [clang-format] keep TypeScript argument decorators in line (authored by krasimir).
[clang-format] keep TypeScript argument decorators in line
Aug 24 2021, 3:38 AM
krasimir closed D108620: [clang-format] keep TypeScript argument decorators in line.
Aug 24 2021, 3:38 AM · Restricted Project, Restricted Project
krasimir added inline comments to D108620: [clang-format] keep TypeScript argument decorators in line.
Aug 24 2021, 3:05 AM · Restricted Project, Restricted Project
krasimir updated the diff for D108620: [clang-format] keep TypeScript argument decorators in line.
  • consider also functions and setters
Aug 24 2021, 3:04 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D108620: [clang-format] keep TypeScript argument decorators in line: MyDeveloperDay.
Aug 24 2021, 2:42 AM · Restricted Project, Restricted Project