krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (79 w, 6 d)

Recent Activity

Today

krasimir committed rC330574: [clang-format] Fix clang-tidy readability problems, NFCI.
[clang-format] Fix clang-tidy readability problems, NFCI
Mon, Apr 23, 3:06 AM
krasimir committed rL330574: [clang-format] Fix clang-tidy readability problems, NFCI.
[clang-format] Fix clang-tidy readability problems, NFCI
Mon, Apr 23, 3:06 AM
krasimir committed rC330569: Revert "[clang-format] Improve Incomplete detection for (text) protos".
Revert "[clang-format] Improve Incomplete detection for (text) protos"
Mon, Apr 23, 1:56 AM
krasimir committed rL330569: Revert "[clang-format] Improve Incomplete detection for (text) protos".
Revert "[clang-format] Improve Incomplete detection for (text) protos"
Mon, Apr 23, 1:55 AM
krasimir accepted D45726: Format closing braces when reformatting the line containing theopening brace..
Mon, Apr 23, 1:49 AM

Thu, Apr 19

krasimir committed rC330324: [clang-format] Don't remove empty lines before namespace endings.
[clang-format] Don't remove empty lines before namespace endings
Thu, Apr 19, 6:05 AM
krasimir committed rL330324: [clang-format] Don't remove empty lines before namespace endings.
[clang-format] Don't remove empty lines before namespace endings
Thu, Apr 19, 6:05 AM
krasimir closed D45373: [clang-format] Don't remove empty lines before namespace endings.
Thu, Apr 19, 6:05 AM
krasimir added inline comments to D45373: [clang-format] Don't remove empty lines before namespace endings.
Thu, Apr 19, 5:18 AM
krasimir added a comment to D45726: Format closing braces when reformatting the line containing theopening brace..

Another point: for the example in the summary about bailing-out early, is there a test for this already? If not, we should add one.

Thu, Apr 19, 3:16 AM
krasimir updated the summary of D45726: Format closing braces when reformatting the line containing theopening brace..
Thu, Apr 19, 3:15 AM
krasimir updated the summary of D45726: Format closing braces when reformatting the line containing theopening brace..
Thu, Apr 19, 3:14 AM
krasimir retitled D45726: Format closing braces when reformatting the line containing theopening brace. from Format closing braces when reformatting the line containing the opening brace. This required a couple of yaks to be shaved: 1. MatchingOpeningBlockLineIndex was misused to also store the closing index; instead, use a second variable, as this... to Format closing braces when reformatting the line containing theopening brace..
Thu, Apr 19, 3:13 AM
krasimir added a comment to D45726: Format closing braces when reformatting the line containing theopening brace..

Great patch!

Thu, Apr 19, 3:13 AM

Fri, Apr 13

krasimir added inline comments to D44203: [clang-format] Improve Incomplete detection for (text) protos.
Fri, Apr 13, 6:41 AM
krasimir committed rL330016: [clang-format] Improve Incomplete detection for (text) protos.
[clang-format] Improve Incomplete detection for (text) protos
Fri, Apr 13, 6:40 AM
krasimir committed rC330016: [clang-format] Improve Incomplete detection for (text) protos.
[clang-format] Improve Incomplete detection for (text) protos
Fri, Apr 13, 6:40 AM
krasimir closed D44203: [clang-format] Improve Incomplete detection for (text) protos.
Fri, Apr 13, 6:40 AM
krasimir updated the diff for D44203: [clang-format] Improve Incomplete detection for (text) protos.
  • Address review comments
Fri, Apr 13, 6:40 AM

Mon, Apr 9

krasimir committed rL329573: [RuntimeDyld][PowerPC] Fix a newly added test in r329355.
[RuntimeDyld][PowerPC] Fix a newly added test in r329355
Mon, Apr 9, 7:32 AM
krasimir closed D45361: [RuntimeDyld][PowerPC] Fix a newly added test in r329355.
Mon, Apr 9, 7:32 AM

Fri, Apr 6

krasimir created D45373: [clang-format] Don't remove empty lines before namespace endings.
Fri, Apr 6, 8:29 AM
krasimir created D45361: [RuntimeDyld][PowerPC] Fix a newly added test in r329355.
Fri, Apr 6, 3:52 AM

Thu, Apr 5

krasimir added inline comments to D44203: [clang-format] Improve Incomplete detection for (text) protos.
Thu, Apr 5, 3:29 AM
krasimir updated the diff for D44203: [clang-format] Improve Incomplete detection for (text) protos.
  • Address review comments
Thu, Apr 5, 3:29 AM
krasimir committed rL329263: [clang-format] Preserve spaces before a percent in (text) protos.
[clang-format] Preserve spaces before a percent in (text) protos
Thu, Apr 5, 2:36 AM
krasimir committed rC329263: [clang-format] Preserve spaces before a percent in (text) protos.
[clang-format] Preserve spaces before a percent in (text) protos
Thu, Apr 5, 2:36 AM
krasimir added a comment to rL329258: [MIR-Canon] Fixing warnings in Non-assert builds..

Why not inline LastRenameReg into the DEBUG macro? Now that call will be made in non-debug builds :(

Thu, Apr 5, 1:38 AM

Wed, Apr 4

krasimir accepted D42034: [clang-format] In tests, expected code should be format-stable.

Thank you!

Wed, Apr 4, 2:09 AM

Thu, Mar 29

krasimir added inline comments to D44765: PR36643 Make clang-format support more generic TMarcos.
Thu, Mar 29, 2:47 AM

Tue, Mar 27

krasimir requested changes to D42034: [clang-format] In tests, expected code should be format-stable.

Thank you!
If this works, we should apply it to all files in unittest/Format.

Tue, Mar 27, 1:38 PM
krasimir added a reviewer for D44765: PR36643 Make clang-format support more generic TMarcos: klimek.
Tue, Mar 27, 1:34 PM
krasimir added a comment to D44765: PR36643 Make clang-format support more generic TMarcos.

I don't have preferences over names, but I agree with Alex that the option should have more detailed description.

Tue, Mar 27, 1:34 PM
krasimir committed rCTE328622: [clang-move] Fix test failing due to clang-format change.
[clang-move] Fix test failing due to clang-format change
Tue, Mar 27, 6:43 AM
krasimir committed rL328622: [clang-move] Fix test failing due to clang-format change.
[clang-move] Fix test failing due to clang-format change
Tue, Mar 27, 6:42 AM
krasimir committed rL328621: Revert "[clang-format] Remove empty lines before }[;] // comment".
Revert "[clang-format] Remove empty lines before }[;] // comment"
Tue, Mar 27, 6:17 AM
krasimir committed rC328621: Revert "[clang-format] Remove empty lines before }[;] // comment".
Revert "[clang-format] Remove empty lines before }[;] // comment"
Tue, Mar 27, 6:17 AM

Mar 20 2018

krasimir added a comment to D44695: [clang-format] Partially revert r322749, replacing array with DenseSet.

One way in which DenseSet is better is that it supports StringRefs - we don't have to define hash. Seems like the lack of this override in core LLVM suggests that unordered_set is not commonly used with StringRefs.

Mar 20 2018, 12:20 PM
krasimir added inline comments to D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic.
Mar 20 2018, 11:34 AM
krasimir added reviewers for D44695: [clang-format] Partially revert r322749, replacing array with DenseSet: benhamilton, bkramer, djasper, jolesiak.
Mar 20 2018, 11:32 AM
krasimir created D44695: [clang-format] Partially revert r322749, replacing array with DenseSet.
Mar 20 2018, 11:31 AM

Mar 19 2018

krasimir committed rL327861: [clang-format] Remove empty lines before }[;] // comment.
[clang-format] Remove empty lines before }[;] // comment
Mar 19 2018, 8:38 AM
krasimir committed rC327861: [clang-format] Remove empty lines before }[;] // comment.
[clang-format] Remove empty lines before }[;] // comment
Mar 19 2018, 8:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 19 2018, 8:38 AM
krasimir created D44631: [clang-format] Remove empty lines before }[;] // comment.
Mar 19 2018, 8:34 AM

Mar 16 2018

krasimir committed rL327716: [clang-format] Disallow breaks before ']' in text proto extensions.
[clang-format] Disallow breaks before ']' in text proto extensions
Mar 16 2018, 8:26 AM
krasimir committed rC327716: [clang-format] Disallow breaks before ']' in text proto extensions.
[clang-format] Disallow breaks before ']' in text proto extensions
Mar 16 2018, 8:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 16 2018, 8:26 AM
krasimir updated the diff for D44569: [clang-format] Disallow breaks before ']' in text proto extensions.
  • Remove newlines
Mar 16 2018, 8:15 AM
krasimir created D44569: [clang-format] Disallow breaks before ']' in text proto extensions.
Mar 16 2018, 8:14 AM
krasimir committed rC327708: [clang-format] Fix raw string prefix penalty.
[clang-format] Fix raw string prefix penalty
Mar 16 2018, 7:04 AM
krasimir committed rL327708: [clang-format] Fix raw string prefix penalty.
[clang-format] Fix raw string prefix penalty
Mar 16 2018, 7:04 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 16 2018, 7:03 AM
krasimir created D44563: [clang-format] Fix raw string prefix penalty.
Mar 16 2018, 7:03 AM

Mar 14 2018

krasimir added inline comments to D33560: [clang-format] Add option to specify explicit config file.
Mar 14 2018, 9:30 AM

Mar 8 2018

krasimir committed rC326996: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
[clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings
Mar 8 2018, 3:33 AM
krasimir committed rL326996: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
[clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings
Mar 8 2018, 3:33 AM
krasimir closed D44141: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
Mar 8 2018, 3:33 AM

Mar 7 2018

krasimir committed rC326945: [clang-format] Break consecutive string literals in text protos.
[clang-format] Break consecutive string literals in text protos
Mar 7 2018, 1:35 PM
krasimir committed rL326945: [clang-format] Break consecutive string literals in text protos.
[clang-format] Break consecutive string literals in text protos
Mar 7 2018, 1:35 PM
krasimir closed D44204: [clang-format] Break consecutive string literals in text protos.
Mar 7 2018, 1:35 PM
krasimir added a reviewer for D44204: [clang-format] Break consecutive string literals in text protos: alexfh.
Mar 7 2018, 5:42 AM
krasimir created D44204: [clang-format] Break consecutive string literals in text protos.
Mar 7 2018, 5:34 AM
krasimir created D44203: [clang-format] Improve Incomplete detection for (text) protos.
Mar 7 2018, 5:16 AM
krasimir added inline comments to D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC.
Mar 7 2018, 2:42 AM

Mar 6 2018

krasimir committed rC326792: [clang-format] fix handling of consecutive unary operators.
[clang-format] fix handling of consecutive unary operators
Mar 6 2018, 5:59 AM
krasimir committed rL326792: [clang-format] fix handling of consecutive unary operators.
[clang-format] fix handling of consecutive unary operators
Mar 6 2018, 5:59 AM
krasimir closed D43312: [clang-format] fix handling of consecutive unary operators.
Mar 6 2018, 5:59 AM
krasimir committed rC326781: [clang-format] Fix documentation for SpaceAfterCStyleCast option.
[clang-format] Fix documentation for SpaceAfterCStyleCast option
Mar 6 2018, 5:26 AM
krasimir committed rL326781: [clang-format] Fix documentation for SpaceAfterCStyleCast option.
[clang-format] Fix documentation for SpaceAfterCStyleCast option
Mar 6 2018, 5:26 AM
krasimir closed D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.
Mar 6 2018, 5:26 AM
krasimir added a comment to D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.

I'll commit this for you.

Mar 6 2018, 5:24 AM
krasimir added inline comments to D43904: [clang-format] Improve detection of ObjC for-in statements.
Mar 6 2018, 5:23 AM
krasimir added inline comments to D43906: [clang-format] Improve detection of Objective-C block types.
Mar 6 2018, 5:14 AM
krasimir created D44141: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings.
Mar 6 2018, 3:35 AM

Mar 5 2018

krasimir accepted D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.

Thank you!

Mar 5 2018, 1:28 PM
krasimir added inline comments to D43906: [clang-format] Improve detection of Objective-C block types.
Mar 5 2018, 10:54 AM
krasimir added inline comments to D43904: [clang-format] Improve detection of ObjC for-in statements.
Mar 5 2018, 10:50 AM
krasimir added inline comments to D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC.
Mar 5 2018, 10:43 AM

Mar 1 2018

krasimir added a reviewer for D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC: djasper.
Mar 1 2018, 1:27 AM
krasimir requested changes to D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option.

This rst file is generated from include/clang/Format/Format.h using docs/tools/dump_format_style.py. Update it there and run the tool to regenerate the .rst file.

Mar 1 2018, 1:22 AM

Feb 27 2018

krasimir committed rL326227: [clang-format] Format operator key in protos.
[clang-format] Format operator key in protos
Feb 27 2018, 11:10 AM
krasimir committed rC326227: [clang-format] Format operator key in protos.
[clang-format] Format operator key in protos
Feb 27 2018, 11:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 27 2018, 11:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 27 2018, 11:10 AM
krasimir created D43830: [clang-format] Format operator key in protos.
Feb 27 2018, 11:10 AM

Feb 26 2018

krasimir accepted D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp.
Feb 26 2018, 4:49 AM

Feb 21 2018

krasimir accepted D43522: [clang-format] New API guessLanguage().
Feb 21 2018, 1:18 AM

Feb 19 2018

krasimir committed rC325513: [clang-format] Fix text proto extension scope opening detection.
[clang-format] Fix text proto extension scope opening detection
Feb 19 2018, 8:02 AM
krasimir committed rL325513: [clang-format] Fix text proto extension scope opening detection.
[clang-format] Fix text proto extension scope opening detection
Feb 19 2018, 8:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 19 2018, 8:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 19 2018, 8:02 AM
krasimir created D43469: [clang-format] Fix text proto extension scope opening detection.
Feb 19 2018, 8:02 AM
krasimir committed rC325509: [clang-format] Fixup a case of text proto message attributes.
[clang-format] Fixup a case of text proto message attributes
Feb 19 2018, 7:33 AM
krasimir committed rL325509: [clang-format] Fixup a case of text proto message attributes.
[clang-format] Fixup a case of text proto message attributes
Feb 19 2018, 7:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 19 2018, 7:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Feb 19 2018, 7:33 AM
krasimir created D43465: [clang-format] Fixup a case of text proto message attributes.
Feb 19 2018, 7:33 AM

Feb 16 2018

krasimir accepted D43312: [clang-format] fix handling of consecutive unary operators.

Thank you! Do you have commit access or should I commit this for you?

Feb 16 2018, 6:25 AM
krasimir committed rL325336: [clang-format] Enable google text proto formatting in R"proto('s.
[clang-format] Enable google text proto formatting in R"proto('s
Feb 16 2018, 4:12 AM