krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (28 w, 1 h)

Recent Activity

Fri, Apr 21

krasimir added a reviewer for D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources: klimek.
Fri, Apr 21, 8:54 AM
krasimir committed rL300985: [clang-format] Replace IncompleteFormat by a struct with Line.
[clang-format] Replace IncompleteFormat by a struct with Line
Fri, Apr 21, 7:48 AM
krasimir closed D32298: [clang-format] Replace IncompleteFormat by a struct with Line by committing rL300985: [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 7:48 AM
krasimir committed rL300983: [clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC.
[clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC
Fri, Apr 21, 7:42 AM
krasimir committed rL300982: [clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC.
[clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC
Fri, Apr 21, 7:34 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 7:30 AM
krasimir retitled D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources from [Tooling, libclang] Remove unused CompilationDatabase::MappedSources to [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
Fri, Apr 21, 7:20 AM
krasimir created D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
Fri, Apr 21, 7:19 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 6:38 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Refactor tests
Fri, Apr 21, 6:37 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Changed IncompleteFormat to FormatComplete
Fri, Apr 21, 6:27 AM
krasimir retitled D32298: [clang-format] Replace IncompleteFormat by a struct with Line from [clang-format] Turn IncompleteFormat into a string to [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 4:01 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Introduce a proper abstraction
Fri, Apr 21, 3:58 AM
krasimir added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 2:47 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Removed double declaration
Fri, Apr 21, 2:47 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Address review comments
Fri, Apr 21, 2:43 AM

Thu, Apr 20

krasimir added a reviewer for D32298: [clang-format] Replace IncompleteFormat by a struct with Line: djasper.
Thu, Apr 20, 9:44 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Removed comments
Thu, Apr 20, 9:43 AM
krasimir updated the diff for D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
  • Updated string escaping
Thu, Apr 20, 9:39 AM
krasimir created D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Thu, Apr 20, 9:35 AM
krasimir committed rL300841: Delete unused IncompleteFormat variable, NFCi..
Delete unused IncompleteFormat variable, NFCi.
Thu, Apr 20, 6:58 AM

Thu, Apr 13

krasimir added a comment to D31992: [clangd] Escape only necessary characters in JSON output.

Seems that we're starting to hit some YAML/JSON mismatches, or is it that your YAML string support is lacking?

Thu, Apr 13, 5:38 AM · Restricted Project
krasimir added a reviewer for D31992: [clangd] Escape only necessary characters in JSON output: klimek.
Thu, Apr 13, 5:37 AM · Restricted Project

Wed, Apr 12

krasimir committed rL300077: [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC.
[clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC
Wed, Apr 12, 10:25 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

By the way, you may want to look at this build bot stage 2 failure (not sure if that's just stale data or a genuine new failure).
http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto_check/14795/consoleFull#74713522449ba4694-19c4-4d7e-bec5-911270d8a58c
Specifically, look for the line:

TEST 'LLVM :: Analysis/CostModel/SystemZ/ext-load.ll' FAILED
Wed, Apr 12, 8:39 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

Thanks!

Wed, Apr 12, 5:28 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

I'll revert this in 10 minutes to keep the build going.

Wed, Apr 12, 5:20 AM
krasimir added a comment to rL300052: [SystemZ] TargetTransformInfo cost functions implemented..

Seems that this breaks CostModel/SystemZ/fp-cast.ll:

Command Output (stderr):
--
/usr/local/google/home/krasimir/work3/llvm/test/Analysis/CostModel/SystemZ/fp-cast.ll:113:10: error: expected string not found in input
; CHECK: Cost Model: Found an estimated cost of 6 for instruction: %v17 = fptosi <2 x double> undef to <2 x i32>
^
<stdin>:34:1: note: scanning from here
Cost Model: Found an estimated cost of 7 for instruction: %v17 = fptosi <2 x double> undef to <2 x i32>
^
Wed, Apr 12, 5:06 AM
krasimir committed rL300051: [DWARF] Fix compiler warnings in DWARFContext.cpp, NFCi.
[DWARF] Fix compiler warnings in DWARFContext.cpp, NFCi
Wed, Apr 12, 4:46 AM

Tue, Apr 11

krasimir committed rL299935: [clangd] Implement item kind for completion results.
[clangd] Implement item kind for completion results
Tue, Apr 11, 6:40 AM
krasimir closed D31853: [clangd] Implement item kind for completion results by committing rL299935: [clangd] Implement item kind for completion results.
Tue, Apr 11, 6:39 AM · Restricted Project
krasimir added a comment to D31853: [clangd] Implement item kind for completion results.

Do you still need someone to commit this?

Tue, Apr 11, 6:21 AM · Restricted Project
krasimir accepted D31853: [clangd] Implement item kind for completion results.

Looks good! Thank you!

Tue, Apr 11, 1:56 AM · Restricted Project

Mon, Apr 10

krasimir committed rL299844: [clangd] Fix nondeterminism in clangd test.
[clangd] Fix nondeterminism in clangd test
Mon, Apr 10, 7:19 AM
krasimir committed rL299843: [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per….
[clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per…
Mon, Apr 10, 6:44 AM
krasimir closed D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd. by committing rL299843: [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per….
Mon, Apr 10, 6:44 AM · Restricted Project
krasimir accepted D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd..

Looks good!

Mon, Apr 10, 6:42 AM · Restricted Project
krasimir added a reviewer for D31881: DRAFT [clang-format] Format raw string proto text literals: djasper.
Mon, Apr 10, 5:47 AM
krasimir updated the diff for D31881: DRAFT [clang-format] Format raw string proto text literals.
  • Remove debugging macro
Mon, Apr 10, 5:46 AM
krasimir created D31881: DRAFT [clang-format] Format raw string proto text literals.
Mon, Apr 10, 5:45 AM
krasimir requested changes to D31853: [clangd] Implement item kind for completion results.

Looks good! However it would be easier for reviewers if you could please use arc: http://llvm.org/docs/Phabricator.html#id2
This makes it easy since I only have to do arc patch D31853 in order to update my client source tree with your changes.
Could you please create a review like that?

Mon, Apr 10, 2:56 AM · Restricted Project

Fri, Apr 7

krasimir committed rL299758: [clangd] Extract FsPath from file:// uri.
[clangd] Extract FsPath from file:// uri
Fri, Apr 7, 4:16 AM
krasimir closed D31401: [clangd] Extract FsPath from file:// uri by committing rL299758: [clangd] Extract FsPath from file:// uri.
Fri, Apr 7, 4:16 AM

Thu, Apr 6

krasimir accepted D31401: [clangd] Extract FsPath from file:// uri.

Looks good!

Thu, Apr 6, 5:27 AM
krasimir added a comment to D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd..

Looks great! I'm wondering, can you think of ways to test the didClose method similarly to how it's done for other handlers?

Thu, Apr 6, 5:07 AM · Restricted Project

Tue, Apr 4

krasimir committed rL299440: [clangd] Fix completion test to not depend on the standard library.
[clangd] Fix completion test to not depend on the standard library
Tue, Apr 4, 8:21 AM
krasimir committed rL299426: [clangd] Remove private vector fields from completion test..
[clangd] Remove private vector fields from completion test.
Tue, Apr 4, 3:54 AM
krasimir added inline comments to D31401: [clangd] Extract FsPath from file:// uri.
Tue, Apr 4, 3:12 AM
krasimir accepted D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).

Great!

Tue, Apr 4, 3:01 AM
krasimir committed rL299421: [clangd] Add code completion support.
[clangd] Add code completion support
Tue, Apr 4, 2:59 AM
krasimir closed D31328: [clangd] Add code completion support by committing rL299421: [clangd] Add code completion support.
Tue, Apr 4, 2:59 AM

Tue, Mar 28

krasimir added a comment to D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).

Looks good! I just have two nits.

Tue, Mar 28, 3:06 PM

Mar 25 2017

krasimir added a reviewer for D31328: [clangd] Add code completion support: malaperle-ericsson.
Mar 25 2017, 5:50 AM

Mar 24 2017

krasimir updated the diff for D31328: [clangd] Add code completion support.
  • Make Items ownership more explicit
Mar 24 2017, 7:59 AM
krasimir updated the diff for D31328: [clangd] Add code completion support.
  • Address review comments
Mar 24 2017, 7:26 AM
krasimir updated the diff for D31328: [clangd] Add code completion support.
  • Add '.' and '>' as completion trigger characters
Mar 24 2017, 7:06 AM
krasimir updated the diff for D31328: [clangd] Add code completion support.
  • Clean-up leftovers
Mar 24 2017, 6:30 AM
krasimir created D31328: [clangd] Add code completion support.
Mar 24 2017, 6:18 AM
krasimir committed rL298697: [libclang] Bury dead TemporaryFiles.
[libclang] Bury dead TemporaryFiles
Mar 24 2017, 3:02 AM
krasimir closed D31288: [libclang] Bury dead TemporaryFiles by committing rL298697: [libclang] Bury dead TemporaryFiles.
Mar 24 2017, 3:02 AM
krasimir committed rL298696: [clangd] Add support for vscode extension configuration.
[clangd] Add support for vscode extension configuration
Mar 24 2017, 2:41 AM
krasimir closed D31121: [clangd] Add support for vscode extension configuration by committing rL298696: [clangd] Add support for vscode extension configuration.
Mar 24 2017, 2:41 AM

Mar 23 2017

krasimir updated the summary of D31288: [libclang] Bury dead TemporaryFiles.
Mar 23 2017, 8:30 AM
krasimir created D31288: [libclang] Bury dead TemporaryFiles.
Mar 23 2017, 8:27 AM
krasimir accepted D31121: [clangd] Add support for vscode extension configuration.

Looks good! Sorry for the delay.

Mar 23 2017, 8:21 AM

Mar 20 2017

krasimir added a comment to D31121: [clangd] Add support for vscode extension configuration.

It looks pretty good! I just have a minor suggestion.

Mar 20 2017, 5:29 AM
krasimir added inline comments to D31121: [clangd] Add support for vscode extension configuration.
Mar 20 2017, 3:46 AM

Mar 14 2017

krasimir committed rL297730: Add more clang-format changes to the 5.0 release notes.
Add more clang-format changes to the 5.0 release notes
Mar 14 2017, 3:46 AM

Mar 10 2017

krasimir abandoned D30822: [clang-format] Indent the same amount a sequence of string literals.

this is nonsense

Mar 10 2017, 6:51 AM
krasimir updated the summary of D30822: [clang-format] Indent the same amount a sequence of string literals.
Mar 10 2017, 6:18 AM
krasimir created D30822: [clang-format] Indent the same amount a sequence of string literals.
Mar 10 2017, 6:16 AM
krasimir committed rL297455: [clang-format] Use a reference in loop variable; NFC.
[clang-format] Use a reference in loop variable; NFC
Mar 10 2017, 5:21 AM

Mar 8 2017

krasimir committed rL297274: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before….
[clang-format] Look at NoLineBreak and NoLineBreakInOperand before…
Mar 8 2017, 5:07 AM
krasimir closed D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken by committing rL297274: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before….
Mar 8 2017, 5:06 AM
krasimir updated the diff for D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.
  • Remove empty stack check
Mar 8 2017, 5:03 AM
krasimir removed a reviewer for D30675: [clangd] Fix not being able to attach a debugger on macOS: krasimir.
Mar 8 2017, 3:12 AM
krasimir committed rL297265: [clang-format] Fixed a typo in Format.cpp and a clang-tidy nit about std….
[clang-format] Fixed a typo in Format.cpp and a clang-tidy nit about std…
Mar 8 2017, 1:25 AM
krasimir committed rL297263: [clang-format] Fix parameter name comment; NFC.
[clang-format] Fix parameter name comment; NFC
Mar 8 2017, 1:14 AM
krasimir committed rL297262: [clang-format] Reformat BreakableToken.h; NFC.
[clang-format] Reformat BreakableToken.h; NFC
Mar 8 2017, 1:10 AM
krasimir committed rL297261: [clang-format] Enable comment reflowing in multiline comments containing pragmas.
[clang-format] Enable comment reflowing in multiline comments containing pragmas
Mar 8 2017, 1:07 AM
krasimir closed D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas by committing rL297261: [clang-format] Enable comment reflowing in multiline comments containing pragmas.
Mar 8 2017, 1:07 AM

Mar 7 2017

krasimir updated the diff for D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas.
  • Make the test example idiomatic
Mar 7 2017, 8:47 AM
krasimir updated the diff for D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas.
  • Fix test comment
Mar 7 2017, 8:24 AM
krasimir created D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas.
Mar 7 2017, 8:22 AM
krasimir added a comment to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

Thank you for the fix!

Mar 7 2017, 7:36 AM · Restricted Project
krasimir committed rL297140: [clang-format] Support namespaces ending in semicolon.
[clang-format] Support namespaces ending in semicolon
Mar 7 2017, 6:19 AM
krasimir closed D30688: [clang-format] Support namespaces ending in semicolon by committing rL297140: [clang-format] Support namespaces ending in semicolon.
Mar 7 2017, 6:19 AM
krasimir updated the diff for D30688: [clang-format] Support namespaces ending in semicolon.
  • Remove braces
Mar 7 2017, 6:18 AM
krasimir updated the summary of D30688: [clang-format] Support namespaces ending in semicolon.
Mar 7 2017, 2:29 AM
krasimir created D30688: [clang-format] Support namespaces ending in semicolon.
Mar 7 2017, 2:26 AM

Mar 6 2017

krasimir committed rL297034: [clang-format] Add tests for ambiguous namespaces to the comment fixer.
[clang-format] Add tests for ambiguous namespaces to the comment fixer
Mar 6 2017, 9:41 AM
krasimir committed rL297028: [clang-format] Make NamespaceEndCommentFixer add at most one comment.
[clang-format] Make NamespaceEndCommentFixer add at most one comment
Mar 6 2017, 8:56 AM
krasimir closed D30659: [clang-format] Make NamespaceEndCommentFixer add at most one comment by committing rL297028: [clang-format] Make NamespaceEndCommentFixer add at most one comment.
Mar 6 2017, 8:56 AM
krasimir updated the diff for D30659: [clang-format] Make NamespaceEndCommentFixer add at most one comment.
  • Added missing newline
Mar 6 2017, 8:54 AM
krasimir created D30659: [clang-format] Make NamespaceEndCommentFixer add at most one comment.
Mar 6 2017, 8:39 AM

Mar 3 2017

krasimir abandoned D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline.

This patch is superseded by D30575.

Mar 3 2017, 7:32 AM
krasimir updated the summary of D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.
Mar 3 2017, 7:28 AM
krasimir updated the diff for D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.
  • Remove file
Mar 3 2017, 7:21 AM
krasimir created D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.
Mar 3 2017, 7:19 AM
krasimir added a comment to D30532: Add examples to clang-format configuration.

I also think that examples for the flags are good. My use case is that while developing/debugging its nice to see a short example for a random flag in the documentation pop-up.

Mar 3 2017, 3:30 AM