People krasimir

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (44 w, 3 d)

Recent Activity

Mon, Aug 14

krasimir abandoned D36668: Rebase with master.
Mon, Aug 14, 4:09 AM
krasimir committed rL310831: clang-format: Fix left pointer alignment after delctype/typeof.
clang-format: Fix left pointer alignment after delctype/typeof
Mon, Aug 14, 4:07 AM
krasimir closed D35847: clang-format: Fix left pointer alignment after delctype/typeof by committing rL310831: clang-format: Fix left pointer alignment after delctype/typeof.
Mon, Aug 14, 4:07 AM · Restricted Project
krasimir created D36668: Rebase with master.
Mon, Aug 14, 3:58 AM

Fri, Aug 11

krasimir created D36614: [clang-format] Refine trailing comment detection.
Fri, Aug 11, 7:09 AM

Wed, Aug 9

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Update the section in moveStateToNextToken to match the original
Wed, Aug 9, 3:42 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Get the penalty from the recursive invocation
Wed, Aug 9, 3:25 AM
krasimir committed rL310458: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment….
[clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment…
Wed, Aug 9, 2:43 AM
krasimir closed D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas by committing rL310458: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment….
Wed, Aug 9, 2:43 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Wed, Aug 9, 2:30 AM

Tue, Aug 8

krasimir updated the diff for D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas.
  • Remove debugging
Tue, Aug 8, 2:42 AM
krasimir updated the diff for D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas.
  • Simplify getSplitAfterLastLine
Tue, Aug 8, 2:41 AM

Mon, Aug 7

krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Mon, Aug 7, 6:29 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Mon, Aug 7, 3:47 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Mon, Aug 7, 2:53 AM

Sat, Aug 5

krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Sat, Aug 5, 11:30 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Fix formatting around a newly added block
Sat, Aug 5, 11:24 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Document estimatedPenalty
Sat, Aug 5, 11:17 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Sat, Aug 5, 9:15 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Move reformatRawStringLiteral to breakProtrudingToken
Sat, Aug 5, 9:14 AM
krasimir created D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas.
Sat, Aug 5, 8:36 AM
krasimir accepted D35847: clang-format: Fix left pointer alignment after delctype/typeof.

Looks good! Please reformat the newly added code blocks with clang-format before submitting.

Sat, Aug 5, 8:14 AM · Restricted Project

Fri, Aug 4

krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Fri, Aug 4, 8:57 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Update comments
Fri, Aug 4, 5:07 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Address review comments
Fri, Aug 4, 5:05 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Fri, Aug 4, 5:05 AM
krasimir added a comment to D35943: [clang-format] Format raw string literals.

I think this is ready for a round of reviews.

Fri, Aug 4, 1:56 AM
krasimir abandoned D31881: DRAFT [clang-format] Format raw string proto text literals.

Superseded by D35943.

Fri, Aug 4, 1:47 AM
krasimir added inline comments to D35847: clang-format: Fix left pointer alignment after delctype/typeof.
Fri, Aug 4, 1:37 AM · Restricted Project

Thu, Aug 3

krasimir added inline comments to D34512: Add preliminary Cross Translation Unit support library.
Thu, Aug 3, 7:27 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Rebase with master
Thu, Aug 3, 7:21 AM
krasimir committed rL309941: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
[clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos
Thu, Aug 3, 7:18 AM
krasimir closed D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos by committing rL309941: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
Thu, Aug 3, 7:18 AM
krasimir updated the diff for D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
  • Rebase with master
Thu, Aug 3, 7:14 AM
krasimir added inline comments to D35847: clang-format: Fix left pointer alignment after delctype/typeof.
Thu, Aug 3, 7:02 AM · Restricted Project
krasimir committed rL309937: [clang-format] Fix parsing of <>-style proto options.
[clang-format] Fix parsing of <>-style proto options
Thu, Aug 3, 6:44 AM
krasimir closed D36217: [clang-format] Fix parsing of <>-style proto options by committing rL309937: [clang-format] Fix parsing of <>-style proto options.
Thu, Aug 3, 6:44 AM
krasimir added a comment to D36261: [clangd] Use multiple working threads in clangd..

Great!

Thu, Aug 3, 6:09 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Propagate estimated raw string penalty to the reflow optimization
Thu, Aug 3, 5:56 AM

Wed, Aug 2

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add a test demonstrating exceeding the column limit
Wed, Aug 2, 8:21 AM
krasimir retitled D36217: [clang-format] Fix parsing of <>-style proto options from Fix parsing of <>-style proto options to [clang-format] Fix parsing of <>-style proto options.
Wed, Aug 2, 6:34 AM
krasimir created D36217: [clang-format] Fix parsing of <>-style proto options.
Wed, Aug 2, 6:34 AM
krasimir retitled D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos from [clang-format] Fix indent of 'key <...>' in text protos to [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
Wed, Aug 2, 4:38 AM
krasimir updated the diff for D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
  • Fix similar issue for 'key {...}'
Wed, Aug 2, 4:37 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Adjust the indent of raw string suffixes
Wed, Aug 2, 3:52 AM
krasimir added a reviewer for D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos: klimek.
Wed, Aug 2, 2:43 AM

Tue, Aug 1

krasimir committed rL309689: [Tooling] Add LLVM_NODISCARD to Replacements::merge.
[Tooling] Add LLVM_NODISCARD to Replacements::merge
Tue, Aug 1, 7:59 AM
krasimir closed D36149: [Tooling] Add LLVM_NODISCARD to Replacements::merge by committing rL309689: [Tooling] Add LLVM_NODISCARD to Replacements::merge.
Tue, Aug 1, 7:59 AM
krasimir created D36149: [Tooling] Add LLVM_NODISCARD to Replacements::merge.
Tue, Aug 1, 7:16 AM
krasimir created D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos.
Tue, Aug 1, 5:36 AM

Mon, Jul 31

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add LastStartColumn and prefix and postfix raw string alignment
Mon, Jul 31, 9:03 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add more tests for raw string operands
Mon, Jul 31, 5:22 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for raw string operands
Mon, Jul 31, 5:17 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for breaks before raw strings
Mon, Jul 31, 3:24 AM

Sun, Jul 30

krasimir accepted D35986: [clangd] Add ':' to completion trigger characters..

Looks good!

Sun, Jul 30, 2:16 PM

Fri, Jul 28

krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for raw strings starting on own line
Fri, Jul 28, 7:41 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for case-sensitive delimiter matching
Fri, Jul 28, 6:42 AM
krasimir added inline comments to D35943: [clang-format] Format raw string literals.
Fri, Jul 28, 6:30 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add BasedOnStyle to RawStringFormat
Fri, Jul 28, 6:29 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Make reformatRawStringLiteral return the new state column
  • Add FormattedRawString cache
Fri, Jul 28, 5:52 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for raw strings in arguments
Fri, Jul 28, 5:16 AM

Thu, Jul 27

krasimir accepted D35950: [clangd] Don't reverse priorities of completion items..

Looks good!

Thu, Jul 27, 10:34 AM
krasimir added inline comments to D35950: [clangd] Don't reverse priorities of completion items..
Thu, Jul 27, 10:32 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add tests for delimiters and make delimiter search case-insensitive
Thu, Jul 27, 9:45 AM
krasimir retitled D35943: [clang-format] Format raw string literals from Add string delimiters and compute raw string styles to [clang-format] Format raw string literals.
Thu, Jul 27, 9:23 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Add comments on magic
Thu, Jul 27, 9:21 AM
krasimir updated the diff for D35943: [clang-format] Format raw string literals.
  • Fixed formatting
Thu, Jul 27, 9:11 AM
krasimir created D35943: [clang-format] Format raw string literals.
Thu, Jul 27, 7:37 AM

Tue, Jul 25

krasimir accepted D35557: clang-format: merge short case labels with trailing comments.

Looks good! Thanks!

Tue, Jul 25, 4:52 AM
krasimir committed rL308970: [clangd] Reuse compile commands during reparse.
[clangd] Reuse compile commands during reparse
Tue, Jul 25, 4:40 AM
krasimir closed D35825: [clangd] Reuse compile commands during reparse by committing rL308970: [clangd] Reuse compile commands during reparse.
Tue, Jul 25, 4:40 AM
krasimir updated the diff for D35825: [clangd] Reuse compile commands during reparse.
  • Address review comment
Tue, Jul 25, 2:54 AM
krasimir created D35825: [clangd] Reuse compile commands during reparse.
Tue, Jul 25, 2:25 AM

Mon, Jul 24

krasimir accepted D35483: clang-format: fix block OpeningLineIndex around preprocessor.

Looks good! Thanks!
Please rebase with master before committing since we've been touching the same lines in UnwrappedLineParser.cpp.

Mon, Jul 24, 1:06 PM
krasimir committed rL308918: [clang-format] Reorder assignments, NFC.
[clang-format] Reorder assignments, NFC
Mon, Jul 24, 12:53 PM
krasimir committed rL308882: [clang-format] Fix comment levels between '} else {' and PPDirective..
[clang-format] Fix comment levels between '} else {' and PPDirective.
Mon, Jul 24, 7:54 AM
krasimir closed D35794: [clang-format] Fix comment levels between '} else {' and PPDirective. by committing rL308882: [clang-format] Fix comment levels between '} else {' and PPDirective..
Mon, Jul 24, 7:54 AM
krasimir updated the diff for D35794: [clang-format] Fix comment levels between '} else {' and PPDirective..
  • Address review comments
Mon, Jul 24, 7:49 AM
krasimir updated the diff for D35794: [clang-format] Fix comment levels between '} else {' and PPDirective..
  • Remove unused import
Mon, Jul 24, 7:31 AM
krasimir added a reviewer for D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.: klimek.
Mon, Jul 24, 7:30 AM
krasimir updated the diff for D35794: [clang-format] Fix comment levels between '} else {' and PPDirective..
  • Switch to relative levels
Mon, Jul 24, 7:30 AM
krasimir updated the diff for D35794: [clang-format] Fix comment levels between '} else {' and PPDirective..
  • Make the closing brace use the same thing
Mon, Jul 24, 6:51 AM
krasimir created D35794: [clang-format] Fix comment levels between '} else {' and PPDirective..
Mon, Jul 24, 4:34 AM

Fri, Jul 21

krasimir accepted D35406: [clangd] Replace ASTUnit with manual AST management..

Looks good!

Fri, Jul 21, 5:12 AM · Restricted Project
krasimir committed rL308725: [clang-format] Fix comment levels between '}' and PPDirective.
[clang-format] Fix comment levels between '}' and PPDirective
Fri, Jul 21, 3:27 AM
krasimir closed D35485: [clang-format] Fix comment levels between '}' and PPDirective by committing rL308725: [clang-format] Fix comment levels between '}' and PPDirective.
Fri, Jul 21, 3:26 AM
krasimir added inline comments to D35557: clang-format: merge short case labels with trailing comments.
Fri, Jul 21, 2:38 AM
krasimir accepted D35682: Fixed failing assert in code completion..

Looks good!

Fri, Jul 21, 1:49 AM
krasimir added a comment to D35485: [clang-format] Fix comment levels between '}' and PPDirective.

@djasper: ping

Fri, Jul 21, 1:12 AM

Thu, Jul 20

krasimir committed rL308684: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
[clang-format] Put '/**' and '*/' on own lines in multiline jsdocs
Thu, Jul 20, 3:30 PM
krasimir closed D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs by committing rL308684: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
Thu, Jul 20, 3:30 PM
krasimir updated the diff for D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
  • Add negative tests
Thu, Jul 20, 3:25 PM
krasimir added inline comments to D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
Thu, Jul 20, 9:44 AM
krasimir updated the diff for D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
  • Address review comments
Thu, Jul 20, 9:43 AM
krasimir added a reviewer for D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs: mprobst.
Thu, Jul 20, 7:51 AM
krasimir updated the diff for D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
  • Remove empty test block
Thu, Jul 20, 7:51 AM
krasimir created D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs.
Thu, Jul 20, 7:50 AM
krasimir added inline comments to D35483: clang-format: fix block OpeningLineIndex around preprocessor.
Thu, Jul 20, 2:47 AM

Jul 19 2017

krasimir updated the diff for D35485: [clang-format] Fix comment levels between '}' and PPDirective.
  • Adapt the fix from comment suggestion
Jul 19 2017, 8:53 AM
krasimir added inline comments to D35485: [clang-format] Fix comment levels between '}' and PPDirective.
Jul 19 2017, 8:53 AM