Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (144 w, 6 d)

Recent Activity

May 10 2019

krasimir committed rG4dea1378eac0: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"" (authored by krasimir).
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir committed rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir added a reverting change for rL356912: Revert "[clang-format] Keep protobuf "package" statement on one line": rL360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM
krasimir committed rC360411: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""
May 10 2019, 2:15 AM
krasimir closed D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 10 2019, 2:15 AM · Restricted Project
krasimir accepted D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

Sorry for the delay. I'll submit this for you.

May 10 2019, 1:56 AM · Restricted Project

May 7 2019

krasimir committed rLLDB360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rG435e76a558b3: [lldb] Add MacroQualified switch cases for r360109 (authored by krasimir).
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:58 AM
krasimir committed rL360146: [lldb] Add MacroQualified switch cases for r360109.
[lldb] Add MacroQualified switch cases for r360109
May 7 2019, 6:57 AM
krasimir closed D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 6:57 AM · Restricted Project
krasimir added a reviewer for D61640: [lldb] Add MacroQualified switch cases for r360109: gribozavr.
May 7 2019, 5:46 AM · Restricted Project
krasimir updated the summary of D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:45 AM · Restricted Project
krasimir created D61640: [lldb] Add MacroQualified switch cases for r360109.
May 7 2019, 5:41 AM · Restricted Project
krasimir committed rG866e05f02346: Revert "[TableGen] Fix a typo" (authored by krasimir).
Revert "[TableGen] Fix a typo"
May 7 2019, 4:39 AM
krasimir committed rL360136: Revert "[TableGen] Fix a typo".
Revert "[TableGen] Fix a typo"
May 7 2019, 4:37 AM
krasimir closed D61632: Revert "[TableGen] Fix a typo".
May 7 2019, 4:37 AM · Restricted Project
krasimir added reviewers for D61632: Revert "[TableGen] Fix a typo": yan_luo, craig.topper.
May 7 2019, 2:15 AM · Restricted Project
krasimir added a reviewer for D61632: Revert "[TableGen] Fix a typo": sammccall.
May 7 2019, 2:03 AM · Restricted Project
krasimir created D61632: Revert "[TableGen] Fix a typo".
May 7 2019, 1:57 AM · Restricted Project

Apr 18 2019

krasimir committed rGbda8482abaa8: [clang-format] Fix indent of trailing raw string param after newline (authored by krasimir).
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:13 AM
krasimir committed rL358689: [clang-format] Fix indent of trailing raw string param after newline.
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:12 AM
krasimir committed rC358689: [clang-format] Fix indent of trailing raw string param after newline.
[clang-format] Fix indent of trailing raw string param after newline
Apr 18 2019, 10:12 AM
krasimir closed D60558: [clang-format] Fix indent of trailing raw string param after newline.
Apr 18 2019, 10:12 AM · Restricted Project

Apr 12 2019

krasimir committed rG69150467b098: [clang-format] Use SpacesBeforeTrailingComments for "option" directive (authored by krasimir).
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir committed rL358275: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir committed rC358275: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
[clang-format] Use SpacesBeforeTrailingComments for "option" directive
Apr 12 2019, 3:11 AM
krasimir closed D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
Apr 12 2019, 3:11 AM · Restricted Project
krasimir added a comment to D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.

I'll merge this.

Apr 12 2019, 2:46 AM · Restricted Project

Apr 11 2019

krasimir edited reviewers for D60558: [clang-format] Fix indent of trailing raw string param after newline, added: djasper; removed: ioeric.
Apr 11 2019, 10:43 AM · Restricted Project
krasimir accepted D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.

Thank you!

Apr 11 2019, 4:41 AM · Restricted Project
krasimir added a reviewer for D60558: [clang-format] Fix indent of trailing raw string param after newline: ioeric.
Apr 11 2019, 3:15 AM · Restricted Project
krasimir created D60558: [clang-format] Fix indent of trailing raw string param after newline.
Apr 11 2019, 3:05 AM · Restricted Project

Apr 8 2019

krasimir resigned from D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.
Apr 8 2019, 3:53 AM · Restricted Project
krasimir added inline comments to D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.
Apr 8 2019, 3:42 AM · Restricted Project

Apr 5 2019

krasimir added inline comments to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Apr 5 2019, 6:25 AM · Restricted Project
krasimir added a comment to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Generally I'm against introducing new style flags or flag options unless a supported style requires it.
IMO this increases maintenance burden and can quickly lead to a big space of style flags that contain tricky incompatibilities.

Apr 5 2019, 6:10 AM · Restricted Project
krasimir added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

I believe there is no such thing as an "short else statement". The else is part of the if statement and if it is present, I don't consider the whole if statement short. As such, IMO the bug is invalid.

Apr 5 2019, 6:01 AM · Restricted Project, Restricted Project

Apr 4 2019

krasimir committed rG00e7ae9f80cc: [clang-format] Preserve include blocks in ObjC Google style (authored by krasimir).
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:03 AM
krasimir committed rL357695: [clang-format] Preserve include blocks in ObjC Google style.
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:03 AM
krasimir committed rC357695: [clang-format] Preserve include blocks in ObjC Google style.
[clang-format] Preserve include blocks in ObjC Google style
Apr 4 2019, 7:02 AM
krasimir closed D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 7:02 AM · Restricted Project, Restricted Project
krasimir updated the diff for D60263: [clang-format] Preserve include blocks in ObjC Google style.
  • Add a note about intent
Apr 4 2019, 7:02 AM · Restricted Project, Restricted Project
krasimir added a comment to D60263: [clang-format] Preserve include blocks in ObjC Google style.

Why would we want this to be different in Obj-C and C++?

Apr 4 2019, 6:46 AM · Restricted Project, Restricted Project
krasimir added inline comments to D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:33 AM · Restricted Project, Restricted Project
krasimir created D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:15 AM · Restricted Project, Restricted Project

Apr 3 2019

krasimir committed rG925bb20c794f: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir).
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:15 AM
krasimir committed rL357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:14 AM
krasimir committed rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
[clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Apr 3 2019, 8:14 AM
krasimir closed D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
Apr 3 2019, 8:14 AM · Restricted Project
krasimir updated the diff for D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
  • Address review comments
Apr 3 2019, 7:51 AM · Restricted Project
krasimir created D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
Apr 3 2019, 7:03 AM · Restricted Project
krasimir added a reviewer for D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK: ioeric.
Apr 3 2019, 7:03 AM · Restricted Project

Apr 1 2019

krasimir committed rG7af32444b9b1: [X86] Fix a test from r357317 (authored by krasimir).
[X86] Fix a test from r357317
Apr 1 2019, 4:44 AM
krasimir committed rL357380: [X86] Fix a test from r357317.
[X86] Fix a test from r357317
Apr 1 2019, 4:44 AM
krasimir closed D60060: [X86] Fix a test from r357317.
Apr 1 2019, 4:44 AM · Restricted Project
krasimir added a reviewer for D60060: [X86] Fix a test from r357317: bkramer.
Apr 1 2019, 4:39 AM · Restricted Project
krasimir created D60060: [X86] Fix a test from r357317.
Apr 1 2019, 4:39 AM · Restricted Project

Mar 25 2019

krasimir committed rGfc67176eec7e: [clang-format] Refine structured binding detection (authored by krasimir).
[clang-format] Refine structured binding detection
Mar 25 2019, 10:28 AM
krasimir committed rC356928: [clang-format] Refine structured binding detection.
[clang-format] Refine structured binding detection
Mar 25 2019, 10:28 AM
krasimir committed rL356928: [clang-format] Refine structured binding detection.
[clang-format] Refine structured binding detection
Mar 25 2019, 10:28 AM
krasimir closed D59774: [clang-format] Refine structured binding detection.
Mar 25 2019, 10:27 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D59774: [clang-format] Refine structured binding detection: klimek.
Mar 25 2019, 9:01 AM · Restricted Project, Restricted Project
krasimir updated the diff for D59774: [clang-format] Refine structured binding detection.
  • Cleanup
Mar 25 2019, 8:49 AM · Restricted Project, Restricted Project
krasimir updated the diff for D59774: [clang-format] Refine structured binding detection.
  • Use exsiting implementation
Mar 25 2019, 8:47 AM · Restricted Project, Restricted Project
krasimir created D59774: [clang-format] Refine structured binding detection.
Mar 25 2019, 8:02 AM · Restricted Project, Restricted Project

Mar 11 2019

krasimir committed rGc416c52b07f5: clang-format: distinguish ObjC call subexpressions after r355434 (authored by krasimir).
clang-format: distinguish ObjC call subexpressions after r355434
Mar 11 2019, 9:05 AM
krasimir committed rC355831: clang-format: distinguish ObjC call subexpressions after r355434.
clang-format: distinguish ObjC call subexpressions after r355434
Mar 11 2019, 9:04 AM
krasimir committed rL355831: clang-format: distinguish ObjC call subexpressions after r355434.
clang-format: distinguish ObjC call subexpressions after r355434
Mar 11 2019, 9:04 AM
krasimir closed D59210: clang-format: distinguish ObjC call subexpressions after r355434.
Mar 11 2019, 9:04 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D59210: clang-format: distinguish ObjC call subexpressions after r355434: gribozavr.
Mar 11 2019, 8:15 AM · Restricted Project, Restricted Project
krasimir updated the summary of D59210: clang-format: distinguish ObjC call subexpressions after r355434.
Mar 11 2019, 7:21 AM · Restricted Project, Restricted Project
krasimir created D59210: clang-format: distinguish ObjC call subexpressions after r355434.
Mar 11 2019, 7:19 AM · Restricted Project, Restricted Project

Feb 26 2019

krasimir accepted D58241: [clang-format] SpaceBeforeParens for lambda expressions.

nit: Please add a sentence on what this patch does in the description.

Feb 26 2019, 5:12 AM · Restricted Project

Feb 20 2019

krasimir committed rG777bb8253393: [clang-format] Do not emit replacements if Java imports are OK (authored by krasimir).
[clang-format] Do not emit replacements if Java imports are OK
Feb 20 2019, 3:46 AM
krasimir committed rC354452: [clang-format] Do not emit replacements if Java imports are OK.
[clang-format] Do not emit replacements if Java imports are OK
Feb 20 2019, 3:46 AM
krasimir committed rL354452: [clang-format] Do not emit replacements if Java imports are OK.
[clang-format] Do not emit replacements if Java imports are OK
Feb 20 2019, 3:44 AM
krasimir closed D58436: [clang-format] Do not emit replacements if Java imports are OK.
Feb 20 2019, 3:43 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D58436: [clang-format] Do not emit replacements if Java imports are OK: ioeric.
Feb 20 2019, 3:35 AM · Restricted Project, Restricted Project
krasimir created D58436: [clang-format] Do not emit replacements if Java imports are OK.
Feb 20 2019, 3:34 AM · Restricted Project, Restricted Project

Feb 5 2019

krasimir committed rG12971803c4dc: Fix typo in comment, NFCI (authored by krasimir).
Fix typo in comment, NFCI
Feb 5 2019, 7:01 AM
krasimir committed rL353176: Fix typo in comment, NFCI.
Fix typo in comment, NFCI
Feb 5 2019, 7:00 AM
krasimir committed rG7ffc4681cae4: [Expressions] Fix -Wreorder warning from r353149 (authored by krasimir).
[Expressions] Fix -Wreorder warning from r353149
Feb 5 2019, 3:37 AM
krasimir committed rL353161: [Expressions] Fix -Wreorder warning from r353149.
[Expressions] Fix -Wreorder warning from r353149
Feb 5 2019, 3:36 AM
krasimir committed rLLDB353161: [Expressions] Fix -Wreorder warning from r353149.
[Expressions] Fix -Wreorder warning from r353149
Feb 5 2019, 3:36 AM
krasimir closed D57742: [Expressions] Fix -Wreorder warning from r353149.
Feb 5 2019, 3:36 AM · Restricted Project
krasimir added a comment to D57742: [Expressions] Fix -Wreorder warning from r353149.

No worries. Thanks for the quick response!

Feb 5 2019, 3:34 AM · Restricted Project
krasimir added a reviewer for D57742: [Expressions] Fix -Wreorder warning from r353149: bkramer.
Feb 5 2019, 3:25 AM · Restricted Project
krasimir added inline comments to rL353149: [Expressions] Add support of expressions evaluation in some object's context.
Feb 5 2019, 3:24 AM
krasimir created D57742: [Expressions] Fix -Wreorder warning from r353149.
Feb 5 2019, 3:23 AM · Restricted Project
krasimir accepted D57732: Correct inf typo.

Thank you!

Feb 5 2019, 2:21 AM · Restricted Project
krasimir added a comment to rL353129: [SamplePGO][NFC] Minor improvement to replace a temporary vector with a.

Sorry, already fixed by https://reviews.llvm.org/rL353134.

Feb 5 2019, 1:25 AM
krasimir added a comment to rL353129: [SamplePGO][NFC] Minor improvement to replace a temporary vector with a.

That triggers a warning:

llvm/lib/Transforms/IPO/SampleProfile.cpp:1331:50: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'unsigned int' in initializer list [-Wc++11-narrowing]
                        MDB.createBranchWeights({BlockWeights[BB]}));
                                                 ^~~~~~~~~~~~~~~~
Feb 5 2019, 1:18 AM

Feb 4 2019

krasimir committed rG20bef459fca6: [clang-format] Fix breaking of qualified operator (authored by krasimir).
[clang-format] Fix breaking of qualified operator
Feb 4 2019, 1:56 AM
krasimir committed rL353033: [clang-format] Fix breaking of qualified operator.
[clang-format] Fix breaking of qualified operator
Feb 4 2019, 1:56 AM
krasimir committed rC353033: [clang-format] Fix breaking of qualified operator.
[clang-format] Fix breaking of qualified operator
Feb 4 2019, 1:56 AM
krasimir closed D57604: [clang-format] Fix breaking of qualified operator.
Feb 4 2019, 1:56 AM · Restricted Project

Feb 1 2019

krasimir added a reviewer for D57604: [clang-format] Fix breaking of qualified operator: djasper.
Feb 1 2019, 10:43 AM · Restricted Project
krasimir updated the diff for D57604: [clang-format] Fix breaking of qualified operator.
  • Format tests
Feb 1 2019, 10:42 AM · Restricted Project
krasimir updated the summary of D57604: [clang-format] Fix breaking of qualified operator.
Feb 1 2019, 10:41 AM · Restricted Project
krasimir created D57604: [clang-format] Fix breaking of qualified operator.
Feb 1 2019, 10:39 AM · Restricted Project