krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (105 w, 2 d)

Recent Activity

Yesterday

krasimir committed rL344773: [clangd] Fix msan failure after r344735 by initializing bitfields.
[clangd] Fix msan failure after r344735 by initializing bitfields
Thu, Oct 18, 11:07 PM
krasimir committed rCTE344773: [clangd] Fix msan failure after r344735 by initializing bitfields.
[clangd] Fix msan failure after r344735 by initializing bitfields
Thu, Oct 18, 11:07 PM
krasimir requested changes to D52150: [clang-format] BeforeHash added to IndentPPDirectives.

As per https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options, could you please provide more info about the need for this option first?

Thu, Oct 18, 1:59 PM
krasimir requested changes to D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.

OK, so this is not a real bug in the sense of non-working current features, it's more like a feature request.
As per https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options, I (and I'm sure other reviewers) would like to understand better this use-case before it's added to clang-format.

Thu, Oct 18, 1:56 PM
krasimir requested changes to D53072: [clang-format] Introduce the flag which allows not to shrink lines.

In general there's a high bar for adding new style options to clang-format:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options

Thu, Oct 18, 1:52 PM

Wed, Oct 17

krasimir updated subscribers of rL344722: Revert "Return a named error in the result object of an expression with no….
Wed, Oct 17, 8:14 PM
krasimir committed rLLDB344722: Revert "Return a named error in the result object of an expression with no….
Revert "Return a named error in the result object of an expression with no…
Wed, Oct 17, 8:13 PM
krasimir committed rL344722: Revert "Return a named error in the result object of an expression with no….
Revert "Return a named error in the result object of an expression with no…
Wed, Oct 17, 8:13 PM
krasimir added inline comments to D50403: [clang-format]AlignConsecutiveAssignments.
Wed, Oct 17, 7:17 PM · Restricted Project
krasimir committed rL344721: [llvm-exegesis] Mark destructor virtual after r344695.
[llvm-exegesis] Mark destructor virtual after r344695
Wed, Oct 17, 7:08 PM

Tue, Oct 16

krasimir added a comment to rL344639: Revert "[WebAssembly] LSDA info generation".

Link to build bot breakage:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/7959/steps/check-llvm%20asan/logs/stdio

Tue, Oct 16, 12:20 PM
krasimir committed rL344639: Revert "[WebAssembly] LSDA info generation".
Revert "[WebAssembly] LSDA info generation"
Tue, Oct 16, 11:52 AM
krasimir committed rL344637: Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport….
Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport…
Tue, Oct 16, 11:47 AM
krasimir committed rCTE344637: Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport….
Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport…
Tue, Oct 16, 11:47 AM

Fri, Oct 5

krasimir added a comment to D52842: clang-format: Don't insert spaces in front of :: for Java 8 Method References..

Looks good!
I didn't find any instances where this messes-up C++ code (and it looks fine to me for Java code).

Fri, Oct 5, 10:53 AM
krasimir added inline comments to D52842: clang-format: Don't insert spaces in front of :: for Java 8 Method References..
Fri, Oct 5, 10:52 AM
krasimir closed D52800: Java import sorting in clang-format.
Fri, Oct 5, 10:23 AM
krasimir added an edge to rC343862: [clang-format] Java import sorting in clang-format: D52800: Java import sorting in clang-format.
Fri, Oct 5, 10:23 AM
krasimir added 1 commit(s) for D52800: Java import sorting in clang-format: rC343862: [clang-format] Java import sorting in clang-format.
Fri, Oct 5, 10:23 AM
krasimir committed rL343862: [clang-format] Java import sorting in clang-format.
[clang-format] Java import sorting in clang-format
Fri, Oct 5, 10:21 AM
krasimir committed rC343862: [clang-format] Java import sorting in clang-format.
[clang-format] Java import sorting in clang-format
Fri, Oct 5, 10:21 AM
krasimir added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

Digging a bit further, seems like the behavior you're looking for could be achieved by setting the AlignAfterOpenBracket option to DontAlign or AlwaysBreak:

% clang-format -style='{BasedOnStyle: google, AlignAfterOpenBracket: AlwaysBreak}' test.cc
 void f() {
   something->Method2s(
       1,
       [this] {
         Do1();
         Do2();
       },
       1);
 }
 % clang-format -style='{BasedOnStyle: google, AlignAfterOpenBracket: DontAlign}' test.cc
 void f() {
   something->Method2s(1,
       [this] {
         Do1();
         Do2();
       },
       1);
 }

Does this work for you?

This is interesting. It obviously does what I want with the lambda, but forces this:

void f() {
  auto stub = PopulateContextHereAndHereSomethi(GetSomethingHere(),
                                                GetSomethingElseHere());
}

into this:

void f() {
  auto stub = PopulateContextHereAndHereSomethi(
      GetSomethingHere(), GetSomethingElseHere());
}

The former looks better to me and that's what Emacs does when you press Tab. I think people here at work will balk at this formatting...

I don't think modifying the behavior as posed in this change based on the existence of multiline lambdas and the value of the BinPackArguments option is better than what we have now, especially when AlignAfterOpenBracket=Align.

Yeah, I hear you. The patch is intended to work with AlignAfterOpenBracket=Align and BinPackArguments=false and only tweaks the lambdas' placement.

How about I key the new behavior off a new value of AlignAfterOpenBracket, such as AlignAfterOpenBracket=AlignExceptLambda?

Sorry, I don't think we want to support something this specific. I'd like to hear djasper@ and klimek@ opinions about this.

Fri, Oct 5, 10:16 AM · Restricted Project
krasimir added a comment to D52842: clang-format: Don't insert spaces in front of :: for Java 8 Method References..

I'll take a look. I'm a bit worried that this might potentially affect C++ files too: I'll run an experiment over some random files to confirm that we're not missing something.

Fri, Oct 5, 10:06 AM
krasimir accepted D52800: Java import sorting in clang-format.

This gooks great! Thanks for the contribution!
If you don't have commit access to Clang I can commit this for you.

Fri, Oct 5, 9:06 AM

Wed, Oct 3

krasimir added inline comments to D52800: Java import sorting in clang-format.
Wed, Oct 3, 5:11 PM
krasimir added a comment to D52800: Java import sorting in clang-format.

Another example: we have to be careful with something like this as we don't want to break correct code:

import x;
import a.loooooong.
  c;
import y;
Wed, Oct 3, 1:38 PM
krasimir added inline comments to D52800: Java import sorting in clang-format.
Wed, Oct 3, 9:17 AM

Mon, Oct 1

krasimir committed rC343517: [clang-format] Update comment, NFCI.
[clang-format] Update comment, NFCI
Mon, Oct 1, 11:45 AM
krasimir committed rL343517: [clang-format] Update comment, NFCI.
[clang-format] Update comment, NFCI
Mon, Oct 1, 11:44 AM
krasimir committed rC343513: [clang-format] Fix typo in comment, NFCI.
[clang-format] Fix typo in comment, NFCI
Mon, Oct 1, 11:19 AM
krasimir committed rL343513: [clang-format] Fix typo in comment, NFCI.
[clang-format] Fix typo in comment, NFCI
Mon, Oct 1, 11:19 AM
krasimir added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

Digging a bit further, seems like the behavior you're looking for could be achieved by setting the AlignAfterOpenBracket option to DontAlign or AlwaysBreak:

% clang-format -style='{BasedOnStyle: google, AlignAfterOpenBracket: AlwaysBreak}' test.cc
void f() {
  something->Method2s(
      1,
      [this] {
        Do1();
        Do2();
      },
      1);
}
% clang-format -style='{BasedOnStyle: google, AlignAfterOpenBracket: DontAlign}' test.cc
void f() {
  something->Method2s(1,
      [this] {
        Do1();
        Do2();
      },
      1);
}
Mon, Oct 1, 10:59 AM · Restricted Project
krasimir added a reviewer for D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter: sammccall.
Mon, Oct 1, 9:15 AM
krasimir updated the diff for D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter.
  • Add more tests and tidy-up
Mon, Oct 1, 9:11 AM
krasimir updated the summary of D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter.
Mon, Oct 1, 8:43 AM
krasimir updated the summary of D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter.
Mon, Oct 1, 8:30 AM
krasimir added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

IMO BinPackArguments==false does not imply that there should be a line break before the first arguments, only that there should not be two arguments from the same argument list that appear on the same line.

That's right. However consider the following points:

  1. a lambda function is already placed onto its own line when it is the first arg (as you can see in the first test)

I believe that a newline before a first arg lambda is controlled by a different mechanism independent of bin packing, probably by a rule that is more general than just "newline before first arg lambda". I think djasper@ could know more about this case.

Hmm... perhaps. I have not been able to find an explicit rule for that.

  1. the other args are placed onto a distinct line
  2. this behavior looks very close to "bin packing"
  3. adding a new option for the minor cases seems to be an overkill

    Having said that, I can add a new explicit style option. Do you think that will improve consensus? Would you expect test cases for positive and negative values of the option?

Not really. It's generally hard to add a new style option, as that is mandated by an existing commonly used public style guide that requires it.

Mon, Oct 1, 7:59 AM · Restricted Project

Sat, Sep 29

krasimir added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

IMO BinPackArguments==false does not imply that there should be a line break before the first arguments, only that there should not be two arguments from the same argument list that appear on the same line.

That's right. However consider the following points:

  1. a lambda function is already placed onto its own line when it is the first arg (as you can see in the first test)

I believe that a newline before a first arg lambda is controlled by a different mechanism independent of bin packing, probably by a rule that is more general than just "newline before first arg lambda". I think djasper@ could know more about this case.

  1. the other args are placed onto a distinct line
  2. this behavior looks very close to "bin packing"
  3. adding a new option for the minor cases seems to be an overkill

    Having said that, I can add a new explicit style option. Do you think that will improve consensus? Would you expect test cases for positive and negative values of the option?

I don't see how the example before:

void f() {
  something->Method2s(1,
                      [this] {
                        Do1();
                        Do2();
                      },
                      1);
}

is inconsistent, as not adding a newline before the first argument is typical, as in:

$ clang-format -style='{BasedOnStyle: google, BinPackArguments: false}' test.cc                                                             ~
void f() {
  something->Method2s("111111111111111111",
                      "2222222222222222222222222222222222222222222222222222",
                      3);
}
Sat, Sep 29, 8:31 AM · Restricted Project

Fri, Sep 28

krasimir added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

IMO BinPackArguments==false does not imply that there should be a line break before the first arguments, only that there should not be two arguments from the same argument list that appear on the same line.

Fri, Sep 28, 5:39 PM · Restricted Project

Wed, Sep 26

krasimir accepted D52536: clang-format: [JS] conditional types..
Wed, Sep 26, 9:50 AM

Mon, Sep 24

krasimir created D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter.
Mon, Sep 24, 7:19 PM
krasimir added a comment to D50147: clang-format: support external styles.

I don't understand the use-case this patch is realizing. Suppose I have a bunch of projects that have to share a format style. Then I can checkout them under a common root directory and put an appropriate .clang-format file there.

Mon, Sep 24, 6:24 PM

Sep 18 2018

krasimir accepted D33440: clang-format: better handle statement macros.
Sep 18 2018, 2:54 AM

Aug 29 2018

krasimir committed rL340912: [MC] fix a clang-tidy warning, NFC.
[MC] fix a clang-tidy warning, NFC
Aug 29 2018, 3:42 AM
krasimir closed D51406: [MC] fix a clang-tidy warning, NFC.
Aug 29 2018, 3:41 AM
krasimir created D51406: [MC] fix a clang-tidy warning, NFC.
Aug 29 2018, 1:40 AM

Aug 13 2018

krasimir committed rL339573: [clang-format] Fix comment, NFC.
[clang-format] Fix comment, NFC
Aug 13 2018, 7:33 AM
krasimir committed rC339573: [clang-format] Fix comment, NFC.
[clang-format] Fix comment, NFC
Aug 13 2018, 7:33 AM

Aug 7 2018

krasimir committed rL339123: [clang-format] comment reflow: add last line's penalty when ending broken.
[clang-format] comment reflow: add last line's penalty when ending broken
Aug 7 2018, 3:24 AM
krasimir committed rC339123: [clang-format] comment reflow: add last line's penalty when ending broken.
[clang-format] comment reflow: add last line's penalty when ending broken
Aug 7 2018, 3:24 AM
krasimir closed D50378: [clang-format] comment reflow: add last line's penalty when ending broken.
Aug 7 2018, 3:24 AM
krasimir closed D50378: [clang-format] comment reflow: add last line's penalty when ending broken.
Aug 7 2018, 3:24 AM
krasimir added a reviewer for D50378: [clang-format] comment reflow: add last line's penalty when ending broken: mprobst.
Aug 7 2018, 3:13 AM
krasimir created D50378: [clang-format] comment reflow: add last line's penalty when ending broken.
Aug 7 2018, 3:12 AM

Aug 3 2018

krasimir accepted D50249: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 6:07 AM
krasimir committed rC338839: clang-format-diff: Make it work with python3 too.
clang-format-diff: Make it work with python3 too
Aug 3 2018, 3:05 AM
krasimir committed rL338839: clang-format-diff: Make it work with python3 too.
clang-format-diff: Make it work with python3 too
Aug 3 2018, 3:05 AM
krasimir closed D48098: clang-format-diff: Make it work with python3 too.
Aug 3 2018, 3:05 AM
krasimir accepted D50230: clang-format: [JS] don't break comments before any '{'.

Great! Thanks!

Aug 3 2018, 2:19 AM

Aug 2 2018

krasimir accepted D50177: clang-format: fix a crash in comment wraps..

Great! Thank you!

Aug 2 2018, 4:22 AM

Aug 1 2018

krasimir committed rC338524: [clang-format] Add some text proto functions to Google style.
[clang-format] Add some text proto functions to Google style
Aug 1 2018, 5:35 AM
krasimir committed rL338524: [clang-format] Add some text proto functions to Google style.
[clang-format] Add some text proto functions to Google style
Aug 1 2018, 5:35 AM
krasimir closed D50132: [clang-format] Add some text proto functions to Google style.
Aug 1 2018, 5:35 AM
krasimir added a reviewer for D50132: [clang-format] Add some text proto functions to Google style: klimek.
Aug 1 2018, 5:09 AM
krasimir committed rC338519: [clang-format] Add @private to the list of jsdoc annotations.
[clang-format] Add @private to the list of jsdoc annotations
Aug 1 2018, 4:48 AM
krasimir committed rL338519: [clang-format] Add @private to the list of jsdoc annotations.
[clang-format] Add @private to the list of jsdoc annotations
Aug 1 2018, 4:48 AM
krasimir closed D50138: [clang-format] Add @private to the list of jsdoc annotations.
Aug 1 2018, 4:48 AM
krasimir added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Could you clarify how each piece is supposed to be aligned in these examples?
This is what makes me happy:

// column  limit             V
int a = condition1 ? result1
      : conditio2 ? result2
      : loooooooooocondition 
        ? result2
        : dition3 ? resul3
                  : resul4;
Aug 1 2018, 4:44 AM
krasimir created D50138: [clang-format] Add @private to the list of jsdoc annotations.
Aug 1 2018, 4:17 AM
krasimir created D50132: [clang-format] Add some text proto functions to Google style.
Aug 1 2018, 12:51 AM

Jul 30 2018

krasimir added inline comments to rL338232: [clang-format] Indent after breaking Javadoc annotated line.
Jul 30 2018, 5:23 AM
krasimir committed rL338245: [clang-format] Silence -Wdocumentation warnings.
[clang-format] Silence -Wdocumentation warnings
Jul 30 2018, 5:23 AM
krasimir committed rC338245: [clang-format] Silence -Wdocumentation warnings.
[clang-format] Silence -Wdocumentation warnings
Jul 30 2018, 5:23 AM
krasimir added inline comments to rL338232: [clang-format] Indent after breaking Javadoc annotated line.
Jul 30 2018, 5:09 AM
krasimir committed rC338232: [clang-format] Indent after breaking Javadoc annotated line.
[clang-format] Indent after breaking Javadoc annotated line
Jul 30 2018, 1:46 AM
krasimir committed rL338232: [clang-format] Indent after breaking Javadoc annotated line.
[clang-format] Indent after breaking Javadoc annotated line
Jul 30 2018, 1:46 AM
krasimir closed D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 30 2018, 1:46 AM
krasimir updated the diff for D49797: [clang-format] Indent after breaking Javadoc annotated line.
  • Address comments
Jul 30 2018, 1:28 AM

Jul 27 2018

krasimir added inline comments to D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 27 2018, 8:36 AM
krasimir added inline comments to D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 27 2018, 7:03 AM
krasimir updated the diff for D49797: [clang-format] Indent after breaking Javadoc annotated line.
  • Address review comments
Jul 27 2018, 7:03 AM

Jul 26 2018

krasimir added a reviewer for D49797: [clang-format] Indent after breaking Javadoc annotated line: mprobst.
Jul 26 2018, 3:53 AM
krasimir updated the diff for D49797: [clang-format] Indent after breaking Javadoc annotated line.
  • Update tests
Jul 26 2018, 3:50 AM

Jul 25 2018

krasimir created D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 25 2018, 7:13 AM
krasimir committed rC337899: [clang-format ]Extend IncludeCategories regex documentation.
[clang-format ]Extend IncludeCategories regex documentation
Jul 25 2018, 3:22 AM
krasimir committed rL337899: [clang-format ]Extend IncludeCategories regex documentation.
[clang-format ]Extend IncludeCategories regex documentation
Jul 25 2018, 3:22 AM
krasimir closed D48827: [clang-format ]Extend IncludeCategories regex documentation.
Jul 25 2018, 3:22 AM
krasimir added a comment to D48098: clang-format-diff: Make it work with python3 too.

MarcoFalke: do you need someone to submit this for you?

Jul 25 2018, 3:18 AM

Jul 5 2018

krasimir accepted D48827: [clang-format ]Extend IncludeCategories regex documentation.

Thank you!

Jul 5 2018, 7:19 AM
krasimir committed rL336336: Partially revert r336268 in address-offsets.ll.
Partially revert r336268 in address-offsets.ll
Jul 5 2018, 4:35 AM
krasimir closed D48962: Partially revert r336268 in address-offsets.ll.
Jul 5 2018, 4:35 AM
krasimir retitled D48962: Partially revert r336268 in address-offsets.ll from Partially revert r336268 in address-offests.ll to Partially revert r336268 in address-offsets.ll.
Jul 5 2018, 4:33 AM
krasimir added a reviewer for D48962: Partially revert r336268 in address-offsets.ll: bkramer.
Jul 5 2018, 4:32 AM
krasimir created D48962: Partially revert r336268 in address-offsets.ll.
Jul 5 2018, 4:32 AM
krasimir raised a concern with rL336268: NFC - Various typo fixes in tests.

This breaks CodeGen/WebAssembly/address-offsets.ll. There the typos are intentional, explicitly introduced to disable these cases in r280285. Re-introduced the typos in this file in r336336.

Jul 5 2018, 4:24 AM

Jul 3 2018

krasimir requested changes to D48827: [clang-format ]Extend IncludeCategories regex documentation.

This file is automatically generated from Format.h using clang/docs/tools/dump_format_style.py. Please update.

Jul 3 2018, 1:12 AM

Jun 29 2018

krasimir accepted D48679: [clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:)) after ObjC method decl.
Jun 29 2018, 7:38 AM
krasimir committed rL335978: [clang-format] Support additional common functions for text proto formatting.
[clang-format] Support additional common functions for text proto formatting
Jun 29 2018, 7:30 AM
krasimir committed rC335978: [clang-format] Support additional common functions for text proto formatting.
[clang-format] Support additional common functions for text proto formatting
Jun 29 2018, 7:30 AM
krasimir closed D48760: [clang-format] Support additional common functions for text proto formatting.
Jun 29 2018, 7:30 AM