krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (92 w, 2 d)

Recent Activity

Thu, Jul 5

krasimir accepted D48827: [clang-format ]Extend IncludeCategories regex documentation.

Thank you!

Thu, Jul 5, 7:19 AM
krasimir committed rL336336: Partially revert r336268 in address-offsets.ll.
Partially revert r336268 in address-offsets.ll
Thu, Jul 5, 4:35 AM
krasimir closed D48962: Partially revert r336268 in address-offsets.ll.
Thu, Jul 5, 4:35 AM
krasimir retitled D48962: Partially revert r336268 in address-offsets.ll from Partially revert r336268 in address-offests.ll to Partially revert r336268 in address-offsets.ll.
Thu, Jul 5, 4:33 AM
krasimir added a reviewer for D48962: Partially revert r336268 in address-offsets.ll: bkramer.
Thu, Jul 5, 4:32 AM
krasimir created D48962: Partially revert r336268 in address-offsets.ll.
Thu, Jul 5, 4:32 AM
krasimir raised a concern with rL336268: NFC - Various typo fixes in tests.

This breaks CodeGen/WebAssembly/address-offsets.ll. There the typos are intentional, explicitly introduced to disable these cases in r280285. I'll go ahead an re-introduce the typos in that file now.

Thu, Jul 5, 4:24 AM

Tue, Jul 3

krasimir requested changes to D48827: [clang-format ]Extend IncludeCategories regex documentation.

This file is automatically generated from Format.h using clang/docs/tools/dump_format_style.py. Please update.

Tue, Jul 3, 1:12 AM

Fri, Jun 29

krasimir accepted D48679: [clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:)) after ObjC method decl.
Fri, Jun 29, 7:38 AM
krasimir committed rL335978: [clang-format] Support additional common functions for text proto formatting.
[clang-format] Support additional common functions for text proto formatting
Fri, Jun 29, 7:30 AM
krasimir committed rC335978: [clang-format] Support additional common functions for text proto formatting.
[clang-format] Support additional common functions for text proto formatting
Fri, Jun 29, 7:30 AM
krasimir closed D48760: [clang-format] Support additional common functions for text proto formatting.
Fri, Jun 29, 7:30 AM
krasimir accepted D48098: clang-format-diff: Make it work with python3 too.

Checked with both python 2 and python 3 as suggested. Works like a charm! Thank you!

Fri, Jun 29, 7:28 AM
krasimir added a reviewer for D48760: [clang-format] Support additional common functions for text proto formatting: djasper.
Fri, Jun 29, 3:20 AM
krasimir created D48760: [clang-format] Support additional common functions for text proto formatting.
Fri, Jun 29, 3:20 AM

Thu, Jun 28

krasimir committed rC335876: [clang-format] Do not format raw string literals inside a recognized function….
[clang-format] Do not format raw string literals inside a recognized function…
Thu, Jun 28, 10:03 AM
krasimir committed rL335876: [clang-format] Do not format raw string literals inside a recognized function….
[clang-format] Do not format raw string literals inside a recognized function…
Thu, Jun 28, 10:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Jun 28, 10:03 AM
krasimir created D48728: [clang-format] Do not format raw string literals inside a recognized function with a non-recognized delimiter.
Thu, Jun 28, 10:00 AM

Tue, Jun 26

krasimir committed rC335595: [clang-format] Enable text proto formatting in common functions.
[clang-format] Enable text proto formatting in common functions
Tue, Jun 26, 5:05 AM
krasimir committed rL335595: [clang-format] Enable text proto formatting in common functions.
[clang-format] Enable text proto formatting in common functions
Tue, Jun 26, 5:05 AM
krasimir closed D48363: [clang-format] Enable text proto formatting in common functions.
Tue, Jun 26, 5:05 AM
krasimir updated the summary of D48363: [clang-format] Enable text proto formatting in common functions.
Tue, Jun 26, 1:44 AM

Mon, Jun 25

krasimir committed rL335459: [clang-format] Keep @message together in text protos.
[clang-format] Keep @message together in text protos
Mon, Jun 25, 5:50 AM
krasimir committed rC335459: [clang-format] Keep @message together in text protos.
[clang-format] Keep @message together in text protos
Mon, Jun 25, 5:50 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jun 25, 5:50 AM
krasimir created D48543: [clang-format] Keep @message together in text protos.
Mon, Jun 25, 5:39 AM
krasimir committed rC335449: [clang-format] Fix end-of-file comments text proto formatting.
[clang-format] Fix end-of-file comments text proto formatting
Mon, Jun 25, 4:13 AM
krasimir committed rL335449: [clang-format] Fix end-of-file comments text proto formatting.
[clang-format] Fix end-of-file comments text proto formatting
Mon, Jun 25, 4:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jun 25, 4:13 AM
krasimir created D48539: [clang-format] Fix end-of-file comments text proto formatting.
Mon, Jun 25, 3:39 AM

Wed, Jun 20

krasimir created D48363: [clang-format] Enable text proto formatting in common functions.
Wed, Jun 20, 5:41 AM

Jun 14 2018

krasimir accepted D48161: clang-format: Fix documentation generation.
Jun 14 2018, 2:35 AM
krasimir added inline comments to D48098: clang-format-diff: Make it work with python3 too.
Jun 14 2018, 2:07 AM

Jun 13 2018

krasimir requested changes to D48098: clang-format-diff: Make it work with python3 too.

Sorry, I'm not familiar with this tool. Could you elaborate:

  • why is this switch necessary?
  • what's expected to be supported with it?
  • how do I test it?
Jun 13 2018, 2:57 AM

Jun 12 2018

krasimir committed rL334527: [clang-format] Fix crash while reflowing backslash in comments.
[clang-format] Fix crash while reflowing backslash in comments
Jun 12 2018, 12:37 PM
krasimir committed rC334527: [clang-format] Fix crash while reflowing backslash in comments.
[clang-format] Fix crash while reflowing backslash in comments
Jun 12 2018, 12:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jun 12 2018, 12:37 PM
krasimir updated the summary of D48089: [clang-format] Fix crash while reflowing backslash in comments.
Jun 12 2018, 12:15 PM
krasimir updated the summary of D48089: [clang-format] Fix crash while reflowing backslash in comments.
Jun 12 2018, 12:14 PM
krasimir created D48089: [clang-format] Fix crash while reflowing backslash in comments.
Jun 12 2018, 12:13 PM
krasimir committed rC334517: [clang-format] Discourage breaks in submessage entries, hard rule.
[clang-format] Discourage breaks in submessage entries, hard rule
Jun 12 2018, 10:31 AM
krasimir committed rL334517: [clang-format] Discourage breaks in submessage entries, hard rule.
[clang-format] Discourage breaks in submessage entries, hard rule
Jun 12 2018, 10:31 AM
krasimir closed D48063: [clang-format] Discourage breaks in submessage entries, hard rule.
Jun 12 2018, 10:31 AM
krasimir updated the diff for D48063: [clang-format] Discourage breaks in submessage entries, hard rule.
  • Split-up the if-condition
Jun 12 2018, 10:29 AM
krasimir removed reviewers for D48034: [clang-format] Discourage breaks in submessage entries: sammccall, djasper.
Jun 12 2018, 3:45 AM
krasimir added reviewers for D48063: [clang-format] Discourage breaks in submessage entries, hard rule: djasper, sammccall.
Jun 12 2018, 3:45 AM
krasimir updated the diff for D48063: [clang-format] Discourage breaks in submessage entries, hard rule.
  • Add tests
Jun 12 2018, 3:45 AM
krasimir updated the summary of D48063: [clang-format] Discourage breaks in submessage entries, hard rule.
Jun 12 2018, 3:29 AM
krasimir created D48063: [clang-format] Discourage breaks in submessage entries, hard rule.
Jun 12 2018, 1:32 AM

Jun 11 2018

krasimir added a comment to D48034: [clang-format] Discourage breaks in submessage entries.

All else equal, I'd expect this to be a hard rule, at least in google-style.

"foo\n { a: b }" --> "foo {\n a: b\n}" only makes the first line longer, by 2 chars. So if 78 < indent + len("foo") <= 80 we're breaking the line limit, but that seems vanishingly rare.

If the penalty is sufficient to stop it happening almost always, maybe it works out the same.

Jun 11 2018, 10:06 AM
krasimir updated the summary of D48034: [clang-format] Discourage breaks in submessage entries.
Jun 11 2018, 9:53 AM
krasimir created D48034: [clang-format] Discourage breaks in submessage entries.
Jun 11 2018, 9:53 AM
krasimir committed rL334401: [clang-format] text protos: put entries on separate lines if there is a….
[clang-format] text protos: put entries on separate lines if there is a…
Jun 11 2018, 5:57 AM
krasimir committed rC334401: [clang-format] text protos: put entries on separate lines if there is a….
[clang-format] text protos: put entries on separate lines if there is a…
Jun 11 2018, 5:57 AM
krasimir closed D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
Jun 11 2018, 5:57 AM
krasimir updated the diff for D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
  • Address review comments
Jun 11 2018, 5:56 AM

Jun 8 2018

krasimir requested changes to D47577: [clang-format] Separate block comments with CRLF correctly.
Jun 8 2018, 2:14 AM

Jun 7 2018

krasimir added a reviewer for D46757: [clang-format] text protos: put entries on separate lines if there is a submessage: sammccall.
Jun 7 2018, 6:47 AM
krasimir updated the summary of D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
Jun 7 2018, 6:46 AM
krasimir retitled D46757: [clang-format] text protos: put entries on separate lines if there is a submessage from [clang-format] Break inside submessages containing a submessage and something else to [clang-format] text protos: put entries on separate lines if there is a submessage.
Jun 7 2018, 6:46 AM
krasimir updated the diff for D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
  • Add comments tests
Jun 7 2018, 6:41 AM
krasimir updated the diff for D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
  • Update comments
Jun 7 2018, 6:35 AM
krasimir committed rL334179: [clang-format] Consider tok::hashhash in python-style comments.
[clang-format] Consider tok::hashhash in python-style comments
Jun 7 2018, 2:53 AM
krasimir committed rC334179: [clang-format] Consider tok::hashhash in python-style comments.
[clang-format] Consider tok::hashhash in python-style comments
Jun 7 2018, 2:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jun 7 2018, 2:53 AM
krasimir requested changes to D47519: [clang-format] Detect amp type as TT_PointerOrReference in function annotations.
Jun 7 2018, 2:30 AM
krasimir created D47870: [clang-format] Consider tok::hashhash in python-style comments.
Jun 7 2018, 1:36 AM
krasimir updated the diff for D46757: [clang-format] text protos: put entries on separate lines if there is a submessage.
  • Polish
Jun 7 2018, 1:19 AM

Jun 6 2018

krasimir added inline comments to D47519: [clang-format] Detect amp type as TT_PointerOrReference in function annotations.
Jun 6 2018, 6:17 AM

May 30 2018

krasimir accepted D47527: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver".
May 30 2018, 5:22 AM

May 25 2018

krasimir added inline comments to rL333230: [C-API] Add functions to create GDB, Intel, Oprofile event listeners..
May 25 2018, 3:15 AM
krasimir committed rL333265: Fix ODR violation from r333230.
Fix ODR violation from r333230
May 25 2018, 3:14 AM
krasimir added inline comments to rL333230: [C-API] Add functions to create GDB, Intel, Oprofile event listeners..
May 25 2018, 3:07 AM

May 24 2018

krasimir accepted D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 24 2018, 3:43 AM

May 23 2018

krasimir committed rC333092: [clang-format] fix buildbots after r333085.
[clang-format] fix buildbots after r333085
May 23 2018, 8:25 AM
krasimir committed rL333092: [clang-format] fix buildbots after r333085.
[clang-format] fix buildbots after r333085
May 23 2018, 8:25 AM
krasimir committed rC333085: [clang-format] Break template declarations followed by comments.
[clang-format] Break template declarations followed by comments
May 23 2018, 7:22 AM
krasimir committed rL333085: [clang-format] Break template declarations followed by comments.
[clang-format] Break template declarations followed by comments
May 23 2018, 7:22 AM
krasimir closed D47257: [clang-format] Break template declarations followed by comments.
May 23 2018, 7:22 AM
krasimir added a reviewer for D47257: [clang-format] Break template declarations followed by comments: sammccall.
May 23 2018, 6:50 AM
krasimir created D47257: [clang-format] Break template declarations followed by comments.
May 23 2018, 6:49 AM

May 22 2018

krasimir added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 10:19 AM
krasimir added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 8:56 AM
krasimir added inline comments to D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver.
May 22 2018, 7:59 AM
krasimir added a comment to D47191: [clang-format] Fix crash in getLengthToMatchingParen.

Added a test in rL332974.
Didn't add a test case and didn't wait for review. Sorry about that!

May 22 2018, 4:52 AM
krasimir added 1 commit(s) for D47191: [clang-format] Fix crash in getLengthToMatchingParen: rL332974: [clang-format] Add a test case for crash.
May 22 2018, 4:50 AM
krasimir added an edge to rL332974: [clang-format] Add a test case for crash: D47191: [clang-format] Fix crash in getLengthToMatchingParen.
May 22 2018, 4:50 AM
krasimir committed rL332974: [clang-format] Add a test case for crash.
[clang-format] Add a test case for crash
May 22 2018, 4:48 AM
krasimir committed rC332974: [clang-format] Add a test case for crash.
[clang-format] Add a test case for crash
May 22 2018, 4:48 AM
krasimir accepted D47193: clang-format: [JS] do not wrap before any `is`..
May 22 2018, 3:40 AM
krasimir committed rC332961: [clang-format] Fix crash in getLengthToMatchingParen.
[clang-format] Fix crash in getLengthToMatchingParen
May 22 2018, 2:51 AM
krasimir committed rL332961: [clang-format] Fix crash in getLengthToMatchingParen.
[clang-format] Fix crash in getLengthToMatchingParen
May 22 2018, 2:50 AM
This revision was not accepted when it landed; it landed in state Needs Review.
May 22 2018, 2:50 AM
krasimir added a reviewer for D47191: [clang-format] Fix crash in getLengthToMatchingParen: bkramer.
May 22 2018, 2:49 AM
krasimir created D47191: [clang-format] Fix crash in getLengthToMatchingParen.
May 22 2018, 2:48 AM

May 18 2018

krasimir abandoned D44695: [clang-format] Partially revert r322749, replacing array with DenseSet.
May 18 2018, 2:46 AM

May 14 2018

krasimir committed rL332225: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen.
[clang-format] Continue after non-scope-closers in getLengthToMatchingParen
May 14 2018, 3:37 AM
krasimir committed rC332225: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen.
[clang-format] Continue after non-scope-closers in getLengthToMatchingParen
May 14 2018, 3:37 AM
This revision was not accepted when it landed; it landed in state Needs Review.
May 14 2018, 3:37 AM