Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (336 w, 5 d)

Recent Activity

Wed, Mar 22

krasimir added a comment to rG1e0709167f5e: Revert "[Modules] Remove unnecessary check when generating name lookup table in….

It will be helpful if you can provide a reproducer or a reproducer command.

We're looking into this. We are hitting this in a large modules build and it's taking up some effort to reduce.

Wed, Mar 22, 2:46 PM · Restricted Project, Restricted Project

Mon, Mar 13

krasimir added a comment to rG1e0709167f5e: Revert "[Modules] Remove unnecessary check when generating name lookup table in….

It will be helpful if you can provide a reproducer or a reproducer command.

Mon, Mar 13, 7:50 AM · Restricted Project, Restricted Project

Fri, Mar 10

krasimir added a reverting change for rGdb987b9589be: [Modules] Remove unnecessary check when generating name lookup table in…: rG1e0709167f5e: Revert "[Modules] Remove unnecessary check when generating name lookup table in….
Fri, Mar 10, 5:16 AM · Restricted Project, Restricted Project
krasimir committed rG1e0709167f5e: Revert "[Modules] Remove unnecessary check when generating name lookup table in… (authored by krasimir).
Revert "[Modules] Remove unnecessary check when generating name lookup table in…
Fri, Mar 10, 5:16 AM · Restricted Project, Restricted Project

Thu, Mar 9

krasimir added a comment to D145320: [libc++] Granularize <type_traits> includes.

I submitted https://github.com/llvm/llvm-project/commit/8227349f7e4f1a6ceb4cceb464c8f4420ff1dd0a to address errors we started seeing in <optional> after this. Leaving a comment here so the author can take a look and check if this is reasonable.

Thu, Mar 9, 5:11 AM · Restricted Project, Restricted Project, Restricted Project
krasimir committed rG8227349f7e4f: [libc++] Add missing includes to optional (authored by krasimir).
[libc++] Add missing includes to optional
Thu, Mar 9, 5:08 AM · Restricted Project, Restricted Project

Jan 25 2023

krasimir committed rG35ae2482e5f6: [bazel] fix for 494734b06d62b54fdcbd982f96274dede572ba07 (authored by krasimir).
[bazel] fix for 494734b06d62b54fdcbd982f96274dede572ba07
Jan 25 2023, 6:01 AM · Restricted Project

Jan 23 2023

krasimir committed rGfa4260479838: bazel: adapt for https://github.com/llvm/llvm… (authored by krasimir).
bazel: adapt for https://github.com/llvm/llvm…
Jan 23 2023, 7:40 AM · Restricted Project

Jan 16 2023

krasimir committed rGcaf393da1823: Fix format for `case` in .proto files (authored by fowles).
Fix format for `case` in .proto files
Jan 16 2023, 9:44 AM · Restricted Project, Restricted Project
krasimir closed D141547: Fix format for `case` in .proto files.
Jan 16 2023, 9:44 AM · Restricted Project, Restricted Project
krasimir accepted D141547: Fix format for `case` in .proto files.

Thank you!

Jan 16 2023, 7:42 AM · Restricted Project, Restricted Project

Jan 12 2023

krasimir added inline comments to D141547: Fix format for `case` in .proto files.
Jan 12 2023, 4:20 AM · Restricted Project, Restricted Project

Jan 11 2023

krasimir added a reverting change for rG879bfe6a9792: Revert "[clang-format] Add an option for breaking after C++11 attributes": rG922c8891d991: Revert "Revert "[clang-format] Add an option for breaking after C++11….
Jan 11 2023, 3:32 AM · Restricted Project, Restricted Project
krasimir committed rG922c8891d991: Revert "Revert "[clang-format] Add an option for breaking after C++11… (authored by krasimir).
Revert "Revert "[clang-format] Add an option for breaking after C++11…
Jan 11 2023, 3:32 AM · Restricted Project, Restricted Project
krasimir added a comment to D140956: [clang-format] Add an option for breaking after C++11 attributes.

Was it actually a regression or did this patch also fix a bug? It seems that the continuation indent before the & in your example is inconsistent with other similar function declarations.

Jan 11 2023, 3:29 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

krasimir added a reverting change for rGa28f0747c2f3: [clang-format] Add an option for breaking after C++11 attributes: rG879bfe6a9792: Revert "[clang-format] Add an option for breaking after C++11 attributes".
Jan 10 2023, 1:59 AM · Restricted Project, Restricted Project
krasimir committed rG879bfe6a9792: Revert "[clang-format] Add an option for breaking after C++11 attributes" (authored by krasimir).
Revert "[clang-format] Add an option for breaking after C++11 attributes"
Jan 10 2023, 1:59 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D140956: [clang-format] Add an option for breaking after C++11 attributes: rG879bfe6a9792: Revert "[clang-format] Add an option for breaking after C++11 attributes".
Jan 10 2023, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D140956: [clang-format] Add an option for breaking after C++11 attributes.

It looks like this regressed the following example:

% cat test.cc  # formatted with older clang-format
aaaaaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbb>
    &cccccccccccccccccccccccccccccccccccccc() {
  return 1;
}
% clang-format --version
clang-format version 16.0.0 (https://github.com/llvm/llvm-project.git a28f0747c2f3728bd8a6f64f7c8ba80b4e0cda9f)
% clang-format -style=google test.cc
aaaaaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbb> &
cccccccccccccccccccccccccccccccccccccc() {
  return 1;
}
%
Jan 10 2023, 1:17 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2022

krasimir committed rGf86cdb485361: [clang][dataflow] Remove unused lambda capture (authored by merrymeerkat).
[clang][dataflow] Remove unused lambda capture
Dec 16 2022, 6:40 AM · Restricted Project, Restricted Project
krasimir closed D140211: [clang][dataflow] Remove unused lambda capture.
Dec 16 2022, 6:40 AM · Restricted Project, Restricted Project
krasimir added a comment to D140211: [clang][dataflow] Remove unused lambda capture.

I'll submit this for you.

Dec 16 2022, 6:37 AM · Restricted Project, Restricted Project
krasimir accepted D140211: [clang][dataflow] Remove unused lambda capture.
Dec 16 2022, 6:37 AM · Restricted Project, Restricted Project
krasimir committed rG231992d9b88f: [clang] silence unused variable warning (authored by krasimir).
[clang] silence unused variable warning
Dec 16 2022, 3:23 AM · Restricted Project, Restricted Project

Dec 14 2022

krasimir committed rGafcf8fa5ad06: [bazel] add some more deps to libc BUILD files (authored by krasimir).
[bazel] add some more deps to libc BUILD files
Dec 14 2022, 2:28 AM · Restricted Project
krasimir committed rG5c8bf9de9335: [bazel] Add __support_common dep (authored by krasimir).
[bazel] Add __support_common dep
Dec 14 2022, 2:17 AM · Restricted Project
krasimir added a reverting change for D136554: Implement CWG2631: rG339a7687e1c0: Revert "Implement CWG2631".
Dec 14 2022, 1:11 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rGf1f1b60c7ba6: Implement CWG2631: rG339a7687e1c0: Revert "Implement CWG2631".
Dec 14 2022, 1:11 AM · Restricted Project, Restricted Project
krasimir committed rG339a7687e1c0: Revert "Implement CWG2631" (authored by krasimir).
Revert "Implement CWG2631"
Dec 14 2022, 1:11 AM · Restricted Project, Restricted Project

Dec 13 2022

krasimir added a reverting change for rG0eb694bec09d: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V: rG1f9fe3427b5a: Revert "[RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V".
Dec 13 2022, 7:32 AM · Restricted Project, Restricted Project
krasimir committed rG1f9fe3427b5a: Revert "[RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V" (authored by krasimir).
Revert "[RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V"
Dec 13 2022, 7:32 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V: rG1f9fe3427b5a: Revert "[RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V".
Dec 13 2022, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for rG512a98e7184e: Delete sanitizer_common-based ('old') scudo: o7: rG78f786d02a46: Revert "Delete sanitizer_common-based ('old') scudo: o7".
Dec 13 2022, 7:04 AM · Restricted Project, Restricted Project
krasimir committed rG78f786d02a46: Revert "Delete sanitizer_common-based ('old') scudo: o7" (authored by krasimir).
Revert "Delete sanitizer_common-based ('old') scudo: o7"
Dec 13 2022, 7:04 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D139884: Delete sanitizer_common-based ('old') scudo: o7: rG78f786d02a46: Revert "Delete sanitizer_common-based ('old') scudo: o7".
Dec 13 2022, 7:04 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rG3bfba672afd5: [Assignment Tracking][13/*] Account for assignment tracking in SROA: rG5e6351d927fe: Revert "[Assignment Tracking][13/*] Account for assignment tracking in SROA".
Dec 13 2022, 1:57 AM · Restricted Project, Restricted Project
krasimir committed rG5e6351d927fe: Revert "[Assignment Tracking][13/*] Account for assignment tracking in SROA" (authored by krasimir).
Revert "[Assignment Tracking][13/*] Account for assignment tracking in SROA"
Dec 13 2022, 1:57 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D133296: [Assignment Tracking][13/*] Account for assignment tracking in SROA: rG5e6351d927fe: Revert "[Assignment Tracking][13/*] Account for assignment tracking in SROA".
Dec 13 2022, 1:57 AM · Restricted Project, debug-info, Restricted Project

Nov 10 2022

krasimir committed rGf76d3f328ae2: [bazel] Add LoongArch for 85f08c4197aea68b2444e6874524b5f8b4067cfd (authored by krasimir).
[bazel] Add LoongArch for 85f08c4197aea68b2444e6874524b5f8b4067cfd
Nov 10 2022, 5:50 AM · Restricted Project

Nov 8 2022

krasimir accepted D137584: Add const information about AST nodes used to construct CFG elements..
Nov 8 2022, 1:07 AM · Restricted Project, Restricted Project

Aug 11 2022

krasimir committed rG603edb93bcc1: [bazel] Add WindowsDriver as a dep of OrcJIT (llvmorg-16-init-1433… (authored by krasimir).
[bazel] Add WindowsDriver as a dep of OrcJIT (llvmorg-16-init-1433…
Aug 11 2022, 2:19 AM · Restricted Project

Jul 15 2022

krasimir committed rG8dd2ef213085: [clang-format] distinguish multiplication after brace-init from pointer (authored by krasimir).
[clang-format] distinguish multiplication after brace-init from pointer
Jul 15 2022, 2:46 AM · Restricted Project, Restricted Project
krasimir closed D129771: [clang-format] distinguish multiplication after brace-init from pointer.
Jul 15 2022, 2:46 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D129771: [clang-format] distinguish multiplication after brace-init from pointer.

I think we can also add new test cases in clang/unittests/Format/TokenAnnotatorTest.cpp.

Tokens = annotate("int i = int{42} * 34;");
...
Jul 15 2022, 2:42 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the diff for D129771: [clang-format] distinguish multiplication after brace-init from pointer.
  • address review comments
Jul 15 2022, 2:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2022

krasimir added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Proposed https://reviews.llvm.org/D129771.

Jul 14 2022, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the summary of D129771: [clang-format] distinguish multiplication after brace-init from pointer.
Jul 14 2022, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
krasimir requested review of D129771: [clang-format] distinguish multiplication after brace-init from pointer.
Jul 14 2022, 6:47 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

I think we cannot identify struct, union, class or enum by the right bracket. Clang-format will split the input into multiple lines. For instance struct Tmp {} *tmp; will be separated as struct Tmp { and } *tmp;. In annotating, we only handle the relation of tokens in a single line, so we cannot know whether } belongs to struct or not.

Jul 14 2022, 4:56 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Appears that this regressed examples like this:

// before
int i = int{16} * 1024;
// after
int i = int{16}* 1024;

Naively it looks like in all added examples, the token preceding the matching { of the } is one of struct, class, union, enum, or a >. Could we adapt this heuristic to only apply TT_PointerOrReference in cases like this?

Jul 14 2022, 2:52 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2022

krasimir added a reverting change for rG7625e01d6616: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records: rG8f2ba3633646: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame….
Jun 15 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project
krasimir committed rG8f2ba3633646: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame… (authored by krasimir).
Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame…
Jun 15 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records: rG8f2ba3633646: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame….
Jun 15 2022, 7:10 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

krasimir added a comment to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

We found another regression with this in wrongly indenting/not putting on its own line ObjC @interface:

% ./clang-format --version           
clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655)
% cat test.m
NS_SWIFT_NAME(A)
@interface B : C
@property(readonly) D value;
@end
May 17 2022, 8:06 AM · Restricted Project, Restricted Project

May 16 2022

krasimir added a comment to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

It looks like this regressed the following example by adding an unwanted level of indentation to the #elif B branch:

% ./clang-format --version
clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655)
% cat test.cc             
#define MACRO_BEGIN
May 16 2022, 8:03 AM · Restricted Project, Restricted Project

May 11 2022

krasimir committed rG52328dafda13: silence new -Wunused-result warnings in test (authored by krasimir).
silence new -Wunused-result warnings in test
May 11 2022, 11:35 PM · Restricted Project, Restricted Project

May 3 2022

krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@krasimir could you please test this patch on your side?

@kwk thank you! the new version of the patch looks good!

May 3 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

krasimir abandoned D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Apr 28 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir committed rGbe656df18721: [clang-format] add a regression test for include sorting (authored by krasimir).
[clang-format] add a regression test for include sorting
Apr 28 2022, 2:03 AM · Restricted Project, Restricted Project
krasimir closed D124513: [clang-format] add a regression test for include sorting.
Apr 28 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C: rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective….
Apr 28 2022, 2:01 AM · Restricted Project, Restricted Project
krasimir committed rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective… (authored by krasimir).
Revert "[clang-format] SortIncludes should support "@import" lines in Objective…
Apr 28 2022, 2:01 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C: rGe8cc7490d234: Revert "[clang-format] SortIncludes should support "@import" lines in Objective….
Apr 28 2022, 2:01 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

krasimir added a reviewer for D124513: [clang-format] add a regression test for include sorting: MyDeveloperDay.
Apr 27 2022, 2:58 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reviewer for D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C": MyDeveloperDay.
Apr 27 2022, 2:57 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the diff for D124513: [clang-format] add a regression test for include sorting.
  • update with just the last commit
Apr 27 2022, 2:55 AM · Restricted Project, Restricted Project, Restricted Project
krasimir requested review of D124513: [clang-format] add a regression test for include sorting.
Apr 27 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C: D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Apr 27 2022, 2:49 AM · Restricted Project, Restricted Project
krasimir requested review of D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Apr 27 2022, 2:49 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reverting change for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C: D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C".
Apr 27 2022, 2:49 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@krasimir I'm on sick leave and will have a look as soon as I'm back. Can it wait that long?

Apr 27 2022, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2022

krasimir added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

It appears that this regressed include sorting in the following case, where the contents of test.h show the expected include order and the clang-format behavior before this patch:

% cat test.h
#include <cstdint>
Apr 25 2022, 2:00 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

krasimir added a reverting change for rG126b37a713dc: [clang-format] Correctly recognize arrays in template parameter list.: rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list.".
Mar 24 2022, 2:16 AM · Restricted Project
krasimir committed rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list." (authored by krasimir).
Revert "[clang-format] Correctly recognize arrays in template parameter list."
Mar 24 2022, 2:16 AM · Restricted Project
krasimir added a reverting change for D121584: [clang-format] Correctly recognize arrays in template parameter list.: rGbe5c3ca7fbae: Revert "[clang-format] Correctly recognize arrays in template parameter list.".
Mar 24 2022, 2:16 AM · Restricted Project, Restricted Project
krasimir added a comment to D121584: [clang-format] Correctly recognize arrays in template parameter list..

It appears that this regressed some ObjC patterns:

Mar 24 2022, 1:11 AM · Restricted Project, Restricted Project

Mar 22 2022

krasimir committed rGeb35e0ecbe0a: [clang-format] don't break up #-style comment sections (authored by krasimir).
[clang-format] don't break up #-style comment sections
Mar 22 2022, 7:30 AM · Restricted Project
krasimir closed D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
krasimir updated the summary of D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:05 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a reviewer for D122230: [clang-format] don't break up #-style comment sections: curdeius.
Mar 22 2022, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
krasimir edited projects for D122230: [clang-format] don't break up #-style comment sections, added: Restricted Project; removed Restricted Project.
Mar 22 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir requested review of D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

So I'd rather keep the old behaviour for # in Proto but not in C-like languages. Is that acceptable?

Mar 22 2022, 6:43 AM · Restricted Project, Restricted Project

Mar 21 2022

krasimir added a comment to D121584: [clang-format] Correctly recognize arrays in template parameter list..

It appears that this regressed some ObjC patterns:

% cat test.m  # before: good
void f() {
  //
  BOOL a = [b.c count] > 1;
  int b = a;
}
% clang-format -style=google test.m  # after: bad, statements joined on the same line
void f() {
  //
  BOOL a = [b.c count] > 1; int b = a;
}
%
Mar 21 2022, 4:32 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This is getting more fun: the reason why /// isn't broken up is because the first character / after the comment leader // is considered punctuation per isPunctuation's CHAR_RAWDEL, which includes all these {}[]#<>%:;?*+-/^&|~!=,"':

Mar 21 2022, 3:06 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this:

################################################################################
# Big section name
################################################################################

That's a pity.
Do you think that just doing a different thing (what we had before) for Proto (and if possible other languages where # is used in a similar way) should be enough?

Mar 21 2022, 1:54 AM · Restricted Project, Restricted Project
krasimir added a comment to D121451: [clang-format] Add space to comments starting with '#'..

This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this:

################################################################################
# Big section name
################################################################################
Mar 21 2022, 1:40 AM · Restricted Project, Restricted Project

Mar 16 2022

krasimir added inline comments to D121758: [clang-format] Add support for formatting Verilog code.
Mar 16 2022, 2:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

krasimir committed rGad709bcfb02e: [lldb] Fix -Wformat warning after 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31 (authored by krasimir).
[lldb] Fix -Wformat warning after 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31
Mar 9 2022, 3:42 AM · Restricted Project

Mar 4 2022

krasimir added a comment to D118869: [clang-format] Non-latin comment prefix whitespace.

Thank you!
Turns out the original source wasn't using an ascii space for the comment indentation but a unicode [c2 a0] no-break space:

2f 2f c2 a0 43 6f 6d 6d  65 6e 74 0a 69 6e 74 20  |//..Comment.int |

IMO we shouldn't aim to handle non-ascii spaces for indentation in clang-format; the new behavior on this example is fine.

Mar 4 2022, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D118869: [clang-format] Non-latin comment prefix whitespace: Restricted Project.

It appears that this caused a regression by adding an additional space of indentation to line comments in some cases:

% cat test.cc  # (before)
// Comment
int i;
% clang-format -style=google test.cc
//  Comment
int i;

@ksyx could you please take a look?

Mar 4 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2022

krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

I just pushed 6cb42cd6669785f3b611106e1b6b38bbe65733a9 to hopefully fix this.

Mar 3 2022, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

krasimir removed a reviewer for D118361: clang-format: [JS] sort import aliases.: krasimir.
Mar 2 2022, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence thank you for looking into this, sorry for the late reply!

Mar 2 2022, 7:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example?

Sorry, I don't have a solution right now.

Feb 24 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
krasimir added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example?

Feb 24 2022, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

krasimir accepted D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages..

Thank you!

Feb 22 2022, 7:09 AM · Restricted Project
krasimir committed rGc9592ae49b8c: [clang-format] Fix preprocessor nesting after commit… (authored by krasimir).
[clang-format] Fix preprocessor nesting after commit…
Feb 22 2022, 6:44 AM
krasimir closed D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c.
Feb 22 2022, 6:44 AM · Restricted Project, Restricted Project
krasimir updated the diff for D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c.
  • address review comments
Feb 22 2022, 6:42 AM · Restricted Project, Restricted Project