krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (66 w, 4 d)

Recent Activity

Yesterday

krasimir committed rL322956: [clang-format] Adds a canonical delimiter to raw string formatting.
[clang-format] Adds a canonical delimiter to raw string formatting
Fri, Jan 19, 8:21 AM
krasimir committed rC322956: [clang-format] Adds a canonical delimiter to raw string formatting.
[clang-format] Adds a canonical delimiter to raw string formatting
Fri, Jan 19, 8:21 AM
krasimir closed D42187: [clang-format] Adds a canonical delimiter to raw string formatting.
Fri, Jan 19, 8:21 AM
krasimir committed rL322954: [clang-format] Fix shortening blocks in macros causing merged next line.
[clang-format] Fix shortening blocks in macros causing merged next line
Fri, Jan 19, 8:14 AM
krasimir committed rC322954: [clang-format] Fix shortening blocks in macros causing merged next line.
[clang-format] Fix shortening blocks in macros causing merged next line
Fri, Jan 19, 8:14 AM
krasimir closed D42298: [clang-format] Fix shortening blocks in macros causing merged next line.
Fri, Jan 19, 8:14 AM
krasimir updated the diff for D42298: [clang-format] Fix shortening blocks in macros causing merged next line.
  • Remove double whitespace
Fri, Jan 19, 6:40 AM
krasimir updated the diff for D42298: [clang-format] Fix shortening blocks in macros causing merged next line.
  • Remove added newline
Fri, Jan 19, 6:36 AM
krasimir created D42298: [clang-format] Fix shortening blocks in macros causing merged next line.
Fri, Jan 19, 6:34 AM
krasimir added inline comments to D42187: [clang-format] Adds a canonical delimiter to raw string formatting.
Fri, Jan 19, 4:22 AM
krasimir updated the diff for D42187: [clang-format] Adds a canonical delimiter to raw string formatting.
  • Add a comment about std::string
Fri, Jan 19, 4:20 AM

Thu, Jan 18

krasimir resigned from D40988: Clang-format: add finer-grained options for putting all arguments on one line.
Thu, Jan 18, 7:32 AM
krasimir added inline comments to D42036: [clang-format] Keep comments aligned to macros.
Thu, Jan 18, 7:25 AM
krasimir requested changes to D41448: Fix counting parameters/arguments for ObjC..
Thu, Jan 18, 7:18 AM
krasimir accepted D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style.
Thu, Jan 18, 7:14 AM

Wed, Jan 17

krasimir committed rC322749: [clang-format] Replace unordered_set with an array.
[clang-format] Replace unordered_set with an array
Wed, Jan 17, 12:03 PM
krasimir committed rL322749: [clang-format] Replace unordered_set with an array.
[clang-format] Replace unordered_set with an array
Wed, Jan 17, 12:03 PM
krasimir closed D42189: [clang-format] Replace unordered_set with an array.
Wed, Jan 17, 12:03 PM
krasimir updated the diff for D42189: [clang-format] Replace unordered_set with an array.
  • Add comment
Wed, Jan 17, 11:31 AM
krasimir updated the diff for D42189: [clang-format] Replace unordered_set with an array.
  • Address review comment
Wed, Jan 17, 11:12 AM
krasimir updated subscribers of D42189: [clang-format] Replace unordered_set with an array.
Wed, Jan 17, 10:50 AM
krasimir created D42189: [clang-format] Replace unordered_set with an array.
Wed, Jan 17, 10:50 AM
krasimir added a reviewer for D42187: [clang-format] Adds a canonical delimiter to raw string formatting: bkramer.
Wed, Jan 17, 10:19 AM
krasimir created D42187: [clang-format] Adds a canonical delimiter to raw string formatting.
Wed, Jan 17, 10:16 AM
krasimir committed rC322678: [clang-format] adds enclosing function detection to raw string formatting.
[clang-format] adds enclosing function detection to raw string formatting
Wed, Jan 17, 8:20 AM
krasimir committed rL322678: [clang-format] adds enclosing function detection to raw string formatting.
[clang-format] adds enclosing function detection to raw string formatting
Wed, Jan 17, 8:20 AM
krasimir closed D42167: [clang-format] adds enclosing function detection to raw string formatting.
Wed, Jan 17, 8:20 AM
krasimir closed D42167: [clang-format] adds enclosing function detection to raw string formatting.
Wed, Jan 17, 8:20 AM
krasimir updated the diff for D42167: [clang-format] adds enclosing function detection to raw string formatting.
  • Format a function
Wed, Jan 17, 7:05 AM
krasimir added a reviewer for D42167: [clang-format] adds enclosing function detection to raw string formatting: bkramer.
Wed, Jan 17, 5:00 AM
krasimir updated the diff for D42167: [clang-format] adds enclosing function detection to raw string formatting.
  • Update comments
Wed, Jan 17, 4:59 AM
krasimir created D42167: [clang-format] adds enclosing function detection to raw string formatting.
Wed, Jan 17, 4:54 AM
krasimir committed rC322634: [clang-format] Reorganize RawStringFormat based on language.
[clang-format] Reorganize RawStringFormat based on language
Wed, Jan 17, 4:27 AM
krasimir committed rL322634: [clang-format] Reorganize RawStringFormat based on language.
[clang-format] Reorganize RawStringFormat based on language
Wed, Jan 17, 4:26 AM
krasimir closed D42098: [clang-format] Reorganize RawStringFormat based on language.
Wed, Jan 17, 4:26 AM

Tue, Jan 16

krasimir updated the diff for D42098: [clang-format] Reorganize RawStringFormat based on language.
  • Update comments
Tue, Jan 16, 3:30 AM
krasimir created D42098: [clang-format] Reorganize RawStringFormat based on language.
Tue, Jan 16, 3:29 AM

Mon, Jan 15

krasimir committed rL322479: [clang-format] Adds a FormatStyleSet.
[clang-format] Adds a FormatStyleSet
Mon, Jan 15, 4:09 AM
krasimir committed rC322479: [clang-format] Adds a FormatStyleSet.
[clang-format] Adds a FormatStyleSet
Mon, Jan 15, 4:09 AM
krasimir closed D41487: [clang-format] Adds a FormatStyleSet.
Mon, Jan 15, 4:09 AM

Mon, Jan 8

krasimir edited reviewers for D41487: [clang-format] Adds a FormatStyleSet, added: bkramer; removed: klimek, djasper.
Mon, Jan 8, 8:54 AM
krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Remove accidentally added file
Mon, Jan 8, 8:02 AM
krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Address review comments
Mon, Jan 8, 8:01 AM
krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Address review comments
Mon, Jan 8, 6:40 AM

Fri, Jan 5

krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Address review comments
Fri, Jan 5, 6:00 AM
krasimir added a comment to D41448: Fix counting parameters/arguments for ObjC..

Can we have tests please?

Fri, Jan 5, 4:42 AM

Dec 21 2017

krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Remove accidentally created file
Dec 21 2017, 7:46 AM
krasimir updated the diff for D41487: [clang-format] Adds a FormatStyleSet.
  • Address review comments
Dec 21 2017, 7:45 AM
krasimir added inline comments to D41487: [clang-format] Adds a FormatStyleSet.
Dec 21 2017, 7:12 AM
krasimir created D41487: [clang-format] Adds a FormatStyleSet.
Dec 21 2017, 5:30 AM

Dec 12 2017

krasimir closed D41108: [clang-format] Improve ObjC headers detection..
Dec 12 2017, 5:46 AM
krasimir added an edge to rL320479: [clang-format] Improve ObjC headers detection.: D41108: [clang-format] Improve ObjC headers detection..
Dec 12 2017, 5:46 AM
krasimir added 1 commit(s) for D41108: [clang-format] Improve ObjC headers detection.: rL320479: [clang-format] Improve ObjC headers detection..
Dec 12 2017, 5:46 AM
krasimir committed rC320479: [clang-format] Improve ObjC headers detection..
[clang-format] Improve ObjC headers detection.
Dec 12 2017, 5:44 AM
krasimir committed rL320479: [clang-format] Improve ObjC headers detection..
[clang-format] Improve ObjC headers detection.
Dec 12 2017, 5:44 AM
krasimir accepted D41108: [clang-format] Improve ObjC headers detection..

Thank you! I'll go ahead and commit this for you!

Dec 12 2017, 5:43 AM

Dec 7 2017

krasimir updated the diff for D40909: [clang-format] Reorganize raw string delimiters.
  • Address review comments
Dec 7 2017, 5:52 AM
krasimir added inline comments to D40909: [clang-format] Reorganize raw string delimiters.
Dec 7 2017, 5:43 AM
krasimir added inline comments to D40909: [clang-format] Reorganize raw string delimiters.
Dec 7 2017, 5:32 AM
krasimir updated the summary of D40909: [clang-format] Reorganize raw string delimiters.
Dec 7 2017, 3:39 AM
krasimir updated the diff for D40909: [clang-format] Reorganize raw string delimiters.
  • Updated documentation
Dec 7 2017, 3:34 AM
krasimir updated the summary of D40832: [clang-format] Adds canonical raw string delimiters support.
Dec 7 2017, 3:09 AM
krasimir updated the diff for D40909: [clang-format] Reorganize raw string delimiters.
  • Added support for enclosing function names
Dec 7 2017, 3:09 AM
krasimir updated the diff for D40909: [clang-format] Reorganize raw string delimiters.
  • Added unsafe canonical delimiter update handling
Dec 7 2017, 2:33 AM

Dec 6 2017

krasimir created D40909: [clang-format] Reorganize raw string delimiters.
Dec 6 2017, 9:34 AM

Dec 5 2017

krasimir updated the diff for D40832: [clang-format] Adds canonical raw string delimiters support.
  • Make 'textproto' the canonical text proto delimiter for google style
Dec 5 2017, 9:35 AM
krasimir added a reviewer for D40832: [clang-format] Adds canonical raw string delimiters support: djasper.
Dec 5 2017, 5:20 AM
krasimir updated the diff for D40832: [clang-format] Adds canonical raw string delimiters support.
  • Update documentation
Dec 5 2017, 5:19 AM
krasimir created D40832: [clang-format] Adds canonical raw string delimiters support.
Dec 5 2017, 5:13 AM

Nov 30 2017

krasimir accepted D40605: Better trade-off for excess characters vs. staying within the column limits..
Nov 30 2017, 9:20 AM
krasimir added inline comments to D40605: Better trade-off for excess characters vs. staying within the column limits..
Nov 30 2017, 9:14 AM
krasimir updated subscribers of D40605: Better trade-off for excess characters vs. staying within the column limits..
Nov 30 2017, 5:34 AM

Nov 29 2017

krasimir accepted D40310: Restructure how we break tokens..

LGTM

Nov 29 2017, 6:06 AM
krasimir added inline comments to D40310: Restructure how we break tokens..
Nov 29 2017, 3:27 AM

Nov 28 2017

krasimir added a comment to D40310: Restructure how we break tokens..

Re: "I tried to write a test for this, and convinced myself that while +1 is correct, it is currently impossible to change behavior based on the missing +1.":
In order to have different outcome based on the start column, you could use tabs. Consider the content "aaa\tb" with 4 spaces of tabstop. This takes up 5 columns (say, under the column limit) if it starts at column 0, and 8 columns (say, over the column limit) if it starts at column 1.

Nov 28 2017, 11:03 AM
krasimir added inline comments to D40310: Restructure how we break tokens..
Nov 28 2017, 10:55 AM
krasimir added inline comments to D40310: Restructure how we break tokens..
Nov 28 2017, 2:53 AM

Nov 27 2017

krasimir committed rL319024: [clang-format] Add option to group multiple #include blocks when sorting….
[clang-format] Add option to group multiple #include blocks when sorting…
Nov 27 2017, 5:25 AM
krasimir closed D40288: [clang-format] Add option to group multiple #include blocks when sorting includes by committing rL319024: [clang-format] Add option to group multiple #include blocks when sorting….
Nov 27 2017, 5:25 AM

Nov 24 2017

krasimir committed rL318960: [clang-format] Deduplicate using declarations.
[clang-format] Deduplicate using declarations
Nov 24 2017, 10:00 AM
krasimir closed D40435: [clang-format] Deduplicate using declarations by committing rL318960: [clang-format] Deduplicate using declarations.
Nov 24 2017, 10:00 AM
krasimir updated the diff for D40435: [clang-format] Deduplicate using declarations.
  • Address review comments
Nov 24 2017, 8:47 AM
krasimir accepted D40288: [clang-format] Add option to group multiple #include blocks when sorting includes.

Thank you! Do you have commit access?

Nov 24 2017, 6:50 AM
krasimir added a comment to D40310: Restructure how we break tokens..

Started the review. It would take a few cycles 💃

Nov 24 2017, 6:43 AM
krasimir added a reviewer for D40435: [clang-format] Deduplicate using declarations: bkramer.
Nov 24 2017, 6:11 AM
krasimir created D40435: [clang-format] Deduplicate using declarations.
Nov 24 2017, 6:10 AM

Nov 23 2017

krasimir added inline comments to D40310: Restructure how we break tokens..
Nov 23 2017, 7:39 AM

Nov 22 2017

krasimir requested changes to D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens..

looks like there are more changes needed.

Nov 22 2017, 3:37 AM
krasimir added a comment to D40310: Restructure how we break tokens..

Here're a few nits. I'll need an evening to review the meaty part :)

Nov 22 2017, 3:28 AM
krasimir added a comment to D40288: [clang-format] Add option to group multiple #include blocks when sorting includes.

Looks good! Just a few nits:

Nov 22 2017, 2:47 AM

Nov 17 2017

krasimir committed rL318525: [clang-format] Add text proto filename detection.
[clang-format] Add text proto filename detection
Nov 17 2017, 7:11 AM
krasimir closed D40120: [clang-format] Add text proto filename detection by committing rL318525: [clang-format] Add text proto filename detection.
Nov 17 2017, 7:10 AM
krasimir accepted D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens..
Nov 17 2017, 3:15 AM
krasimir added inline comments to D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens..
Nov 17 2017, 2:42 AM
krasimir updated the diff for D40120: [clang-format] Add text proto filename detection.
  • Remove METADATA
Nov 17 2017, 2:25 AM

Nov 16 2017

krasimir created D40120: [clang-format] Add text proto filename detection.
Nov 16 2017, 3:40 AM

Nov 15 2017

krasimir added inline comments to D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens..
Nov 15 2017, 3:34 AM

Nov 10 2017

krasimir accepted D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly more orthogonal pieces..

Maybe we should further refactor getRawStringStyle into llvm::Optional<std::pair<style, delimiter>> getRawStringStyleAndDelimiter and that would nicely take care of the duplicated effort?

Nov 10 2017, 8:51 AM
krasimir added inline comments to D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly more orthogonal pieces..
Nov 10 2017, 7:25 AM
krasimir committed rL317886: [clang-format] Support python-style comments in text protos.
[clang-format] Support python-style comments in text protos
Nov 10 2017, 4:50 AM