- User Since
- Oct 11 2016, 5:32 AM (170 w, 4 d)
- Fix typo
- Fix typo
- Address review comments
- Add more tests
Thu, Jan 16
How about if and try? Is there a list somewhere for all such valid identifiers?
Tue, Jan 14
I also am worried that this makes it impossible to just sort includes.
Mon, Jan 13
Sat, Jan 11
Wed, Jan 8
The original code seems ubsan-clean.
Internally, I can see that either (1) this causes the following code to miscompile, or (2) the code is UB:
Note that in that code the two checks on lines 57 and 64 are related if that helps.
Oct 18 2019
Oct 9 2019
Oct 1 2019
Sep 30 2019
Sep 18 2019
This change appears to cause build bot failures under msan:
FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579) ******************** TEST 'LLVM :: DebugInfo/AArch64/asan-stack-vars.mir' FAILED ******************** Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0 -start-before=livedebugvalues -filetype=obj -o - /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump -v - | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir -- Exit Code: 2
Hey! Thank you very much for your investigations!
Sep 17 2019
@samparker : right after r372126 there still seems to be a test failure remaining:
This caused some ASAN tests to start breaking:
Adding @djasper as this is really a re-implementation of https://reviews.llvm.org/D6833.
Agree with @MyDeveloperDay that in general we should aim to document all the known cases where a style doesn't work (with FIXMEs etc.), but not submit failing tests. We can have tests that demonstrate the current (bad) behavior together with a FIXME comment about what is the expected good outcome instead.
Sep 13 2019
This was for experimental purposes, abandoning.
This looks good with the FIXME.
Sep 10 2019
I'll need some more time to investigate the implications of this with respect to Objective-C disambiguation stuff.
Specifically, this may interact with funny ways with the heuristic outlined in (old) UnwrappedLineParser.cpp line 1453:
// In a C++ lambda a template type can only occur after an arrow. We use // this as an heuristic to distinguish between Objective-C expressions // followed by an `a->b` expression, such as: // ([obj func:arg] + a->b)
Aug 26 2019
Aug 23 2019
Aug 8 2019
- Apply review comments
Jul 25 2019
Jul 23 2019
May 10 2019
Sorry for the delay. I'll submit this for you.