krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (36 w, 3 d)

Recent Activity

Today

krasimir added a comment to D34443: DISCUSS investigate multiline <>-message fields in proto options.

do we wanna keep the '<' classify as a template opener or as a dict literal?

Fri, Jun 23, 5:59 AM
krasimir committed rL306094: [clang-format] Add a SortUsingDeclaration option and enable it by default.
[clang-format] Add a SortUsingDeclaration option and enable it by default
Fri, Jun 23, 4:47 AM
krasimir closed D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default. by committing rL306094: [clang-format] Add a SortUsingDeclaration option and enable it by default.
Fri, Jun 23, 4:47 AM
krasimir updated the diff for D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..
  • Enable for llvm style
Fri, Jun 23, 4:44 AM
krasimir committed rL306093: [clang-format] Update dump_format_style.py to indent nested fields.
[clang-format] Update dump_format_style.py to indent nested fields
Fri, Jun 23, 4:30 AM
krasimir closed D34552: [clang-format] Update dump_format_style.py to indent nested fields by committing rL306093: [clang-format] Update dump_format_style.py to indent nested fields.
Fri, Jun 23, 4:30 AM
krasimir created D34552: [clang-format] Update dump_format_style.py to indent nested fields.
Fri, Jun 23, 3:20 AM
krasimir updated the diff for D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..
  • Merge with master
Fri, Jun 23, 1:56 AM
krasimir committed rL306089: [clang-format] Update style documentation, NFC.
[clang-format] Update style documentation, NFC
Fri, Jun 23, 1:48 AM
krasimir closed D34457: [clang-format] Update style documentation, NFC by committing rL306089: [clang-format] Update style documentation, NFC.
Fri, Jun 23, 1:48 AM

Wed, Jun 21

krasimir retitled D34457: [clang-format] Update style documentation, NFC from [clang-format] Update style documentation to [clang-format] Update style documentation, NFC.
Wed, Jun 21, 9:03 AM
krasimir updated the diff for D34457: [clang-format] Update style documentation, NFC.
  • Update style options comments
Wed, Jun 21, 9:00 AM
krasimir created D34457: [clang-format] Update style documentation, NFC.
Wed, Jun 21, 8:54 AM
krasimir updated the diff for D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..
  • Extracted style documentation
Wed, Jun 21, 8:48 AM
krasimir updated the diff for D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..
  • Fix option comments
Wed, Jun 21, 8:36 AM
krasimir created D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..
Wed, Jun 21, 8:29 AM
krasimir committed rL305901: [clang-format] Support sorting using declarations.
[clang-format] Support sorting using declarations
Wed, Jun 21, 5:04 AM
krasimir closed D33823: [clang-format] Support sorting using declarations by committing rL305901: [clang-format] Support sorting using declarations.
Wed, Jun 21, 5:04 AM
krasimir updated the summary of D34443: DISCUSS investigate multiline <>-message fields in proto options.
Wed, Jun 21, 4:52 AM
krasimir created D34443: DISCUSS investigate multiline <>-message fields in proto options.
Wed, Jun 21, 4:51 AM
krasimir added a comment to D34441: [clang-format] Support text proto messages.

Tests for <>-style message fields are missing because I discovered that they don't really work in a multiline setting in proto options anyways. I'll address this problem separately.

Wed, Jun 21, 4:45 AM
krasimir updated the diff for D34441: [clang-format] Support text proto messages.
  • Remove newline
Wed, Jun 21, 4:41 AM
krasimir added a reviewer for D34441: [clang-format] Support text proto messages: djasper.
Wed, Jun 21, 4:39 AM
krasimir created D34441: [clang-format] Support text proto messages.
Wed, Jun 21, 4:35 AM

Mon, Jun 19

krasimir retitled D34351: [clang-format] Simplify TT_SelectorName assignment logic from Simplify TT_SelectorName assignment logic to [clang-format] Simplify TT_SelectorName assignment logic.
Mon, Jun 19, 8:03 AM
krasimir created D34351: [clang-format] Simplify TT_SelectorName assignment logic.
Mon, Jun 19, 8:03 AM
krasimir added inline comments to D33823: [clang-format] Support sorting using declarations.
Mon, Jun 19, 6:06 AM
krasimir updated the diff for D33823: [clang-format] Support sorting using declarations.
  • Update test case
Mon, Jun 19, 6:06 AM
krasimir updated the diff for D33823: [clang-format] Support sorting using declarations.
  • Address review comments
Mon, Jun 19, 6:05 AM

Thu, Jun 15

krasimir committed rL305454: [clangd] Add priority to completion item sort text.
[clangd] Add priority to completion item sort text
Thu, Jun 15, 2:12 AM
krasimir closed D34137: [clangd] Add priority to completion item sort text by committing rL305454: [clangd] Add priority to completion item sort text.
Thu, Jun 15, 2:12 AM · Restricted Project
krasimir removed a reviewer for D33491: clang-format: Fix C99 designated initializers corner cases: krasimir.
Thu, Jun 15, 1:15 AM

Wed, Jun 14

krasimir abandoned D34201: [clangd] Move dependencies of ClangdLSPServer out of its implementation.

On a second thought, meh :D

Wed, Jun 14, 6:35 AM · Restricted Project
krasimir added inline comments to D32480: clang-format: Add CompactNamespaces option.
Wed, Jun 14, 4:37 AM · Restricted Project
krasimir added a comment to D32480: clang-format: Add CompactNamespaces option.

Looks good, except for the tests that actually add or fix namespace end comments should be moved to NamespaceEndCommentsFixerTest.cpp.

Wed, Jun 14, 4:35 AM · Restricted Project
krasimir added a reviewer for D34201: [clangd] Move dependencies of ClangdLSPServer out of its implementation: ilya-biryukov.
Wed, Jun 14, 4:28 AM · Restricted Project
krasimir updated the summary of D34201: [clangd] Move dependencies of ClangdLSPServer out of its implementation.
Wed, Jun 14, 4:28 AM · Restricted Project
krasimir created D34201: [clangd] Move dependencies of ClangdLSPServer out of its implementation.
Wed, Jun 14, 4:25 AM · Restricted Project
krasimir updated the diff for D34137: [clangd] Add priority to completion item sort text.
  • Address review comments
Wed, Jun 14, 4:10 AM · Restricted Project
krasimir added a reviewer for D34137: [clangd] Add priority to completion item sort text: ilya-biryukov.
Wed, Jun 14, 1:43 AM · Restricted Project
krasimir accepted D34151: [clangd] Add a filename parameter to FileSystemProvider..
Wed, Jun 14, 1:42 AM · Restricted Project

Tue, Jun 13

krasimir accepted D34148: [clangd] Store references instead of unique_ptrs in ClangdServer..

But, of course, that can be done in a separate commit.

Tue, Jun 13, 8:22 AM
krasimir added inline comments to D34148: [clangd] Store references instead of unique_ptrs in ClangdServer..
Tue, Jun 13, 8:21 AM
krasimir committed rL305293: [clang-format] Document the StartOfTokenColumn parameter, NFC.
[clang-format] Document the StartOfTokenColumn parameter, NFC
Tue, Jun 13, 7:59 AM
krasimir accepted D34146: [clangd] Allow to override contents of the file during completion..
Tue, Jun 13, 6:53 AM
krasimir added a project to D34137: [clangd] Add priority to completion item sort text: Restricted Project.
Tue, Jun 13, 2:02 AM · Restricted Project
krasimir created D34137: [clangd] Add priority to completion item sort text.
Tue, Jun 13, 2:00 AM · Restricted Project

Mon, Jun 12

krasimir accepted D34107: [clangd] Allow to override contents of the file during completion..
Mon, Jun 12, 1:37 PM
krasimir accepted D34106: [clangd] Use 'std::string' for VFSTag instead of 'int'.
Mon, Jun 12, 12:42 PM · Restricted Project
krasimir added a comment to D33823: [clang-format] Support sorting using declarations.

@klimek: ping

Mon, Jun 12, 7:39 AM

Thu, Jun 8

krasimir committed rL304983: [clangd] extend completion test.
[clangd] extend completion test
Thu, Jun 8, 9:03 AM
krasimir committed rL304981: [clangd] Separate authority less uris from completion tests.
[clangd] Separate authority less uris from completion tests
Thu, Jun 8, 8:22 AM
krasimir committed rL304980: [clangd] Add parameter and return type information to completion results.
[clangd] Add parameter and return type information to completion results
Thu, Jun 8, 8:12 AM
krasimir closed D34033: [clangd] Add parameter and return type information to completion results by committing rL304980: [clangd] Add parameter and return type information to completion results.
Thu, Jun 8, 8:12 AM · Restricted Project
krasimir added inline comments to D34033: [clangd] Add parameter and return type information to completion results.
Thu, Jun 8, 7:48 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Add sortText and filterText
Thu, Jun 8, 7:48 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Remove optional chunks. They might contain control characters
Thu, Jun 8, 7:41 AM · Restricted Project
krasimir added reviewers for D34033: [clangd] Add parameter and return type information to completion results: bkramer, ilya-biryukov.
Thu, Jun 8, 7:07 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Remove newline
Thu, Jun 8, 7:06 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Remove unused method
Thu, Jun 8, 7:05 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Fix indentation
Thu, Jun 8, 7:04 AM · Restricted Project
krasimir updated the summary of D34033: [clangd] Add parameter and return type information to completion results.
Thu, Jun 8, 7:03 AM · Restricted Project
krasimir updated the diff for D34033: [clangd] Add parameter and return type information to completion results.
  • Add a test case
Thu, Jun 8, 7:02 AM · Restricted Project
krasimir created D34033: [clangd] Add parameter and return type information to completion results.
Thu, Jun 8, 6:58 AM · Restricted Project

Wed, Jun 7

krasimir committed rL304912: [clang-format] Fix alignment of preprocessor trailing comments.
[clang-format] Fix alignment of preprocessor trailing comments
Wed, Jun 7, 7:05 AM
krasimir closed D33982: [clang-format] Fix alignment of preprocessor trailing comments by committing rL304912: [clang-format] Fix alignment of preprocessor trailing comments.
Wed, Jun 7, 7:05 AM
krasimir updated the diff for D33982: [clang-format] Fix alignment of preprocessor trailing comments.
  • Address review comments
Wed, Jun 7, 7:04 AM
krasimir abandoned D32901: OLD DRAFT [clang-format] Handle trailing comment sections in import statement lines.
Wed, Jun 7, 5:45 AM
krasimir updated the summary of D33982: [clang-format] Fix alignment of preprocessor trailing comments.
Wed, Jun 7, 4:44 AM
krasimir updated the summary of D33982: [clang-format] Fix alignment of preprocessor trailing comments.
Wed, Jun 7, 4:42 AM
krasimir created D33982: [clang-format] Fix alignment of preprocessor trailing comments.
Wed, Jun 7, 4:37 AM

Sun, Jun 4

krasimir committed rL304687: [clang-format] Don't align too long broken trailing comments.
[clang-format] Don't align too long broken trailing comments
Sun, Jun 4, 12:27 PM
krasimir closed D33830: [clang-format] Don't align too long broken trailing comments by committing rL304687: [clang-format] Don't align too long broken trailing comments.
Sun, Jun 4, 12:27 PM

Fri, Jun 2

krasimir added a reviewer for D33830: [clang-format] Don't align too long broken trailing comments: alexfh.
Fri, Jun 2, 7:44 AM
krasimir created D33830: [clang-format] Don't align too long broken trailing comments.
Fri, Jun 2, 6:55 AM
krasimir added a reviewer for D33823: [clang-format] Support sorting using declarations: djasper.
Fri, Jun 2, 4:37 AM
krasimir updated the diff for D33823: [clang-format] Support sorting using declarations.
  • Fix comments
Fri, Jun 2, 4:35 AM
krasimir created D33823: [clang-format] Support sorting using declarations.
Fri, Jun 2, 3:52 AM

Thu, Jun 1

krasimir added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I think that what you're trying to solve is not practically that important, is unlikely to improve the handling of comments, and will add a lot of complexity.

Thu, Jun 1, 3:55 AM

Fri, May 26

krasimir accepted D33416: [clangd] Allow to use vfs::FileSystem for file accesses..
Fri, May 26, 1:01 AM

May 24 2017

krasimir committed rL303742: [clang-format] Remove unused using directive, NFC.
[clang-format] Remove unused using directive, NFC
May 24 2017, 5:16 AM
krasimir added inline comments to D33416: [clangd] Allow to use vfs::FileSystem for file accesses..
May 24 2017, 2:49 AM

May 23 2017

krasimir committed rL303635: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
[Tooling][libclang] Remove unused CompilationDatabase::MappedSources
May 23 2017, 6:50 AM
krasimir closed D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources by committing rL303635: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.
May 23 2017, 6:50 AM
krasimir accepted D33415: [clangd] Replaced WorkerRequest with std::function....

Looks good.

May 23 2017, 4:59 AM · Restricted Project
krasimir added a comment to D32480: clang-format: Add CompactNamespaces option.

In any case, adding a namespace end comment to a line closing multiple namespaces is super confusing for me: what does the comment refer to: the inner one, the outer one, or both?
}} // namespace A::B

May 23 2017, 4:43 AM · Restricted Project
krasimir added a comment to D32480: clang-format: Add CompactNamespaces option.

This change should also adapt NamespaceEndCommentFixer to respect the new option and not introduce/remove/change the comments unexpectedly.

May 23 2017, 4:39 AM · Restricted Project
krasimir added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

@klimek: ping

May 23 2017, 3:21 AM
krasimir added inline comments to D33415: [clangd] Replaced WorkerRequest with std::function....
May 23 2017, 2:51 AM · Restricted Project
krasimir added inline comments to D33415: [clangd] Replaced WorkerRequest with std::function....
May 23 2017, 2:48 AM · Restricted Project

May 22 2017

krasimir committed rL303547: [clangd] Switch to incomplete translation units.
[clangd] Switch to incomplete translation units
May 22 2017, 5:49 AM
krasimir closed D33350: [clangd] Switch to incomplete translation units by committing rL303547: [clangd] Switch to incomplete translation units.
May 22 2017, 5:49 AM
krasimir accepted D33285: clang-format: do not reflow bullet lists.

Looks great!

May 22 2017, 5:39 AM
krasimir added inline comments to D33395: [clangd] Split clangd into library+executable (mainly for unit tests)..
May 22 2017, 4:57 AM · Restricted Project
krasimir committed rL303541: [clang-format] Keep trailing preprocessor line comments separate from the….
[clang-format] Keep trailing preprocessor line comments separate from the…
May 22 2017, 3:08 AM
krasimir closed D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments by committing rL303541: [clang-format] Keep trailing preprocessor line comments separate from the….
May 22 2017, 3:08 AM
krasimir updated the diff for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
  • Remove parentheses
May 22 2017, 3:06 AM
krasimir added inline comments to D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
May 22 2017, 3:00 AM
krasimir updated the diff for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments.
  • Address review comments
May 22 2017, 3:00 AM
krasimir added a reviewer for D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments: djasper.
May 22 2017, 1:45 AM