Page MenuHomePhabricator

jbcoe (Jonathan B Coe)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2015, 7:00 PM (199 w, 1 d)

Recent Activity

Sep 11 2018

jbcoe committed rL341930: [python bindings] Expose getNumTemplateArguments.
[python bindings] Expose getNumTemplateArguments
Sep 11 2018, 5:48 AM
jbcoe committed rC341930: [python bindings] Expose getNumTemplateArguments.
[python bindings] Expose getNumTemplateArguments
Sep 11 2018, 5:48 AM
jbcoe closed D51299: [python bindings] Expose template argument API for Type.
Sep 11 2018, 5:48 AM
jbcoe closed D51299: [python bindings] Expose template argument API for Type.
Sep 11 2018, 5:48 AM

Sep 9 2018

jbcoe added a comment to D51299: [python bindings] Expose template argument API for Type.

I can commit this. Thanks for the great work!

Sep 9 2018, 5:36 PM

Sep 8 2018

jbcoe accepted D51299: [python bindings] Expose template argument API for Type.
Sep 8 2018, 6:48 PM

Jun 28 2018

jbcoe added a reviewer for D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface: jbcoe.
Jun 28 2018, 2:01 AM

Jun 21 2018

jbcoe committed rC335282: [bindings] Fix most Python binding unittests on Windows.
[bindings] Fix most Python binding unittests on Windows
Jun 21 2018, 1:12 PM
jbcoe committed rL335282: [bindings] Fix most Python binding unittests on Windows.
[bindings] Fix most Python binding unittests on Windows
Jun 21 2018, 1:11 PM
jbcoe closed D47864: [python] Fix most Python binding unittests on Windows.
Jun 21 2018, 1:11 PM
jbcoe added a comment to D47864: [python] Fix most Python binding unittests on Windows.

Would you like me to commit this for you?

Jun 21 2018, 12:05 PM

Jun 7 2018

jbcoe accepted D47864: [python] Fix most Python binding unittests on Windows.
Jun 7 2018, 12:46 PM

May 10 2018

jbcoe committed rL332045: implementing Cursor.get_included_file in python bindings.
implementing Cursor.get_included_file in python bindings
May 10 2018, 2:43 PM
jbcoe committed rC332045: implementing Cursor.get_included_file in python bindings.
implementing Cursor.get_included_file in python bindings
May 10 2018, 2:43 PM
jbcoe closed D46383: implementing Cursor.get_included_file in python bindings.
May 10 2018, 2:43 PM

May 9 2018

jbcoe added a comment to D46383: implementing Cursor.get_included_file in python bindings.

I will try to commit this today.

May 9 2018, 12:10 AM

May 5 2018

jbcoe accepted D46383: implementing Cursor.get_included_file in python bindings.
May 5 2018, 1:50 AM

Apr 24 2018

jbcoe committed rL330772: [clang-tidy] Improve bugprone-unused-return-value check.
[clang-tidy] Improve bugprone-unused-return-value check
Apr 24 2018, 2:28 PM
jbcoe committed rCTE330772: [clang-tidy] Improve bugprone-unused-return-value check.
[clang-tidy] Improve bugprone-unused-return-value check
Apr 24 2018, 2:28 PM
jbcoe closed D45891: [clang-tidy] Improve bugprone-unused-return-value check.
Apr 24 2018, 2:28 PM · Restricted Project
jbcoe added a comment to D45891: [clang-tidy] Improve bugprone-unused-return-value check.

I can merge this for you. Congratulations on the commit!

Apr 24 2018, 11:48 AM · Restricted Project

Apr 23 2018

jbcoe resigned from D45463: [AST] Print correct tag decl for tag specifier.
Apr 23 2018, 7:21 AM

Apr 22 2018

jbcoe committed rC330557: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug….
[python bindings] Fix Cursor.result_type for ObjC method declarations - Bug…
Apr 22 2018, 1:55 PM
jbcoe committed rL330557: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug….
[python bindings] Fix Cursor.result_type for ObjC method declarations - Bug…
Apr 22 2018, 1:55 PM
jbcoe closed D45671: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug 36677.
Apr 22 2018, 1:55 PM
jbcoe added a comment to D45671: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug 36677.

Congrats on your first patch! I can commit this for you.

Apr 22 2018, 1:49 PM

Apr 15 2018

jbcoe accepted D45671: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug 36677.
Apr 15 2018, 11:40 AM

Apr 7 2018

jbcoe accepted D42893: [libclang] Add clang_File_tryGetRealPathName.
Apr 7 2018, 12:31 PM
jbcoe added a comment to D42893: [libclang] Add clang_File_tryGetRealPathName.

Tests for libclang are in clang/unittests/libclang/LibclangTest.cpp

Apr 7 2018, 9:07 AM
jbcoe added a comment to D42893: [libclang] Add clang_File_tryGetRealPathName.

I’ll see if I can find a suitable location for a test.

Apr 7 2018, 12:33 AM

Mar 31 2018

jbcoe requested changes to D42893: [libclang] Add clang_File_tryGetRealPathName.

Can you add some simple tests?

Mar 31 2018, 11:01 AM

Mar 24 2018

jbcoe committed rCTE328418: [clang-tidy] Enable Python 3 support for add_new_check.py.
[clang-tidy] Enable Python 3 support for add_new_check.py
Mar 24 2018, 3:53 AM
jbcoe committed rL328418: [clang-tidy] Enable Python 3 support for add_new_check.py.
[clang-tidy] Enable Python 3 support for add_new_check.py
Mar 24 2018, 3:52 AM
jbcoe closed D44217: [clang-tidy] Enable Python 3 support for add_new_check.py.
Mar 24 2018, 3:52 AM

Mar 8 2018

jbcoe updated the diff for D44217: [clang-tidy] Enable Python 3 support for add_new_check.py.
Mar 8 2018, 1:12 PM

Mar 7 2018

jbcoe created D44217: [clang-tidy] Enable Python 3 support for add_new_check.py.
Mar 7 2018, 10:51 AM

Jan 27 2018

jbcoe resigned from D40481: [libclang] Fix cursors for arguments of Subscript and Call operators.
Jan 27 2018, 2:15 AM
jbcoe removed a reviewer for D40481: [libclang] Fix cursors for arguments of Subscript and Call operators: jbcoe.
Jan 27 2018, 2:15 AM

Jan 23 2018

jbcoe planned changes to D42234: [ADT] Add PropagateConst from LFTS2.
Jan 23 2018, 5:52 AM
jbcoe added a comment to D42234: [ADT] Add PropagateConst from LFTS2.

I'll put another patch together showing how PropagateConst might be used in llvm/clang.

Jan 23 2018, 5:52 AM

Jan 18 2018

jbcoe added a comment to D42234: [ADT] Add PropagateConst from LFTS2.

I was planning on deferring application (some instances of unique_ptr member data) to a follow-up patch. Would you prefer that I conflate them?

Jan 18 2018, 10:42 AM
jbcoe updated the diff for D42234: [ADT] Add PropagateConst from LFTS2.

Fix typo

Jan 18 2018, 10:24 AM
jbcoe created D42234: [ADT] Add PropagateConst from LFTS2.
Jan 18 2018, 2:32 AM

Jan 16 2018

jbcoe accepted D42099: [libclang] Add missing CINDEX_LINKAGE.
Jan 16 2018, 2:28 PM
jbcoe committed rC322540: [libclang] Add PrintingPolicy for pretty printing declarations.
[libclang] Add PrintingPolicy for pretty printing declarations
Jan 16 2018, 2:21 AM
jbcoe committed rL322540: [libclang] Add PrintingPolicy for pretty printing declarations.
[libclang] Add PrintingPolicy for pretty printing declarations
Jan 16 2018, 2:21 AM
jbcoe closed D39903: [libclang] Allow pretty printing declarations.
Jan 16 2018, 2:21 AM

Jan 15 2018

jbcoe added a comment to D39903: [libclang] Allow pretty printing declarations.

I can merge this for you.

Jan 15 2018, 12:36 AM

Jan 14 2018

jbcoe accepted D39903: [libclang] Allow pretty printing declarations.
Jan 14 2018, 11:52 PM

Jan 13 2018

jbcoe added inline comments to D39903: [libclang] Allow pretty printing declarations.
Jan 13 2018, 3:01 AM

Jan 12 2018

jbcoe requested changes to D39903: [libclang] Allow pretty printing declarations.
Jan 12 2018, 5:54 AM
jbcoe added a comment to D39903: [libclang] Allow pretty printing declarations.

Looking good, only a few nits.

Jan 12 2018, 3:24 AM

Jan 11 2018

jbcoe added inline comments to D39903: [libclang] Allow pretty printing declarations.
Jan 11 2018, 1:35 PM
jbcoe added a reviewer for D39903: [libclang] Allow pretty printing declarations: jbcoe.
Jan 11 2018, 8:32 AM
jbcoe removed a reviewer for D39903: [libclang] Allow pretty printing declarations: jbcoe.
Jan 11 2018, 8:31 AM
jbcoe added a comment to D39903: [libclang] Allow pretty printing declarations.

It might be worth adding some very simple get/set tests to ensure that properties are set as intended.

Jan 11 2018, 8:31 AM
jbcoe added inline comments to D39903: [libclang] Allow pretty printing declarations.
Jan 11 2018, 12:29 AM

Nov 21 2017

jbcoe resigned from D39903: [libclang] Allow pretty printing declarations.
Nov 21 2017, 12:22 PM

Nov 5 2017

jbcoe added a comment to D39639: do not use valDecl if it is null.

The test I wrote for D37639 is not great (nor is the code fixed I proposed). A Python-free test would be much better. Lots of the build bots (to the best of my knowledge) don't run Python tests.

Nov 5 2017, 8:39 PM
jbcoe requested changes to D39639: do not use valDecl if it is null.
Nov 5 2017, 12:48 PM
jbcoe added a comment to D39639: do not use valDecl if it is null.

I'm not qualified to review this fix but i think it would be more compelling if accompanied by a test that fails without the fix.

Nov 5 2017, 12:48 PM

Oct 16 2017

jbcoe resigned from D38919: [libcxx] Implemented <experimental/array> from Library Fundamentals V2.
Oct 16 2017, 4:47 PM
jbcoe committed rL315959: [libclang] Add support for querying cursor availability.
[libclang] Add support for querying cursor availability
Oct 16 2017, 4:46 PM
jbcoe closed D36973: [libclang] Add support for querying cursor availability by committing rL315959: [libclang] Add support for querying cursor availability.
Oct 16 2017, 4:46 PM · Restricted Project
jbcoe committed rL315958: [libclang] Visit attributes for function and class templates.
[libclang] Visit attributes for function and class templates
Oct 16 2017, 4:43 PM
jbcoe closed D36955: [libclang] Visit attributes for function and class templates by committing rL315958: [libclang] Visit attributes for function and class templates.
Oct 16 2017, 4:43 PM · Restricted Project

Oct 10 2017

jbcoe accepted D36955: [libclang] Visit attributes for function and class templates.

Would you like me to commit this for you?

Oct 10 2017, 2:23 PM · Restricted Project
jbcoe accepted D36973: [libclang] Add support for querying cursor availability.

Would you like me to commit this for you?

Oct 10 2017, 2:22 PM · Restricted Project

Sep 27 2017

jbcoe added a comment to D37639: Experimental bugfix for Itanium name mangling segfault.

Is there anything I can do to make this patch more useful?

Sep 27 2017, 12:23 AM
jbcoe requested changes to D36955: [libclang] Visit attributes for function and class templates.

Looks great. Please add tests to clang/tools/c-index-test/c-index-test.c too as the Python tests are not run on build-bots (to the best of my knowledge).

Sep 27 2017, 12:21 AM · Restricted Project

Sep 26 2017

jbcoe requested changes to D36973: [libclang] Add support for querying cursor availability.
Sep 26 2017, 3:30 PM · Restricted Project

Sep 25 2017

jbcoe added inline comments to D36973: [libclang] Add support for querying cursor availability.
Sep 25 2017, 8:11 AM · Restricted Project

Sep 21 2017

jbcoe committed rL313913: [libclang] Keep track of TranslationUnit instance when annotating tokens.
[libclang] Keep track of TranslationUnit instance when annotating tokens
Sep 21 2017, 1:50 PM
jbcoe closed D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens by committing rL313913: [libclang] Keep track of TranslationUnit instance when annotating tokens.
Sep 21 2017, 1:50 PM · Restricted Project
jbcoe added a comment to D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens.

Do you need someone to commit this change for you?

Sep 21 2017, 12:32 AM · Restricted Project

Sep 9 2017

jbcoe updated the summary of D37639: Experimental bugfix for Itanium name mangling segfault.
Sep 9 2017, 1:02 AM
jbcoe updated the summary of D37639: Experimental bugfix for Itanium name mangling segfault.
Sep 9 2017, 1:02 AM

Sep 8 2017

jbcoe created D37639: Experimental bugfix for Itanium name mangling segfault.
Sep 8 2017, 12:43 PM
jbcoe abandoned D30896: [Clang-tidy] add check misc-prefer-switch-for-enums.
Sep 8 2017, 12:39 PM · Restricted Project
jbcoe accepted D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens.
Sep 8 2017, 12:39 PM · Restricted Project
jbcoe requested changes to D36973: [libclang] Add support for querying cursor availability.
Sep 8 2017, 12:32 PM · Restricted Project

Sep 6 2017

jbcoe committed rL312622: Fix __repr__ for Diagnostic in clang.cindex.
Fix __repr__ for Diagnostic in clang.cindex
Sep 6 2017, 12:35 AM
jbcoe closed D37490: Fix __repr__ for Diagnostic in clang.cindex by committing rL312622: Fix __repr__ for Diagnostic in clang.cindex.
Sep 6 2017, 12:35 AM · Restricted Project

Sep 5 2017

jbcoe created D37490: Fix __repr__ for Diagnostic in clang.cindex.
Sep 5 2017, 12:50 PM · Restricted Project

Aug 18 2017

jbcoe committed rL311219: Update LLVM 5.0 release notes for clang.cindex changes.
Update LLVM 5.0 release notes for clang.cindex changes
Aug 18 2017, 6:25 PM
jbcoe closed D36902: Update LLVM 5.0 release notes for clang.cindex changes.
Aug 18 2017, 6:25 PM
jbcoe updated the summary of D36902: Update LLVM 5.0 release notes for clang.cindex changes.
Aug 18 2017, 3:19 PM
jbcoe created D36902: Update LLVM 5.0 release notes for clang.cindex changes.
Aug 18 2017, 3:09 PM

Jun 27 2017

jbcoe committed rL306483: [libclang] Support for querying the exception specification type through….
[libclang] Support for querying the exception specification type through…
Jun 27 2017, 3:55 PM
jbcoe closed D34091: Support for querying the exception specification type through libclang by committing rL306483: [libclang] Support for querying the exception specification type through….
Jun 27 2017, 3:55 PM

Jun 26 2017

jbcoe added a comment to D34091: Support for querying the exception specification type through libclang.

I can merge this for you Andrew.

Jun 26 2017, 5:03 PM

Jun 11 2017

jbcoe added a reviewer for D34091: Support for querying the exception specification type through libclang: aaron.ballman.
Jun 11 2017, 3:04 PM

Apr 21 2017

jbcoe accepted D30773: Make git-clang-format python 3 compatible.

LGTM

Apr 21 2017, 2:45 AM

Apr 20 2017

jbcoe committed rL300829: Add Python 3 support to clang.cindex.
Add Python 3 support to clang.cindex
Apr 20 2017, 3:24 AM
jbcoe closed D31568: Add Python 3 support to clang.cindex by committing rL300829: Add Python 3 support to clang.cindex.
Apr 20 2017, 3:24 AM · Restricted Project

Apr 7 2017

jbcoe added a reviewer for D31568: Add Python 3 support to clang.cindex: MathieuDuponchelle.
Apr 7 2017, 4:39 AM · Restricted Project

Apr 4 2017

jbcoe updated the diff for D31568: Add Python 3 support to clang.cindex.

Remove a couple of unnecessary type conversions.

Apr 4 2017, 2:13 PM · Restricted Project
jbcoe added a reviewer for D31568: Add Python 3 support to clang.cindex: modocache.
Apr 4 2017, 2:11 PM · Restricted Project

Apr 1 2017

jbcoe created D31568: Add Python 3 support to clang.cindex.
Apr 1 2017, 5:01 AM · Restricted Project

Mar 30 2017

jbcoe committed rL299071: [clang-tidy] fix docs in hicpp checks.
[clang-tidy] fix docs in hicpp checks
Mar 30 2017, 6:12 AM