Page MenuHomePhabricator
People jbcoe

jbcoe (Jonathan B Coe)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2015, 7:00 PM (422 w, 5 d)

Recent Activity
View All

Sep 14 2022

jbcoe resigned from D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 14 2022, 7:44 AM · Restricted Project, Restricted Project

Dec 15 2021

jbcoe accepted D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty.
Dec 15 2021, 4:43 AM · Restricted Project, Restricted Project

Dec 14 2021

jbcoe added inline comments to D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions .
Dec 14 2021, 2:43 PM · Restricted Project, Restricted Project
jbcoe accepted D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions .
Dec 14 2021, 9:55 AM · Restricted Project, Restricted Project
jbcoe added a reviewer for D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions : jbcoe.
Dec 14 2021, 8:57 AM · Restricted Project, Restricted Project
jbcoe removed reviewers for D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.: jbcoe, MyDeveloperDay.
Dec 14 2021, 8:57 AM · Restricted Project, Restricted Project
jbcoe added a reviewer for D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.: MyDeveloperDay.
Dec 14 2021, 8:54 AM · Restricted Project, Restricted Project
jbcoe added a reviewer for D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.: jbcoe.
Dec 14 2021, 8:54 AM · Restricted Project, Restricted Project

Nov 5 2021

jbcoe accepted D112887: [clang-format] [PR52228] clang-format csharp inconsistant nested namespace indentation.
Nov 5 2021, 4:48 PM · Restricted Project, Restricted Project

Jun 29 2021

jbcoe accepted D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

Some outstanding nits to address but this looks good to me.

Jun 29 2021, 1:13 PM · Restricted Project, Restricted Project

May 28 2021

jbcoe accepted D103307: [clang-format] successive C# attributes cause line breaking issues.

Thanks for this!

May 28 2021, 3:49 AM · Restricted Project, Restricted Project

May 5 2021

jbcoe added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Thanks for this patch!

May 5 2021, 3:52 AM · Restricted Project, Restricted Project

Jul 31 2020

jbcoe accepted D85016: [clang-format] Add space between method modifier and a tuple return type in C#.
Jul 31 2020, 3:34 AM · Restricted Project

Jun 17 2020

jbcoe accepted D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style.

Thanks for this!

Jun 17 2020, 8:36 AM · Restricted Project, Restricted Project

Jun 9 2020

jbcoe created D81467: [clang-format] Microsoft style fixes for C# properties.
Jun 9 2020, 6:33 AM · Restricted Project, Restricted Project

Jun 8 2020

jbcoe updated the diff for D81394: [clang-format] Brace breaking for C# lambdas.

Amend comment - behaviour with addUnwrappedLine is expected and applied fix is fine.

Jun 8 2020, 9:22 AM · Restricted Project, Restricted Project
jbcoe added reviewers for D81394: [clang-format] Brace breaking for C# lambdas: krasimir, MyDeveloperDay.
Jun 8 2020, 8:11 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D81394: [clang-format] Brace breaking for C# lambdas.

Workaround for broken parsing of C# lambdas.

Jun 8 2020, 8:11 AM · Restricted Project, Restricted Project
jbcoe created D81394: [clang-format] Brace breaking for C# lambdas.
Jun 8 2020, 7:37 AM · Restricted Project, Restricted Project
jbcoe planned changes to D81394: [clang-format] Brace breaking for C# lambdas.
Jun 8 2020, 7:37 AM · Restricted Project, Restricted Project

Jun 5 2020

jbcoe created D81255: [clang-format] treat 'lock' as a keyword for C# code.
Jun 5 2020, 5:27 AM · Restricted Project, Restricted Project

Jun 4 2020

jbcoe requested review of D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.
Jun 4 2020, 7:38 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.
Jun 4 2020, 7:38 AM · Restricted Project, Restricted Project

Jun 1 2020

jbcoe added a comment to D80490: [clang-tidy] Check for rule of five and zero..

Perhaps associated is https://github.com/isocpp/CppCoreGuidelines/issues/870 which was closed but never (in my mind) resolved.

Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
jbcoe added a comment to D80490: [clang-tidy] Check for rule of five and zero..

https://reviews.llvm.org/D16376 was written by me, I'm afraid I don't recall why I abandoned it and was surprised to see that it had not been submitted.

Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
jbcoe resigned from D80490: [clang-tidy] Check for rule of five and zero..
Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project

May 15 2020

jbcoe closed D79000: [clang-format] C# property formatting can be controlled by config options.

Submitted as 8fa743ab82027da443bac050e86b70bcdb78cbee

May 15 2020, 6:27 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79000: [clang-format] C# property formatting can be controlled by config options.
May 15 2020, 6:27 AM · Restricted Project, Restricted Project

May 14 2020

jbcoe planned changes to D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.

I will get the Google Style guide uploaded and update this patch with a link.

May 14 2020, 10:16 AM · Restricted Project, Restricted Project

May 11 2020

jbcoe added a comment to D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.

I expect that accepting this patch will need require an update to be made to https://github.com/google/styleguide.

May 11 2020, 7:29 AM · Restricted Project, Restricted Project
jbcoe created D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.
May 11 2020, 6:56 AM · Restricted Project, Restricted Project

May 5 2020

jbcoe created D79414: [clang-format] C# always regards && as a binary operator.
May 5 2020, 6:25 AM · Restricted Project, Restricted Project

May 4 2020

jbcoe abandoned D75194: [clang-format] Do not merge very long C# automatic properties.
May 4 2020, 3:10 AM · Restricted Project, Restricted Project

Apr 29 2020

jbcoe added a comment to D79000: [clang-format] C# property formatting can be controlled by config options.
public int Style2
{ get; set }
Apr 29 2020, 3:43 AM · Restricted Project, Restricted Project

Apr 28 2020

jbcoe added a comment to D79000: [clang-format] C# property formatting can be controlled by config options.

Reverted this commit. Will pick this up tomorrow. Apologies for the noise!

Apr 28 2020, 10:11 AM · Restricted Project, Restricted Project
jbcoe reopened D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 10:11 AM · Restricted Project, Restricted Project
jbcoe added a comment to D79000: [clang-format] C# property formatting can be controlled by config options.

I've just merged this in by mistake. Can revert or amend as we like.

Apr 28 2020, 9:38 AM · Restricted Project, Restricted Project
jbcoe created D79008: [clang-format] insert space after C# keyword var in var (key, value).
Apr 28 2020, 8:01 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:56 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:56 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:56 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:56 AM · Restricted Project, Restricted Project
jbcoe retitled D79000: [clang-format] C# property formatting can be controlled by config options from [clang-format] C# property accessor formatting can be controlled by config options to [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project
jbcoe created D79000: [clang-format] C# property formatting can be controlled by config options.
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D78915: [clang-format] Improved parser for C# properties.

Added missing comments.

Apr 28 2020, 5:51 AM · Restricted Project, Restricted Project

Apr 27 2020

jbcoe updated the diff for D78915: [clang-format] Improved parser for C# properties.

Format patch.

Apr 27 2020, 7:29 AM · Restricted Project, Restricted Project
jbcoe created D78915: [clang-format] Improved parser for C# properties.
Apr 27 2020, 4:15 AM · Restricted Project, Restricted Project
jbcoe accepted D78909: [clang-format] NFC clang-format the clang-format sources.

Thanks!

Apr 27 2020, 4:15 AM · Restricted Project, Restricted Project

Apr 23 2020

jbcoe added inline comments to D78642: [clang-format] Handle C# property accessors when parsing lines.
Apr 23 2020, 10:16 AM · Restricted Project, Restricted Project

Apr 22 2020

jbcoe updated the diff for D78642: [clang-format] Handle C# property accessors when parsing lines.

Format patch

Apr 22 2020, 3:15 PM · Restricted Project, Restricted Project
jbcoe created D78642: [clang-format] Handle C# property accessors when parsing lines.
Apr 22 2020, 8:06 AM · Restricted Project, Restricted Project
jbcoe abandoned D74952: [clang-format] Align chained method invocations for C# code.
Apr 22 2020, 3:44 AM · Restricted Project

Apr 16 2020

jbcoe updated the diff for D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast.

Format patch

Apr 16 2020, 6:43 AM · Restricted Project, Restricted Project
jbcoe created D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast.
Apr 16 2020, 6:10 AM · Restricted Project, Restricted Project

Mar 31 2020

jbcoe updated the diff for D77064: [clang-format] Correct line breaks in C# generic type constraints.

Fix failing test by preventing inconsistent states from being constructed where canBreak is false and mustBreak is true.

Mar 31 2020, 10:33 AM · Restricted Project, Restricted Project

Mar 30 2020

jbcoe created D77064: [clang-format] Correct line breaks in C# generic type constraints.
Mar 30 2020, 8:38 AM · Restricted Project, Restricted Project

Mar 23 2020

jbcoe created D76621: [clang-format] No space inserted between commas in C#.
Mar 23 2020, 9:14 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75760: [clang-format] Do not indent C# array initialisers as continuations.

Rebase and update patch.

Mar 23 2020, 7:36 AM · Restricted Project, Restricted Project
jbcoe created D76597: [clang-format] Reflow long C# generic type constraints correctly.
Mar 23 2020, 4:21 AM · Restricted Project, Restricted Project
jbcoe added a comment to D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers.

That's right David, this typo was fixed in a reverted and re-applied commit: https://reviews.llvm.org/D75856, https://reviews.llvm.org/D75747

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project

Mar 19 2020

jbcoe updated the summary of D76367: [clang-format] Handle C# generic type constraints.
Mar 19 2020, 5:21 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D76367: [clang-format] Handle C# generic type constraints.

Address review comments to move deleted test and remove redundant code.

Mar 19 2020, 5:21 AM · Restricted Project, Restricted Project

Mar 18 2020

jbcoe created D76367: [clang-format] Handle C# generic type constraints.
Mar 18 2020, 8:41 AM · Restricted Project, Restricted Project

Mar 13 2020

jbcoe added inline comments to D75760: [clang-format] Do not indent C# array initialisers as continuations.
Mar 13 2020, 8:01 AM · Restricted Project, Restricted Project

Mar 11 2020

jbcoe updated the diff for D75983: [clang-format] Improved identification of C# nullables.

Fix nits from review.

Mar 11 2020, 6:18 AM · Restricted Project, Restricted Project
jbcoe retitled D75984: [clang-format] No space in `new()` and `this[Type x]` in C# from [clang-format] No space in 'new()' and 'this[Type x]' in C# to [clang-format] No space in `new()` and `this[Type x]` in C#.
Mar 11 2020, 6:17 AM · Restricted Project, Restricted Project
jbcoe updated the summary of D75983: [clang-format] Improved identification of C# nullables.
Mar 11 2020, 6:17 AM · Restricted Project, Restricted Project
jbcoe created D75984: [clang-format] No space in `new()` and `this[Type x]` in C#.
Mar 11 2020, 5:44 AM · Restricted Project, Restricted Project
jbcoe created D75983: [clang-format] Improved identification of C# nullables.
Mar 11 2020, 5:08 AM · Restricted Project, Restricted Project

Mar 9 2020

jbcoe updated the diff for D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers.

Format code.

Mar 9 2020, 10:46 AM · Restricted Project, Restricted Project
jbcoe added inline comments to D75731: [clang-format] C# does not indent braced initializers as continuations.
Mar 9 2020, 10:14 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75856: [clang-format] cleanup from D75517.
Mar 9 2020, 10:13 AM · Restricted Project, Restricted Project
jbcoe created D75856: [clang-format] cleanup from D75517.
Mar 9 2020, 9:41 AM · Restricted Project, Restricted Project

Mar 6 2020

jbcoe created D75760: [clang-format] Do not indent C# array initialisers as continuations.
Mar 6 2020, 10:28 AM · Restricted Project, Restricted Project
jbcoe added a comment to D75760: [clang-format] Do not indent C# array initialisers as continuations.

Needs https://reviews.llvm.org/D75731 and https://reviews.llvm.org/D75747 to be merged first.

Mar 6 2020, 10:28 AM · Restricted Project, Restricted Project
jbcoe created D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers.
Mar 6 2020, 7:41 AM · Restricted Project, Restricted Project
jbcoe added a comment to D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers.

Requires https://reviews.llvm.org/D75731 to be merged first.

Mar 6 2020, 7:41 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75731: [clang-format] C# does not indent braced initializers as continuations.

Remove comma to tidy up ugly format test and actually test what is needed.

Mar 6 2020, 7:09 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75731: [clang-format] C# does not indent braced initializers as continuations.
Mar 6 2020, 6:04 AM · Restricted Project, Restricted Project
jbcoe created D75731: [clang-format] C# does not indent braced initializers as continuations.
Mar 6 2020, 4:24 AM · Restricted Project, Restricted Project

Mar 4 2020

jbcoe updated the diff for D75606: [clang-format] Improve identification of C# nullables.

Remove duplicate check following review comment.

Mar 4 2020, 10:09 AM · Restricted Project, Restricted Project
jbcoe created D75606: [clang-format] Improve identification of C# nullables.
Mar 4 2020, 6:11 AM · Restricted Project, Restricted Project

Mar 3 2020

jbcoe updated the diff for D75473: [clang-format] parse C# object initialisers.

Remove code without test coverage.

Mar 3 2020, 3:00 PM · Restricted Project, Restricted Project
jbcoe planned changes to D75473: [clang-format] parse C# object initialisers.
Mar 3 2020, 3:00 PM · Restricted Project, Restricted Project
jbcoe added inline comments to D75473: [clang-format] parse C# object initialisers.
Mar 3 2020, 3:00 PM · Restricted Project, Restricted Project
jbcoe created D75517: [clang-format] Do not format C# array subscript operators as attributes.
Mar 3 2020, 5:02 AM · Restricted Project, Restricted Project
jbcoe added inline comments to D75465: [clang-format] Do not merge target-name and : for C# attributes.
Mar 3 2020, 2:37 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75465: [clang-format] Do not merge target-name and : for C# attributes.

Do not allow spaces around C# attribute colons.

Mar 3 2020, 2:37 AM · Restricted Project, Restricted Project

Mar 2 2020

jbcoe planned changes to D75194: [clang-format] Do not merge very long C# automatic properties.

I will try to handle this in unwrapped line parser.

Mar 2 2020, 11:36 AM · Restricted Project, Restricted Project
jbcoe created D75473: [clang-format] parse C# object initialisers.
Mar 2 2020, 11:36 AM · Restricted Project, Restricted Project
jbcoe created D75465: [clang-format] Do not merge target-name and : for C# attributes.
Mar 2 2020, 9:29 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test.
Mar 2 2020, 7:24 AM · Restricted Project, Restricted Project
jbcoe created D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test.
Mar 2 2020, 7:14 AM · Restricted Project, Restricted Project
jbcoe created D75455: [clang-format] Allow nested [] in C# attributes.
Mar 2 2020, 6:59 AM · Restricted Project, Restricted Project
jbcoe updated the diff for D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#.

Do not add new punctuators for ??, ?. and ?[

Mar 2 2020, 5:29 AM · Restricted Project, Restricted Project
jbcoe retitled D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C# from [clang-format] Handle ?. ?? and ?[ as C# tokens to [clang-format] Handle NullCoalescing and NullConditional operators in C#.
Mar 2 2020, 5:29 AM · Restricted Project, Restricted Project
jbcoe planned changes to D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#.

Handle ??, ?. and ?[ in lib/Format/FormatTokenLexer.

Mar 2 2020, 3:56 AM · Restricted Project, Restricted Project
jbcoe added a reviewer for D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#: MyDeveloperDay.
Mar 2 2020, 3:00 AM · Restricted Project, Restricted Project

Feb 28 2020

jbcoe updated the diff for D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#.

Fix failing test by parsing tokens after '?[' in the same way as tokens after '['.

Feb 28 2020, 6:12 PM · Restricted Project, Restricted Project
jbcoe planned changes to D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#.

There's a weird test failure I'm unable to reproduce outside of the tests with real source code where

Feb 28 2020, 10:23 AM · Restricted Project, Restricted Project