Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D78576

[SVE] Make VectorType::getNumElements() complain for scalable vectors
ClosedPublic
Actions

Authored by ctetreau on Apr 21 2020, 10:41 AM.

Details

Reviewers
efriedma
sdesmalen
c-rhodes
Commits
rG3d178581ac7f: [SVE] Make VectorType::getNumElements() complain for scalable vectors
Summary

Piggy-back off of TypeSize's STRICT_FIXED_SIZE_VECTORS flag and:

  • if it is defined, assert that the vector is not scalable
  • if it is not defined, complain if the vector is scalable

Diff Detail

Event Timeline

ctetreau created this revision.Apr 21 2020, 10:41 AM
Herald added a reviewer: efriedma. · View Herald TranscriptApr 21 2020, 10:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, psnobl, rkruppe and 2 others. · View Herald Transcript
ctetreau added reviewers: sdesmalen, c-rhodes.Apr 21 2020, 10:43 AM
ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.
Harbormaster failed remote builds in B54125: Diff 259052!Apr 21 2020, 11:21 AM
sdesmalen accepted this revision.Apr 21 2020, 12:46 PM

LGTM

This revision is now accepted and ready to land.Apr 21 2020, 12:46 PM
ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 22 2020, 9:33 AM
ctetreau updated this revision to Diff 259615.Apr 23 2020, 9:46 AM

fix broken tests

Herald added a subscriber: hiraditya. · View Herald TranscriptApr 23 2020, 9:46 AM
Closed by commit rG3d178581ac7f: [SVE] Make VectorType::getNumElements() complain for scalable vectors (authored by ctetreau). · Explain WhyApr 23 2020, 10:48 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B54429: Diff 259615!Apr 23 2020, 11:22 AM
nikic added a subscriber: nikic.Apr 23 2020, 1:47 PM
nikic added inline comments.
llvm/include/llvm/IR/DerivedTypes.h
421

Tiny style nit: This line seems unnecessary, as EC is already a member of VectorType.

Revision Contents
Changeset List

PathSize
llvm/
9 lines
include/
llvm/
IR/
16 lines
lib/
IR/
5 lines
6 lines

Diff 259630

View Options

llvm/CMakeLists.txt

Loading...
View Options

llvm/include/llvm/IR/DerivedTypes.h

Loading...
View Options

llvm/lib/IR/AsmWriter.cpp

Loading...
View Options

llvm/lib/IR/Function.cpp

Loading...