I've tested this patch on macOS and Windows.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
@rnk would you mind taking a look at this for portability concerns. Any idea if there are any problematic/interesting difference in semantics between the concept of PIDs on Windows & Linux, etc?
Comment Actions
lgtm
Looks like it saves a bunch of ifdefs in otherwise platform neutral code, thanks.
llvm/include/llvm/Support/Process.h | ||
---|---|---|
41 | The "legacy interfaces" comment is concerning, but this still seems logical. |
The "legacy interfaces" comment is concerning, but this still seems logical.