This is an archive of the discontinued LLVM Phabricator instance.

Introduce llvm::sys::Process::getProcessId() and adopt it
ClosedPublic

Authored by broadwaylamb on Apr 13 2020, 8:33 AM.

Details

Diff Detail

Event Timeline

broadwaylamb created this revision.Apr 13 2020, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2020, 8:33 AM

LGTM, but it'd be nice to have another one as well

dblaikie added a subscriber: rnk.Apr 13 2020, 12:14 PM

@rnk would you mind taking a look at this for portability concerns. Any idea if there are any problematic/interesting difference in semantics between the concept of PIDs on Windows & Linux, etc?

rnk accepted this revision.Apr 15 2020, 2:26 PM

lgtm

Looks like it saves a bunch of ifdefs in otherwise platform neutral code, thanks.

llvm/include/llvm/Support/Process.h
41

The "legacy interfaces" comment is concerning, but this still seems logical.

This revision is now accepted and ready to land.Apr 15 2020, 2:26 PM
This revision was automatically updated to reflect the committed changes.