[clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

[Abpostelnicu]

Summary

Add option to use alpha checkers from clang-analyzer when using run-clang-tidy.py.
In D46159 has been added the possibility to use alpha checkers from clang-analyzer but this option hasn't reach run-clang-tidy.py, the purpose of this patch is to have this option.

[sylvestre.ledru]

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

[Abpostelnicu]

Add release notes.

[Abpostelnicu]

In D77882#1976216, @sylvestre.ledru wrote:

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

Is it ok just to add this to the clang-tools-extra/docs/ReleaseNotes.rst release notes?

[sylvestre.ledru]

LGTM! thanks

[hans]

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512

Can you take a look?

[Abpostelnicu]

In D77882#2274292, @hans wrote:

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512

Can you take a look?

Are you sure? This has been fixed from august in trunk https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py#L87

[Abpostelnicu]

Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb

[hans]

In D77882#2274570, @Abpostelnicu wrote:

Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb

Great, that was the missing piece :) Thanks!

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

 
 def make_absolute(f, directory):
   if os.path.isabs(f):
     return f
   return os.path.normpath(os.path.join(directory, f))
 
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
-                        header_filter, extra_arg, extra_arg_before, quiet,
-                        config):
+                        header_filter, allow_enabling_alpha_checkers,
+                        extra_arg, extra_arg_before, quiet, config):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary]
+  if allow_enabling_alpha_checkers is not None:
+    start.append('-allow-enabling-analyzer-alpha-checkers')
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
   if checks:
     start.append('-checks=' + checks)
   if tmpdir is not None:
     start.append('-export-fixes')
     # Get a temporary file. We immediately close the handle so clang-tidy can
     # overwrite it.

 
 
 def run_tidy(args, tmpdir, build_path, queue, lock, failed_files):
   """Takes filenames out of queue and runs clang-tidy on them."""
   while True:
     name = queue.get()
     invocation = get_tidy_invocation(name, args.clang_tidy_binary, args.checks,
                                      tmpdir, build_path, args.header_filter,
+                                     args.allow_enabling_alpha_checkers,
                                      args.extra_arg, args.extra_arg_before,
                                      args.quiet, args.config)
 
     proc = subprocess.Popen(invocation, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     output, err = proc.communicate()
     if proc.returncode != 0:
       failed_files.append(name)
     with lock:
       sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8'))
       if len(err) > 0:
         sys.stdout.flush()
         sys.stderr.write(err.decode('utf-8'))
     queue.task_done()
 
 
 def main():
   parser = argparse.ArgumentParser(description='Runs clang-tidy over all files '
                                    'in a compilation database. Requires '
                                    'clang-tidy and clang-apply-replacements in '
                                    '$PATH.')
+  parser.add_argument('-allow-enabling-alpha-checkers',
+                      action='store_true', help='allow alpha checkers from '
+                                                'clang-analyzer.')
   parser.add_argument('-clang-tidy-binary', metavar='PATH',
                       default='clang-tidy',
                       help='path to clang-tidy binary')
   parser.add_argument('-clang-apply-replacements-binary', metavar='PATH',
                       default='clang-apply-replacements',
                       help='path to clang-apply-replacements binary')
   parser.add_argument('-checks', default=None,
                       help='checks filter, when not specified, use clang-tidy '
def main():
   if args.build_path is not None:
     build_path = args.build_path
   else:
     # Find our database
     build_path = find_compilation_database(db_path)
 
   try:
     invocation = [args.clang_tidy_binary, '-list-checks']
+    if args.allow_enabling_alpha_checkers:
+      invocation.append('-allow-enabling-analyzer-alpha-checkers')
     invocation.append('-p=' + build_path)
     if args.checks:
       invocation.append('-checks=' + args.checks)
     invocation.append('-')
     if args.quiet:
       # Even with -quiet we still want to check if we can call clang-tidy.
       with open(os.devnull, 'w') as dev_null:
         subprocess.check_call(invocation, stdout=dev_null)