Page MenuHomePhabricator

[AMDGPU] Expand vector trunc stores from i16 to i8
ClosedPublic

Authored by rampitec on Apr 7 2020, 4:44 PM.

Diff Detail

Event Timeline

rampitec created this revision.Apr 7 2020, 4:44 PM
arsenm added a comment.Apr 7 2020, 4:46 PM

Can merge with the existing store tests

Can merge with the existing store tests

Which file do you prefer?

Can merge with the existing store tests

Which file do you prefer?

In fact that was long annoying me, we have many tests with zillions of functions. When I need to debug I first have to find which function has failed, then extract it.

I understand that we do not want to have a billion of files, but really a number of failures does not tell much anymore and a four or even five digit line number within a test usually discourages.

I know it is not only me, after all that is why we have all that update* scripts. Then we update a huge test and I refuse to believe everybody really looks to all the changes. We are saving on forks, but we are loosing in test quality I suppose.

arsenm accepted this revision.Apr 7 2020, 7:44 PM

Can merge with the existing store tests

Which file do you prefer?

Can merge with the existing store tests

Which file do you prefer?

In fact that was long annoying me, we have many tests with zillions of functions. When I need to debug I first have to find which function has failed, then extract it.

I understand that we do not want to have a billion of files, but really a number of failures does not tell much anymore and a four or even five digit line number within a test usually discourages.

I know it is not only me, after all that is why we have all that update* scripts. Then we update a huge test and I refuse to believe everybody really looks to all the changes. We are saving on forks, but we are loosing in test quality I suppose.

Some of the older tests, like load and store, are not consistent enough. Ideally we would have tests for all of the types of loads for every address space (possibly generated)

This revision is now accepted and ready to land.Apr 7 2020, 7:44 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2020, 9:48 PM