This is an archive of the discontinued LLVM Phabricator instance.

Differential D77546

[test][llvm-objcopy] Make test robust against "foo" being in user's path
ClosedPublic

Authored by jhenderson on Apr 6 2020, 6:05 AM.

Details

Reviewers
thakis
grimar
MaskRay
• espindola
alexander-shaposhnikov
rupprecht
Commits
rGccf16c4d381d: Make test more robust
Summary

This was requested in a comment against D61727.

Diff Detail

Event Timeline

jhenderson created this revision.Apr 6 2020, 6:05 AM
Herald added a reviewer: • espindola. · View Herald TranscriptApr 6 2020, 6:05 AM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: abrachet, emaste. · View Herald Transcript
jhenderson mentioned this in D61727: [llvm-objcopy] Add additional testing for various cases.Apr 6 2020, 6:10 AM
grimar accepted this revision.Apr 6 2020, 6:29 AM

LGTM. I saw the same approach used for issues like this already, so I believe it is OK.

This revision is now accepted and ready to land.Apr 6 2020, 6:29 AM
Harbormaster completed remote builds in B51928: Diff 255307.Apr 6 2020, 7:00 AM
Closed by commit rGccf16c4d381d: Make test more robust (authored by jhenderson). · Explain WhyApr 6 2020, 7:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
2 lines

Diff 255307

llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
# SECTION-REMOVE: Sections [ # SECTION-REMOVE: Sections [
# SECTION-REMOVE: Name: .strtab ( # SECTION-REMOVE: Name: .strtab (
# SECTION-REMOVE: Symbols [ # SECTION-REMOVE: Symbols [
# SECTION-REMOVE: Name: foo ( # SECTION-REMOVE: Name: foo (
## Case 5: removing a symbol. ## Case 5: removing a symbol.
# RUN: llvm-objcopy %t.o %t.remove-symbol -N foo # RUN: llvm-objcopy %t.o %t.remove-symbol -N foo
# RUN: llvm-readobj --section-headers --symbols %t.remove-symbol \ # RUN: llvm-readobj --section-headers --symbols %t.remove-symbol \
# RUN: | FileCheck %s --check-prefix=SYMBOL-REMOVE --implicit-check-not=.shstrtab --implicit-check-not=foo # RUN: | FileCheck %s --check-prefix=SYMBOL-REMOVE --implicit-check-not=.shstrtab --implicit-check-not="Name: foo"
# SYMBOL-REMOVE: Sections [ # SYMBOL-REMOVE: Sections [
# SYMBOL-REMOVE: Name: .foo ( # SYMBOL-REMOVE: Name: .foo (
# SYMBOL-REMOVE: Name: .strtab ( # SYMBOL-REMOVE: Name: .strtab (
# SYMBOL-REMOVE: Symbols [ # SYMBOL-REMOVE: Symbols [
## Case 6: adding a section. ## Case 6: adding a section.
# RUN: llvm-objcopy %t.o %t.add-section --add-section .bar=%s # RUN: llvm-objcopy %t.o %t.add-section --add-section .bar=%s
Show All 35 Lines