This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove maximum vector length limit from combineBasicSADPattern.
ClosedPublic

Authored by craig.topper on Mar 21 2020, 6:16 PM.

Details

Summary

createPSADBW uses SplitsOpsAndApply so should be able to handle
any size.

Restrict the extract result type to i32 or i64 since that's what
we have coverage for today and probably matches what the
isSimple() check gave us before.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 21 2020, 6:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2020, 6:16 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
RKSimon accepted this revision.Mar 22 2020, 11:37 AM

LGTM

llvm/lib/Target/X86/X86ISelLowering.cpp
37836

clang-format

This revision is now accepted and ready to land.Mar 22 2020, 11:37 AM
This revision was automatically updated to reflect the committed changes.