Details
Diff Detail
Event Timeline
@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.
That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface and did everything like before where commit information was available. "Author: Marius Brehler <marius.brehler@iml.fraunhofer.de>" would be great!
This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)
Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.
And I will use arc next time ;) Thank you very much for commiting my changes and taking care!