This patch adds PCRelative support for global addresses that may not be known at link time and may require access through the GOT.
nemanjai lei hfinkel
- Group Reviewers
- rGb771c4a842d6: [PowerPC][Future] More support for PCRel addressing for global values
Approving this even though there is a problem with the logic in SelectAddressPCRel() as I trust that you will fix the obvious bug when committing this.
Won't this always evaluate to true if ConstPoolNode is not null? Perhaps this should have been bitwise-and?
Similarly to the previous patch, this needs to be removed from the AIX block.
This one and the above conditions, I guess you mistakenly did bitwise OR instead of AND.
Sorry I missed that git clang-format changed whitespace on unrelated lines.
Pulling out simply because of this seems like unnecessary churn for the bots
especially since the formatting is an improvement.
If someone would like me to pull it, I certainly don't mind.
I will definitely be more vigilant next time.
I commented on the commit b771c4a8, FYI