Page MenuHomePhabricator

anil9 (Anil Mahmud)
User

Projects

User does not belong to any projects.

User Details

User Since
May 8 2019, 4:03 AM (72 w, 3 d)

Recent Activity

Jul 6 2020

anil9 added inline comments to D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..
Jul 6 2020, 1:53 PM · Restricted Project

Jul 2 2020

anil9 added inline comments to D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation.
Jul 2 2020, 6:53 PM · Restricted Project

Jul 1 2020

anil9 accepted D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

LGTM

Jul 1 2020, 12:59 PM · Restricted Project
anil9 added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 12:26 PM · Restricted Project
anil9 added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 10:49 AM · Restricted Project

Jun 25 2020

anil9 added inline comments to D82584: [PowerPC][Power10] Exploit the High Order Vector Multiply Instructions on Power10.
Jun 25 2020, 4:56 PM · Restricted Project, Restricted Project
anil9 added inline comments to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Jun 25 2020, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
anil9 added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jun 25 2020, 4:23 PM · Restricted Project, Restricted Project, Restricted Project

Jun 11 2020

anil9 added inline comments to D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang.
Jun 11 2020, 11:25 PM · Restricted Project, Restricted Project, Restricted Project

Jun 9 2020

anil9 added inline comments to D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.
Jun 9 2020, 12:31 AM · Restricted Project

Jun 8 2020

anil9 added inline comments to D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.
Jun 8 2020, 11:57 PM · Restricted Project
anil9 added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jun 8 2020, 11:25 PM · Restricted Project

Jun 2 2020

anil9 added inline comments to D80151: [PowerPC] Fix pattern for DCBFL/DCBFLP instrinsics..
Jun 2 2020, 4:24 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2020

anil9 added a comment to D79868: [DebugInfo] Correct debuginfo for post-ra hoist and sink in Machine LICM.
May 26 2020, 6:00 PM · Restricted Project

May 18 2020

anil9 created D80151: [PowerPC] Fix pattern for DCBFL/DCBFLP instrinsics..
May 18 2020, 1:00 PM · Restricted Project, Restricted Project, Restricted Project

May 14 2020

anil9 added a comment to rG4532a50899b1: Infer alignment of unmarked loads in IR/bitcode parsing..

This changeset is causing this buildbot to fail : clang-ppc64le-linux-multistage

May 14 2020, 7:03 PM

May 5 2020

anil9 updated the diff for D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

Condensed the test case.

May 5 2020, 11:20 AM · Restricted Project
anil9 added inline comments to D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.
May 5 2020, 4:16 AM · Restricted Project
anil9 updated the diff for D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

Simplified the mir file.

May 5 2020, 3:11 AM · Restricted Project
anil9 added inline comments to D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.
May 5 2020, 3:11 AM · Restricted Project
anil9 retitled D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables from Remove extra instruction left by emitRLDICWhenLoweringJumpTables to [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.
May 5 2020, 3:11 AM · Restricted Project
anil9 set the repository for D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables to rG LLVM Github Monorepo.
May 5 2020, 3:11 AM · Restricted Project

Apr 23 2020

anil9 added a comment to D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

The error would be something like this

 %4:g8rc = RLDICL killed %16:g8rc, 0, 32
 %26:g8rc_and_g8rc_nox0 = RLDIC %16:g8rc, 2, 30

*** Bad machine code: Using a killed virtual register ***
- function:    fn1
- basic block: %bb.1 if.then (0x1000a68f270)
- instruction: %26:g8rc_and_g8rc_nox0 = RLDIC %16:g8rc, 2, 30
- operand 1:   %16:g8rc
fatal error: error in backend: Found 1 machine code errors.

Providing a mir test case would be better.

Apr 23 2020, 6:59 AM · Restricted Project
anil9 updated the diff for D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

Replaced the .ll test case with a .mir test case to be able to see the effect of removing SrcMI more clearly.

Apr 23 2020, 6:59 AM · Restricted Project

Apr 21 2020

anil9 updated the diff for D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

Removed the check for !SrcMI->hasImplicitDef() in emitRLDICWhenLoweringJumpTables before deleting SrcMI, since at this stage we do not expect Implicit defs by SrcMI

Apr 21 2020, 11:57 PM · Restricted Project
anil9 added inline comments to D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.
Apr 21 2020, 10:40 PM · Restricted Project
anil9 added a comment to D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.

Could you pre-commit the test case as an NFC patch so that we can see the difference?

Apr 21 2020, 10:47 AM · Restricted Project

Apr 20 2020

anil9 added inline comments to D78272: [DAGCombiner] Combine shifts into multiply-high .
Apr 20 2020, 9:40 PM · Restricted Project
anil9 added inline comments to D78517: [PowerPC][Future] Remove "unskipableSimplifyCode()" in PPCMIPeephole.cpp.
Apr 20 2020, 9:40 PM · Restricted Project

Apr 19 2020

anil9 added inline comments to D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code.
Apr 19 2020, 7:12 PM · Restricted Project

Apr 13 2020

anil9 created D78063: [PowerPC] Remove extra instruction left by emitRLDICWhenLoweringJumpTables.
Apr 13 2020, 4:20 PM · Restricted Project

Apr 4 2020

anil9 added inline comments to D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Apr 4 2020, 7:42 PM · Restricted Project
anil9 added inline comments to D75931: [PowerPC][Future] Add initial support for PC Relative addressing to get jump table base address.
Apr 4 2020, 7:42 PM · Restricted Project

Apr 2 2020

anil9 added inline comments to D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.
Apr 2 2020, 2:06 PM · Restricted Project

Mar 25 2020

anil9 added inline comments to D76064: [PowerPC][Future] Add initial support for PC Relative addressing for global values that require GOT indirect addressing.
Mar 25 2020, 10:43 PM · Restricted Project
anil9 added inline comments to D76160: [PowerPC][Future] Add offsets to PC Relative relocations. .
Mar 25 2020, 10:43 PM · Restricted Project
anil9 added inline comments to D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Mar 25 2020, 9:07 PM · Restricted Project

Mar 4 2020

anil9 added inline comments to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Mar 4 2020, 6:31 PM · Restricted Project, Restricted Project

Mar 3 2020

anil9 added inline comments to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Mar 3 2020, 1:47 PM · Restricted Project, Restricted Project
anil9 added inline comments to D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.
Mar 3 2020, 6:03 AM · Restricted Project

Jan 30 2020

anil9 updated the diff for D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.

Added an offset to a pointer in one of the tests, for added coverage.

Jan 30 2020, 12:10 PM · Restricted Project

Jan 23 2020

anil9 updated the diff for D69066: Add support for intrinsic llvm.ppc.eieio.

Added test case.

Jan 23 2020, 1:24 PM · Restricted Project

Jan 10 2020

anil9 updated the diff for D69066: Add support for intrinsic llvm.ppc.eieio.

Addressed review comment. [NFC]

Jan 10 2020, 11:46 AM · Restricted Project

Jan 7 2020

anil9 added inline comments to D69066: Add support for intrinsic llvm.ppc.eieio.
Jan 7 2020, 11:21 AM · Restricted Project
anil9 updated the diff for D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.

Integrated the test cases dcbfl.ll and dcbflp.ll in the previous differential to the previously existing test case dcbf.ll

Jan 7 2020, 10:52 AM · Restricted Project

Dec 17 2019

anil9 updated the diff for D71481: [PowerPC][NFC] Refactor splat of constant to vector..

Addressed review comments : Added a comment.

Dec 17 2019, 1:05 PM · Restricted Project

Dec 13 2019

anil9 created D71481: [PowerPC][NFC] Refactor splat of constant to vector..
Dec 13 2019, 10:33 AM · Restricted Project

Nov 24 2019

anil9 added a comment to rG29f6f9b2b2bf: [PowerPC] combine rlwinm+rlwinm to rlwinm combine x3 = rlwinm x3, 27, 5, 31 x3….

It seems it needs a big endian machine to fail as all the little endian machines seem to be unaffected. And also it will fail in stage 2 not stage 1 as shown in the link.

Nov 24 2019, 7:03 PM

Nov 23 2019

anil9 added a comment to rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy.

It is breaking buildbots other than the sanitizer one too.

Nov 23 2019, 10:12 AM

Nov 22 2019

anil9 added a comment to rG29f6f9b2b2bf: [PowerPC] combine rlwinm+rlwinm to rlwinm combine x3 = rlwinm x3, 27, 5, 31 x3….

This change set is breaking the buildbot :

Nov 22 2019, 10:43 PM
anil9 added a comment to rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy.

This changeset is breaking this buildbot :

Nov 22 2019, 5:37 PM

Nov 19 2019

anil9 added a comment to rG58ea00b51fe9: [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline..

This changeset is breaking the buildbot clang-ppc64le-linux (http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/28006/steps/ninja%20check%201/logs/stdio)

Nov 19 2019, 12:10 AM

Nov 18 2019

anil9 added a comment to rGae31c7299ba6: DwarfGenerator - fix uninitialized variable warnings. NFC..

This changeset is breaking this buildbot

Nov 18 2019, 9:20 AM

Nov 16 2019

anil9 added a comment to rG72768685567b: [MirNamer][Canonicalizer]: Perform instruction semantic based renaming.

This changeset is causing failures in multiple buildbots

Nov 16 2019, 10:34 PM
anil9 added a comment to rG08ea1ee2db5f: [NFC] Refactor representation of materialized temporaries.

This changeset is causing this failure in multiple buildbots

Nov 16 2019, 10:21 PM

Nov 11 2019

anil9 added a comment to rG1984a27db58e: [DBG][OPT] Attempt to salvage or undef debug info when removing trivially….

This changeset is causing a buildbot failure :

Nov 11 2019, 6:42 AM

Oct 31 2019

anil9 added inline comments to D69066: Add support for intrinsic llvm.ppc.eieio.
Oct 31 2019, 8:00 AM · Restricted Project

Oct 28 2019

anil9 added a comment to D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
In D68411#1718116, @lei wrote:

Since these are just mnemonics for using dcbf, why not just add the tests to llvm/test/CodeGen/PowerPC/dcbf.ll instead of creating 2 small test files.

Oct 28 2019, 12:00 AM · Restricted Project

Oct 22 2019

anil9 updated the summary of D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
Oct 22 2019, 10:49 AM · Restricted Project
anil9 updated the summary of D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
Oct 22 2019, 10:31 AM · Restricted Project
anil9 updated the summary of D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
Oct 22 2019, 10:31 AM · Restricted Project

Oct 16 2019

anil9 created D69066: Add support for intrinsic llvm.ppc.eieio.
Oct 16 2019, 12:59 PM · Restricted Project

Oct 3 2019

anil9 created D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
Oct 3 2019, 11:41 AM · Restricted Project

Jun 1 2019

anil9 added a comment to rL361830: Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the sections….

Your changeset is causing at least some of the stage2 failures in the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test?numbuilds=300
http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/3951/steps/build-stage2-unified-tree/logs/stdio
Please upload a fix for it or pull back your changeset.
Thanks.

Jun 1 2019, 12:02 AM

May 30 2019

anil9 added a comment to rL362112: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on….

Your changeset is causing a failure in the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/3845

May 30 2019, 11:16 AM

May 28 2019

anil9 added a comment to rL361912: [X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to.

It seems your changeset broke this buildbot . There are other prior failures but it seems your changeset introduced some new failures, listed below.
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt?numbuilds=100
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/27772

May 28 2019, 8:24 PM
anil9 added a comment to rL361907: Revise the google-objc-global-variable-declaration check to match the style….

I think your changeset caused a failure in this buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio

May 28 2019, 8:04 PM

May 24 2019

anil9 added a comment to rL361355: [PPC64] Parse -elfv1 -elfv2 when specified on target triple.

Regarding my last comment about the possibility of your changesets causing stage 2 failures, the failures are not from your changeset. The author of rL361356 confirmed they are from his changeset.

May 24 2019, 7:41 AM
anil9 added a comment to rL361356: [MIR] Add simple PRE pass to MachineCSE.

Hi @anil9 . Yes, you are right -- it's my change being causing the stage 2 failure. I'm working on fix. Should I revert it meanwhile?

May 24 2019, 7:33 AM

May 23 2019

anil9 added a comment to rL361567: Break false dependencies on target libraries.

Hello , your changeset is causing this buildbot to fail.

May 23 2019, 6:23 PM
anil9 added a comment to rL361355: [PPC64] Parse -elfv1 -elfv2 when specified on target triple.

Your changeset might be causing failures on this buildbot http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage?numbuilds=100
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/18248
Most of the stage 2 changes are still failing consistently, could you please, take a look.
Given the machine is going for a planned outage on Friday I may not be able to sort the exact cause so I am letting you earlier.
Thanks.

May 23 2019, 2:34 PM
anil9 added a comment to rL361356: [MIR] Add simple PRE pass to MachineCSE.

Your changeset might be causing failures on this buildbot http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage?numbuilds=100
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/18248
Most of the stage 2 changes are still failing consistently, could you please, take a look.
Given the machine is going for a planned outage on Friday I may not be able to sort the exact cause so I am letting you earlier.
Thanks.

May 23 2019, 2:30 PM

May 22 2019

anil9 added a comment to rL361252: [clangd] Add tweak to convert normal to raw string literal, when it contains….

Hello, your patch seems to be causing a failure in the following buildbot.

May 22 2019, 5:31 PM
anil9 added a comment to rL361251: [DebugInfo] Fix tests missed by r362148.

I am Anil, the current buildbot maintainer. Your change set ( gen-dwarf-cpp.s, line 19) has broken this buildbot. http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9819

May 22 2019, 7:42 AM