RDF is designed to be target agnostic. Therefore it would be useful to have it available for other targets, such as X86.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM other than the question about the functionality change.
llvm/lib/CodeGen/RDFGraph.cpp | ||
---|---|---|
756 | Thanks for this patch! Qq, is this some functionality change? Why does the refactor require this update? |
llvm/lib/CodeGen/RDFGraph.cpp | ||
---|---|---|
756 | The original RDF implementation didn't need to handle Windows targets. The TLI::getExceptionSelectionRegister() method has an assertion testing that it is not called for Windows EH personality functions. There is no exception selector register on Windows. |