Page MenuHomePhabricator

Move RDF from Hexagon to Codegen [1/6]
ClosedPublic

Authored by sconstab on Tue, Mar 10, 9:49 AM.

Details

Summary

RDF is designed to be target agnostic. Therefore it would be useful to have it available for other targets, such as X86.

Diff Detail

Event Timeline

sconstab created this revision.Tue, Mar 10, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 10, 9:49 AM

LGTM other than the question about the functionality change.

llvm/lib/CodeGen/RDFGraph.cpp
756–759

Thanks for this patch! Qq, is this some functionality change? Why does the refactor require this update?

llvm/lib/CodeGen/RDFGraph.cpp
756–759

The original RDF implementation didn't need to handle Windows targets. The TLI::getExceptionSelectionRegister() method has an assertion testing that it is not called for Windows EH personality functions. There is no exception selector register on Windows.

Jim added a subscriber: Jim.Tue, Mar 10, 10:33 PM

This obviously looks great to me, but I'll let someone else give the final approval.

sconstab retitled this revision from Move RDF from Hexagon to Codegen to Move RDF from Hexagon to Codegen [1/5].Wed, Mar 11, 12:35 PM
sconstab retitled this revision from Move RDF from Hexagon to Codegen [1/5] to Move RDF from Hexagon to Codegen [1/6].Mon, Mar 16, 9:28 AM
kparzysz accepted this revision.Mon, Mar 16, 10:00 AM

It looks like @zbrid has already LGTMd this.

This revision is now accepted and ready to land.Mon, Mar 16, 10:00 AM
This revision was automatically updated to reflect the committed changes.