This is an archive of the discontinued LLVM Phabricator instance.

Differential D75826

[NFC] Add lexicon definition for PHI node.
AbandonedPublic

Authored by xgupta on Mar 8 2020, 9:37 AM.

Details

Reviewers
silvas
ftynse
Summary

Made a new entry for PHI node in LLVM lexicons.

Diff Detail

Event Timeline

xgupta created this revision.Mar 8 2020, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2020, 9:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
xgupta updated this revision to Diff 249005.Mar 8 2020, 9:44 AM

Correct the formatting of change.

xgupta updated this revision to Diff 249006.Mar 8 2020, 9:49 AM

Correct the link syntax for rst language.

SouraVX added a subscriber: SouraVX.Mar 8 2020, 10:14 AM

Since it's not a code level change, perhaps adding [NFCI] or [NFC] label to summary of change would help/facilitate reviewers in review process.

xgupta added a comment.Mar 8 2020, 10:44 AM
In D75826#1911729, @SouraVX wrote:

Since it's not a code level change, perhaps adding [NFCI] or [NFC] label to summary of change would help/facilitate reviewers in review process.

Thanks, I will remember from the next time.

Harbormaster completed remote builds in B48497: Diff 249005.Mar 8 2020, 11:12 AM
Harbormaster completed remote builds in B48498: Diff 249006.Mar 8 2020, 11:44 AM
Harbormaster completed remote builds in B48495: Diff 249003.
xgupta retitled this revision from Add lexicon definition for PHI node. to [NFC] Add lexicon definition for PHI node..Mar 8 2020, 12:27 PM
xgupta edited reviewers, added: ftynse; removed: hubert.reinterpretcast.Mar 11 2020, 9:47 AM
xgupta removed a subscriber: llvm-commits.
xgupta added a comment.Mar 11 2020, 10:40 PM

Does someone commit these changes who have commit right

ftynse added inline comments.Mar 16 2020, 9:54 AM
llvm/docs/Lexicon.rst
210

Could you rather explain it with more words (if necessary) instead of linking to a non-LLVM project that looks mostly dead?

silvas resigned from this revision.Mar 25 2020, 6:26 PM
ftynse resigned from this revision.Apr 16 2020, 1:21 AM

This looks dead.

xgupta abandoned this revision.Aug 30 2020, 8:47 AM
Herald added a subscriber: danielkiss. · View Herald TranscriptAug 30 2020, 8:47 AM

Revision Contents

PathSize
llvm/
docs/
3 lines

Diff 249006

llvm/docs/Lexicon.rst

Show First 20 Lines • Show All 200 Lines • ▼ Show 20 Lines
**Object Pointer** **Object Pointer**
A pointer to an object such that the garbage collector is able to trace A pointer to an object such that the garbage collector is able to trace
references contained within the object. This term is used in opposition to references contained within the object. This term is used in opposition to
`derived pointer`_. `derived pointer`_.
P P
- -
**PHI**
`PHI <http://www.llvmpy.org/llvmpy-doc/dev/doc/llvm_concepts.html#ssa-form-and-phi-nodes>`_ node is the consequence of single assignment form in LLVM IR whose values depend on the operand corresponding to their dynamic predecessor basic block.
ftynseUnsubmitted
Not Done
ReplyInline Actions

Could you rather explain it with more words (if necessary) instead of linking to a non-LLVM project that looks mostly dead?

ftynse: Could you rather explain it with more words (if necessary) instead of linking to a non-LLVM…
**PR** **PR**
Problem report. A bug filed on `the LLVM Bug Tracking System Problem report. A bug filed on `the LLVM Bug Tracking System
<https://bugs.llvm.org/enter_bug.cgi>`_. <https://bugs.llvm.org/enter_bug.cgi>`_.
**PRE** **PRE**
Partial Redundancy Elimination Partial Redundancy Elimination
R R
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines