Page MenuHomePhabricator

[NFC] Add lexicon definition for PHI node.
Needs ReviewPublic

Authored by xgupta on Mar 8 2020, 9:37 AM.

Details

Reviewers
silvas
ftynse
Summary

Made a new entry for PHI node in LLVM lexicons.

Diff Detail

Event Timeline

xgupta created this revision.Mar 8 2020, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2020, 9:37 AM
xgupta updated this revision to Diff 249005.Mar 8 2020, 9:44 AM

Correct the formatting of change.

xgupta updated this revision to Diff 249006.Mar 8 2020, 9:49 AM

Correct the link syntax for rst language.

Since it's not a code level change, perhaps adding [NFCI] or [NFC] label to summary of change would help/facilitate reviewers in review process.

Since it's not a code level change, perhaps adding [NFCI] or [NFC] label to summary of change would help/facilitate reviewers in review process.

Thanks, I will remember from the next time.

Harbormaster completed remote builds in B48495: Diff 249003.
xgupta retitled this revision from Add lexicon definition for PHI node. to [NFC] Add lexicon definition for PHI node..Mar 8 2020, 12:27 PM
xgupta edited reviewers, added: ftynse; removed: hubert.reinterpretcast.Mar 11 2020, 9:47 AM
xgupta removed a subscriber: llvm-commits.

Does someone commit these changes who have commit right

ftynse added inline comments.Mar 16 2020, 9:54 AM
llvm/docs/Lexicon.rst
210

Could you rather explain it with more words (if necessary) instead of linking to a non-LLVM project that looks mostly dead?

silvas resigned from this revision.Mar 25 2020, 6:26 PM
ftynse resigned from this revision.Apr 16 2020, 1:21 AM

This looks dead.