It isn't used anywhere (except on imaginary triples like
sparc-apple-ios) and it also violates plugin separation.
This patch deletes it and declares UnwindLLDB to be _the_ lldb unwinder.
Paths
| Differential D75680
[lldb] Delete UnwindMacOSXFrameBackchain ClosedPublic Authored by labath on Mar 5 2020, 6:19 AM.
Details Summary It isn't used anywhere (except on imaginary triples like This patch deletes it and declares UnwindLLDB to be _the_ lldb unwinder.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Mar 5 2020, 8:35 AM Comment Actions LGTM. The only time this plugin gets activated is when there's been some problem with the arch triple and we end up defaulting to this unwinder, which never works anyway. Comment Actions LGTM. If UnwindLLDB is the unwinder, that makes things a little easier for plugin separation. Comment Actions
Yep, I think that after this we can just move UnwindLLDB into the core libraries. But that is a different patch... Closed by commit rG71c1c184744c: [lldb] Delete UnwindMacOSXFrameBackchain (authored by labath). · Explain WhyMar 6 2020, 12:03 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 248655 lldb/source/Plugins/Process/Utility/CMakeLists.txt
lldb/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.h
lldb/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp
lldb/source/Plugins/Process/Utility/UnwindMacOSXFrameBackchain.h
lldb/source/Plugins/Process/Utility/UnwindMacOSXFrameBackchain.cpp
lldb/source/Target/Thread.cpp
|