This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Delete UnwindMacOSXFrameBackchain
ClosedPublic

Authored by labath on Mar 5 2020, 6:19 AM.

Details

Summary

It isn't used anywhere (except on imaginary triples like
sparc-apple-ios) and it also violates plugin separation.

This patch deletes it and declares UnwindLLDB to be _the_ lldb unwinder.

Diff Detail

Event Timeline

labath created this revision.Mar 5 2020, 6:19 AM
JDevlieghere accepted this revision.Mar 5 2020, 8:35 AM
This revision is now accepted and ready to land.Mar 5 2020, 8:35 AM
jasonmolenda accepted this revision.Mar 5 2020, 9:35 AM

LGTM. The only time this plugin gets activated is when there's been some problem with the arch triple and we end up defaulting to this unwinder, which never works anyway.

xiaobai accepted this revision.Mar 5 2020, 12:11 PM

LGTM. If UnwindLLDB is the unwinder, that makes things a little easier for plugin separation.

If UnwindLLDB is the unwinder, that makes things a little easier for plugin separation.

Yep, I think that after this we can just move UnwindLLDB into the core libraries. But that is a different patch...

This revision was automatically updated to reflect the committed changes.
lldb/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp