Page MenuHomePhabricator

[llvm-objdump] --syms: make flags closer to GNU objdump
ClosedPublic

Authored by MaskRay on Mar 4 2020, 5:48 PM.

Details

Summary

This fixes several issues. The behavior changes are:

A SHN_COMMON symbol does not have the 'g' flag.
An undefined symbol does not have 'g' or 'l' flag.
A STB_GLOBAL SymbolRef::ST_Unknown symbol has the 'g' flag.
A STB_LOCAL SymbolRef::ST_Unknown symbol has the 'l' flag.

There are 30+ other lld tests need fixing.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 4 2020, 5:48 PM
grimar added a comment.EditedMar 5 2020, 12:58 AM

It looks fine, I confirm I observe the same behavior with "GNU objdump (GNU Binutils for Ubuntu) 2.31.1".

There are 30+ other lld tests need fixing.

I think you can continue with this, perhaps worth to wait for a second opinion just in case.

rupprecht accepted this revision.Mar 5 2020, 9:18 AM
This revision is now accepted and ready to land.Mar 5 2020, 9:18 AM
This revision was automatically updated to reflect the committed changes.