After committing D75056, which I've reverted now, these compiler-rt tests failed:
FAIL: AddressSanitizer-aarch64-linux::odr_c_test.c FAIL: AddressSanitizer-aarch64-linux::set_shadow_test.c
and the same tests in a different configuration:
FAIL: AddressSanitizer-aarch64-linux-dynamic::odr_c_test.c FAIL: AddressSanitizer-aarch64-linux-dynamic::set_shadow_test.c
I don't want to hold up this commit for these tests, so I intend to recommit D75056 soon'ish with these test changes included. I am posting this for review so that we can (post-commit) further address this.
It looks like these tests are not very robust and rely on -fcommon behaviour. But both tests are not really in my area, so a second opinion would be good to confirm if adding -fcommon to the run lines is good enough, or if the tests need to be rewritten.