This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel] Add missing floating point and s128 libcall support
ClosedPublic

Authored by gargaroff on Mar 3 2020, 4:40 AM.

Details

Summary

Add libcall support for G_FMINNUM, G_FMAXNUM, G_FSQRT, G_FRINT, G_FNEARBYINT.

Add 128-bit support to all simple libcalls.

Diff Detail

Event Timeline

gargaroff created this revision.Mar 3 2020, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 4:40 AM
gargaroff updated this revision to Diff 247880.Mar 3 2020, 6:26 AM

Fix clang-tidy warnings reported by pre-merge checks.

arsenm added inline comments.Mar 3 2020, 2:32 PM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
461–463

Should there be a table for this? The nested ternary operators are becoming unwieldy

gargaroff updated this revision to Diff 248119.Mar 4 2020, 1:11 AM

Address review comments

gargaroff updated this revision to Diff 248120.Mar 4 2020, 1:13 AM

Sorry, still struggling with Phabricator...

Apply correct patch, addressing review comments.

arsenm accepted this revision.Mar 4 2020, 12:44 PM

LGTM

This revision is now accepted and ready to land.Mar 4 2020, 12:44 PM
gargaroff marked an inline comment as done.EditedMar 4 2020, 11:46 PM

Thank you! Would you mind committing this for me?

Author name: Dominik Montada
Author email: dominik.montada@hightec-rt.com

Nevermind, I just got commit access and was able to commit this myself.