This is an archive of the discontinued LLVM Phabricator instance.

[X86] Always emit an integer vbroadcast_load from lowerBuildVectorAsBroadcast regardless of AVX vs AVX2
ClosedPublic

Authored by craig.topper on Feb 29 2020, 1:27 PM.

Details

Summary

If we go with D75412, we no longer depend on the scalar type directly. So we don't need to avoid using i64. We already have AVX1 fallback patterns with i32 and i64 scalar types so we don't need to avoid using integer types on AVX1.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 29 2020, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 29 2020, 1:27 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
RKSimon accepted this revision.Mar 3 2020, 9:37 AM

LGTM - as a side note I think we should bite the bullet and get on with moving to fixed-width hex values for all constant pool x86 asm comments at this point as a first step toward D37184

This revision is now accepted and ready to land.Mar 3 2020, 9:37 AM
This revision was automatically updated to reflect the committed changes.