This is an archive of the discontinued LLVM Phabricator instance.

Differential D74879

[llvm-objcopy][test] Improve empty section tests
ClosedPublic

Authored by MaskRay on Feb 19 2020, 4:17 PM.

Details

Reviewers
grimar
jhenderson
rupprecht
• espindola
alexander-shaposhnikov
Commits
rG6503aadcc6c9: [llvm-objcopy][test] Improve empty section tests
Summary

empty-sections.test: add two tests adapted from @jhenderson's https://reviews.llvm.org/D74755#1882221
strip-non-alloc.test: improve. D74755 will change the attribution of an empty section.

They mostly test the behavior of Object.cpp:sectionWithinSegment : how we attribute sections to segments.
ParentSegment can affect some subtle layout decisions.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 19 2020, 4:17 PM
Herald added a reviewer: • espindola. · View Herald TranscriptFeb 19 2020, 4:17 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, abrachet, emaste. · View Herald Transcript
MaskRay added a child revision: D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.Feb 19 2020, 4:20 PM
MaskRay mentioned this in D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.Feb 19 2020, 4:34 PM
Harbormaster completed remote builds in B46873: Diff 245551.Feb 19 2020, 4:52 PM
grimar added inline comments.Feb 20 2020, 12:11 AM
llvm/test/tools/llvm-objcopy/ELF/empty-section.test
5

Can you add a comment here and for the test below?

71

[SHF_ALLOC] is one byte off.

MaskRay updated this revision to Diff 246077.Feb 22 2020, 8:37 AM
MaskRay marked 3 inline comments as done.

Improve tests

Harbormaster failed remote builds in B47090: Diff 246077!Feb 22 2020, 8:52 AM
MaskRay updated this revision to Diff 246078.Feb 22 2020, 9:19 AM
MaskRay edited the summary of this revision. (Show Details)

Improve tests

Harbormaster failed remote builds in B47091: Diff 246078!Feb 22 2020, 9:38 AM
jhenderson added inline comments.Feb 25 2020, 1:17 AM
llvm/test/tools/llvm-objcopy/ELF/empty-section.test
13

Seems to me like here and below you can get rid of the columns after Off?

39

according to the

llvm/test/tools/llvm-objcopy/ELF/strip-non-alloc.test
11–12 ↗(On Diff #246078)

Shouldn't these two be on the same line?

MaskRay updated this revision to Diff 246527.Feb 25 2020, 12:03 PM
MaskRay marked 3 inline comments as done.

Address comments

MaskRay added inline comments.Feb 25 2020, 12:07 PM
llvm/test/tools/llvm-objcopy/ELF/empty-section.test
5

The original test is not very useful. I will replace it with --docnum=2 with segments removed.

Harbormaster completed remote builds in B47228: Diff 246527.Feb 25 2020, 1:34 PM
jhenderson accepted this revision.Feb 26 2020, 1:54 AM

LGTM.

This revision is now accepted and ready to land.Feb 26 2020, 1:54 AM
Closed by commit rG6503aadcc6c9: [llvm-objcopy][test] Improve empty section tests (authored by MaskRay). · Explain WhyFeb 26 2020, 9:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
85 lines

Diff 245551

llvm/test/tools/llvm-objcopy/ELF/empty-section.test

# RUN: yaml2obj %s -o %t # RUN: yaml2obj --docnum=1 %s -o %t1
# RUN: llvm-objcopy %t %t2 # RUN: llvm-objcopy %t1 %t1.out
# RUN: llvm-readobj --sections %t2 | FileCheck %s # RUN: llvm-readelf -S %t1.out | FileCheck --check-prefix=CHECK1 %s
# CHECK1: Name Type Address Off Size ES Flg Lk Inf Al
grimarUnsubmitted
Done
ReplyInline Actions

Can you add a comment here and for the test below?

grimar: Can you add a comment here and for the test below?
MaskRayAuthorUnsubmitted
Done
ReplyInline Actions

The original test is not very useful. I will replace it with --docnum=2 with segments removed.

MaskRay: The original test is not very useful. I will replace it with --docnum=2 with segments removed.
# CHECK1-NEXT: NULL 0000000000000000 000000 000000 00 0 0 0
# CHECK1-NEXT: .text PROGBITS 0000000000000000 001000 000004 00 AX 0 0 4
# CHECK1-NEXT: .empty PROGBITS 0000000000001000 002000 000000 00 A 0 0 4096
# CHECK1-NEXT: .data PROGBITS 0000000000001000 002000 000004 00 A 0 0 4096
# CHECK1-NEXT: .strtab STRTAB 0000000000000000 002004 000001 00 0 0 1
# CHECK1-NEXT: .shstrtab STRTAB 0000000000000000 002005 000026 00 0 0 1
!ELF !ELF
jhendersonUnsubmitted
Done
ReplyInline Actions

Seems to me like here and below you can get rid of the columns after Off?

jhenderson: Seems to me like here and below you can get rid of the columns after `Off`?
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_EXEC Type: ET_EXEC
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Show All 9 Lines - Name: .empty
Content: "" Content: ""
- Name: .data - Name: .data
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Address: 0x1000 Address: 0x1000
AddressAlign: 0x0000000000001000 AddressAlign: 0x0000000000001000
Content: "00000000" Content: "00000000"
# RUN: yaml2obj --docnum=2 %s -o %t2
jhendersonUnsubmitted
Done
ReplyInline Actions

according to the

jhenderson: according to the
# RUN: llvm-objcopy %t2 %t2.out
# RUN: llvm-readelf -S %t2.out | FileCheck --check-prefix=CHECK2 %s
# CHECK: Name: .text # CHECK2: Name Type Address Off Size ES Flg Lk Inf Al
# CHECK-NEXT: Type: SHT_PROGBITS # CHECK2-NEXT: NULL 0000000000000000 000000 000000 00 0 0 0
# CHECK-NEXT: Flags [ # CHECK2-NEXT: .foo PROGBITS 0000000000000000 000100 000100 00 A 0 0 256
# CHECK-NEXT: SHF_ALLOC # CHECK2-NEXT: .empty PROGBITS 0000000000001000 001000 000000 00 A 0 0 0
# CHECK-NEXT: SHF_EXECINSTR # CHECK2-NEXT: .baz PROGBITS 0000000000001000 001000 000100 00 A 0 0 4096
# CHECK-NEXT: ]
# CHECK: Name: .empty
# CHECK-NEXT: Type: SHT_PROGBITS
# CHECK-NEXT: Flags [
# CHECK-NEXT: SHF_ALLOC
# CHECK-NEXT: ]
# CHECK-NEXT: Address: 0x1000
# CHECK-NEXT: Offset: 0x2000
# CHECK-NEXT: Size: 0
# CHECK: Name: .data --- !ELF
# CHECK-NEXT: Type: SHT_PROGBITS FileHeader:
# CHECK-NEXT: Flags [ Class: ELFCLASS64
# CHECK-NEXT: SHF_ALLOC Data: ELFDATA2LSB
# CHECK-NEXT: ] Type: ET_EXEC
# CHECK-NEXT: Address: 0x1000 Machine: EM_X86_64
# CHECK-NEXT: Offset: 0x2000 Sections:
# CHECK-NEXT: Size: 4 - Name: gap
Type: Fill
Size: 0xE00
- Name: .foo
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ]
AddressAlign: 0x100
Address: 0
Size: 0x100
- Name: .empty
Type: SHT_PROGBITS
Flags: [SHF_ALLOC]
Address: 0x1000
- Name: .baz
Type: SHT_PROGBITS
Flags: [SHF_ALLOC]
grimarUnsubmitted
Done
ReplyInline Actions

[SHF_ALLOC] is one byte off.

grimar: `[SHF_ALLOC]` is one byte off.
AddressAlign: 0x1000
Address: 0x1000
Size: 0x100
ProgramHeaders:
- Type: PT_LOAD
VAddr: 0
PAddr: 0
Align: 0x100
Sections:
- Section: .foo
- Type: PT_LOAD
VAddr: 0x1000
PAddr: 0x1000
Align: 0x1000
Sections:
- Section: .empty
- Section: .baz