Reasons are the same as: D74637
The thing I said on the other patch about DIERef vs user_id_t still applies. Let's continue the discussion there...
|37 ↗||(On Diff #244873)|
I'd very much like to avoid a default-constructed DIERef -- in the previous refactoring, I've deleted that concept and tried to use Optional<DIERef> in contexts, where the object can be empty.
Per discussion on the other patch, I think this is fine too, just can we get rid of the DIERef default constructor? I think all you'd need is to use the insert DenseMap function instead of operator.