This is an archive of the discontinued LLVM Phabricator instance.

Do not build the CUBIN conversion pass when NVPTX Backend isn't configured
ClosedPublic

Authored by mehdi_amini on Feb 14 2020, 1:15 AM.

Details

Summary

This pass would currently build, but fail to run when this backend isn't
linked in. On the other hand, we'd like it to initialize only the NVPTX
backend, which isn't possible if we continue to build it without the
backend available. Instead of building a broken configuration, let's
skip building the pass entirely.

Diff Detail

Event Timeline

mehdi_amini created this revision.Feb 14 2020, 1:15 AM
bkramer accepted this revision.Feb 14 2020, 1:17 AM

In the long term I'd prefer to not initialize backends inside of pass at all, but for the short term this is better than pulling in all backends.

This revision is now accepted and ready to land.Feb 14 2020, 1:17 AM

ifdef out the pass registration

This revision was automatically updated to reflect the committed changes.
SouraVX added a subscriber: SouraVX.Mar 9 2020, 3:34 AM