Since llvm-go is no longer part of the distribution, the binding testing have started to fail.
This is a straight forward attempt at fixing that. Note that I'm by no mean a go developer, which is probably reflected by the commit.
Paths
| Differential D74540
Rework go bindings so that binding tests work fine AbandonedPublic Authored by serge-sans-paille on Feb 13 2020, 3:09 AM.
Details Summary Since llvm-go is no longer part of the distribution, the binding testing have started to fail. This is a straight forward attempt at fixing that. Note that I'm by no mean a go developer, which is probably reflected by the commit.
Diff Detail
Unit TestsFailed
Event TimelineComment Actions So this is just using the system go compiler instead of llvm-go and all the files move to src/ because that's how the normal go compiler expects the workspace to look like? Comment Actions
yeah, that's basically it. Plus a few lit config stuff to make sure everything works. Which is not settled yet per the validation :-) This revision is now accepted and ready to land.Feb 13 2020, 4:32 AM Closed by commit rGe8f8873da5ea: Rework go bindings so that validation works fine (authored by serge-sans-paille). · Explain WhyFeb 13 2020, 5:21 AM This revision was automatically updated to reflect the committed changes. Comment Actions This broke users of the go bindings who were using build.sh, and changed the import path for the bindings unnecessarily. Can we please just bring back llvm-go as I requested before? This revision is now accepted and ready to land.Feb 13 2020, 8:35 AM Comment Actions
@pcc Are you the best one fixing this issue properly :) ? I guess this patch fixed the /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/test/Bindings/Go/Output/go.test.script: line 1: llvm-go: command not found diagnostic we continuously get from the premerge bot, so I still appreciate Serge's work.... https://reviews.llvm.org/harbormaster/unit/view/3381/
Revision Contents
Diff 244375 llvm/bindings/go/build.sh
llvm/bindings/go/llvm/IRBindings.h
llvm/bindings/go/llvm/IRBindings.cpp
llvm/bindings/go/llvm/InstrumentationBindings.h
llvm/bindings/go/llvm/InstrumentationBindings.cpp
llvm/bindings/go/llvm/SupportBindings.h
llvm/bindings/go/llvm/SupportBindings.cpp
llvm/bindings/go/llvm/analysis.go
llvm/bindings/go/llvm/bitreader.go
llvm/bindings/go/llvm/bitwriter.go
llvm/bindings/go/llvm/dibuilder.go
llvm/bindings/go/llvm/executionengine.go
llvm/bindings/go/llvm/executionengine_test.go
llvm/bindings/go/llvm/ir.go
llvm/bindings/go/llvm/ir_test.go
llvm/bindings/go/llvm/linker.go
llvm/bindings/go/llvm/llvm_config.go.in
llvm/bindings/go/llvm/llvm_dep.go
llvm/bindings/go/llvm/string.go
llvm/bindings/go/llvm/string_test.go
llvm/bindings/go/llvm/support.go
llvm/bindings/go/llvm/target.go
llvm/bindings/go/llvm/transforms_coroutines.go
llvm/bindings/go/llvm/transforms_instrumentation.go
llvm/bindings/go/llvm/transforms_ipo.go
llvm/bindings/go/llvm/transforms_pmbuilder.go
llvm/bindings/go/llvm/transforms_scalar.go
llvm/bindings/go/llvm/version.go
llvm/bindings/go/src/llvm/IRBindings.h
llvm/bindings/go/src/llvm/IRBindings.cpp
llvm/bindings/go/src/llvm/InstrumentationBindings.h
llvm/bindings/go/src/llvm/InstrumentationBindings.cpp
llvm/bindings/go/src/llvm/SupportBindings.h
llvm/bindings/go/src/llvm/SupportBindings.cpp
llvm/bindings/go/src/llvm/analysis.go
llvm/bindings/go/src/llvm/bitreader.go
llvm/bindings/go/src/llvm/bitwriter.go
llvm/bindings/go/src/llvm/dibuilder.go
llvm/bindings/go/src/llvm/executionengine.go
llvm/bindings/go/src/llvm/executionengine_test.go
llvm/bindings/go/src/llvm/ir.go
llvm/bindings/go/src/llvm/ir_test.go
llvm/bindings/go/src/llvm/linker.go
llvm/bindings/go/src/llvm/llvm_config.go.in
llvm/bindings/go/src/llvm/llvm_dep.go
llvm/bindings/go/src/llvm/string.go
llvm/bindings/go/src/llvm/string_test.go
llvm/bindings/go/src/llvm/support.go
llvm/bindings/go/src/llvm/target.go
llvm/bindings/go/src/llvm/transforms_coroutines.go
llvm/bindings/go/src/llvm/transforms_instrumentation.go
llvm/bindings/go/src/llvm/transforms_ipo.go
llvm/bindings/go/src/llvm/transforms_pmbuilder.go
llvm/bindings/go/src/llvm/transforms_scalar.go
llvm/bindings/go/src/llvm/version.go
llvm/test/Bindings/Go/go.test
llvm/test/Bindings/Go/lit.local.cfg
llvm/test/lit.cfg.py
llvm/utils/lit/lit/llvm/subst.py
|