This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix benchmarks CMakeLists.txt
ClosedPublic

Authored by gchatelet on Jan 27 2020, 1:57 AM.

Details

Summary

This is a follow up on https://reviews.llvm.org/rGaba80d0734d1#886881.
target_link_options requires CMake>=3.13.

Diff Detail

Event Timeline

gchatelet created this revision.Jan 27 2020, 1:57 AM

is too recent for current CMake version

Explicitly mention that target_link_options requires CMake>=3.13

abrachet accepted this revision.Jan 27 2020, 10:33 AM

+1 to @MaskRay's suggestion to put it in the description so we can look at the FIXME's blame later.

This revision is now accepted and ready to land.Jan 27 2020, 10:33 AM
gchatelet updated this revision to Diff 241145.Jan 29 2020, 6:43 AM
  • address comments

Sorry I messed up the Patches, I'll revert to previous state...

gchatelet updated this revision to Diff 241151.Jan 29 2020, 6:55 AM
  • updated commit message
gchatelet edited the summary of this revision. (Show Details)Jan 29 2020, 6:56 AM
This revision was automatically updated to reflect the committed changes.