Page MenuHomePhabricator

[clang][CodeComplete] Propogate printing policy to FunctionDecl
ClosedPublic

Authored by kadircet on Tue, Jan 14, 9:13 AM.

Details

Summary

Printing policy was not propogated to functiondecls when creating a
completion string which resulted in canonical template parameters like
foo<type-parameter-0-0>. This patch propogates printing policy to those as
well.

Fixes https://github.com/clangd/clangd/issues/76

Diff Detail

Event Timeline

kadircet created this revision.Tue, Jan 14, 9:13 AM

The patch contains only tests, are we missing the actual functional change?

Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped.

failed: Clangd Unit Tests._/ClangdTests/SignatureHelpTest.PartialSpec

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

kadircet updated this revision to Diff 238017.Tue, Jan 14, 9:51 AM
  • Upload the correct diff

The patch contains only tests, are we missing the actual functional change?

oopsy

Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

hokein accepted this revision.Mon, Jan 20, 3:01 AM
hokein added a subscriber: kuhnel.

@kuhnel, I think we should exclude from running clang-format on lint test files.

This revision is now accepted and ready to land.Mon, Jan 20, 3:01 AM
This revision was automatically updated to reflect the committed changes.

thx for the feedback, I created an issue for this: https://github.com/google/llvm-premerge-checks/issues/98