This patch:
- enable frame pointer for AIX
 - update some of red zone comments[we may need an extra NFC patch to address all red zone related comments]
 - add testcases
 
 Differential  D72454  
[AIX] Enable frame pointer for AIX and add related test suite Authored by Xiangling_L on Jan 9 2020, 7:13 AM. 
Details This patch: 
 
Diff Detail 
 Event Timeline
 
 
 Comment Actions I think this patch is really close, just needs some typo fixes. I'm hesitant to approve since no one else has had a chance to look at it. 
 Comment Actions Preliminary comments. I still need to go through the test changes more thoroughly. 
 
 
 
 
 Comment Actions Some early issues. I need more time to go through the AIX assembly in detail to ensure it's correct. 
 
 
 
 Comment Actions 
 I am not against them in general even though I let alot of feedback on why we should remove most of them :) .If you think they are useful I am willing to work with you to refine them into something we are both happy with. I think the same kind of goals we have when writing code comments apply to test comments: 
 
 
 I think the 3rd point is already covered, Its 1 and 2 that I'm pushing for. 
 Comment Actions Only minor test questions / requests. The change looks ok. I think we should explain the stack adj differences with the XL compiler before committing, specifically: do we need to allocate the PSA for the current frame even if there are no calls? 
 Comment Actions Update the testcases to make the description of each less verbose; 
  | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The comment talks about the Darwin ABI but it looks that part of the code is removed. Should the comment be edited or am I misunderstanding?