This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Mark several tests as not dependent on debug info
ClosedPublic

Authored by teemperor on Jan 9 2020, 6:05 AM.

Details

Summary

This just adds NO_DEBUG_INFO_TESTCASE to tests that don't really exercise anything debug information specific
and therefore don't need to be rerun for all debug information variants.

Diff Detail

Event Timeline

teemperor created this revision.Jan 9 2020, 6:05 AM
Herald added a project: Restricted Project. · View Herald Transcript

Some of the tests technically touch debug information but don't test features specific to it. If anyone thinks some of these tests are worthwhile to run with all debug information variants then let me know.

labath added a comment.Jan 9 2020, 6:30 AM

These all seem fine to me...

lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
13 ↗(On Diff #237047)

This shouldn't be needed as all PExpectTests set this by default...

lldb/packages/Python/lldbsuite/test/commands/platform/process/TestProcessList.py
18 ↗(On Diff #237047)

duplicate annotation

aprantl accepted this revision.Jan 9 2020, 9:18 AM

I believe that all of these make sense.

lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py
12

Do you think you could dig up that radar and rename this to something more meaningful?

This revision is now accepted and ready to land.Jan 9 2020, 9:18 AM
This revision was automatically updated to reflect the committed changes.

This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it):

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12554

This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it):

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12554

It seems indeed like this is causing timeouts but it's not clear how adding NO_DEBUG_INFO_TESTCASE can cause that. Anyway, I reverted the changes to the test that started timing out so that should fix it. Thanks!